git.iko.soy/reflex-dom
on develop help sign in
PR review: Fix typos and fully qualify changelog
0dc8d80Tom Smalley
reflex-dom-core/ChangeLog.md+2−2
compare with develop
unifiedsplit
@@ -20,8 +20,8 @@
20* Fix bug in hydration when dealing with unexpected HTML ([#361](https://github.com/reflex-frp/reflex-dom/pull/361)).
20* Fix bug in hydration when dealing with unexpected HTML ([#361](https://github.com/reflex-frp/reflex-dom/pull/361)).
21
21
22* Export attributes used for controlling hydration at the element level
22* Export attributes used for controlling hydration at the element level
23− * "data-ssr" is now available as `hydratableAttribute`
23+ * "data-ssr" is now available as `Reflex.Dom.Builder.Immediate.hydratableAttribute`
24− * "data-hydration-skip" is now available as `skipHydrationAttribute`
24+ * "data-hydration-skip" is now available as `Reflex.Dom.Builder.Immediate.skipHydrationAttribute`
25
25
26## 0.5.3
26## 0.5.3
27
27
reflex-dom-core/src/Reflex/Dom/Builder/Immediate.hs+2−2
@@ -778,7 +778,7 @@ hydrateElement elementTag cfg child = do
778 wrapResult <- liftIO newEmptyMVar
778 wrapResult <- liftIO newEmptyMVar
779 let -- Determine if we should skip an element. We currently skip elements for
779 let -- Determine if we should skip an element. We currently skip elements for
780 -- two reasons:
780 -- two reasons:
781− -- 1) it was not produced a static builder which supports hydration
781+ -- 1) it was not produced by a static builder which supports hydration
782 -- 2) it is explicitly marked to be skipped
782 -- 2) it is explicitly marked to be skipped
783 shouldSkip :: DOM.Element -> HydrationRunnerT t m Bool
783 shouldSkip :: DOM.Element -> HydrationRunnerT t m Bool
784 shouldSkip e = do
784 shouldSkip e = do
@@ -800,7 +800,7 @@ hydrateElement elementTag cfg child = do
800 Just node -> DOM.castTo DOM.Element node >>= \case
800 Just node -> DOM.castTo DOM.Element node >>= \case
801 Nothing -> go (Just node) -- this node is not an element, skip
801 Nothing -> go (Just node) -- this node is not an element, skip
802 Just e -> shouldSkip e >>= \case
802 Just e -> shouldSkip e >>= \case
803− True -> go (Just node) -- this element is should be skipped by hydration
803+ True -> go (Just node) -- this element should be skipped by hydration
804 False -> do
804 False -> do
805 t <- Element.getTagName e
805 t <- Element.getTagName e
806 -- TODO: check attributes?
806 -- TODO: check attributes?