on develop help sign in
Use `Lens'` where possible for readability
commitb1c14862fca56d365220c0152e4d22f81af17496 authorJohn Ericson <John.Ericson@Obsidian.Systems> dateThu 15 Nov 2018, 16:17 (8 years ago) parent8bde2d7
2 files changed+8−8
reflex-dom-core/src/Reflex/Dom/Builder/Class.hs+7−7 reflex-dom-core/src/Reflex/Dom/Xhr.hs+1−1
reflex-dom-core/src/Reflex/Dom/Builder/Class.hs+7−7
@@ -403,49 +403,49 @@ concat <$> mapM (uncurry makeLensesWithoutField)
403403#endif
404404
405405-- | This lens is technically illegal. The implementation of 'TextNodeConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextNodeConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
406−textNodeConfig_setContents :: Reflex t => Lens (TextNodeConfig t) (TextNodeConfig t) (Event t Text) (Event t Text)
406+textNodeConfig_setContents :: Reflex t => Lens' (TextNodeConfig t) (Event t Text)
407407textNodeConfig_setContents =
408408 let getter = fromMaybe never . _textNodeConfig_setContents
409409 setter t e = t { _textNodeConfig_setContents = Just e }
410410 in lens getter setter
411411
412412-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
413−inputElementConfig_setValue :: Reflex t => Lens (InputElementConfig er t m) (InputElementConfig er t m) (Event t Text) (Event t Text)
413+inputElementConfig_setValue :: Reflex t => Lens' (InputElementConfig er t m) (Event t Text)
414414inputElementConfig_setValue =
415415 let getter = fromMaybe never . _inputElementConfig_setValue
416416 setter t e = t { _inputElementConfig_setValue = Just e }
417417 in lens getter setter
418418
419419-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
420−inputElementConfig_setChecked :: Reflex t => Lens (InputElementConfig er t m) (InputElementConfig er t m) (Event t Bool) (Event t Bool)
420+inputElementConfig_setChecked :: Reflex t => Lens' (InputElementConfig er t m) (Event t Bool)
421421inputElementConfig_setChecked =
422422 let getter = fromMaybe never . _inputElementConfig_setChecked
423423 setter t e = t { _inputElementConfig_setChecked = Just e }
424424 in lens getter setter
425425
426426-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
427−rawElementConfig_modifyAttributes :: Reflex t => Lens (RawElementConfig er t m) (RawElementConfig er t m) (Event t (Map AttributeName (Maybe Text))) (Event t (Map AttributeName (Maybe Text)))
427+rawElementConfig_modifyAttributes :: Reflex t => Lens' (RawElementConfig er t m) (Event t (Map AttributeName (Maybe Text)))
428428rawElementConfig_modifyAttributes =
429429 let getter = fromMaybe never . _rawElementConfig_modifyAttributes
430430 setter t e = t { _rawElementConfig_modifyAttributes = Just e }
431431 in lens getter setter
432432
433433-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
434−elementConfig_modifyAttributes :: Reflex t => Lens (ElementConfig er t m) (ElementConfig er t m) (Event t (Map AttributeName (Maybe Text))) (Event t (Map AttributeName (Maybe Text)))
434+elementConfig_modifyAttributes :: Reflex t => Lens' (ElementConfig er t m) (Event t (Map AttributeName (Maybe Text)))
435435elementConfig_modifyAttributes =
436436 let getter = fromMaybe never . _elementConfig_modifyAttributes
437437 setter t e = t { _elementConfig_modifyAttributes = Just e }
438438 in lens getter setter
439439
440440-- | This lens is technically illegal. The implementation of 'TextAreaElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextAreaElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
441−textAreaElementConfig_setValue :: Reflex t => Lens (TextAreaElementConfig er t m) (TextAreaElementConfig er t m) (Event t Text) (Event t Text)
441+textAreaElementConfig_setValue :: Reflex t => Lens' (TextAreaElementConfig er t m) (Event t Text)
442442textAreaElementConfig_setValue =
443443 let getter = fromMaybe never . _textAreaElementConfig_setValue
444444 setter t e = t { _textAreaElementConfig_setValue = Just e }
445445 in lens getter setter
446446
447447-- | This lens is technically illegal. The implementation of 'SelectElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'SelectElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
448−selectElementConfig_setValue :: Reflex t => Lens (SelectElementConfig er t m) (SelectElementConfig er t m) (Event t Text) (Event t Text)
448+selectElementConfig_setValue :: Reflex t => Lens' (SelectElementConfig er t m) (Event t Text)
449449selectElementConfig_setValue =
450450 let getter = fromMaybe never . _selectElementConfig_setValue
451451 setter t e = t { _selectElementConfig_setValue = Just e }
reflex-dom-core/src/Reflex/Dom/Xhr.hs+1−1
@@ -215,7 +215,7 @@ _xhrResponse_body :: XhrResponse -> Maybe Text
215215_xhrResponse_body = _xhrResponse_responseText
216216
217217{-# DEPRECATED xhrResponse_body "Use xhrResponse_response or xhrResponse_responseText instead." #-}
218−xhrResponse_body :: Lens XhrResponse XhrResponse (Maybe Text) (Maybe Text)
218+xhrResponse_body :: Lens' XhrResponse (Maybe Text)
219219xhrResponse_body = lens _xhrResponse_responseText (\r t -> r { _xhrResponse_responseText = t })
220220
221221instance a ~ () => Default (XhrRequestConfig a) where