on develop help sign in
Use `Lens'` where possible for readability
b1c1486John Ericson
reflex-dom-core/src/Reflex/Dom/Builder/Class.hs+7−7
@@ -403,49 +403,49 @@ concat <$> mapM (uncurry makeLensesWithoutField)
403#endif
403#endif
404
404
405-- | This lens is technically illegal. The implementation of 'TextNodeConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextNodeConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
405-- | This lens is technically illegal. The implementation of 'TextNodeConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextNodeConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
406−textNodeConfig_setContents :: Reflex t => Lens (TextNodeConfig t) (TextNodeConfig t) (Event t Text) (Event t Text)
406+textNodeConfig_setContents :: Reflex t => Lens' (TextNodeConfig t) (Event t Text)
407textNodeConfig_setContents =
407textNodeConfig_setContents =
408 let getter = fromMaybe never . _textNodeConfig_setContents
408 let getter = fromMaybe never . _textNodeConfig_setContents
409 setter t e = t { _textNodeConfig_setContents = Just e }
409 setter t e = t { _textNodeConfig_setContents = Just e }
410 in lens getter setter
410 in lens getter setter
411
411
412-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
412-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
413−inputElementConfig_setValue :: Reflex t => Lens (InputElementConfig er t m) (InputElementConfig er t m) (Event t Text) (Event t Text)
413+inputElementConfig_setValue :: Reflex t => Lens' (InputElementConfig er t m) (Event t Text)
414inputElementConfig_setValue =
414inputElementConfig_setValue =
415 let getter = fromMaybe never . _inputElementConfig_setValue
415 let getter = fromMaybe never . _inputElementConfig_setValue
416 setter t e = t { _inputElementConfig_setValue = Just e }
416 setter t e = t { _inputElementConfig_setValue = Just e }
417 in lens getter setter
417 in lens getter setter
418
418
419-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
419-- | This lens is technically illegal. The implementation of 'InputElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'InputElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
420−inputElementConfig_setChecked :: Reflex t => Lens (InputElementConfig er t m) (InputElementConfig er t m) (Event t Bool) (Event t Bool)
420+inputElementConfig_setChecked :: Reflex t => Lens' (InputElementConfig er t m) (Event t Bool)
421inputElementConfig_setChecked =
421inputElementConfig_setChecked =
422 let getter = fromMaybe never . _inputElementConfig_setChecked
422 let getter = fromMaybe never . _inputElementConfig_setChecked
423 setter t e = t { _inputElementConfig_setChecked = Just e }
423 setter t e = t { _inputElementConfig_setChecked = Just e }
424 in lens getter setter
424 in lens getter setter
425
425
426-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
426-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
427−rawElementConfig_modifyAttributes :: Reflex t => Lens (RawElementConfig er t m) (RawElementConfig er t m) (Event t (Map AttributeName (Maybe Text))) (Event t (Map AttributeName (Maybe Text)))
427+rawElementConfig_modifyAttributes :: Reflex t => Lens' (RawElementConfig er t m) (Event t (Map AttributeName (Maybe Text)))
428rawElementConfig_modifyAttributes =
428rawElementConfig_modifyAttributes =
429 let getter = fromMaybe never . _rawElementConfig_modifyAttributes
429 let getter = fromMaybe never . _rawElementConfig_modifyAttributes
430 setter t e = t { _rawElementConfig_modifyAttributes = Just e }
430 setter t e = t { _rawElementConfig_modifyAttributes = Just e }
431 in lens getter setter
431 in lens getter setter
432
432
433-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
433-- | This lens is technically illegal. The implementation of 'RawElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'RawElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
434−elementConfig_modifyAttributes :: Reflex t => Lens (ElementConfig er t m) (ElementConfig er t m) (Event t (Map AttributeName (Maybe Text))) (Event t (Map AttributeName (Maybe Text)))
434+elementConfig_modifyAttributes :: Reflex t => Lens' (ElementConfig er t m) (Event t (Map AttributeName (Maybe Text)))
435elementConfig_modifyAttributes =
435elementConfig_modifyAttributes =
436 let getter = fromMaybe never . _elementConfig_modifyAttributes
436 let getter = fromMaybe never . _elementConfig_modifyAttributes
437 setter t e = t { _elementConfig_modifyAttributes = Just e }
437 setter t e = t { _elementConfig_modifyAttributes = Just e }
438 in lens getter setter
438 in lens getter setter
439
439
440-- | This lens is technically illegal. The implementation of 'TextAreaElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextAreaElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
440-- | This lens is technically illegal. The implementation of 'TextAreaElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'TextAreaElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
441−textAreaElementConfig_setValue :: Reflex t => Lens (TextAreaElementConfig er t m) (TextAreaElementConfig er t m) (Event t Text) (Event t Text)
441+textAreaElementConfig_setValue :: Reflex t => Lens' (TextAreaElementConfig er t m) (Event t Text)
442textAreaElementConfig_setValue =
442textAreaElementConfig_setValue =
443 let getter = fromMaybe never . _textAreaElementConfig_setValue
443 let getter = fromMaybe never . _textAreaElementConfig_setValue
444 setter t e = t { _textAreaElementConfig_setValue = Just e }
444 setter t e = t { _textAreaElementConfig_setValue = Just e }
445 in lens getter setter
445 in lens getter setter
446
446
447-- | This lens is technically illegal. The implementation of 'SelectElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'SelectElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
447-- | This lens is technically illegal. The implementation of 'SelectElementConfig' uses a 'Maybe' under the hood for efficiency reasons. However, always interacting with 'SelectElementConfig' via lenses will always behave correctly, and if you pattern match on it, you should always treat 'Nothing' as 'never'.
448−selectElementConfig_setValue :: Reflex t => Lens (SelectElementConfig er t m) (SelectElementConfig er t m) (Event t Text) (Event t Text)
448+selectElementConfig_setValue :: Reflex t => Lens' (SelectElementConfig er t m) (Event t Text)
449selectElementConfig_setValue =
449selectElementConfig_setValue =
450 let getter = fromMaybe never . _selectElementConfig_setValue
450 let getter = fromMaybe never . _selectElementConfig_setValue
451 setter t e = t { _selectElementConfig_setValue = Just e }
451 setter t e = t { _selectElementConfig_setValue = Just e }
reflex-dom-core/src/Reflex/Dom/Xhr.hs+1−1
@@ -215,7 +215,7 @@ _xhrResponse_body :: XhrResponse -> Maybe Text
215_xhrResponse_body = _xhrResponse_responseText
215_xhrResponse_body = _xhrResponse_responseText
216
216
217{-# DEPRECATED xhrResponse_body "Use xhrResponse_response or xhrResponse_responseText instead." #-}
217{-# DEPRECATED xhrResponse_body "Use xhrResponse_response or xhrResponse_responseText instead." #-}
218−xhrResponse_body :: Lens XhrResponse XhrResponse (Maybe Text) (Maybe Text)
218+xhrResponse_body :: Lens' XhrResponse (Maybe Text)
219xhrResponse_body = lens _xhrResponse_responseText (\r t -> r { _xhrResponse_responseText = t })
219xhrResponse_body = lens _xhrResponse_responseText (\r t -> r { _xhrResponse_responseText = t })
220
220
221instance a ~ () => Default (XhrRequestConfig a) where
221instance a ~ () => Default (XhrRequestConfig a) where