on develop help sign in
remove defunct perform event TODOs
commitd2d152d5f6fe57d4c00e9df75b180664b12904cc authorOwen Shepherd <owen.shepherd@obsidian.systems> dateTue 7 Apr 2020, 16:45 (7 years ago) parentf8403b6
1 file changed−4
src/Reflex/PerformEvent/Base.hs−4
src/Reflex/PerformEvent/Base.hs−4
@@ -94,7 +94,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
9494 (result0, requests0) <- lift $ runA a0
9595 newA <- requestingIdentity $ runA <$> a'
9696 requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA
97− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
9897 RequesterInternalT $ tellEvent requests
9998 pure (result0, fmapCheap fst newA)
10099 {-# INLINE traverseIntMapWithKeyWithAdjust #-}
@@ -109,7 +108,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
109108 results' = fmap fst <$> children'
110109 requests' = fmap snd `fmapCheap` children'
111110 requests <- switchHoldPromptOnlyIncremental mergeIntIncremental coincidencePatchIntMap requests0 requests'
112− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
113111 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatIntMapMaybe
114112 pure (results0, results')
115113 {-# INLINE traverseDMapWithKeyWithAdjust #-}
@@ -125,7 +123,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
125123 results' = mapPatchDMap (snd . getCompose) <$> children'
126124 requests' = weakenPatchDMapWith (fst . getCompose) `fmapCheap` children'
127125 requests <- switchHoldPromptOnlyIncremental mergeMapIncremental coincidencePatchMap requests0 requests'
128− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
129126 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
130127 pure (results0, results')
131128 {-# INLINE traverseDMapWithKeyWithAdjustWithMove #-}
@@ -141,7 +138,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
141138 results' = mapPatchDMapWithMove (snd . getCompose) <$> children'
142139 requests' = weakenPatchDMapWithMoveWith (fst . getCompose) `fmapCheap` children'
143140 requests <- switchHoldPromptOnlyIncremental mergeMapIncrementalWithMove coincidencePatchMapWithMove requests0 requests'
144− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
145141 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
146142 pure (results0, results')
147143