on develop help sign in
remove defunct perform event TODOs
d2d152dOwen Shepherd
src/Reflex/PerformEvent/Base.hs−4
@@ -94,7 +94,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
94 (result0, requests0) <- lift $ runA a0
94 (result0, requests0) <- lift $ runA a0
95 newA <- requestingIdentity $ runA <$> a'
95 newA <- requestingIdentity $ runA <$> a'
96 requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA
96 requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA
97− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
98 RequesterInternalT $ tellEvent requests
97 RequesterInternalT $ tellEvent requests
99 pure (result0, fmapCheap fst newA)
98 pure (result0, fmapCheap fst newA)
100 {-# INLINE traverseIntMapWithKeyWithAdjust #-}
99 {-# INLINE traverseIntMapWithKeyWithAdjust #-}
@@ -109,7 +108,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
109 results' = fmap fst <$> children'
108 results' = fmap fst <$> children'
110 requests' = fmap snd `fmapCheap` children'
109 requests' = fmap snd `fmapCheap` children'
111 requests <- switchHoldPromptOnlyIncremental mergeIntIncremental coincidencePatchIntMap requests0 requests'
110 requests <- switchHoldPromptOnlyIncremental mergeIntIncremental coincidencePatchIntMap requests0 requests'
112− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
113 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatIntMapMaybe
111 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatIntMapMaybe
114 pure (results0, results')
112 pure (results0, results')
115 {-# INLINE traverseDMapWithKeyWithAdjust #-}
113 {-# INLINE traverseDMapWithKeyWithAdjust #-}
@@ -125,7 +123,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
125 results' = mapPatchDMap (snd . getCompose) <$> children'
123 results' = mapPatchDMap (snd . getCompose) <$> children'
126 requests' = weakenPatchDMapWith (fst . getCompose) `fmapCheap` children'
124 requests' = weakenPatchDMapWith (fst . getCompose) `fmapCheap` children'
127 requests <- switchHoldPromptOnlyIncremental mergeMapIncremental coincidencePatchMap requests0 requests'
125 requests <- switchHoldPromptOnlyIncremental mergeMapIncremental coincidencePatchMap requests0 requests'
128− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
129 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
126 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
130 pure (results0, results')
127 pure (results0, results')
131 {-# INLINE traverseDMapWithKeyWithAdjustWithMove #-}
128 {-# INLINE traverseDMapWithKeyWithAdjustWithMove #-}
@@ -141,7 +138,6 @@ instance (ReflexHost t, PrimMonad (HostFrame t)) => Adjustable t (PerformEventT
141 results' = mapPatchDMapWithMove (snd . getCompose) <$> children'
138 results' = mapPatchDMapWithMove (snd . getCompose) <$> children'
142 requests' = weakenPatchDMapWithMoveWith (fst . getCompose) `fmapCheap` children'
139 requests' = weakenPatchDMapWithMoveWith (fst . getCompose) `fmapCheap` children'
143 requests <- switchHoldPromptOnlyIncremental mergeMapIncrementalWithMove coincidencePatchMapWithMove requests0 requests'
140 requests <- switchHoldPromptOnlyIncremental mergeMapIncrementalWithMove coincidencePatchMapWithMove requests0 requests'
144− --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent
145 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
141 RequesterInternalT $ tellEvent $ fforMaybeCheap requests concatMapMaybe
146 pure (results0, results')
142 pure (results0, results')
147
143