@@ -9,7 +9,6 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12−{-# LANGUAGE MultiWayIf #-}
1312{-# LANGUAGE RankNTypes #-}
1413{-# LANGUAGE RoleAnnotations #-}
1514{-# LANGUAGE ScopedTypeVariables #-}
@@ -20,6 +19,7 @@
2019{-# LANGUAGE DeriveFunctor #-}
2120{-# LANGUAGE StandaloneDeriving #-}
2221{-# LANGUAGE InstanceSigs #-}
22+{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,15 +38,17 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41−--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4241import Control.Monad.Reader.Class
4342import Control.Monad.IO.Class
4443import Control.Monad.ReaderIO
4544import Control.Monad.Ref
45+import Control.Monad.Fail (MonadFail)
46+import qualified Control.Monad.Fail as MonadFail
4647import Data.Align
4748import Data.Coerce
48−import Data.Dependent.Map (DMap, DSum (..))
49+import Data.Dependent.Map (DMap)
4950import qualified Data.Dependent.Map as DMap
51+import Data.Dependent.Sum (DSum (..))
5052import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5153import qualified Data.FastMutableIntMap as FastMutableIntMap
5254import Data.Foldable hiding (concat, elem, sequence_)
@@ -59,12 +61,13 @@ import qualified Data.IntMap.Strict as IntMap
5961import Data.IORef
6062import Data.Kind (Type)
6163import Data.Maybe hiding (mapMaybe)
62−import Data.Monoid ((<>))
64+import Data.Monoid (mempty, (<>))
6365import Data.Proxy
6466import Data.These
6567import Data.Traversable
68+import Data.Type.Equality ((:~:)(Refl))
6669import Data.Witherable (Filterable, mapMaybe)
67−import GHC.Exts
70+import GHC.Exts hiding (toList)
6871import GHC.IORef (IORef (..))
6972import GHC.Stack
7073import Reflex.FastWeak
@@ -72,22 +75,27 @@ import System.IO.Unsafe
7275import System.Mem.Weak
7376import Unsafe.Coerce
7477
75−#if defined(MIN_VERSION_semialign)
78+#ifdef MIN_VERSION_semialign
7679#if MIN_VERSION_these(0,8,0)
7780import Data.These.Combinators (justThese)
7881#endif
82+#if MIN_VERSION_semialign(1,1,0)
83+import Data.Zip (Zip (..))
84+#endif
7985#endif
8086
8187#ifdef DEBUG_CYCLES
8288import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89+#endif
90+
8391import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
8492import qualified Data.List.NonEmpty as NonEmpty
85−import Data.Monoid (mempty)
8693import Data.Tree (Forest, Tree (..), drawForest)
87−#endif
94+import Data.List (isPrefixOf)
8895
89−import Data.FastWeakBag (FastWeakBag)
96+import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
9097import qualified Data.FastWeakBag as FastWeakBag
98+
9199import Data.Reflection
92100import Data.Some (Some(Some))
93101import Data.Type.Coercion
@@ -98,22 +106,26 @@ import qualified Reflex.Class
98106import qualified Reflex.Class as R
99107import qualified Reflex.Host.Class
100108import Reflex.NotReady.Class
101−import Reflex.Patch
102−import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
109+import Data.Patch
110+import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111+import Reflex.PerformEvent.Base (PerformEventT)
103112
104113#ifdef DEBUG_TRACE_EVENTS
105114import qualified Data.ByteString.Char8 as BS8
106115import System.IO (stderr)
116+import Data.List (isPrefixOf)
107117#endif
108118
109−import Debug.Trace
119+-- TODO stdout might not be the best channel for debug output
120+debugStrLn :: String -> IO ()
121+debugStrLn = putStrLn
110122
111123#ifdef DEBUG_TRACE_EVENTS
112−
113124withStackOneLine :: (BS8.ByteString -> a) -> a
114125withStackOneLine expr = unsafePerformIO $ do
115126 stack <- currentCallStack
116− return (expr (BS8.pack (unwords (reverse stack))))
127+ return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128+ where dropInternal = filterStack "Reflex.Spider.Internal"
117129
118130#endif
119131
@@ -124,28 +136,42 @@ debugInvalidateHeight :: Bool
124136debugInvalidate :: Bool
125137
126138#ifdef DEBUG
127−
128139#define DEBUG_NODEIDS
129140
141+#ifdef DEBUG_TRACE_PROPAGATION
130142debugPropagate = True
143+#else
144+debugPropagate = False
145+#endif
131146
147+#ifdef DEBUG_TRACE_HEIGHT
148+debugInvalidateHeight = True
149+#else
132150debugInvalidateHeight = False
151+#endif
133152
153+#ifdef DEBUG_TRACE_INVALIDATION
134154debugInvalidate = True
155+#else
156+debugInvalidate = False
157+#endif
135158
136159class HasNodeId a where
137160 getNodeId :: a -> Int
138161
139−instance HasNodeId (Hold x p a) where
140− getNodeId = holdNodeId
162+instance HasNodeId (CacheSubscribed x a) where
163+ getNodeId = _cacheSubscribed_nodeId
164+
165+instance HasNodeId (FanInt x a) where
166+ getNodeId = _fanInt_nodeId
141167
142−instance HasNodeId (PushSubscribed x a b) where
143− getNodeId = pushSubscribedNodeId
168+instance HasNodeId (Hold x p) where
169+ getNodeId = holdNodeId
144170
145171instance HasNodeId (SwitchSubscribed x a) where
146172 getNodeId = switchSubscribedNodeId
147173
148−instance HasNodeId (FanSubscribed x a) where
174+instance HasNodeId (FanSubscribed x v a) where
149175 getNodeId = fanSubscribedNodeId
150176
151177instance HasNodeId (CoincidenceSubscribed x a) where
@@ -159,41 +185,16 @@ instance HasNodeId (Pull x a) where
159185
160186{-# INLINE showNodeId #-}
161187showNodeId :: HasNodeId a => a -> String
162−showNodeId = ("#"<>) . show . getNodeId
163−
164−showSubscriberType :: Subscriber x a -> String
165−showSubscriberType = \case
166− SubscriberPush _ _ -> "SubscriberPush"
167− SubscriberMerge _ _ -> "SubscriberMerge"
168− SubscriberFan _ -> "SubscriberFan"
169− SubscriberMergeChange _ -> "SubscriberMergeChange"
170− SubscriberHold _ -> "SubscriberHold"
171− SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
172− SubscriberSwitch _ -> "SubscriberSwitch"
173− SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
174− SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
175− SubscriberHandle -> "SubscriberHandle"
176−
177−showEventType :: Event x a -> String
178−showEventType = \case
179− EventRoot _ _ -> "EventRoot"
180− EventNever -> "EventNever"
181− EventPush _ -> "EventPush"
182− EventMerge _ -> "EventMerge"
183− EventFan _ _ -> "EventFan"
184− EventSwitch _ -> "EventSwitch"
185− EventCoincidence _ -> "EventCoincidence"
186− EventHold _ -> "EventHold"
187− EventDyn _ -> "EventDyn"
188− EventHoldIdentity _ -> "EventHoldIdentity"
189− EventDynIdentity _ -> "EventDynIdentity"
188+showNodeId = showNodeId' . getNodeId
189+
190+showNodeId' :: Int -> String
191+showNodeId' = ("#"<>) . show
192+
190193
191194#else
192195
193196debugPropagate = False
194−
195197debugInvalidateHeight = False
196−
197198debugInvalidate = False
198199
199200-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -201,6 +202,10 @@ debugInvalidate = False
201202showNodeId :: a -> String
202203showNodeId _ = ""
203204
205+{-# INLINE showNodeId' #-}
206+showNodeId' :: Int -> String
207+showNodeId' _ = ""
208+
204209#endif
205210
206211#ifdef DEBUG_NODEIDS
@@ -246,9 +251,9 @@ subscribeAndRead = unEvent
246251-- caching; if the computation function is very cheap, this is (much) more
247252-- efficient than 'push'
248253{-# INLINE [1] pushCheap #-}
249−pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
254+pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
250255pushCheap !f e = Event $ \sub -> do
251− (subscription, occ) <- subscribeAndRead e $ sub
256+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
252257 { subscriberPropagate = \a -> do
253258 mb <- f a
254259 mapM_ (subscriberPropagate sub) mb
@@ -267,10 +272,10 @@ terminalSubscriber p = Subscriber
267272
268273-- | Subscribe to an Event only for the duration of one occurrence
269274{-# INLINE subscribeAndReadHead #-}
270−subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
275+subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
271276subscribeAndReadHead e sub = do
272277 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
273− (subscription, occ) <- subscribeAndRead e $ sub
278+ (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
274279 { subscriberPropagate = \a -> do
275280 liftIO $ unsubscribe =<< readIORef subscriptionRef
276281 subscriberPropagate sub a
@@ -281,24 +286,42 @@ subscribeAndReadHead e sub = do
281286 return (subscription, occ)
282287
283288--TODO: Make this lazy in its input event
284−headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
289+headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
285290headE originalE = do
286291 parent <- liftIO $ newIORef $ Just originalE
287292 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
288293 let clearParent = liftIO $ writeIORef parent Nothing
289− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
294+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
290295 when (isJust occ) clearParent
291− return $ Event $ \sub -> do
296+ return $ Event $ \sub ->
292297 liftIO (readIORef parent) >>= \case
293− Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
298+ Nothing -> subscribeAndReadNever
294299 Just e -> subscribeAndReadHead e sub
295300
296301data CacheSubscribed x a
297302 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
298303 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
299304 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305+#ifdef DEBUG_NODEIDS
306+ , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307+#endif
300308 }
301309
310+nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311+nowSpiderEventM =
312+ SpiderEvent <$> now
313+
314+now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315+ ) => m (Event x ())
316+now = do
317+ nowOrNot <- liftIO $ newIORef $ Just ()
318+ scheduleClear nowOrNot
319+ return . Event $ \_ -> do
320+ occ <- liftIO . readIORef $ nowOrNot
321+ return ( EventSubscription (return ()) eventSubscribedNow
322+ , occ
323+ )
324+
302325-- | Construct an 'Event' whose value is guaranteed not to be recomputed
303326-- repeatedly
304327--
@@ -323,18 +346,23 @@ cacheEvent e =
323346 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
324347 Just subscribedTicket -> return subscribedTicket
325348 Nothing -> do
349+#ifdef DEBUG_NODEIDS
350+ nodeId <- liftIO newNodeId
351+#endif
326352 subscribers <- liftIO FastWeakBag.empty
327353 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354+#ifdef DEBUG_NODEIDS
355+ (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356+#else
328357 (parentSub, occ) <- subscribeAndRead e $ Subscriber
329− { subscriberPropagate = \a -> do
330− liftIO $ writeIORef occRef $ Just a
331− scheduleClear occRef
332− propagateFast a subscribers
333− , subscriberInvalidateHeight = \old -> do
334− FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
335− , subscriberRecalculateHeight = \new -> do
336− FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
337− }
358+#endif
359+ { subscriberPropagate = \a -> do
360+ liftIO $ writeIORef occRef (Just a)
361+ scheduleClear occRef
362+ propagateFast a subscribers
363+ , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364+ , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365+ }
338366 when (isJust occ) $ do
339367 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
340368 scheduleClear occRef
@@ -342,29 +370,45 @@ cacheEvent e =
342370 { _cacheSubscribed_subscribers = subscribers
343371 , _cacheSubscribed_parent = parentSub
344372 , _cacheSubscribed_occurrence = occRef
373+#ifdef DEBUG_NODEIDS
374+ , _cacheSubscribed_nodeId = nodeId
375+#endif
345376 }
346377 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
347378 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
348379 return subscribedTicket
349− liftIO $ do
350− subscribed <- getFastWeakTicketValue subscribedTicket
351− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
352− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
353− let es = EventSubscription
354− { _eventSubscription_unsubscribe = do
355− FastWeakBag.remove ticket
356− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
357− when isEmpty $ do
358− writeIORef mSubscribedRef emptyFastWeak
359− unsubscribe $ _cacheSubscribed_parent subscribed
360− touch ticket
361− touch subscribedTicket
362− , _eventSubscription_subscribed = EventSubscribed
363− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
364− , eventSubscribedRetained = toAny subscribedTicket
365− }
366− }
367− return (es, occ)
380+ liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381+
382+cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383+ -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384+cacheSubscription sub mSubscribedRef subscribedTicket = do
385+ subscribed <- getFastWeakTicketValue subscribedTicket
386+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388+
389+ let parentSub = _cacheSubscribed_parent subscribed
390+ es = EventSubscription
391+ { _eventSubscription_unsubscribe = do
392+ FastWeakBag.remove ticket
393+
394+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395+ when isEmpty $ do
396+ writeIORef mSubscribedRef emptyFastWeak
397+ unsubscribe parentSub
398+ touch ticket
399+ touch subscribedTicket
400+ , _eventSubscription_subscribed = EventSubscribed
401+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402+ , eventSubscribedRetained = toAny subscribedTicket
403+#ifdef DEBUG_CYCLES
404+ , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405+ , eventSubscribedHasOwnHeightRef = False
406+ , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407+#endif
408+ }
409+ }
410+ return (es, occ)
411+
368412
369413subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
370414subscribe e s = fst <$> subscribeAndRead e s
@@ -376,11 +420,14 @@ wrap tag getSpecificSubscribed sub = do
376420 let es = tag subd
377421 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
378422
379−eventRoot :: GCompare k => k a -> Root x k -> Event x a
423+eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
380424eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
381425
426+subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427+subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428+
382429eventNever :: Event x a
383−eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
430+eventNever = Event $ const subscribeAndReadNever
384431
385432eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
386433eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -417,16 +464,6 @@ data Subscriber x a = Subscriber
417464 , subscriberRecalculateHeight :: !(Height -> IO ())
418465 }
419466
420−--TODO: Move this comment to WeakBag
421−-- These function are constructor functions that are marked NOINLINE so they are
422−-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
423−-- so any weak references that are attached to the constructors will have their
424−-- finalizer run. Using the opaque constructor, does not see the
425−-- constructor application, so it behaves like an IORef and cannot be fused away.
426−--
427−-- The result is also evaluated to WHNF, since forcing a thunk invalidates
428−-- the weak pointer to it in some cases.
429−
430467newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
431468newSubscriberHold h = return $ Subscriber
432469 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -435,10 +472,10 @@ newSubscriberHold h = return $ Subscriber
435472 }
436473
437474newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
438−newSubscriberFan subscribed = return $ Subscriber
475+newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
439476 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
440477 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
441− tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
478+ tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
442479 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
443480 scheduleClear $ fanSubscribedOccurrence subscribed
444481 let f _ (Pair v subsubs) = do
@@ -447,72 +484,55 @@ newSubscriberFan subscribed = return $ Subscriber
447484 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
448485 return ()
449486 , subscriberInvalidateHeight = \old -> do
450− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
451487 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
452− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
453− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
488+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
454489 , subscriberRecalculateHeight = \new -> do
455− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
456490 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
457− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
458− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
491+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
459492 }
460493
461494newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
462−newSubscriberSwitch subscribed = return $ Subscriber
495+newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
463496 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
464− tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
465497 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
466498 scheduleClear $ switchSubscribedOccurrence subscribed
467499 propagate a $ switchSubscribedSubscribers subscribed
468500 , subscriberInvalidateHeight = \_ -> do
469− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
470501 oldHeight <- readIORef $ switchSubscribedHeight subscribed
471502 when (oldHeight /= invalidHeight) $ do
472503 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
473− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
474− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
475− , subscriberRecalculateHeight = \new -> do
476− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
477− updateSwitchHeight new subscribed
478− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
479− }
504+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505+ , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506+ }
480507
481508newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
482−newSubscriberCoincidenceOuter subscribed = return $ Subscriber
509+newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
483510 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
484− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
485511 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
486512 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
487513 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
488514 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
489515 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516+
490517 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
491518 scheduleClear $ coincidenceSubscribedInnerParent subscribed
492519 case occ of
493− Nothing -> do
520+ Nothing ->
494521 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
495522 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
496− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
497− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
523+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
498525 Just o -> do -- Since it's already firing, no need to adjust height
499526 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
500527 scheduleClear $ coincidenceSubscribedOccurrence subscribed
501528 propagate o $ coincidenceSubscribedSubscribers subscribed
502− , subscriberInvalidateHeight = \_ -> do
503− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
504− invalidateCoincidenceHeight subscribed
505− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
506− , subscriberRecalculateHeight = \_ -> do
507− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
508− recalculateCoincidenceHeight subscribed
509− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
529+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
510531 }
511532
512533newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
513−newSubscriberCoincidenceInner subscribed = return $ Subscriber
534+newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
514535 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
515− tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
516536 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
517537 case occ of
518538 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -520,14 +540,8 @@ newSubscriberCoincidenceInner subscribed = return $ Subscriber
520540 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
521541 scheduleClear $ coincidenceSubscribedOccurrence subscribed
522542 propagate a $ coincidenceSubscribedSubscribers subscribed
523− , subscriberInvalidateHeight = \_ -> do
524− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
525− invalidateCoincidenceHeight subscribed
526− when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
527− , subscriberRecalculateHeight = \_ -> do
528− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
529− recalculateCoincidenceHeight subscribed
530− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
543+ , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544+ , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
531545 }
532546
533547invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -537,18 +551,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
537551recalculateSubscriberHeight = flip subscriberRecalculateHeight
538552
539553-- | Propagate everything at the current height
540−propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
541−propagate a subscribers = withIncreasedDepth $ do
554+propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555+propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
542556 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
543557 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
544− WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
558+ WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
545559
546560-- | Propagate everything at the current height
547−propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
548−propagateFast a subscribers = withIncreasedDepth $ do
561+propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562+propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
549563 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
550564 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
551− FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
565+ FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
552566
553567--------------------------------------------------------------------------------
554568-- EventSubscribed
@@ -566,7 +580,7 @@ data EventSubscribed x = EventSubscribed
566580 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
567581 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
568582#ifdef DEBUG_CYCLES
569− , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
583+ , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
570584 , eventSubscribedHasOwnHeightRef :: !Bool
571585 , eventSubscribedWhoCreated :: !(IO [String])
572586#endif
@@ -593,13 +607,23 @@ eventSubscribedNever = EventSubscribed
593607 , eventSubscribedWhoCreated = return ["never"]
594608#endif
595609 }
610+eventSubscribedNow :: EventSubscribed x
611+eventSubscribedNow = EventSubscribed
612+ { eventSubscribedHeightRef = zeroRef
613+ , eventSubscribedRetained = toAny ()
614+#ifdef DEBUG_CYCLES
615+ , eventSubscribedGetParents = return []
616+ , eventSubscribedHasOwnHeightRef = False
617+ , eventSubscribedWhoCreated = return ["now"]
618+#endif
619+ }
596620
597621eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
598622eventSubscribedFan !subscribed = EventSubscribed
599623 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
600624 , eventSubscribedRetained = toAny subscribed
601625#ifdef DEBUG_CYCLES
602− , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
626+ , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
603627 , eventSubscribedHasOwnHeightRef = False
604628 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
605629#endif
@@ -612,7 +636,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
612636#ifdef DEBUG_CYCLES
613637 , eventSubscribedGetParents = do
614638 s <- readIORef $ switchSubscribedCurrentParent subscribed
615− return [Some $ _eventSubscription_subscribed s]
639+ return [_eventSubscription_subscribed s]
616640 , eventSubscribedHasOwnHeightRef = True
617641 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
618642#endif
@@ -625,8 +649,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
625649#ifdef DEBUG_CYCLES
626650 , eventSubscribedGetParents = do
627651 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
628− let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
629− innerParents = maybeToList $ fmap Some innerSubscription
652+ let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653+ innerParents = maybeToList $ innerSubscription
630654 return $ outerParent : innerParents
631655 , eventSubscribedHasOwnHeightRef = True
632656 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -640,15 +664,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
640664whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
641665whoCreatedEventSubscribed = eventSubscribedWhoCreated
642666
643−walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
667+walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
644668walkInvalidHeightParents s0 = do
645− subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
669+ subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
646670 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
647671 when (h == invalidHeight) $ do
648672 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
649− modify (Some s :)
673+ modify (s :)
650674 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
651− forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
675+ forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
652676 return subscribers
653677#endif
654678
@@ -970,8 +994,10 @@ instance Monad (BehaviorM x) where
970994 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
971995 {-# INLINE return #-}
972996 return x = BehaviorM $ return x
997+#if !MIN_VERSION_base(4,13,0)
973998 {-# INLINE fail #-}
974999 fail s = BehaviorM $ fail s
1000+#endif
9751001
9761002data BehaviorSubscribed x a
9771003 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1031,7 +1057,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10311057newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10321058
10331059-- EventM can do everything BehaviorM can, plus create holds
1034−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
1060+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
10351061
10361062newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10371063
@@ -1056,7 +1082,8 @@ heightBagFromList :: [Height] -> HeightBag
10561082heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10571083
10581084heightBagAdd :: Height -> HeightBag -> HeightBag
1059−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1085+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086+ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10601087
10611088heightBagRemove :: Height -> HeightBag -> HeightBag
10621089heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1065,6 +1092,13 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10651092 0 -> IntMap.delete h c
10661093 _ -> IntMap.insert h (pred old) c
10671094
1095+heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096+heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097+ removed old = HeightBag (pred s) $ case old of
1098+ 0 -> IntMap.delete h c
1099+ _ -> IntMap.insert h (pred old) c
1100+
1101+
10681102heightBagMax :: HeightBag -> Height
10691103heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
10701104 Just ((h, _), _) -> Height h
@@ -1165,7 +1199,10 @@ instance HasSpiderTimeline x => Semialign (Event x) where
11651199 align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
11661200 DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
11671201
1168−#if defined(MIN_VERSION_semialign)
1202+#ifdef MIN_VERSION_semialign
1203+#if MIN_VERSION_semialign(1,1,0)
1204+instance HasSpiderTimeline x => Zip (Event x) where
1205+#endif
11691206 zip x y = mapMaybe justThese $ align x y
11701207#endif
11711208
@@ -1309,55 +1346,110 @@ mkWeakPtrWithDebug x debugNote = do
13091346 x' <- evaluate x
13101347 mkWeakPtr x' $
13111348 if debugFinalize
1312− then Just $ putStrLn $ "finalizing: " ++ debugNote
1349+ then Just $ debugStrLn $ "finalizing: " ++ debugNote
13131350 else Nothing
13141351
13151352type WeakList a = [Weak a]
13161353
1317−{-# INLINE withIncreasedDepth #-}
1354+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355+
1356+
1357+
1358+
13181359#ifdef DEBUG
1319−withIncreasedDepth :: CanTrace x m => m a -> m a
1320−withIncreasedDepth a = do
1321− spiderTimeline <- askSpiderTimelineEnv
1322− liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
1360+
1361+debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362+debugSubscriber description = return . debugSubscriber' description
1363+
1364+debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365+debugSubscriber' description subscribed = Subscriber
1366+ {
1367+ subscriberPropagate = \m -> do
1368+ tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369+ subscriberPropagate subscribed m
1370+ , subscriberInvalidateHeight = \old -> do
1371+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372+ subscriberInvalidateHeight subscribed old
1373+ traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374+ , subscriberRecalculateHeight = \new -> do
1375+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376+ subscriberRecalculateHeight subscribed new
1377+ traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378+ }
1379+
1380+
1381+{-# INLINE withIncreasedDepth #-}
1382+withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383+withIncreasedDepth _ a = do
1384+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
13231385 result <- a
1324− liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
1386+ liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
13251387 return result
1326−#else
1327−withIncreasedDepth :: m a -> m a
1328−withIncreasedDepth = id
1329−#endif
1330−
1331−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
13321388
13331389{-# INLINE tracePropagate #-}
13341390tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1335−tracePropagate p = traceWhen p debugPropagate
1391+tracePropagate p = when debugPropagate . trace p
13361392
13371393{-# INLINE traceInvalidate #-}
13381394traceInvalidate :: String -> IO ()
1339−traceInvalidate = when debugInvalidate . liftIO . putStrLn
1395+traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396+
1397+{-# INLINE traceInvalidateHeight #-}
1398+traceInvalidateHeight :: String -> IO ()
1399+traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
13401400
1341−{-# INLINE traceWhen #-}
1342−traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1343−traceWhen p b message = traceMWhen p b $ return message
1401+{-# INLINE trace #-}
1402+trace :: (CanTrace x m) => proxy x -> String -> m ()
1403+trace p message = traceM p $ return message
13441404
1345−{-# INLINE traceMWhen #-}
1346−traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1347−traceMWhen _ b getMessage = when b $ do
1405+{-# INLINE traceM #-}
1406+traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407+traceM _ getMessage = do
13481408 message <- getMessage
1349−#ifdef DEBUG
1350− spiderTimeline <- askSpiderTimelineEnv
1351− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1409+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410+ liftIO $ debugStrLn $ replicate d ' ' <> message
1411+
13521412#else
1353− let d = 0
1413+
1414+{-# INLINE withIncreasedDepth #-}
1415+withIncreasedDepth :: proxy x -> m a -> m a
1416+withIncreasedDepth _ = id
1417+
1418+{-# INLINE tracePropagate #-}
1419+tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420+tracePropagate _ _ = return ()
1421+
1422+{-# INLINE traceInvalidate #-}
1423+traceInvalidate :: String -> IO ()
1424+traceInvalidate _ = return ()
1425+
1426+{-# INLINE traceInvalidateHeight #-}
1427+traceInvalidateHeight :: String -> IO ()
1428+traceInvalidateHeight _ = return ()
1429+
1430+{-# INLINE debugSubscriber #-}
1431+debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432+debugSubscriber _ = return
1433+
1434+{-# INLINE debugSubscriber' #-}
1435+debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436+debugSubscriber' _ = id
1437+
1438+
1439+
1440+{-# INLINE trace #-}
1441+trace :: (CanTrace x m) => proxy x -> String -> m ()
1442+trace _ _ = return ()
1443+
1444+{-# INLINE traceM #-}
1445+traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446+traceM _ _ = return ()
1447+
13541448#endif
1355− liftIO $ putStrLn $ replicate d ' ' <> message
13561449
13571450whoCreatedIORef :: IORef a -> IO [String]
13581451whoCreatedIORef (IORef a) = whoCreated $! a
13591452
1360−#ifdef DEBUG_CYCLES
13611453groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
13621454groupByHead = \case
13631455 [] -> []
@@ -1368,20 +1460,54 @@ groupByHead = \case
13681460 | otherwise -> (x, xs :| []) : l
13691461
13701462listsToForest :: Eq a => [[a]] -> Forest a
1371−listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
1463+listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464+ where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465+
1466+showStacks :: [[String]] -> String
1467+showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468+
1469+filterStack :: String -> [String] -> [String]
1470+#ifdef DEBUG_HIDE_INTERNALS
1471+filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472+#else
1473+filterStack prefix = id
1474+#endif
1475+
1476+#ifdef DEBUG_CYCLES
1477+
1478+data EventLoopException = EventLoopException [[String]]
1479+instance Exception EventLoopException
1480+
1481+instance Show EventLoopException where
1482+ show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483+ then "no location information, compile with profiling enabled for stack tree"
1484+ else showStacks stacks
1485+
1486+#else
1487+
1488+data EventLoopException = EventLoopException
1489+instance Exception EventLoopException
1490+
1491+instance Show EventLoopException where
1492+ show EventLoopException = "causality loop detected: \n" <>
1493+ "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494+
13721495#endif
13731496
1497+
13741498{-# INLINE propagateSubscriberHold #-}
13751499propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
13761500propagateSubscriberHold h a = do
1377− {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
1501+ {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
13781502 invalidators <- liftIO $ readIORef $ holdInvalidators h
13791503 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504+
13801505 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
13811506 case {-# SCC "apply" #-} apply a v of
13821507 Nothing -> return ()
13831508 Just v' -> do
1384− {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
1509+ {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510+ tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
13851511 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
13861512 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
13871513 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1435,7 +1561,7 @@ getDynHold d = do
14351561zeroRef :: IORef Height
14361562zeroRef = unsafePerformIO $ newIORef zeroHeight
14371563
1438−getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1564+getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
14391565getRootSubscribed k r sub = do
14401566 mSubscribed <- readIORef $ rootSubscribed r
14411567 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1449,7 +1575,9 @@ getRootSubscribed k r sub = do
14491575 let !cached = rootSubscribed r
14501576 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
14511577 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1452− when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
1578+
1579+ tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580+
14531581 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
14541582 writeIORef uninitRef $! uninit
14551583#ifdef DEBUG_NODEIDS
@@ -1499,6 +1627,9 @@ data FanInt x a = FanInt
14991627 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
15001628 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
15011629 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630+#ifdef DEBUG_NODEIDS
1631+ , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632+#endif
15021633 }
15031634
15041635newFanInt :: IO (FanInt x a)
@@ -1506,33 +1637,39 @@ newFanInt = do
15061637 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
15071638 subscriptionRef <- newIORef $ error "fanInt: no subscription"
15081639 occRef <- newIORef $ error "fanInt: no occurrence"
1640+#ifdef DEBUG_NODEIDS
1641+ nodeId <- newNodeId
1642+#endif
15091643 return $ FanInt
15101644 { _fanInt_subscribers = subscribers
15111645 , _fanInt_subscriptionRef = subscriptionRef
15121646 , _fanInt_occRef = occRef
1647+#ifdef DEBUG_NODEIDS
1648+ , _fanInt_nodeId = nodeId
1649+#endif
15131650 }
15141651
15151652fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
15161653fanInt p = unsafePerformIO $ do
15171654 self <- newFanInt
1518− pure $ EventSelectorInt $ \k -> trace ("select " <> show k) $ Event $ \sub -> do
1655+ pure $ EventSelectorInt $ \k -> Event $ \sub -> do
15191656 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
15201657 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1521− (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
1658+ let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659+ (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
15221660 { subscriberPropagate = \m -> do
15231661 liftIO $ writeIORef (_fanInt_occRef self) m
15241662 scheduleIntClear $ _fanInt_occRef self
1525− liftIO $ putStrLn $ "Pushing " <> show (IntMap.size m) <> " occurrences"
1526− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1527− FastWeakBag.traverse b $ \s -> do
1663+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664+ FastWeakBag.traverse_ b $ \s ->
15281665 subscriberPropagate s v
1529− , subscriberInvalidateHeight = \old -> do
1530− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1531− FastWeakBag.traverse b $ \s -> do
1666+ , subscriberInvalidateHeight = \old ->
1667+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668+ FastWeakBag.traverse_ b $ \s ->
15321669 subscriberInvalidateHeight s old
1533− , subscriberRecalculateHeight = \new -> do
1534− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1535− FastWeakBag.traverse b $ \s -> do
1670+ , subscriberRecalculateHeight = \new ->
1671+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672+ FastWeakBag.traverse_ b $ \s ->
15361673 subscriberRecalculateHeight s new
15371674 }
15381675 liftIO $ do
@@ -1546,10 +1683,25 @@ fanInt p = unsafePerformIO $ do
15461683 FastMutableIntMap.insert (_fanInt_subscribers self) k b
15471684 return b
15481685 Just b -> return b
1549− t <- liftIO $ FastWeakBag.insert sub b
1686+ ticket <- liftIO $ FastWeakBag.insert sub b
15501687 currentOcc <- readIORef (_fanInt_occRef self)
1551− (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1552− return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
1688+
1689+ subscribed <- fanIntSubscribed ticket self
1690+ return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691+
1692+fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693+fanIntSubscribed ticket self = do
1694+ subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695+ return $ EventSubscribed
1696+ { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697+ , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698+#ifdef DEBUG_CYCLES
1699+ , eventSubscribedGetParents = return [subscribedParent]
1700+ , eventSubscribedHasOwnHeightRef = False
1701+ , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702+#endif
1703+ }
1704+
15531705
15541706{-# INLINABLE getFanSubscribed #-}
15551707getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1747,7 +1899,7 @@ mergeCheap
17471899 => (forall a. q a -> Event x (v a))
17481900 -> DynamicS x (PatchDMap k q)
17491901 -> Event x (DMap k v)
1750−mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
1902+mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
17511903 where
17521904 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
17531905 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1762,7 +1914,9 @@ mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
17621914 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
17631915 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
17641916 forM_ mOldSubd $ \oldSubd -> do
1765− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1917+ oldHeight <- liftIO $ getEventSubscribedHeight $
1918+ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919+
17661920 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
17671921 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
17681922 foldM f ([], oldParents) $ DMap.toList p
@@ -1787,7 +1941,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
17871941 => (forall a. q a -> Event x (v a))
17881942 -> DynamicS x (PatchDMapWithMove k q)
17891943 -> Event x (DMap k v)
1790−mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
1944+mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
17911945 where
17921946 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
17931947 updateMe subscriber heightBagRef oldParents p = do
@@ -1806,13 +1960,17 @@ mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
18061960 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
18071961 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
18081962 Nothing -> do
1809− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
1963+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964+ _mergeSubscribedParentWithMove_subscription parent
1965+
18101966 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
18111967 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
18121968 Just toKey -> do
18131969 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
18141970 return Nothing
1815− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1971+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972+ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973+
18161974 return (toDelete, applyAlways p' oldParents)
18171975 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
18181976 getInitialSubscribers initialParents subscriber = do
@@ -1837,6 +1995,8 @@ type MergeUpdateFunc k v x p s
18371995 -> p
18381996 -> EventM x ([EventSubscription x], DMap k s)
18391997
1998+type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999+
18402000type MergeInitFunc k v q x s
18412001 = DMap k q
18422002 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -1860,14 +2020,17 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
18602020invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
18612021invalidateMergeHeight' heightRef sub = do
18622022 oldHeight <- readIORef heightRef
1863− when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2023+ -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024+ when (oldHeight /= invalidHeight) $ do
18642025 writeIORef heightRef $! invalidHeight
18652026 subscriberInvalidateHeight sub oldHeight
18662027
18672028revalidateMergeHeight :: Merge x k v s -> IO ()
18682029revalidateMergeHeight m = do
18692030 currentHeight <- readIORef $ _merge_heightRef m
1870− when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2031+
2032+ -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033+ when (currentHeight == invalidHeight) $ do
18712034 heights <- readIORef $ _merge_heightBagRef m
18722035 parents <- readIORef $ _merge_parentsRef m
18732036 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -1875,7 +2038,7 @@ revalidateMergeHeight m = do
18752038 LT -> return ()
18762039 EQ -> do
18772040 let height = succHeight $ heightBagMax heights
1878− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2041+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
18792042 writeIORef (_merge_heightRef m) $! height
18802043 subscriberRecalculateHeight (_merge_sub m) height
18812044 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -1883,36 +2046,45 @@ revalidateMergeHeight m = do
18832046scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
18842047scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
18852048 vals <- liftIO $ readIORef $ _merge_accumRef m
1886− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2049+ -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050+ -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
18872052 --TODO: Assert that m is not empty
18882053 subscriberPropagate (_merge_sub m) vals
18892054
1890−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1891−mergeSubscriber m getKey = Subscriber
2055+checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056+checkCycle subscribed = liftIO $ do
2057+ height <- readIORef (eventSubscribedHeightRef subscribed)
2058+
2059+ -- currentHeight <- getCurrentHeight
2060+ -- when (height <= currentHeight) $ if height /= invalidHeight
2061+ -- then do
2062+ -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063+ -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064+ -- else liftIO $
2065+ when (height == invalidHeight) $
2066+#ifdef DEBUG_CYCLES
2067+ do
2068+ nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069+ stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070+ throwIO (EventLoopException stacks)
2071+#else
2072+ throwIO EventLoopException
2073+#endif
2074+
2075+
2076+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077+mergeSubscriber subscribed m getKey = Subscriber
18922078 { subscriberPropagate = \a -> do
18932079 oldM <- liftIO $ readIORef $ _merge_accumRef m
18942080 k <- getKey
1895− let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
2081+ let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
18962082 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
18972083 liftIO $ writeIORef (_merge_accumRef m) $! newM
18982084 when (DMap.null oldM) $ do -- Only schedule the firing once
18992085 height <- liftIO $ readIORef $ _merge_heightRef m
1900− --TODO: assertions about height
1901− currentHeight <- getCurrentHeight
1902− when (height <= currentHeight) $ do
1903− if height /= invalidHeight
1904− then do
1905− myStack <- liftIO $ whoCreatedIORef undefined --TODO
1906− error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1907− else liftIO $ do
1908−#ifdef DEBUG_CYCLES
1909− nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1910− stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1911− let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1912−#else
1913− let cycleInfo = ""
1914−#endif
1915− error $ "Causality loop found" <> cycleInfo
2086+ checkCycle subscribed
2087+
19162088 scheduleMergeSelf m height
19172089 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
19182090 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -1923,31 +2095,45 @@ mergeSubscriber m getKey = Subscriber
19232095 }
19242096
19252097--TODO: Be able to run as much of this as possible promptly
1926−updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1927−updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
2098+updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099+updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
19282100 where updateMe = do
19292101 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
1930− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
2102+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
19312103 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
19322104 return subscriptionsToKill
19332105
19342106{-# INLINE mergeGCheap' #-}
19352107mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
1936− => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1937−mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
2108+ => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109+mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
19382110 initialParents <- readBehaviorUntracked $ dynamicCurrent d
19392111 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
19402112 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
19412113 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
19422114 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
1943− let m = Merge
2115+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116+
2117+ let subscribed = EventSubscribed
2118+ { eventSubscribedHeightRef = heightRef
2119+ , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120+#ifdef DEBUG_CYCLES
2121+ , eventSubscribedGetParents = do
2122+ let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123+ fmap getParent' . DMap.toList <$> readIORef parentsRef
2124+ , eventSubscribedHasOwnHeightRef = False
2125+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126+#endif
2127+ }
2128+
2129+ m = Merge
19442130 { _merge_parentsRef = parentsRef
19452131 , _merge_heightBagRef = heightBagRef
19462132 , _merge_heightRef = heightRef
19472133 , _merge_sub = sub
19482134 , _merge_accumRef = accumRef
19492135 }
1950− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
2136+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
19512137 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
19522138 myHeight = if invalidHeight `elem` heights
19532139 then invalidHeight
@@ -1956,31 +2142,29 @@ mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
19562142 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
19572143 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
19582144 else (Nothing, dm)
1959− unless (DMap.null accum) $ do
1960− scheduleMergeSelf m myHeight
2145+ unless (DMap.null accum) $ scheduleMergeSelf m myHeight
19612146 liftIO $ writeIORef accumRef $! accum
19622147 liftIO $ writeIORef heightRef $! myHeight
19632148 liftIO $ writeIORef heightBagRef $! myHeightBag
1964− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
19652149 liftIO $ writeIORef parentsRef $! initialParentState
19662150 defer $ SomeMergeInit $ do
1967− let s = Subscriber
2151+ let changeSubscriber = Subscriber
19682152 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
1969− tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1970− defer $ updateMerge m updateFunc a
2153+ tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154+ defer $ updateMerge subscribed m updateFunc a
19712155 , subscriberInvalidateHeight = \_ -> return ()
19722156 , subscriberRecalculateHeight = \_ -> return ()
19732157 }
1974− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1975− forM_ change $ \c -> defer $ updateMerge m updateFunc c
2158+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159+ forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
19762160 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
19772161 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
19782162 -- its subscription.
1979− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2163+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
19802164 let unsubscribeAll = destroy =<< readIORef parentsRef
1981− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1982− , occ
1983− )
2165+
2166+ return (EventSubscription unsubscribeAll subscribed, occ)
2167+
19842168
19852169mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
19862170mergeInt = cacheEvent . mergeIntCheap
@@ -1993,13 +2177,22 @@ mergeIntCheap d = Event $ \sub -> do
19932177 heightRef <- liftIO $ newIORef zeroHeight
19942178 heightBagRef <- liftIO $ newIORef heightBagEmpty
19952179 parents <- liftIO $ FastMutableIntMap.newEmpty
2180+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181+ let subscribed = EventSubscribed
2182+ { eventSubscribedHeightRef = heightRef
2183+ , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184+#ifdef DEBUG_CYCLES
2185+ , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186+ , eventSubscribedHasOwnHeightRef = False
2187+ , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188+#endif
2189+ }
19962190 let scheduleSelf = do
19972191 height <- liftIO $ readIORef $ heightRef
19982192 scheduleMerge' height heightRef $ do
19992193 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
20002194 subscriberPropagate sub vals
2001− invalidateMyHeight = do
2002− invalidateMergeHeight' heightRef sub
2195+ invalidateMyHeight = invalidateMergeHeight' heightRef sub
20032196 recalculateMyHeight = do
20042197 currentHeight <- readIORef heightRef
20052198 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2009,12 +2202,14 @@ mergeIntCheap d = Event $ \sub -> do
20092202 LT -> return ()
20102203 EQ -> do
20112204 let height = succHeight $ heightBagMax heights
2012− when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
2205+ traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
20132206 writeIORef heightRef $! height
20142207 subscriberRecalculateHeight sub height
20152208 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
20162209 mySubscriber k = Subscriber
20172210 { subscriberPropagate = \a -> do
2211+ checkCycle subscribed
2212+
20182213 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
20192214 liftIO $ FastMutableIntMap.insert accum k a
20202215 when wasEmpty scheduleSelf
@@ -2048,7 +2243,6 @@ mergeIntCheap d = Event $ \sub -> do
20482243 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
20492244 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
20502245 return Nothing
2051− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
20522246 defer $ SomeMergeInit $ do
20532247 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
20542248 where
@@ -2062,25 +2256,27 @@ mergeIntCheap d = Event $ \sub -> do
20622256 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
20632257 liftIO $ for_ oldParents $ \oldParent -> do
20642258 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259+
2260+ print ("updateMe", oldParentHeight)
20652261 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
20662262 return $ IntMap.elems oldParents
2067− let s = Subscriber
2263+ let changeSubscriber = Subscriber
20682264 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
20692265 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
20702266 defer $ updateMe a
20712267 , subscriberInvalidateHeight = \_ -> return ()
20722268 , subscriberRecalculateHeight = \_ -> return ()
20732269 }
2074− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
2270+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
20752271 forM_ change $ \c -> defer $ updateMe c
20762272 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
20772273 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
20782274 -- its subscription.
2079− liftIO $ writeIORef changeSubdRef (s, changeSubscription)
2275+ liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
20802276 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2081− return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2082− , occ
2083− )
2277+
2278+
2279+ return (EventSubscription unsubscribeAll subscribed, occ)
20842280
20852281newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
20862282newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2163,19 +2359,19 @@ runFrame a = SpiderHost $ do
21632359 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
21642360 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
21652361 writeIORef vRef v
2166− when debugInvalidate $ putStrLn $ "Invalidating Hold"
2362+ traceInvalidate $ "Invalidating Hold"
21672363 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
21682364 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
21692365 writeIORef (eventEnvMergeUpdates env) []
2170− when debugPropagate $ putStrLn "Updating merges"
2366+ tracePropagate (Proxy::Proxy x) $ "Updating merges"
21712367 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2172− when debugPropagate $ putStrLn "Updating merges done"
2368+ tracePropagate (Proxy::Proxy x) $ "Updating merges done"
21732369 toReconnect <- readIORef toReconnectRef
21742370 clearEventEnv env
21752371 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
21762372 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
21772373 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2178− when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2374+ traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
21792375 finalize wi
21802376 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
21812377 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2189,7 +2385,7 @@ runFrame a = SpiderHost $ do
21892385 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
21902386 {-
21912387 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2192− liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2388+ liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
21932389 EventRoot _ -> "EventRoot"
21942390 EventNever -> "EventNever"
21952391 _ -> "something else"
@@ -2204,7 +2400,7 @@ runFrame a = SpiderHost $ do
22042400 myHeight <- readIORef $ switchSubscribedHeight subscribed
22052401 when (parentHeight /= myHeight) $ do
22062402 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2207− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2403+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
22082404 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
22092405 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
22102406 unsubscribe subscription
@@ -2245,7 +2441,7 @@ invalidateCoincidenceHeight subscribed = do
22452441 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
22462442 when (oldHeight /= invalidHeight) $ do
22472443 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2248− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2444+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
22492445
22502446updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
22512447updateSwitchHeight new subscribed = do
@@ -2253,7 +2449,7 @@ updateSwitchHeight new subscribed = do
22532449 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22542450 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
22552451 writeIORef (switchSubscribedHeight subscribed) $! new
2256− WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2452+ WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
22572453
22582454recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
22592455recalculateCoincidenceHeight subscribed = do
@@ -2262,7 +2458,7 @@ recalculateCoincidenceHeight subscribed = do
22622458 height <- calculateCoincidenceHeight subscribed
22632459 when (height /= invalidHeight) $ do
22642460 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2265− WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2461+ WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
22662462
22672463calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
22682464calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2324,6 +2520,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
23242520 {-# INLINABLE headE #-}
23252521 headE = R.slowHeadE
23262522-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523+ {-# INLINABLE now #-}
2524+ now = nowSpiderEventM
23272525
23282526instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
23292527 {-# INLINABLE sample #-}
@@ -2345,6 +2543,9 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
23452543 {-# INLINABLE headE #-}
23462544 headE = R.slowHeadE
23472545-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546+ {-# INLINABLE now #-}
2547+ now = SpiderPushM nowSpiderEventM
2548+
23482549
23492550instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
23502551 {-# INLINE return #-}
@@ -2353,8 +2554,10 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
23532554 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
23542555 {-# INLINE (>>) #-}
23552556 (>>) = (*>)
2557+#if !MIN_VERSION_base(4,13,0)
23562558 {-# INLINE fail #-}
23572559 fail _ = error "Dynamic does not support 'fail'"
2560+#endif
23582561
23592562{-# INLINABLE newJoinDyn #-}
23602563newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
@@ -2406,6 +2609,9 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
24062609 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
24072610 {-# INLINABLE headE #-}
24082611 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612+ {-# INLINABLE now #-}
2613+ now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614+
24092615
24102616instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
24112617 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2422,6 +2628,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
24222628 {-# INLINABLE headE #-}
24232629 headE = R.slowHeadE
24242630-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631+ {-# INLINABLE now #-}
2632+ now = SpiderHostFrame Reflex.Class.now
24252633
24262634instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
24272635 {-# INLINABLE sample #-}
@@ -2442,6 +2650,8 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
24422650 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
24432651 {-# INLINABLE headE #-}
24442652 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653+ {-# INLINABLE now #-}
2654+ now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
24452655
24462656--------------------------------------------------------------------------------
24472657-- Deprecated items
@@ -2479,13 +2689,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
24792689 touch h
24802690 return result
24812691
2482−instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2692+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
24832693 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
24842694 newFanEventWithTrigger f = SpiderHost $ do
24852695 es <- newFanEventWithTriggerIO f
24862696 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
24872697
2488−instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2698+instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
24892699 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
24902700 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
24912701 es <- newFanEventWithTriggerIO f
@@ -2565,7 +2775,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
25652775 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
25662776 {-# INLINABLE mergeG #-}
25672777 mergeG
2568− :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2778+ :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
25692779 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
25702780 -> DMap k q
25712781 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2633,8 +2843,14 @@ instance Monad (SpiderHost x) where
26332843 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
26342844 {-# INLINABLE return #-}
26352845 return x = SpiderHost $ return x
2846+#if !MIN_VERSION_base(4,13,0)
26362847 {-# INLINABLE fail #-}
2637− fail s = SpiderHost $ fail s
2848+ fail = MonadFail.fail
2849+#endif
2850+
2851+instance MonadFail (SpiderHost x) where
2852+ {-# INLINABLE fail #-}
2853+ fail s = SpiderHost $ MonadFail.fail s
26382854
26392855-- | Run an action affecting the global Spider timeline; this will be guarded by
26402856-- a mutex for that timeline
@@ -2656,19 +2872,21 @@ instance Monad (SpiderHostFrame x) where
26562872 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
26572873 {-# INLINABLE return #-}
26582874 return x = SpiderHostFrame $ return x
2875+#if !MIN_VERSION_base(4,13,0)
26592876 {-# INLINABLE fail #-}
26602877 fail s = SpiderHostFrame $ fail s
2878+#endif
26612879
26622880instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
26632881 notReadyUntil _ = pure ()
26642882 notReady = pure ()
26652883
2666−newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2884+newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
26672885newEventWithTriggerIO f = do
26682886 es <- newFanEventWithTriggerIO $ \Refl -> f
26692887 return $ select es Refl
26702888
2671−newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2889+newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
26722890newFanEventWithTriggerIO f = do
26732891 occRef <- newIORef DMap.empty
26742892 subscribedRef <- newIORef DMap.empty
@@ -2702,3 +2920,11 @@ instance MonadAtomicRef (SpiderHostFrame x) where
27022920instance PrimMonad (SpiderHostFrame x) where
27032921 type PrimState (SpiderHostFrame x) = PrimState IO
27042922 primitive = SpiderHostFrame . EventM . primitive
2923+
2924+instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925+ notReadyUntil _ = return ()
2926+ notReady = return ()
2927+
2928+instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929+ notReadyUntil _ = return ()
2930+ notReady = return ()