@@ -9,6 +9,7 @@
99{-# LANGUAGE GADTs #-}
1010{-# LANGUAGE GeneralizedNewtypeDeriving #-}
1111{-# LANGUAGE LambdaCase #-}
12+{-# LANGUAGE MultiWayIf #-}
1213{-# LANGUAGE RankNTypes #-}
1314{-# LANGUAGE RoleAnnotations #-}
1415{-# LANGUAGE ScopedTypeVariables #-}
@@ -19,7 +20,6 @@
1920{-# LANGUAGE DeriveFunctor #-}
2021{-# LANGUAGE StandaloneDeriving #-}
2122{-# LANGUAGE InstanceSigs #-}
22−{-# LANGUAGE MultiWayIf #-}
2323
2424#ifdef USE_REFLEX_OPTIMIZER
2525{-# OPTIONS_GHC -fplugin=Reflex.Optimizer #-}
@@ -38,17 +38,15 @@ import Control.Monad hiding (forM, forM_, mapM, mapM_)
3838import Control.Monad.Exception
3939import Control.Monad.Identity hiding (forM, forM_, mapM, mapM_)
4040import Control.Monad.Primitive
41+--import Control.Monad.Reader hiding (forM, forM_, mapM, mapM_)
4142import Control.Monad.Reader.Class
4243import Control.Monad.IO.Class
4344import Control.Monad.ReaderIO
4445import Control.Monad.Ref
45−import Control.Monad.Fail (MonadFail)
46−import qualified Control.Monad.Fail as MonadFail
4746import Data.Align
4847import Data.Coerce
49−import Data.Dependent.Map (DMap)
48+import Data.Dependent.Map (DMap, DSum (..))
5049import qualified Data.Dependent.Map as DMap
51−import Data.Dependent.Sum (DSum (..))
5250import Data.FastMutableIntMap (FastMutableIntMap, PatchIntMap (..))
5351import qualified Data.FastMutableIntMap as FastMutableIntMap
5452import Data.Foldable hiding (concat, elem, sequence_)
@@ -61,13 +59,12 @@ import qualified Data.IntMap.Strict as IntMap
6159import Data.IORef
6260import Data.Kind (Type)
6361import Data.Maybe hiding (mapMaybe)
64−import Data.Monoid (mempty, (<>))
62+import Data.Monoid ((<>))
6563import Data.Proxy
6664import Data.These
6765import Data.Traversable
68−import Data.Type.Equality ((:~:)(Refl))
6966import Data.Witherable (Filterable, mapMaybe)
70−import GHC.Exts hiding (toList)
67+import GHC.Exts
7168import GHC.IORef (IORef (..))
7269import GHC.Stack
7370import Reflex.FastWeak
@@ -75,27 +72,22 @@ import System.IO.Unsafe
7572import System.Mem.Weak
7673import Unsafe.Coerce
7774
78−#ifdef MIN_VERSION_semialign
75+#if defined(MIN_VERSION_semialign)
7976#if MIN_VERSION_these(0,8,0)
8077import Data.These.Combinators (justThese)
8178#endif
82−#if MIN_VERSION_semialign(1,1,0)
83−import Data.Zip (Zip (..))
84−#endif
8579#endif
8680
8781#ifdef DEBUG_CYCLES
8882import Control.Monad.State hiding (forM, forM_, mapM, mapM_, sequence)
89−#endif
90−
9183import Data.List.NonEmpty (NonEmpty (..), nonEmpty)
9284import qualified Data.List.NonEmpty as NonEmpty
85+import Data.Monoid (mempty)
9386import Data.Tree (Forest, Tree (..), drawForest)
94−import Data.List (isPrefixOf)
87+#endif
9588
96−import Data.FastWeakBag (FastWeakBag, FastWeakBagTicket)
89+import Data.FastWeakBag (FastWeakBag)
9790import qualified Data.FastWeakBag as FastWeakBag
98−
9991import Data.Reflection
10092import Data.Some (Some(Some))
10193import Data.Type.Coercion
@@ -106,26 +98,22 @@ import qualified Reflex.Class
10698import qualified Reflex.Class as R
10799import qualified Reflex.Host.Class
108100import Reflex.NotReady.Class
109−import Data.Patch
110−import qualified Data.Patch.DMapWithMove as PatchDMapWithMove
111−import Reflex.PerformEvent.Base (PerformEventT)
101+import Reflex.Patch
102+import qualified Reflex.Patch.DMapWithMove as PatchDMapWithMove
112103
113104#ifdef DEBUG_TRACE_EVENTS
114105import qualified Data.ByteString.Char8 as BS8
115106import System.IO (stderr)
116−import Data.List (isPrefixOf)
117107#endif
118108
119−-- TODO stdout might not be the best channel for debug output
120−debugStrLn :: String -> IO ()
121−debugStrLn = putStrLn
109+import Debug.Trace
122110
123111#ifdef DEBUG_TRACE_EVENTS
112+
124113withStackOneLine :: (BS8.ByteString -> a) -> a
125114withStackOneLine expr = unsafePerformIO $ do
126115 stack <- currentCallStack
127− return (expr . BS8.pack . unwords . dropInternal . reverse $ stack)
128− where dropInternal = filterStack "Reflex.Spider.Internal"
116+ return (expr (BS8.pack (unwords (reverse stack))))
129117
130118#endif
131119
@@ -136,42 +124,28 @@ debugInvalidateHeight :: Bool
136124debugInvalidate :: Bool
137125
138126#ifdef DEBUG
127+
139128#define DEBUG_NODEIDS
140129
141−#ifdef DEBUG_TRACE_PROPAGATION
142130debugPropagate = True
143−#else
144−debugPropagate = False
145−#endif
146131
147−#ifdef DEBUG_TRACE_HEIGHT
148−debugInvalidateHeight = True
149−#else
150132debugInvalidateHeight = False
151−#endif
152133
153−#ifdef DEBUG_TRACE_INVALIDATION
154134debugInvalidate = True
155−#else
156−debugInvalidate = False
157−#endif
158135
159136class HasNodeId a where
160137 getNodeId :: a -> Int
161138
162−instance HasNodeId (CacheSubscribed x a) where
163− getNodeId = _cacheSubscribed_nodeId
164−
165−instance HasNodeId (FanInt x a) where
166− getNodeId = _fanInt_nodeId
167−
168−instance HasNodeId (Hold x p) where
139+instance HasNodeId (Hold x p a) where
169140 getNodeId = holdNodeId
170141
142+instance HasNodeId (PushSubscribed x a b) where
143+ getNodeId = pushSubscribedNodeId
144+
171145instance HasNodeId (SwitchSubscribed x a) where
172146 getNodeId = switchSubscribedNodeId
173147
174−instance HasNodeId (FanSubscribed x v a) where
148+instance HasNodeId (FanSubscribed x a) where
175149 getNodeId = fanSubscribedNodeId
176150
177151instance HasNodeId (CoincidenceSubscribed x a) where
@@ -185,16 +159,41 @@ instance HasNodeId (Pull x a) where
185159
186160{-# INLINE showNodeId #-}
187161showNodeId :: HasNodeId a => a -> String
188−showNodeId = showNodeId' . getNodeId
189−
190−showNodeId' :: Int -> String
191−showNodeId' = ("#"<>) . show
192−
162+showNodeId = ("#"<>) . show . getNodeId
163+
164+showSubscriberType :: Subscriber x a -> String
165+showSubscriberType = \case
166+ SubscriberPush _ _ -> "SubscriberPush"
167+ SubscriberMerge _ _ -> "SubscriberMerge"
168+ SubscriberFan _ -> "SubscriberFan"
169+ SubscriberMergeChange _ -> "SubscriberMergeChange"
170+ SubscriberHold _ -> "SubscriberHold"
171+ SubscriberHoldIdentity _ -> "SubscriberHoldIdentity"
172+ SubscriberSwitch _ -> "SubscriberSwitch"
173+ SubscriberCoincidenceOuter _ -> "SubscriberCoincidenceOuter"
174+ SubscriberCoincidenceInner _ -> "SubscriberCoincidenceInner"
175+ SubscriberHandle -> "SubscriberHandle"
176+
177+showEventType :: Event x a -> String
178+showEventType = \case
179+ EventRoot _ _ -> "EventRoot"
180+ EventNever -> "EventNever"
181+ EventPush _ -> "EventPush"
182+ EventMerge _ -> "EventMerge"
183+ EventFan _ _ -> "EventFan"
184+ EventSwitch _ -> "EventSwitch"
185+ EventCoincidence _ -> "EventCoincidence"
186+ EventHold _ -> "EventHold"
187+ EventDyn _ -> "EventDyn"
188+ EventHoldIdentity _ -> "EventHoldIdentity"
189+ EventDynIdentity _ -> "EventDynIdentity"
193190
194191#else
195192
196193debugPropagate = False
194+
197195debugInvalidateHeight = False
196+
198197debugInvalidate = False
199198
200199-- This must be inline, or error messages will cause memory leaks due to retaining the node in question
@@ -202,10 +201,6 @@ debugInvalidate = False
202201showNodeId :: a -> String
203202showNodeId _ = ""
204203
205−{-# INLINE showNodeId' #-}
206−showNodeId' :: Int -> String
207−showNodeId' _ = ""
208−
209204#endif
210205
211206#ifdef DEBUG_NODEIDS
@@ -251,9 +246,9 @@ subscribeAndRead = unEvent
251246-- caching; if the computation function is very cheap, this is (much) more
252247-- efficient than 'push'
253248{-# INLINE [1] pushCheap #-}
254−pushCheap :: HasSpiderTimeline x => (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
249+pushCheap :: (a -> ComputeM x (Maybe b)) -> Event x a -> Event x b
255250pushCheap !f e = Event $ \sub -> do
256− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "push" $ sub
251+ (subscription, occ) <- subscribeAndRead e $ sub
257252 { subscriberPropagate = \a -> do
258253 mb <- f a
259254 mapM_ (subscriberPropagate sub) mb
@@ -272,10 +267,10 @@ terminalSubscriber p = Subscriber
272267
273268-- | Subscribe to an Event only for the duration of one occurrence
274269{-# INLINE subscribeAndReadHead #-}
275−subscribeAndReadHead :: HasSpiderTimeline x => Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
270+subscribeAndReadHead :: Event x a -> Subscriber x a -> EventM x (EventSubscription x, Maybe a)
276271subscribeAndReadHead e sub = do
277272 subscriptionRef <- liftIO $ newIORef $ error "subscribeAndReadHead: not initialized"
278− (subscription, occ) <- subscribeAndRead e $ debugSubscriber' "head" $ sub
273+ (subscription, occ) <- subscribeAndRead e $ sub
279274 { subscriberPropagate = \a -> do
280275 liftIO $ unsubscribe =<< readIORef subscriptionRef
281276 subscriberPropagate sub a
@@ -286,42 +281,24 @@ subscribeAndReadHead e sub = do
286281 return (subscription, occ)
287282
288283--TODO: Make this lazy in its input event
289−headE :: (MonadIO m, Defer (SomeMergeInit x) m, HasSpiderTimeline x) => Event x a -> m (Event x a)
284+headE :: (MonadIO m, Defer (SomeMergeInit x) m) => Event x a -> m (Event x a)
290285headE originalE = do
291286 parent <- liftIO $ newIORef $ Just originalE
292287 defer $ SomeMergeInit $ do --TODO: Rename SomeMergeInit appropriately
293288 let clearParent = liftIO $ writeIORef parent Nothing
294− (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ const clearParent
289+ (_, occ) <- subscribeAndReadHead originalE $ terminalSubscriber $ \_ -> clearParent
295290 when (isJust occ) clearParent
296− return $ Event $ \sub ->
291+ return $ Event $ \sub -> do
297292 liftIO (readIORef parent) >>= \case
298− Nothing -> subscribeAndReadNever
293+ Nothing -> return (EventSubscription (return ()) $ EventSubscribed zeroRef $ toAny (), Nothing)
299294 Just e -> subscribeAndReadHead e sub
300295
301296data CacheSubscribed x a
302297 = CacheSubscribed { _cacheSubscribed_subscribers :: {-# UNPACK #-} !(FastWeakBag (Subscriber x a))
303298 , _cacheSubscribed_parent :: {-# UNPACK #-} !(EventSubscription x)
304299 , _cacheSubscribed_occurrence :: {-# UNPACK #-} !(IORef (Maybe a))
305−#ifdef DEBUG_NODEIDS
306− , _cacheSubscribed_nodeId :: {-# UNPACK #-} !Int
307−#endif
308300 }
309301
310−nowSpiderEventM :: (HasSpiderTimeline x) => EventM x (R.Event (SpiderTimeline x) ())
311−nowSpiderEventM =
312− SpiderEvent <$> now
313−
314−now :: (MonadIO m, Defer (Some Clear) m, HasSpiderTimeline x
315− ) => m (Event x ())
316−now = do
317− nowOrNot <- liftIO $ newIORef $ Just ()
318− scheduleClear nowOrNot
319− return . Event $ \_ -> do
320− occ <- liftIO . readIORef $ nowOrNot
321− return ( EventSubscription (return ()) eventSubscribedNow
322− , occ
323− )
324−
325302-- | Construct an 'Event' whose value is guaranteed not to be recomputed
326303-- repeatedly
327304--
@@ -346,23 +323,18 @@ cacheEvent e =
346323 subscribedTicket <- liftIO (readIORef mSubscribedRef >>= getFastWeakTicket) >>= \case
347324 Just subscribedTicket -> return subscribedTicket
348325 Nothing -> do
349−#ifdef DEBUG_NODEIDS
350− nodeId <- liftIO newNodeId
351−#endif
352326 subscribers <- liftIO FastWeakBag.empty
353327 occRef <- liftIO $ newIORef Nothing -- This should never be read prior to being set below
354−#ifdef DEBUG_NODEIDS
355− (parentSub, occ) <- subscribeAndRead e $ debugSubscriber' ("cacheEvent" <> showNodeId' nodeId) $ Subscriber
356−#else
357328 (parentSub, occ) <- subscribeAndRead e $ Subscriber
358−#endif
359− { subscriberPropagate = \a -> do
360− liftIO $ writeIORef occRef (Just a)
361− scheduleClear occRef
362− propagateFast a subscribers
363− , subscriberInvalidateHeight = FastWeakBag.traverse_ subscribers . invalidateSubscriberHeight
364− , subscriberRecalculateHeight = FastWeakBag.traverse_ subscribers . recalculateSubscriberHeight
365− }
329+ { subscriberPropagate = \a -> do
330+ liftIO $ writeIORef occRef $ Just a
331+ scheduleClear occRef
332+ propagateFast a subscribers
333+ , subscriberInvalidateHeight = \old -> do
334+ FastWeakBag.traverse subscribers $ invalidateSubscriberHeight old
335+ , subscriberRecalculateHeight = \new -> do
336+ FastWeakBag.traverse subscribers $ recalculateSubscriberHeight new
337+ }
366338 when (isJust occ) $ do
367339 liftIO $ writeIORef occRef occ -- Set the initial value of occRef; we don't need to do this if occ is Nothing
368340 scheduleClear occRef
@@ -370,45 +342,29 @@ cacheEvent e =
370342 { _cacheSubscribed_subscribers = subscribers
371343 , _cacheSubscribed_parent = parentSub
372344 , _cacheSubscribed_occurrence = occRef
373−#ifdef DEBUG_NODEIDS
374− , _cacheSubscribed_nodeId = nodeId
375−#endif
376345 }
377346 subscribedTicket <- liftIO $ mkFastWeakTicket subscribed
378347 liftIO $ writeIORef mSubscribedRef =<< getFastWeakTicketWeak subscribedTicket
379348 return subscribedTicket
380− liftIO $ cacheSubscription sub mSubscribedRef subscribedTicket
381−
382−cacheSubscription :: Subscriber x a -> IORef (FastWeak (CacheSubscribed x a))
383− -> FastWeakTicket (CacheSubscribed x a) -> IO (EventSubscription x, Maybe a)
384−cacheSubscription sub mSubscribedRef subscribedTicket = do
385− subscribed <- getFastWeakTicketValue subscribedTicket
386− ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
387− occ <- readIORef $ _cacheSubscribed_occurrence subscribed
388−
389− let parentSub = _cacheSubscribed_parent subscribed
390− es = EventSubscription
391− { _eventSubscription_unsubscribe = do
392− FastWeakBag.remove ticket
393−
394− isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
395− when isEmpty $ do
396− writeIORef mSubscribedRef emptyFastWeak
397− unsubscribe parentSub
398− touch ticket
399− touch subscribedTicket
400− , _eventSubscription_subscribed = EventSubscribed
401− { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed parentSub
402− , eventSubscribedRetained = toAny subscribedTicket
403−#ifdef DEBUG_CYCLES
404− , eventSubscribedGetParents = return [_eventSubscription_subscribed parentSub]
405− , eventSubscribedHasOwnHeightRef = False
406− , eventSubscribedWhoCreated = whoCreatedIORef mSubscribedRef
407−#endif
408− }
409− }
410− return (es, occ)
411−
349+ liftIO $ do
350+ subscribed <- getFastWeakTicketValue subscribedTicket
351+ ticket <- FastWeakBag.insert sub $ _cacheSubscribed_subscribers subscribed
352+ occ <- readIORef $ _cacheSubscribed_occurrence subscribed
353+ let es = EventSubscription
354+ { _eventSubscription_unsubscribe = do
355+ FastWeakBag.remove ticket
356+ isEmpty <- FastWeakBag.isEmpty $ _cacheSubscribed_subscribers subscribed
357+ when isEmpty $ do
358+ writeIORef mSubscribedRef emptyFastWeak
359+ unsubscribe $ _cacheSubscribed_parent subscribed
360+ touch ticket
361+ touch subscribedTicket
362+ , _eventSubscription_subscribed = EventSubscribed
363+ { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ _cacheSubscribed_parent subscribed
364+ , eventSubscribedRetained = toAny subscribedTicket
365+ }
366+ }
367+ return (es, occ)
412368
413369subscribe :: Event x a -> Subscriber x a -> EventM x (EventSubscription x)
414370subscribe e s = fst <$> subscribeAndRead e s
@@ -420,14 +376,11 @@ wrap tag getSpecificSubscribed sub = do
420376 let es = tag subd
421377 return (EventSubscription (WeakBag.remove sln >> touch sln) es, occ)
422378
423−eventRoot :: (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Event x a
379+eventRoot :: GCompare k => k a -> Root x k -> Event x a
424380eventRoot !k !r = Event $ wrap eventSubscribedRoot $ liftIO . getRootSubscribed k r
425381
426−subscribeAndReadNever :: EventM x (EventSubscription x, Maybe a)
427−subscribeAndReadNever = return (EventSubscription (return ()) eventSubscribedNever, Nothing)
428−
429382eventNever :: Event x a
430−eventNever = Event $ const subscribeAndReadNever
383+eventNever = Event $ \_ -> return (EventSubscription (return ()) eventSubscribedNever, Nothing)
431384
432385eventFan :: (GCompare k, HasSpiderTimeline x) => k a -> Fan x k v -> Event x (v a)
433386eventFan !k !f = Event $ wrap eventSubscribedFan $ getFanSubscribed k f
@@ -464,6 +417,16 @@ data Subscriber x a = Subscriber
464417 , subscriberRecalculateHeight :: !(Height -> IO ())
465418 }
466419
420+--TODO: Move this comment to WeakBag
421+-- These function are constructor functions that are marked NOINLINE so they are
422+-- opaque to GHC. If we do not do this, then GHC will sometimes fuse the constructor away
423+-- so any weak references that are attached to the constructors will have their
424+-- finalizer run. Using the opaque constructor, does not see the
425+-- constructor application, so it behaves like an IORef and cannot be fused away.
426+--
427+-- The result is also evaluated to WHNF, since forcing a thunk invalidates
428+-- the weak pointer to it in some cases.
429+
467430newSubscriberHold :: (HasSpiderTimeline x, Patch p) => Hold x p -> IO (Subscriber x p)
468431newSubscriberHold h = return $ Subscriber
469432 { subscriberPropagate = {-# SCC "traverseHold" #-} propagateSubscriberHold h
@@ -472,10 +435,10 @@ newSubscriberHold h = return $ Subscriber
472435 }
473436
474437newSubscriberFan :: forall x k v. (HasSpiderTimeline x, GCompare k) => FanSubscribed x k v -> IO (Subscriber x (DMap k v))
475−newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId subscribed) $ Subscriber
438+newSubscriberFan subscribed = return $ Subscriber
476439 { subscriberPropagate = \a -> {-# SCC "traverseFan" #-} do
477440 subs <- liftIO $ readIORef $ fanSubscribedSubscribers subscribed
478− tracePropagate (Proxy :: Proxy x) $ show (DMap.size subs) <> " keys subscribed, " <> show (DMap.size a) <> " keys firing"
441+ tracePropagate (Proxy :: Proxy x) $ "SubscriberFan" <> showNodeId subscribed <> ": " ++ show (DMap.size subs) ++ " keys subscribed, " ++ show (DMap.size a) ++ " keys firing"
479442 liftIO $ writeIORef (fanSubscribedOccurrence subscribed) $ Just a
480443 scheduleClear $ fanSubscribedOccurrence subscribed
481444 let f _ (Pair v subsubs) = do
@@ -484,55 +447,72 @@ newSubscriberFan subscribed = debugSubscriber ("SubscriberFan " <> showNodeId su
484447 _ <- DMap.traverseWithKey f $ DMap.intersectionWithKey (\_ -> Pair) a subs --TODO: Would be nice to have DMap.traverse_
485448 return ()
486449 , subscriberInvalidateHeight = \old -> do
450+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
487451 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
488− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
452+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ invalidateSubscriberHeight old
453+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
489454 , subscriberRecalculateHeight = \new -> do
455+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed
490456 subscribers <- readIORef $ fanSubscribedSubscribers subscribed
491− forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse_ (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
457+ forM_ (DMap.toList subscribers) $ \(_ :=> v) -> WeakBag.traverse (_fanSubscribedChildren_list v) $ recalculateSubscriberHeight new
458+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberFan" <> showNodeId subscribed <> " done"
492459 }
493460
494461newSubscriberSwitch :: forall x a. HasSpiderTimeline x => SwitchSubscribed x a -> IO (Subscriber x a)
495−newSubscriberSwitch subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
462+newSubscriberSwitch subscribed = return $ Subscriber
496463 { subscriberPropagate = \a -> {-# SCC "traverseSwitch" #-} do
464+ tracePropagate (Proxy :: Proxy x) $ "SubscriberSwitch" <> showNodeId subscribed
497465 liftIO $ writeIORef (switchSubscribedOccurrence subscribed) $ Just a
498466 scheduleClear $ switchSubscribedOccurrence subscribed
499467 propagate a $ switchSubscribedSubscribers subscribed
500468 , subscriberInvalidateHeight = \_ -> do
469+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
501470 oldHeight <- readIORef $ switchSubscribedHeight subscribed
502471 when (oldHeight /= invalidHeight) $ do
503472 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
504− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
505− , subscriberRecalculateHeight = (`updateSwitchHeight` subscribed)
506− }
473+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
474+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
475+ , subscriberRecalculateHeight = \new -> do
476+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed
477+ updateSwitchHeight new subscribed
478+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberSwitch" <> showNodeId subscribed <> " done"
479+ }
507480
508481newSubscriberCoincidenceOuter :: forall x b. HasSpiderTimeline x => CoincidenceSubscribed x b -> IO (Subscriber x (Event x b))
509−newSubscriberCoincidenceOuter subscribed = debugSubscriber ("SubscriberCoincidenceOuter" <> showNodeId subscribed) $ Subscriber
482+newSubscriberCoincidenceOuter subscribed = return $ Subscriber
510483 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceOuter" #-} do
484+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceOuter" <> showNodeId subscribed
511485 outerHeight <- liftIO $ readIORef $ coincidenceSubscribedHeight subscribed
512486 tracePropagate (Proxy :: Proxy x) $ " outerHeight = " <> show outerHeight
513487 (occ, innerHeight, innerSubd) <- subscribeCoincidenceInner a outerHeight subscribed
514488 tracePropagate (Proxy :: Proxy x) $ " isJust occ = " <> show (isJust occ)
515489 tracePropagate (Proxy :: Proxy x) $ " innerHeight = " <> show innerHeight
516−
517490 liftIO $ writeIORef (coincidenceSubscribedInnerParent subscribed) $ Just innerSubd
518491 scheduleClear $ coincidenceSubscribedInnerParent subscribed
519492 case occ of
520− Nothing ->
493+ Nothing -> do
521494 when (innerHeight > outerHeight) $ liftIO $ do -- If the event fires, it will fire at a later height
522495 writeIORef (coincidenceSubscribedHeight subscribed) $! innerHeight
523− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
524− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
496+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight outerHeight
497+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight innerHeight
525498 Just o -> do -- Since it's already firing, no need to adjust height
526499 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) occ
527500 scheduleClear $ coincidenceSubscribedOccurrence subscribed
528501 propagate o $ coincidenceSubscribedSubscribers subscribed
529− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
530− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
502+ , subscriberInvalidateHeight = \_ -> do
503+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
504+ invalidateCoincidenceHeight subscribed
505+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
506+ , subscriberRecalculateHeight = \_ -> do
507+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed
508+ recalculateCoincidenceHeight subscribed
509+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceOuter" <> showNodeId subscribed <> " done"
531510 }
532511
533512newSubscriberCoincidenceInner :: forall x a. HasSpiderTimeline x => CoincidenceSubscribed x a -> IO (Subscriber x a)
534−newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoincidenceInner" <> showNodeId subscribed) $ Subscriber
513+newSubscriberCoincidenceInner subscribed = return $ Subscriber
535514 { subscriberPropagate = \a -> {-# SCC "traverseCoincidenceInner" #-} do
515+ tracePropagate (Proxy :: Proxy x) $ "SubscriberCoincidenceInner" <> showNodeId subscribed
536516 occ <- liftIO $ readIORef $ coincidenceSubscribedOccurrence subscribed
537517 case occ of
538518 Just _ -> return () -- SubscriberCoincidenceOuter must have already propagated this event
@@ -540,8 +520,14 @@ newSubscriberCoincidenceInner subscribed = debugSubscriber ("SubscriberCoinciden
540520 liftIO $ writeIORef (coincidenceSubscribedOccurrence subscribed) $ Just a
541521 scheduleClear $ coincidenceSubscribedOccurrence subscribed
542522 propagate a $ coincidenceSubscribedSubscribers subscribed
543− , subscriberInvalidateHeight = \_ -> invalidateCoincidenceHeight subscribed
544− , subscriberRecalculateHeight = \_ -> recalculateCoincidenceHeight subscribed
523+ , subscriberInvalidateHeight = \_ -> do
524+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
525+ invalidateCoincidenceHeight subscribed
526+ when debugInvalidateHeight $ putStrLn $ "invalidateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
527+ , subscriberRecalculateHeight = \_ -> do
528+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed
529+ recalculateCoincidenceHeight subscribed
530+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: SubscriberCoincidenceInner" <> showNodeId subscribed <> " done"
545531 }
546532
547533invalidateSubscriberHeight :: Height -> Subscriber x a -> IO ()
@@ -551,18 +537,18 @@ recalculateSubscriberHeight :: Height -> Subscriber x a -> IO ()
551537recalculateSubscriberHeight = flip subscriberRecalculateHeight
552538
553539-- | Propagate everything at the current height
554−propagate :: forall x a. HasSpiderTimeline x => a -> WeakBag (Subscriber x a) -> EventM x ()
555−propagate a subscribers = withIncreasedDepth (Proxy::Proxy x) $
540+propagate :: a -> WeakBag (Subscriber x a) -> EventM x ()
541+propagate a subscribers = withIncreasedDepth $ do
556542 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
557543 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
558− WeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
544+ WeakBag.traverse subscribers $ \s -> subscriberPropagate s a
559545
560546-- | Propagate everything at the current height
561−propagateFast :: forall x a. HasSpiderTimeline x => a -> FastWeakBag (Subscriber x a) -> EventM x ()
562−propagateFast a subscribers = withIncreasedDepth (Proxy::Proxy x) $
547+propagateFast :: a -> FastWeakBag (Subscriber x a) -> EventM x ()
548+propagateFast a subscribers = withIncreasedDepth $ do
563549 -- Note: in the following traversal, we do not visit nodes that are added to the list during our traversal; they are new events, which will necessarily have full information already, so there is no need to traverse them
564550 --TODO: Should we check if nodes already have their values before propagating? Maybe we're re-doing work
565− FastWeakBag.traverse_ subscribers $ \s -> subscriberPropagate s a
551+ FastWeakBag.traverse subscribers $ \s -> subscriberPropagate s a
566552
567553--------------------------------------------------------------------------------
568554-- EventSubscribed
@@ -580,7 +566,7 @@ data EventSubscribed x = EventSubscribed
580566 { eventSubscribedHeightRef :: {-# UNPACK #-} !(IORef Height)
581567 , eventSubscribedRetained :: {-# NOUNPACK #-} !Any
582568#ifdef DEBUG_CYCLES
583− , eventSubscribedGetParents :: !(IO [EventSubscribed x]) -- For debugging loops
569+ , eventSubscribedGetParents :: !(IO [Some (EventSubscribed x)]) -- For debugging loops
584570 , eventSubscribedHasOwnHeightRef :: !Bool
585571 , eventSubscribedWhoCreated :: !(IO [String])
586572#endif
@@ -607,23 +593,13 @@ eventSubscribedNever = EventSubscribed
607593 , eventSubscribedWhoCreated = return ["never"]
608594#endif
609595 }
610−eventSubscribedNow :: EventSubscribed x
611−eventSubscribedNow = EventSubscribed
612− { eventSubscribedHeightRef = zeroRef
613− , eventSubscribedRetained = toAny ()
614−#ifdef DEBUG_CYCLES
615− , eventSubscribedGetParents = return []
616− , eventSubscribedHasOwnHeightRef = False
617− , eventSubscribedWhoCreated = return ["now"]
618−#endif
619− }
620596
621597eventSubscribedFan :: FanSubscribed x k v -> EventSubscribed x
622598eventSubscribedFan !subscribed = EventSubscribed
623599 { eventSubscribedHeightRef = eventSubscribedHeightRef $ _eventSubscription_subscribed $ fanSubscribedParent subscribed
624600 , eventSubscribedRetained = toAny subscribed
625601#ifdef DEBUG_CYCLES
626− , eventSubscribedGetParents = return [_eventSubscription_subscribed $ fanSubscribedParent subscribed]
602+ , eventSubscribedGetParents = return [Some $ _eventSubscription_subscribed $ fanSubscribedParent subscribed]
627603 , eventSubscribedHasOwnHeightRef = False
628604 , eventSubscribedWhoCreated = whoCreatedIORef $ fanSubscribedCachedSubscribed subscribed
629605#endif
@@ -636,7 +612,7 @@ eventSubscribedSwitch !subscribed = EventSubscribed
636612#ifdef DEBUG_CYCLES
637613 , eventSubscribedGetParents = do
638614 s <- readIORef $ switchSubscribedCurrentParent subscribed
639− return [_eventSubscription_subscribed s]
615+ return [Some $ _eventSubscription_subscribed s]
640616 , eventSubscribedHasOwnHeightRef = True
641617 , eventSubscribedWhoCreated = whoCreatedIORef $ switchSubscribedCachedSubscribed subscribed
642618#endif
@@ -649,8 +625,8 @@ eventSubscribedCoincidence !subscribed = EventSubscribed
649625#ifdef DEBUG_CYCLES
650626 , eventSubscribedGetParents = do
651627 innerSubscription <- readIORef $ coincidenceSubscribedInnerParent subscribed
652− let outerParent = _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
653− innerParents = maybeToList $ innerSubscription
628+ let outerParent = Some $ _eventSubscription_subscribed $ coincidenceSubscribedOuterParent subscribed
629+ innerParents = maybeToList $ fmap Some innerSubscription
654630 return $ outerParent : innerParents
655631 , eventSubscribedHasOwnHeightRef = True
656632 , eventSubscribedWhoCreated = whoCreatedIORef $ coincidenceSubscribedCachedSubscribed subscribed
@@ -664,15 +640,15 @@ getEventSubscribedHeight es = readIORef $ eventSubscribedHeightRef es
664640whoCreatedEventSubscribed :: EventSubscribed x -> IO [String]
665641whoCreatedEventSubscribed = eventSubscribedWhoCreated
666642
667−walkInvalidHeightParents :: EventSubscribed x -> IO [EventSubscribed x]
643+walkInvalidHeightParents :: EventSubscribed x -> IO [Some (EventSubscribed x)]
668644walkInvalidHeightParents s0 = do
669− subscribers <- flip execStateT mempty $ ($ s0) $ fix $ \loop s -> do
645+ subscribers <- flip execStateT mempty $ ($ Some s0) $ fix $ \loop (Some s) -> do
670646 h <- liftIO $ readIORef $ eventSubscribedHeightRef s
671647 when (h == invalidHeight) $ do
672648 when (eventSubscribedHasOwnHeightRef s) $ liftIO $ writeIORef (eventSubscribedHeightRef s) $! invalidHeightBeingTraversed
673− modify (s :)
649+ modify (Some s :)
674650 mapM_ loop =<< liftIO (eventSubscribedGetParents s)
675− forM_ subscribers $ \s -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
651+ forM_ subscribers $ \(Some s) -> writeIORef (eventSubscribedHeightRef s) $! invalidHeight
676652 return subscribers
677653#endif
678654
@@ -994,10 +970,8 @@ instance Monad (BehaviorM x) where
994970 BehaviorM x >> BehaviorM y = BehaviorM $ x >> y
995971 {-# INLINE return #-}
996972 return x = BehaviorM $ return x
997−#if !MIN_VERSION_base(4,13,0)
998973 {-# INLINE fail #-}
999974 fail s = BehaviorM $ fail s
1000−#endif
1001975
1002976data BehaviorSubscribed x a
1003977 = forall p. BehaviorSubscribedHold (Hold x p)
@@ -1057,7 +1031,7 @@ data SomeMergeUpdate x = SomeMergeUpdate
10571031newtype SomeMergeInit x = SomeMergeInit { unSomeMergeInit :: EventM x () }
10581032
10591033-- EventM can do everything BehaviorM can, plus create holds
1060−newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException)
1034+newtype EventM x a = EventM { unEventM :: IO a } deriving (Functor, Applicative, Monad, MonadIO, MonadFix, MonadException, MonadAsyncException) -- The environment should be Nothing if we are not in a frame, and Just if we are - in which case it is a list of assignments to be done after the frame is over
10611035
10621036newtype MergeSubscribedParent x a = MergeSubscribedParent { unMergeSubscribedParent :: EventSubscription x }
10631037
@@ -1082,8 +1056,7 @@ heightBagFromList :: [Height] -> HeightBag
10821056heightBagFromList heights = heightBagVerify $ foldl' (flip heightBagAdd) heightBagEmpty heights
10831057
10841058heightBagAdd :: Height -> HeightBag -> HeightBag
1085−heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $
1086− IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
1059+heightBagAdd (Height h) (HeightBag s c) = heightBagVerify $ HeightBag (succ s) $ IntMap.insertWithKey (\_ _ old -> succ old) h 0 c
10871060
10881061heightBagRemove :: Height -> HeightBag -> HeightBag
10891062heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.lookup h c of
@@ -1092,13 +1065,6 @@ heightBagRemove (Height h) b@(HeightBag s c) = heightBagVerify $ case IntMap.loo
10921065 0 -> IntMap.delete h c
10931066 _ -> IntMap.insert h (pred old) c
10941067
1095−heightBagRemoveMaybe :: Height -> HeightBag -> Maybe HeightBag
1096−heightBagRemoveMaybe (Height h) b@(HeightBag s c) = heightBagVerify . removed <$> IntMap.lookup h c where
1097− removed old = HeightBag (pred s) $ case old of
1098− 0 -> IntMap.delete h c
1099− _ -> IntMap.insert h (pred old) c
1100−
1101−
11021068heightBagMax :: HeightBag -> Height
11031069heightBagMax (HeightBag _ c) = case IntMap.maxViewWithKey c of
11041070 Just ((h, _), _) -> Height h
@@ -1199,10 +1165,7 @@ instance HasSpiderTimeline x => Semialign (Event x) where
11991165 align ea eb = mapMaybe dmapToThese $ mergeG coerce $ dynamicConst $
12001166 DMap.fromDistinctAscList [LeftTag :=> ea, RightTag :=> eb]
12011167
1202−#ifdef MIN_VERSION_semialign
1203−#if MIN_VERSION_semialign(1,1,0)
1204−instance HasSpiderTimeline x => Zip (Event x) where
1205−#endif
1168+#if defined(MIN_VERSION_semialign)
12061169 zip x y = mapMaybe justThese $ align x y
12071170#endif
12081171
@@ -1346,110 +1309,55 @@ mkWeakPtrWithDebug x debugNote = do
13461309 x' <- evaluate x
13471310 mkWeakPtr x' $
13481311 if debugFinalize
1349− then Just $ debugStrLn $ "finalizing: " ++ debugNote
1312+ then Just $ putStrLn $ "finalizing: " ++ debugNote
13501313 else Nothing
13511314
13521315type WeakList a = [Weak a]
13531316
1354−type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
1355−
1356−
1357−
1358−
1359−#ifdef DEBUG
1360−
1361−debugSubscriber :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> IO (Subscriber x a)
1362−debugSubscriber description = return . debugSubscriber' description
1363−
1364−debugSubscriber' :: forall x a. HasSpiderTimeline x => String -> Subscriber x a -> Subscriber x a
1365−debugSubscriber' description subscribed = Subscriber
1366− {
1367− subscriberPropagate = \m -> do
1368− tracePropagate (Proxy :: Proxy x) ("subscriberPropagate: " <> description)
1369− subscriberPropagate subscribed m
1370− , subscriberInvalidateHeight = \old -> do
1371− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", old = " <> show (unHeight old)
1372− subscriberInvalidateHeight subscribed old
1373− traceInvalidateHeight $ "invalidateSubscriberHeight: " <> description <> ", done"
1374− , subscriberRecalculateHeight = \new -> do
1375− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", new = " <> show (unHeight new)
1376− subscriberRecalculateHeight subscribed new
1377− traceInvalidateHeight $ "subscriberRecalculateHeight: " <> description <> ", done"
1378− }
1379−
1380−
13811317{-# INLINE withIncreasedDepth #-}
1382−withIncreasedDepth :: forall proxy x m a. CanTrace x m => proxy x -> m a -> m a
1383−withIncreasedDepth _ a = do
1384− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) succ
1318+#ifdef DEBUG
1319+withIncreasedDepth :: CanTrace x m => m a -> m a
1320+withIncreasedDepth a = do
1321+ spiderTimeline <- askSpiderTimelineEnv
1322+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) succ
13851323 result <- a
1386− liftIO $ modifyIORef' (_spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)) pred
1324+ liftIO $ modifyIORef' (_spiderTimeline_depth (unSTE spiderTimeline)) pred
13871325 return result
1388−
1389−{-# INLINE tracePropagate #-}
1390−tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1391−tracePropagate p = when debugPropagate . trace p
1392−
1393−{-# INLINE traceInvalidate #-}
1394−traceInvalidate :: String -> IO ()
1395−traceInvalidate = when debugInvalidate . liftIO . debugStrLn
1396−
1397−{-# INLINE traceInvalidateHeight #-}
1398−traceInvalidateHeight :: String -> IO ()
1399−traceInvalidateHeight = when debugInvalidateHeight . liftIO . debugStrLn
1400−
1401−{-# INLINE trace #-}
1402−trace :: (CanTrace x m) => proxy x -> String -> m ()
1403−trace p message = traceM p $ return message
1404−
1405−{-# INLINE traceM #-}
1406−traceM :: forall x proxy m. (CanTrace x m) => proxy x -> m String -> m ()
1407−traceM _ getMessage = do
1408− message <- getMessage
1409− d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE (spiderTimeline :: SpiderTimelineEnv x)
1410− liftIO $ debugStrLn $ replicate d ' ' <> message
1411−
14121326#else
1327+withIncreasedDepth :: m a -> m a
1328+withIncreasedDepth = id
1329+#endif
14131330
1414−{-# INLINE withIncreasedDepth #-}
1415−withIncreasedDepth :: proxy x -> m a -> m a
1416−withIncreasedDepth _ = id
1331+type CanTrace x m = (HasSpiderTimeline x, MonadIO m)
14171332
14181333{-# INLINE tracePropagate #-}
14191334tracePropagate :: (CanTrace x m) => proxy x -> String -> m ()
1420−tracePropagate _ _ = return ()
1335+tracePropagate p = traceWhen p debugPropagate
14211336
14221337{-# INLINE traceInvalidate #-}
14231338traceInvalidate :: String -> IO ()
1424−traceInvalidate _ = return ()
1425−
1426−{-# INLINE traceInvalidateHeight #-}
1427−traceInvalidateHeight :: String -> IO ()
1428−traceInvalidateHeight _ = return ()
1429−
1430−{-# INLINE debugSubscriber #-}
1431−debugSubscriber :: String -> Subscriber x a -> IO (Subscriber x a)
1432−debugSubscriber _ = return
1433−
1434−{-# INLINE debugSubscriber' #-}
1435−debugSubscriber' :: String -> Subscriber x a -> Subscriber x a
1436−debugSubscriber' _ = id
1437−
1438−
1339+traceInvalidate = when debugInvalidate . liftIO . putStrLn
14391340
1440−{-# INLINE trace #-}
1441−trace :: (CanTrace x m) => proxy x -> String -> m ()
1442−trace _ _ = return ()
1443−
1444−{-# INLINE traceM #-}
1445−traceM :: (CanTrace x m) => proxy x -> m String -> m ()
1446−traceM _ _ = return ()
1341+{-# INLINE traceWhen #-}
1342+traceWhen :: (CanTrace x m) => proxy x -> Bool -> String -> m ()
1343+traceWhen p b message = traceMWhen p b $ return message
14471344
1345+{-# INLINE traceMWhen #-}
1346+traceMWhen :: (CanTrace x m) => proxy x -> Bool -> m String -> m ()
1347+traceMWhen _ b getMessage = when b $ do
1348+ message <- getMessage
1349+#ifdef DEBUG
1350+ spiderTimeline <- askSpiderTimelineEnv
1351+ d <- liftIO $ readIORef $ _spiderTimeline_depth $ unSTE spiderTimeline
1352+#else
1353+ let d = 0
14481354#endif
1355+ liftIO $ putStrLn $ replicate d ' ' <> message
14491356
14501357whoCreatedIORef :: IORef a -> IO [String]
14511358whoCreatedIORef (IORef a) = whoCreated $! a
14521359
1360+#ifdef DEBUG_CYCLES
14531361groupByHead :: Eq a => [NonEmpty a] -> [(a, NonEmpty [a])]
14541362groupByHead = \case
14551363 [] -> []
@@ -1460,54 +1368,20 @@ groupByHead = \case
14601368 | otherwise -> (x, xs :| []) : l
14611369
14621370listsToForest :: Eq a => [[a]] -> Forest a
1463−listsToForest lists = buildForest <$> groupByHead (mapMaybe nonEmpty lists)
1464− where buildForest (a, lists') = Node a $ listsToForest $ toList lists'
1465−
1466−showStacks :: [[String]] -> String
1467−showStacks = drawForest . listsToForest . fmap (filterStack "Reflex.Spider.Internal")
1468−
1469−filterStack :: String -> [String] -> [String]
1470−#ifdef DEBUG_HIDE_INTERNALS
1471−filterStack prefix = filter (not . (prefix `isPrefixOf`))
1472−#else
1473−filterStack prefix = id
1474−#endif
1475−
1476−#ifdef DEBUG_CYCLES
1477−
1478−data EventLoopException = EventLoopException [[String]]
1479−instance Exception EventLoopException
1480−
1481−instance Show EventLoopException where
1482− show (EventLoopException stacks) = "causality loop detected:\n" <> if null stacks
1483− then "no location information, compile with profiling enabled for stack tree"
1484− else showStacks stacks
1485−
1486−#else
1487−
1488−data EventLoopException = EventLoopException
1489−instance Exception EventLoopException
1490−
1491−instance Show EventLoopException where
1492− show EventLoopException = "causality loop detected: \n" <>
1493− "compile reflex with flag 'debug-cycles' and compile with profiling enabled for stack tree"
1494−
1371+listsToForest l = fmap (\(a, l') -> Node a $ listsToForest $ toList l') $ groupByHead $ catMaybes $ fmap nonEmpty l
14951372#endif
14961373
1497−
14981374{-# INLINE propagateSubscriberHold #-}
14991375propagateSubscriberHold :: forall x p. (HasSpiderTimeline x, Patch p) => Hold x p -> p -> EventM x ()
15001376propagateSubscriberHold h a = do
1501− {-# SCC "trace" #-} when debugPropagate $ traceM (Proxy :: Proxy x) $ liftIO $ do
1377+ {-# SCC "trace" #-} traceMWhen (Proxy :: Proxy x) debugPropagate $ liftIO $ do
15021378 invalidators <- liftIO $ readIORef $ holdInvalidators h
15031379 return $ "SubscriberHold" <> showNodeId h <> ": " ++ show (length invalidators)
1504−
15051380 v <- {-# SCC "read" #-} liftIO $ readIORef $ holdValue h
15061381 case {-# SCC "apply" #-} apply a v of
15071382 Nothing -> return ()
15081383 Just v' -> do
1509− {-# SCC "trace2" #-} withIncreasedDepth (Proxy :: Proxy x) $
1510− tracePropagate (Proxy :: Proxy x) ("propagateSubscriberHold: assigning Hold" <> showNodeId h)
1384+ {-# SCC "trace2" #-} withIncreasedDepth $ tracePropagate (Proxy :: Proxy x) $ "propagateSubscriberHold: assigning Hold" <> showNodeId h
15111385 vRef <- {-# SCC "vRef" #-} liftIO $ evaluate $ holdValue h
15121386 iRef <- {-# SCC "iRef" #-} liftIO $ evaluate $ holdInvalidators h
15131387 defer $ {-# SCC "assignment" #-} SomeAssignment vRef iRef v'
@@ -1561,7 +1435,7 @@ getDynHold d = do
15611435zeroRef :: IORef Height
15621436zeroRef = unsafePerformIO $ newIORef zeroHeight
15631437
1564−getRootSubscribed :: forall k x a. (GCompare k, HasSpiderTimeline x) => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
1438+getRootSubscribed :: GCompare k => k a -> Root x k -> Subscriber x a -> IO (WeakBagTicket, RootSubscribed x a, Maybe a)
15651439getRootSubscribed k r sub = do
15661440 mSubscribed <- readIORef $ rootSubscribed r
15671441 let getOcc = fmap (coerce . DMap.lookup k) $ readIORef $ rootOccurrence r
@@ -1575,9 +1449,7 @@ getRootSubscribed k r sub = do
15751449 let !cached = rootSubscribed r
15761450 uninitRef <- newIORef $ error "getRootsubscribed: uninitRef not initialized"
15771451 (subs, sln) <- WeakBag.singleton sub weakSelf cleanupRootSubscribed
1578−
1579− tracePropagate (Proxy::Proxy x) $ "getRootSubscribed: calling rootInit"
1580−
1452+ when debugPropagate $ putStrLn $ "getRootSubscribed: calling rootInit"
15811453 uninit <- rootInit r k $ RootTrigger (subs, rootOccurrence r, k)
15821454 writeIORef uninitRef $! uninit
15831455#ifdef DEBUG_NODEIDS
@@ -1627,9 +1499,6 @@ data FanInt x a = FanInt
16271499 { _fanInt_subscribers :: {-# UNPACK #-} !(FastMutableIntMap (FastWeakBag (Subscriber x a))) --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16281500 , _fanInt_subscriptionRef :: {-# UNPACK #-} !(IORef (EventSubscription x)) -- This should have a valid subscription iff subscribers is non-empty
16291501 , _fanInt_occRef :: {-# UNPACK #-} !(IORef (IntMap a))
1630−#ifdef DEBUG_NODEIDS
1631− , _fanInt_nodeId :: {-# UNPACK #-} !Int
1632−#endif
16331502 }
16341503
16351504newFanInt :: IO (FanInt x a)
@@ -1637,39 +1506,33 @@ newFanInt = do
16371506 subscribers <- FastMutableIntMap.newEmpty --TODO: Clean up the keys in here when their child weak bags get empty --TODO: Remove our own subscription when the subscribers list is completely empty
16381507 subscriptionRef <- newIORef $ error "fanInt: no subscription"
16391508 occRef <- newIORef $ error "fanInt: no occurrence"
1640−#ifdef DEBUG_NODEIDS
1641− nodeId <- newNodeId
1642−#endif
16431509 return $ FanInt
16441510 { _fanInt_subscribers = subscribers
16451511 , _fanInt_subscriptionRef = subscriptionRef
16461512 , _fanInt_occRef = occRef
1647−#ifdef DEBUG_NODEIDS
1648− , _fanInt_nodeId = nodeId
1649−#endif
16501513 }
16511514
16521515fanInt :: HasSpiderTimeline x => Event x (IntMap a) -> EventSelectorInt x a
16531516fanInt p = unsafePerformIO $ do
16541517 self <- newFanInt
1655− pure $ EventSelectorInt $ \k -> Event $ \sub -> do
1518+ pure $ EventSelectorInt $ \k -> trace ("select " <> show k) $ Event $ \sub -> do
16561519 isEmpty <- liftIO $ FastMutableIntMap.isEmpty (_fanInt_subscribers self)
16571520 when isEmpty $ do -- This is the first subscriber, so we need to subscribe to our input
1658− let desc = "fanInt" <> showNodeId self <> ", k = " <> show k
1659− (subscription, parentOcc) <- subscribeAndRead p $ debugSubscriber' desc $ Subscriber
1521+ (subscription, parentOcc) <- subscribeAndRead p $ Subscriber
16601522 { subscriberPropagate = \m -> do
16611523 liftIO $ writeIORef (_fanInt_occRef self) m
16621524 scheduleIntClear $ _fanInt_occRef self
1663− FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> --TODO: Do we need to know that no subscribers are being added as we traverse?
1664− FastWeakBag.traverse_ b $ \s ->
1525+ liftIO $ putStrLn $ "Pushing " <> show (IntMap.size m) <> " occurrences"
1526+ FastMutableIntMap.forIntersectionWithImmutable_ (_fanInt_subscribers self) m $ \b v -> do --TODO: Do we need to know that no subscribers are being added as we traverse?
1527+ FastWeakBag.traverse b $ \s -> do
16651528 subscriberPropagate s v
1666− , subscriberInvalidateHeight = \old ->
1667− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1668− FastWeakBag.traverse_ b $ \s ->
1529+ , subscriberInvalidateHeight = \old -> do
1530+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1531+ FastWeakBag.traverse b $ \s -> do
16691532 subscriberInvalidateHeight s old
1670− , subscriberRecalculateHeight = \new ->
1671− FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b ->
1672− FastWeakBag.traverse_ b $ \s ->
1533+ , subscriberRecalculateHeight = \new -> do
1534+ FastMutableIntMap.for_ (_fanInt_subscribers self) $ \b -> do
1535+ FastWeakBag.traverse b $ \s -> do
16731536 subscriberRecalculateHeight s new
16741537 }
16751538 liftIO $ do
@@ -1683,25 +1546,10 @@ fanInt p = unsafePerformIO $ do
16831546 FastMutableIntMap.insert (_fanInt_subscribers self) k b
16841547 return b
16851548 Just b -> return b
1686− ticket <- liftIO $ FastWeakBag.insert sub b
1549+ t <- liftIO $ FastWeakBag.insert sub b
16871550 currentOcc <- readIORef (_fanInt_occRef self)
1688−
1689− subscribed <- fanIntSubscribed ticket self
1690− return (EventSubscription (FastWeakBag.remove ticket) subscribed, IntMap.lookup k currentOcc)
1691−
1692−fanIntSubscribed :: FastWeakBagTicket k -> FanInt x a -> IO (EventSubscribed x)
1693−fanIntSubscribed ticket self = do
1694− subscribedParent <- _eventSubscription_subscribed <$> readIORef (_fanInt_subscriptionRef self)
1695− return $ EventSubscribed
1696− { eventSubscribedHeightRef = eventSubscribedHeightRef subscribedParent
1697− , eventSubscribedRetained = toAny (_fanInt_subscriptionRef self, ticket)
1698−#ifdef DEBUG_CYCLES
1699− , eventSubscribedGetParents = return [subscribedParent]
1700− , eventSubscribedHasOwnHeightRef = False
1701− , eventSubscribedWhoCreated = whoCreatedIORef $ _fanInt_subscriptionRef self
1702−#endif
1703− }
1704−
1551+ (EventSubscription _ (EventSubscribed !heightRef _)) <- readIORef (_fanInt_subscriptionRef self)
1552+ return (EventSubscription (FastWeakBag.remove t) $! EventSubscribed heightRef $! toAny (_fanInt_subscriptionRef self, t), IntMap.lookup k currentOcc)
17051553
17061554{-# INLINABLE getFanSubscribed #-}
17071555getFanSubscribed :: (HasSpiderTimeline x, GCompare k) => k a -> Fan x k v -> Subscriber x (v a) -> EventM x (WeakBagTicket, FanSubscribed x k v, Maybe (v a))
@@ -1899,7 +1747,7 @@ mergeCheap
18991747 => (forall a. q a -> Event x (v a))
19001748 -> DynamicS x (PatchDMap k q)
19011749 -> Event x (DMap k v)
1902−mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updateMe destroy
1750+mergeCheap nt = mergeGCheap' getInitialSubscribers updateMe destroy
19031751 where
19041752 updateMe :: MergeUpdateFunc k v x (PatchDMap k q) (MergeSubscribedParent x)
19051753 updateMe subscriber heightBagRef oldParents (PatchDMap p) = do
@@ -1914,9 +1762,7 @@ mergeCheap nt = mergeGCheap' unMergeSubscribedParent getInitialSubscribers updat
19141762 liftIO $ modifyIORef' heightBagRef $ heightBagAdd newParentHeight
19151763 return $ DMap.insertLookupWithKey' (\_ new _ -> new) k newParent ps
19161764 forM_ mOldSubd $ \oldSubd -> do
1917− oldHeight <- liftIO $ getEventSubscribedHeight $
1918− _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
1919−
1765+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ unMergeSubscribedParent oldSubd
19201766 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19211767 return (maybeToList (unMergeSubscribedParent <$> mOldSubd) ++ subscriptionsToKill, newPs)
19221768 foldM f ([], oldParents) $ DMap.toList p
@@ -1941,7 +1787,7 @@ mergeCheapWithMove :: forall k x v q. (HasSpiderTimeline x, GCompare k)
19411787 => (forall a. q a -> Event x (v a))
19421788 -> DynamicS x (PatchDMapWithMove k q)
19431789 -> Event x (DMap k v)
1944−mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription getInitialSubscribers updateMe destroy
1790+mergeCheapWithMove nt = mergeGCheap' getInitialSubscribers updateMe destroy
19451791 where
19461792 updateMe :: MergeUpdateFunc k v x (PatchDMapWithMove k q) (MergeSubscribedParentWithMove x k)
19471793 updateMe subscriber heightBagRef oldParents p = do
@@ -1960,17 +1806,13 @@ mergeCheapWithMove nt = mergeGCheap' _mergeSubscribedParentWithMove_subscription
19601806 let moveOrDelete :: forall a. k a -> PatchDMapWithMove.NodeInfo k q a -> MergeSubscribedParentWithMove x k a -> Constant (EventM x (Maybe (EventSubscription x))) a
19611807 moveOrDelete _ ni parent = Constant $ case getComposeMaybe $ PatchDMapWithMove._nodeInfo_to ni of
19621808 Nothing -> do
1963− oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $
1964− _mergeSubscribedParentWithMove_subscription parent
1965−
1809+ oldHeight <- liftIO $ getEventSubscribedHeight $ _eventSubscription_subscribed $ _mergeSubscribedParentWithMove_subscription parent
19661810 liftIO $ modifyIORef heightBagRef $ heightBagRemove oldHeight
19671811 return $ Just $ _mergeSubscribedParentWithMove_subscription parent
19681812 Just toKey -> do
19691813 liftIO $ writeIORef (_mergeSubscribedParentWithMove_key parent) $! toKey
19701814 return Nothing
1971− toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $
1972− DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
1973−
1815+ toDelete <- fmap catMaybes $ mapM (\(_ :=> v) -> getConstant v) $ DMap.toList $ DMap.intersectionWithKey moveOrDelete (unPatchDMapWithMove p) oldParents
19741816 return (toDelete, applyAlways p' oldParents)
19751817 getInitialSubscribers :: MergeInitFunc k v q x (MergeSubscribedParentWithMove x k)
19761818 getInitialSubscribers initialParents subscriber = do
@@ -1995,8 +1837,6 @@ type MergeUpdateFunc k v x p s
19951837 -> p
19961838 -> EventM x ([EventSubscription x], DMap k s)
19971839
1998−type MergeGetSubscription x s = forall a. s a -> EventSubscription x
1999−
20001840type MergeInitFunc k v q x s
20011841 = DMap k q
20021842 -> (forall a. EventM x (k a) -> Subscriber x (v a))
@@ -2020,17 +1860,14 @@ invalidateMergeHeight m = invalidateMergeHeight' (_merge_heightRef m) (_merge_su
20201860invalidateMergeHeight' :: IORef Height -> Subscriber x a -> IO ()
20211861invalidateMergeHeight' heightRef sub = do
20221862 oldHeight <- readIORef heightRef
2023− -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
2024− when (oldHeight /= invalidHeight) $ do
1863+ when (oldHeight /= invalidHeight) $ do -- If the height used to be valid, it must be invalid now; we should never have *more* heights than we have parents
20251864 writeIORef heightRef $! invalidHeight
20261865 subscriberInvalidateHeight sub oldHeight
20271866
20281867revalidateMergeHeight :: Merge x k v s -> IO ()
20291868revalidateMergeHeight m = do
20301869 currentHeight <- readIORef $ _merge_heightRef m
2031−
2032− -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
2033− when (currentHeight == invalidHeight) $ do
1870+ when (currentHeight == invalidHeight) $ do -- revalidateMergeHeight may be called multiple times; perhaps the's a way to finesse it to avoid this check
20341871 heights <- readIORef $ _merge_heightBagRef m
20351872 parents <- readIORef $ _merge_parentsRef m
20361873 -- When the number of heights in the bag reaches the number of parents, we should have a valid height
@@ -2038,7 +1875,7 @@ revalidateMergeHeight m = do
20381875 LT -> return ()
20391876 EQ -> do
20401877 let height = succHeight $ heightBagMax heights
2041− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
1878+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
20421879 writeIORef (_merge_heightRef m) $! height
20431880 subscriberRecalculateHeight (_merge_sub m) height
20441881 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show (DMap.size parents) <> ") for Merge"
@@ -2046,45 +1883,36 @@ revalidateMergeHeight m = do
20461883scheduleMergeSelf :: HasSpiderTimeline x => Merge x k v s -> Height -> EventM x ()
20471884scheduleMergeSelf m height = scheduleMerge' height (_merge_heightRef m) $ do
20481885 vals <- liftIO $ readIORef $ _merge_accumRef m
2049− -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us,
2050− -- it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
2051− liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty
1886+ liftIO $ writeIORef (_merge_accumRef m) $! DMap.empty -- Once we're done with this, we can clear it immediately, because if there's a cacheEvent in front of us, it'll handle subsequent subscribers, and if not, we won't get subsequent subscribers
20521887 --TODO: Assert that m is not empty
20531888 subscriberPropagate (_merge_sub m) vals
20541889
2055−checkCycle :: HasSpiderTimeline x => EventSubscribed x -> EventM x ()
2056−checkCycle subscribed = liftIO $ do
2057− height <- readIORef (eventSubscribedHeightRef subscribed)
2058−
2059− -- currentHeight <- getCurrentHeight
2060− -- when (height <= currentHeight) $ if height /= invalidHeight
2061− -- then do
2062− -- myStack <- liftIO $ whoCreatedIORef undefined --TODO
2063− -- error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
2064− -- else liftIO $
2065− when (height == invalidHeight) $
2066−#ifdef DEBUG_CYCLES
2067− do
2068− nodesInvolvedInCycle <- walkInvalidHeightParents subscribed
2069− stacks <- forM nodesInvolvedInCycle whoCreatedEventSubscribed
2070− throwIO (EventLoopException stacks)
2071−#else
2072− throwIO EventLoopException
2073−#endif
2074−
2075−
2076−mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
2077−mergeSubscriber subscribed m getKey = Subscriber
1890+mergeSubscriber :: forall x k v s a. (HasSpiderTimeline x, GCompare k) => Merge x k v s -> EventM x (k a) -> Subscriber x (v a)
1891+mergeSubscriber m getKey = Subscriber
20781892 { subscriberPropagate = \a -> do
20791893 oldM <- liftIO $ readIORef $ _merge_accumRef m
20801894 k <- getKey
2081− let newM = DMap.insertWith (error "Same key fired multiple times for Merge") k a oldM
1895+ let newM = DMap.insertWith (error $ "Same key fired multiple times for Merge") k a oldM
20821896 tracePropagate (Proxy :: Proxy x) $ " DMap.size oldM = " <> show (DMap.size oldM) <> "; DMap.size newM = " <> show (DMap.size newM)
20831897 liftIO $ writeIORef (_merge_accumRef m) $! newM
20841898 when (DMap.null oldM) $ do -- Only schedule the firing once
20851899 height <- liftIO $ readIORef $ _merge_heightRef m
2086− checkCycle subscribed
2087−
1900+ --TODO: assertions about height
1901+ currentHeight <- getCurrentHeight
1902+ when (height <= currentHeight) $ do
1903+ if height /= invalidHeight
1904+ then do
1905+ myStack <- liftIO $ whoCreatedIORef undefined --TODO
1906+ error $ "Height (" ++ show height ++ ") is not greater than current height (" ++ show currentHeight ++ ")\n" ++ unlines (reverse myStack)
1907+ else liftIO $ do
1908+#ifdef DEBUG_CYCLES
1909+ nodesInvolvedInCycle <- walkInvalidHeightParents $ eventSubscribedMerge subscribed
1910+ stacks <- forM nodesInvolvedInCycle $ \(Some es) -> whoCreatedEventSubscribed es
1911+ let cycleInfo = ":\n" <> drawForest (listsToForest stacks)
1912+#else
1913+ let cycleInfo = ""
1914+#endif
1915+ error $ "Causality loop found" <> cycleInfo
20881916 scheduleMergeSelf m height
20891917 , subscriberInvalidateHeight = \old -> do --TODO: When removing a parent doesn't actually change the height, maybe we can avoid invalidating
20901918 modifyIORef' (_merge_heightBagRef m) $ heightBagRemove old
@@ -2095,45 +1923,31 @@ mergeSubscriber subscribed m getKey = Subscriber
20951923 }
20961924
20971925--TODO: Be able to run as much of this as possible promptly
2098−updateMerge :: (HasSpiderTimeline x, GCompare k) => EventSubscribed x -> Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
2099−updateMerge subscribed m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
1926+updateMerge :: (HasSpiderTimeline x, GCompare k) => Merge x k v s -> MergeUpdateFunc k v x p s -> p -> SomeMergeUpdate x
1927+updateMerge m updateFunc p = SomeMergeUpdate updateMe (invalidateMergeHeight m) (revalidateMergeHeight m)
21001928 where updateMe = do
21011929 oldParents <- liftIO $ readIORef $ _merge_parentsRef m
2102− (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber subscribed m) (_merge_heightBagRef m) oldParents p
1930+ (subscriptionsToKill, newParents) <- updateFunc (mergeSubscriber m) (_merge_heightBagRef m) oldParents p
21031931 liftIO $ writeIORef (_merge_parentsRef m) $! newParents
21041932 return subscriptionsToKill
21051933
21061934{-# INLINE mergeGCheap' #-}
21071935mergeGCheap' :: forall k v x p s q. (HasSpiderTimeline x, GCompare k, PatchTarget p ~ DMap k q)
2108− => MergeGetSubscription x s -> MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
2109−mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
1936+ => MergeInitFunc k v q x s -> MergeUpdateFunc k v x p s -> MergeDestroyFunc k s -> DynamicS x p -> Event x (DMap k v)
1937+mergeGCheap' getInitialSubscribers updateFunc destroy d = Event $ \sub -> do
21101938 initialParents <- readBehaviorUntracked $ dynamicCurrent d
21111939 accumRef <- liftIO $ newIORef $ error "merge: accumRef not yet initialized"
21121940 heightRef <- liftIO $ newIORef $ error "merge: heightRef not yet initialized"
21131941 heightBagRef <- liftIO $ newIORef $ error "merge: heightBagRef not yet initialized"
21141942 parentsRef :: IORef (DMap k s) <- liftIO $ newIORef $ error "merge: parentsRef not yet initialized"
2115− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2116−
2117− let subscribed = EventSubscribed
2118− { eventSubscribedHeightRef = heightRef
2119− , eventSubscribedRetained = toAny (parentsRef, changeSubdRef)
2120−#ifdef DEBUG_CYCLES
2121− , eventSubscribedGetParents = do
2122− let getParent' (_ :=> v) = _eventSubscription_subscribed (getParent v)
2123− fmap getParent' . DMap.toList <$> readIORef parentsRef
2124− , eventSubscribedHasOwnHeightRef = False
2125− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2126−#endif
2127− }
2128−
2129− m = Merge
1943+ let m = Merge
21301944 { _merge_parentsRef = parentsRef
21311945 , _merge_heightBagRef = heightBagRef
21321946 , _merge_heightRef = heightRef
21331947 , _merge_sub = sub
21341948 , _merge_accumRef = accumRef
21351949 }
2136− (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber subscribed m
1950+ (dm, heights, initialParentState) <- getInitialSubscribers initialParents $ mergeSubscriber m
21371951 let myHeightBag = heightBagFromList $ filter (/= invalidHeight) heights
21381952 myHeight = if invalidHeight `elem` heights
21391953 then invalidHeight
@@ -2142,29 +1956,31 @@ mergeGCheap' getParent getInitialSubscribers updateFunc destroy d = Event $ \sub
21421956 let (occ, accum) = if currentHeight >= myHeight -- If we should have fired by now
21431957 then (if DMap.null dm then Nothing else Just dm, DMap.empty)
21441958 else (Nothing, dm)
2145− unless (DMap.null accum) $ scheduleMergeSelf m myHeight
1959+ unless (DMap.null accum) $ do
1960+ scheduleMergeSelf m myHeight
21461961 liftIO $ writeIORef accumRef $! accum
21471962 liftIO $ writeIORef heightRef $! myHeight
21481963 liftIO $ writeIORef heightBagRef $! myHeightBag
1964+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
21491965 liftIO $ writeIORef parentsRef $! initialParentState
21501966 defer $ SomeMergeInit $ do
2151− let changeSubscriber = Subscriber
1967+ let s = Subscriber
21521968 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
2153− tracePropagate (Proxy :: Proxy x) "SubscriberMerge/Change"
2154− defer $ updateMerge subscribed m updateFunc a
1969+ tracePropagate (Proxy :: Proxy x) $ "SubscriberMerge/Change"
1970+ defer $ updateMerge m updateFunc a
21551971 , subscriberInvalidateHeight = \_ -> return ()
21561972 , subscriberRecalculateHeight = \_ -> return ()
21571973 }
2158− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2159− forM_ change $ \c -> defer $ updateMerge subscribed m updateFunc c
1974+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
1975+ forM_ change $ \c -> defer $ updateMerge m updateFunc c
21601976 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
21611977 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
21621978 -- its subscription.
2163− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
1979+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
21641980 let unsubscribeAll = destroy =<< readIORef parentsRef
2165−
2166− return (EventSubscription unsubscribeAll subscribed, occ)
2167−
1981+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parentsRef, changeSubdRef)
1982+ , occ
1983+ )
21681984
21691985mergeInt :: forall x a. (HasSpiderTimeline x) => DynamicS x (PatchIntMap (Event x a)) -> Event x (IntMap a)
21701986mergeInt = cacheEvent . mergeIntCheap
@@ -2177,22 +1993,13 @@ mergeIntCheap d = Event $ \sub -> do
21771993 heightRef <- liftIO $ newIORef zeroHeight
21781994 heightBagRef <- liftIO $ newIORef heightBagEmpty
21791995 parents <- liftIO $ FastMutableIntMap.newEmpty
2180− changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
2181− let subscribed = EventSubscribed
2182− { eventSubscribedHeightRef = heightRef
2183− , eventSubscribedRetained = toAny (parents, changeSubdRef)
2184−#ifdef DEBUG_CYCLES
2185− , eventSubscribedGetParents = fmap (_eventSubscription_subscribed . snd) <$> FastMutableIntMap.toList parents
2186− , eventSubscribedHasOwnHeightRef = False
2187− , eventSubscribedWhoCreated = whoCreatedIORef heightRef
2188−#endif
2189− }
21901996 let scheduleSelf = do
21911997 height <- liftIO $ readIORef $ heightRef
21921998 scheduleMerge' height heightRef $ do
21931999 vals <- liftIO $ FastMutableIntMap.getFrozenAndClear accum
21942000 subscriberPropagate sub vals
2195− invalidateMyHeight = invalidateMergeHeight' heightRef sub
2001+ invalidateMyHeight = do
2002+ invalidateMergeHeight' heightRef sub
21962003 recalculateMyHeight = do
21972004 currentHeight <- readIORef heightRef
21982005 when (currentHeight == invalidHeight) $ do --TODO: This will almost always be true; can we get rid of this check and just proceed to the next one always?
@@ -2202,14 +2009,12 @@ mergeIntCheap d = Event $ \sub -> do
22022009 LT -> return ()
22032010 EQ -> do
22042011 let height = succHeight $ heightBagMax heights
2205− traceInvalidateHeight $ "recalculateSubscriberHeight: height: " <> show height
2012+ when debugInvalidateHeight $ putStrLn $ "recalculateSubscriberHeight: height: " <> show height
22062013 writeIORef heightRef $! height
22072014 subscriberRecalculateHeight sub height
22082015 GT -> error $ "revalidateMergeHeight: more heights (" <> show (heightBagSize heights) <> ") than parents (" <> show numParents <> ") for Merge"
22092016 mySubscriber k = Subscriber
22102017 { subscriberPropagate = \a -> do
2211− checkCycle subscribed
2212−
22132018 wasEmpty <- liftIO $ FastMutableIntMap.isEmpty accum
22142019 liftIO $ FastMutableIntMap.insert accum k a
22152020 when wasEmpty scheduleSelf
@@ -2243,6 +2048,7 @@ mergeIntCheap d = Event $ \sub -> do
22432048 else liftIO $ Just <$> FastMutableIntMap.getFrozenAndClear accum
22442049 else do when (not isEmpty) scheduleSelf -- We have things accumulated, but we shouldn't have fired them yet
22452050 return Nothing
2051+ changeSubdRef <- liftIO $ newIORef $ error "getMergeSubscribed: changeSubdRef not yet initialized"
22462052 defer $ SomeMergeInit $ do
22472053 let updateMe a = SomeMergeUpdate u invalidateMyHeight recalculateMyHeight
22482054 where
@@ -2256,27 +2062,25 @@ mergeIntCheap d = Event $ \sub -> do
22562062 oldParents <- liftIO $ FastMutableIntMap.applyPatch parents newSubscriptions
22572063 liftIO $ for_ oldParents $ \oldParent -> do
22582064 oldParentHeight <- getEventSubscribedHeight $ _eventSubscription_subscribed oldParent
2259−
2260− print ("updateMe", oldParentHeight)
22612065 modifyIORef' heightBagRef $ heightBagRemove oldParentHeight
22622066 return $ IntMap.elems oldParents
2263− let changeSubscriber = Subscriber
2067+ let s = Subscriber
22642068 { subscriberPropagate = \a -> {-# SCC "traverseMergeChange" #-} do
22652069 tracePropagate (Proxy :: Proxy x) $ "SubscriberMergeInt/Change"
22662070 defer $ updateMe a
22672071 , subscriberInvalidateHeight = \_ -> return ()
22682072 , subscriberRecalculateHeight = \_ -> return ()
22692073 }
2270− (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) changeSubscriber
2074+ (changeSubscription, change) <- subscribeAndRead (dynamicUpdated d) s
22712075 forM_ change $ \c -> defer $ updateMe c
22722076 -- We explicitly hold on to the unsubscribe function from subscribing to the update event.
22732077 -- If we don't do this, there are certain cases where mergeCheap will fail to properly retain
22742078 -- its subscription.
2275− liftIO $ writeIORef changeSubdRef (changeSubscriber, changeSubscription)
2079+ liftIO $ writeIORef changeSubdRef (s, changeSubscription)
22762080 let unsubscribeAll = traverse_ unsubscribe =<< FastMutableIntMap.getFrozenAndClear parents
2277−
2278−
2279− return (EventSubscription unsubscribeAll subscribed, occ)
2081+ return ( EventSubscription unsubscribeAll $ EventSubscribed heightRef $ toAny (parents, changeSubdRef)
2082+ , occ
2083+ )
22802084
22812085newtype EventSelector x k = EventSelector { select :: forall a. k a -> Event x a }
22822086newtype EventSelectorG x k v = EventSelectorG { selectG :: forall a. k a -> Event x (v a) }
@@ -2359,19 +2163,19 @@ runFrame a = SpiderHost $ do
23592163 coincidenceInfos <- readIORef $ eventEnvResetCoincidences env
23602164 forM_ toAssign $ \(SomeAssignment vRef iRef v) -> {-# SCC "assignment" #-} do
23612165 writeIORef vRef v
2362− traceInvalidate $ "Invalidating Hold"
2166+ when debugInvalidate $ putStrLn $ "Invalidating Hold"
23632167 writeIORef iRef =<< evaluate =<< invalidate toReconnectRef =<< readIORef iRef
23642168 mergeUpdates <- readIORef $ eventEnvMergeUpdates env
23652169 writeIORef (eventEnvMergeUpdates env) []
2366− tracePropagate (Proxy::Proxy x) $ "Updating merges"
2170+ when debugPropagate $ putStrLn "Updating merges"
23672171 mergeSubscriptionsToKill <- runEventM $ concat <$> mapM _someMergeUpdate_update mergeUpdates
2368− tracePropagate (Proxy::Proxy x) $ "Updating merges done"
2172+ when debugPropagate $ putStrLn "Updating merges done"
23692173 toReconnect <- readIORef toReconnectRef
23702174 clearEventEnv env
23712175 switchSubscriptionsToKill <- forM toReconnect $ \(SomeSwitchSubscribed subscribed) -> {-# SCC "switchSubscribed" #-} do
23722176 oldSubscription <- readIORef $ switchSubscribedCurrentParent subscribed
23732177 wi <- readIORef $ switchSubscribedOwnWeakInvalidator subscribed
2374− traceInvalidate $ "Finalizing invalidator for Switch" <> showNodeId subscribed
2178+ when debugInvalidate $ putStrLn $ "Finalizing invalidator for Switch" <> showNodeId subscribed
23752179 finalize wi
23762180 i <- evaluate $ switchSubscribedOwnInvalidator subscribed
23772181 wi' <- mkWeakPtrWithDebug i "wi'"
@@ -2385,7 +2189,7 @@ runFrame a = SpiderHost $ do
23852189 subscription <- unSpiderHost $ runFrame $ {-# SCC "subscribeSwitch" #-} subscribe e sub --TODO: Assert that the event isn't firing --TODO: This should not loop because none of the events should be firing, but still, it is inefficient
23862190 {-
23872191 stackTrace <- liftIO $ fmap renderStack $ ccsToStrings =<< (getCCSOf $! switchSubscribedParent subscribed)
2388− liftIO $ debugStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
2192+ liftIO $ putStrLn $ (++stackTrace) $ "subd' subscribed to " ++ case e of
23892193 EventRoot _ -> "EventRoot"
23902194 EventNever -> "EventNever"
23912195 _ -> "something else"
@@ -2400,7 +2204,7 @@ runFrame a = SpiderHost $ do
24002204 myHeight <- readIORef $ switchSubscribedHeight subscribed
24012205 when (parentHeight /= myHeight) $ do
24022206 writeIORef (switchSubscribedHeight subscribed) $! invalidHeight
2403− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
2207+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ invalidateSubscriberHeight myHeight
24042208 mapM_ _someMergeUpdate_invalidateHeight mergeUpdates --TODO: In addition to when the patch is completely empty, we should also not run this if it has some Nothing values, but none of them have actually had any effect; potentially, we could even check for Just values with no effect (e.g. by comparing their IORefs and ignoring them if they are unchanged); actually, we could just check if the new height is different
24052209 forM_ coincidenceInfos $ \(SomeResetCoincidence subscription mcs) -> do
24062210 unsubscribe subscription
@@ -2441,7 +2245,7 @@ invalidateCoincidenceHeight subscribed = do
24412245 oldHeight <- readIORef $ coincidenceSubscribedHeight subscribed
24422246 when (oldHeight /= invalidHeight) $ do
24432247 writeIORef (coincidenceSubscribedHeight subscribed) $! invalidHeight
2444− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
2248+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ invalidateSubscriberHeight oldHeight
24452249
24462250updateSwitchHeight :: Height -> SwitchSubscribed x a -> IO ()
24472251updateSwitchHeight new subscribed = do
@@ -2449,7 +2253,7 @@ updateSwitchHeight new subscribed = do
24492253 when (oldHeight == invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24502254 when (new /= invalidHeight) $ do --TODO: This 'when' should probably be an assertion
24512255 writeIORef (switchSubscribedHeight subscribed) $! new
2452− WeakBag.traverse_ (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
2256+ WeakBag.traverse (switchSubscribedSubscribers subscribed) $ recalculateSubscriberHeight new
24532257
24542258recalculateCoincidenceHeight :: CoincidenceSubscribed x a -> IO ()
24552259recalculateCoincidenceHeight subscribed = do
@@ -2458,7 +2262,7 @@ recalculateCoincidenceHeight subscribed = do
24582262 height <- calculateCoincidenceHeight subscribed
24592263 when (height /= invalidHeight) $ do
24602264 writeIORef (coincidenceSubscribedHeight subscribed) $! height
2461− WeakBag.traverse_ (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
2265+ WeakBag.traverse (coincidenceSubscribedSubscribers subscribed) $ recalculateSubscriberHeight height
24622266
24632267calculateSwitchHeight :: SwitchSubscribed x a -> IO Height
24642268calculateSwitchHeight subscribed = getEventSubscribedHeight . _eventSubscription_subscribed =<< readIORef (switchSubscribedCurrentParent subscribed)
@@ -2520,8 +2324,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Event
25202324 {-# INLINABLE headE #-}
25212325 headE = R.slowHeadE
25222326-- headE (SpiderEvent e) = SpiderEvent <$> Reflex.Spider.Internal.headE e
2523− {-# INLINABLE now #-}
2524− now = nowSpiderEventM
25252327
25262328instance Reflex.Class.MonadSample (SpiderTimeline x) (SpiderPullM x) where
25272329 {-# INLINABLE sample #-}
@@ -2543,9 +2345,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
25432345 {-# INLINABLE headE #-}
25442346 headE = R.slowHeadE
25452347-- headE (SpiderEvent e) = SpiderPushM $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2546− {-# INLINABLE now #-}
2547− now = SpiderPushM nowSpiderEventM
2548−
25492348
25502349instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x)) where
25512350 {-# INLINE return #-}
@@ -2554,10 +2353,8 @@ instance HasSpiderTimeline x => Monad (Reflex.Class.Dynamic (SpiderTimeline x))
25542353 x >>= f = SpiderDynamic $ dynamicDynIdentity $ newJoinDyn $ newMapDyn (unSpiderDynamic . f) $ unSpiderDynamic x
25552354 {-# INLINE (>>) #-}
25562355 (>>) = (*>)
2557−#if !MIN_VERSION_base(4,13,0)
25582356 {-# INLINE fail #-}
25592357 fail _ = error "Dynamic does not support 'fail'"
2560−#endif
25612358
25622359{-# INLINABLE newJoinDyn #-}
25632360newJoinDyn :: HasSpiderTimeline x => DynamicS x (Identity (DynamicS x (Identity a))) -> Reflex.Spider.Internal.Dyn x (Identity a)
@@ -2609,9 +2406,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26092406 buildDynamic getV0 e = runFrame . runSpiderHostFrame $ Reflex.Class.buildDynamic getV0 e
26102407 {-# INLINABLE headE #-}
26112408 headE e = runFrame . runSpiderHostFrame $ Reflex.Class.headE e
2612− {-# INLINABLE now #-}
2613− now = runFrame . runSpiderHostFrame $ Reflex.Class.now
2614−
26152409
26162410instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHostFrame x) where
26172411 sample = SpiderHostFrame . readBehaviorUntracked . unSpiderBehavior --TODO: This can cause problems with laziness, so we should get rid of it if we can
@@ -2628,8 +2422,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Spide
26282422 {-# INLINABLE headE #-}
26292423 headE = R.slowHeadE
26302424-- headE (SpiderEvent e) = SpiderHostFrame $ SpiderEvent <$> Reflex.Spider.Internal.headE e
2631− {-# INLINABLE now #-}
2632− now = SpiderHostFrame Reflex.Class.now
26332425
26342426instance HasSpiderTimeline x => Reflex.Class.MonadSample (SpiderTimeline x) (SpiderHost x) where
26352427 {-# INLINABLE sample #-}
@@ -2650,8 +2442,6 @@ instance HasSpiderTimeline x => Reflex.Class.MonadHold (SpiderTimeline x) (Refle
26502442 buildDynamic getV0 e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.buildDynamic getV0 e
26512443 {-# INLINABLE headE #-}
26522444 headE e = Reflex.Spider.Internal.ReadPhase $ Reflex.Class.headE e
2653− {-# INLINABLE now #-}
2654− now = Reflex.Spider.Internal.ReadPhase Reflex.Class.now
26552445
26562446--------------------------------------------------------------------------------
26572447-- Deprecated items
@@ -2689,13 +2479,13 @@ instance HasSpiderTimeline x => Reflex.Host.Class.MonadReadEvent (SpiderTimeline
26892479 touch h
26902480 return result
26912481
2692−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
2482+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHost x) where
26932483 newEventWithTrigger = SpiderHost . fmap SpiderEvent . newEventWithTriggerIO
26942484 newFanEventWithTrigger f = SpiderHost $ do
26952485 es <- newFanEventWithTriggerIO f
26962486 return $ Reflex.Class.EventSelector $ SpiderEvent . Reflex.Spider.Internal.select es
26972487
2698−instance HasSpiderTimeline x => Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
2488+instance Reflex.Host.Class.MonadReflexCreateTrigger (SpiderTimeline x) (SpiderHostFrame x) where
26992489 newEventWithTrigger = SpiderHostFrame . EventM . liftIO . fmap SpiderEvent . newEventWithTriggerIO
27002490 newFanEventWithTrigger f = SpiderHostFrame $ EventM $ liftIO $ do
27012491 es <- newFanEventWithTriggerIO f
@@ -2775,7 +2565,7 @@ instance HasSpiderTimeline x => R.Reflex (SpiderTimeline x) where
27752565 fanG e = R.EventSelectorG $ SpiderEvent . selectG (fanG (unSpiderEvent e))
27762566 {-# INLINABLE mergeG #-}
27772567 mergeG
2778− :: forall k2 (k :: k2 -> *) q (v :: k2 -> *). GCompare k
2568+ :: forall (k :: k2 -> *) q (v :: k2 -> *). GCompare k
27792569 => (forall a. q a -> R.Event (SpiderTimeline x) (v a))
27802570 -> DMap k q
27812571 -> R.Event (SpiderTimeline x) (DMap k v)
@@ -2843,14 +2633,8 @@ instance Monad (SpiderHost x) where
28432633 SpiderHost x >> SpiderHost y = SpiderHost $ x >> y
28442634 {-# INLINABLE return #-}
28452635 return x = SpiderHost $ return x
2846−#if !MIN_VERSION_base(4,13,0)
28472636 {-# INLINABLE fail #-}
2848− fail = MonadFail.fail
2849−#endif
2850−
2851−instance MonadFail (SpiderHost x) where
2852− {-# INLINABLE fail #-}
2853− fail s = SpiderHost $ MonadFail.fail s
2637+ fail s = SpiderHost $ fail s
28542638
28552639-- | Run an action affecting the global Spider timeline; this will be guarded by
28562640-- a mutex for that timeline
@@ -2872,21 +2656,19 @@ instance Monad (SpiderHostFrame x) where
28722656 SpiderHostFrame x >> SpiderHostFrame y = SpiderHostFrame $ x >> y
28732657 {-# INLINABLE return #-}
28742658 return x = SpiderHostFrame $ return x
2875−#if !MIN_VERSION_base(4,13,0)
28762659 {-# INLINABLE fail #-}
28772660 fail s = SpiderHostFrame $ fail s
2878−#endif
28792661
28802662instance NotReady (SpiderTimeline x) (SpiderHostFrame x) where
28812663 notReadyUntil _ = pure ()
28822664 notReady = pure ()
28832665
2884−newEventWithTriggerIO :: forall x a. HasSpiderTimeline x => (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
2666+newEventWithTriggerIO :: (RootTrigger x a -> IO (IO ())) -> IO (Event x a)
28852667newEventWithTriggerIO f = do
28862668 es <- newFanEventWithTriggerIO $ \Refl -> f
28872669 return $ select es Refl
28882670
2889−newFanEventWithTriggerIO :: (HasSpiderTimeline x, GCompare k) => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
2671+newFanEventWithTriggerIO :: GCompare k => (forall a. k a -> RootTrigger x a -> IO (IO ())) -> IO (EventSelector x k)
28902672newFanEventWithTriggerIO f = do
28912673 occRef <- newIORef DMap.empty
28922674 subscribedRef <- newIORef DMap.empty
@@ -2920,11 +2702,3 @@ instance MonadAtomicRef (SpiderHostFrame x) where
29202702instance PrimMonad (SpiderHostFrame x) where
29212703 type PrimState (SpiderHostFrame x) = PrimState IO
29222704 primitive = SpiderHostFrame . EventM . primitive
2923−
2924−instance NotReady (SpiderTimeline x) (SpiderHost x) where
2925− notReadyUntil _ = return ()
2926− notReady = return ()
2927−
2928−instance HasSpiderTimeline x => NotReady (SpiderTimeline x) (PerformEventT (SpiderTimeline x) (SpiderHost x)) where
2929− notReadyUntil _ = return ()
2930− notReady = return ()