git.iko.soy/rowtype-yoga/purslint
on main help sign in
Align CLI/tests with full ruleset.

Preserve fix replacements and refresh Zed wasm for LSP tests.

commit278e0e69c91e16b3ddc94f7ff495cf1e385ddaf9 authorMark <mark.eibes@gmail.com> dateWed 28 Jan 2026, 21:26 (8 months ago) parent68a78e4
4 files changed+176−8
compare with main
unifiedsplit
bin/purelint-cli/src/Main.purs+5−1 lib/purelint/src/Purelint/ImportFix.purs+4−7 test/Test/Main.purs+167 zed-extension/extension.wasm
bin/purelint-cli/src/Main.purs+5−1
@@ -78,6 +78,8 @@ import Purelint.Rules.UseMinMax (useMinMaxRule)
7878import Purelint.Rules.UseMinimumSort (useMinimumSortRule)
7979import Purelint.Rules.UseNotElem (useNotElemRule)
8080import Purelint.Rules.UseNull (useNullRule)
81+import Purelint.Rules.UseCaseOf (useCaseOfRule)
82+import Purelint.Rules.FlattenCase (flattenCaseRule)
8183import Purelint.Rules.UseOn (useOnRule)
8284import Purelint.Rules.UseOr (useOrRule)
8385import Purelint.Rules.UsePatternGuards (usePatternGuardsRule)
@@ -97,7 +99,7 @@ import Purelint.Rules.RedundantParens (redundantParensRule)
9799import Purelint.Runner (runRules)
98100import Purelint.Types (LintResult(..), LintWarning(..), Severity(..), SourceCode(..), Suggestion(..))
99101
100−-- | All available rules (76 total)
102+-- | All available rules (81 total)
101103allRules :: Array Rule
102104allRules =
103105 [ alternativeLawRule
@@ -167,6 +169,8 @@ allRules =
167169 , useOnRule
168170 , useOrRule
169171 , usePatternGuardsRule
172+ , useCaseOfRule
173+ , flattenCaseRule
170174 , useReplicateRule
171175 , useSequenceRule
172176 , useSpanRule
lib/purelint/src/Purelint/ImportFix.purs+4−7
@@ -1,11 +1,8 @@
11module Purelint.ImportFix where
22
3−import Prelude
4−
53import Data.Maybe (Maybe)
6−import PureScript.CST.Types (SourceToken)
7−
8−-- [TODO]: This got lost, I'm not sure what it should do
4+-- NOTE: Import processing is currently a no-op. We assume required imports
5+-- are already present in the source and keep replacements intact.
96processImports :: String -> String -> Array
107 { codeText :: Maybe String
118 , importItem :: Maybe String
@@ -16,5 +13,5 @@ processImports :: String -> String -> Array
1613 , replacement :: String
1714 , source :: String
1815 }
19−processImports source replacement imports = do
20− { linesAdded: 0, replacement: "", source: source }
16+processImports source replacement _imports =
17+ { linesAdded: 0, replacement, source }
test/Test/Main.purs+167
@@ -32,6 +32,7 @@ import Purelint.Rules.UseAll (useAllRule)
3232import Purelint.Rules.BooleanSimplify (booleanSimplifyRule)
3333import Purelint.Rules.CollapseLambdas (collapseLambdasRule)
3434import Purelint.Rules.UseConst (useConstRule)
35+import Purelint.Rules.UseDollar (useDollarRule)
3536import Purelint.Rules.UseNull (useNullRule)
3637import Purelint.Rules.UseFromMaybe (useFromMaybeRule)
3738import Purelint.Rules.UseIsJust (useIsJustRule)
@@ -53,6 +54,7 @@ import Purelint.Rules.UseMaybeMap (useMaybeMapRule)
5354import Purelint.Rules.UseApplicative (useApplicativeRule)
5455import Purelint.Rules.UseBindFlip (useBindFlipRule)
5556import Purelint.Rules.UseFor (useForRule)
57+import Purelint.Rules.UseUnwrap (useUnwrapRule)
5658import Purelint.Rules.RedundantGuard (redundantGuardRule)
5759import Purelint.Rules.UseComparing (useComparingRule)
5860import Purelint.Rules.UseOn (useOnRule)
@@ -231,6 +233,15 @@ main = do
231233 <> whenNotTests
232234 <> unlessNotTests
233235 <> useZipTests
236+ <> useReplicateTests
237+ <> useUncurryTests
238+ <> useFromJustTests
239+ <> useHeadTests
240+ <> useElemIndexTests
241+ <> useBreakTests
242+ <> useSpanTests
243+ <> useDollarTests
244+ <> useUnwrapTests
234245 <> redundantNegateTests
235246 <> redundantIdTests
236247 <> nothingBindTests
@@ -1338,6 +1349,162 @@ useZipTests =
13381349 (withPrelude "x = zipWith Tuple [1] [2]") "zip [ 1 ] [ 2 ]"
13391350 ]
13401351
1352+-- ============================================================================
1353+-- UseReplicate Tests
1354+-- ============================================================================
1355+
1356+useReplicateTests :: Array TestResult
1357+useReplicateTests =
1358+ [ assertWarningCount "UseReplicate: take n (repeat x)" [useReplicateRule]
1359+ (withPrelude "x = take 3 (repeat 1)") 1
1360+ , assertRuleId "UseReplicate: correct rule id" [useReplicateRule]
1361+ (withPrelude "x = take 3 (repeat 1)") "UseReplicate"
1362+ , assertSuggestion "UseReplicate: suggests replicate" [useReplicateRule]
1363+ (withPrelude "x = take 3 (repeat 1)") "replicate 3 1"
1364+ , assertWarningCount "UseReplicate: no fire on take n xs" [useReplicateRule]
1365+ (withPrelude "x = take 3 xs") 0
1366+ , assertWarningCount "UseReplicate: no fire without import" [useReplicateRule]
1367+ (withoutImports "x = take 3 (repeat 1)") 0
1368+ ]
1369+
1370+-- ============================================================================
1371+-- UseUncurry Tests
1372+-- ============================================================================
1373+
1374+useUncurryTests :: Array TestResult
1375+useUncurryTests =
1376+ [ assertWarningCount "UseUncurry: f (fst p) (snd p)" [useUncurryRule]
1377+ (withPrelude "x = f (fst p) (snd p)") 1
1378+ , assertRuleId "UseUncurry: correct rule id" [useUncurryRule]
1379+ (withPrelude "x = f (fst p) (snd p)") "UseUncurry"
1380+ , assertSuggestion "UseUncurry: suggests uncurry" [useUncurryRule]
1381+ (withPrelude "x = f (fst p) (snd p)") "uncurry f p"
1382+ , assertWarningCount "UseUncurry: no fire on different args" [useUncurryRule]
1383+ (withPrelude "x = f (fst p) (snd q)") 0
1384+ , assertWarningCount "UseUncurry: no fire without import" [useUncurryRule]
1385+ (withoutImports "x = f (fst p) (snd p)") 0
1386+ ]
1387+
1388+-- ============================================================================
1389+-- UseFromJust Tests
1390+-- ============================================================================
1391+
1392+useFromJustTests :: Array TestResult
1393+useFromJustTests =
1394+ [ assertWarningCount "UseFromJust: fromMaybe d (Just x)" [useFromJustRule]
1395+ (withPrelude "x = fromMaybe 0 (Just 1)") 1
1396+ , assertRuleId "UseFromJust: correct rule id" [useFromJustRule]
1397+ (withPrelude "x = fromMaybe 0 (Just 1)") "UseFromJust"
1398+ , assertSuggestion "UseFromJust: simplifies Just" [useFromJustRule]
1399+ (withPrelude "x = fromMaybe 0 (Just 1)") "1"
1400+ , assertWarningCount "UseFromJust: fromMaybe d Nothing" [useFromJustRule]
1401+ (withPrelude "x = fromMaybe 0 Nothing") 1
1402+ , assertSuggestion "UseFromJust: simplifies Nothing" [useFromJustRule]
1403+ (withPrelude "x = fromMaybe 0 Nothing") "0"
1404+ , assertWarningCount "UseFromJust: no fire without import" [useFromJustRule]
1405+ (withoutImports "x = fromMaybe 0 (Just 1)") 0
1406+ ]
1407+
1408+-- ============================================================================
1409+-- UseHead Tests
1410+-- ============================================================================
1411+
1412+useHeadTests :: Array TestResult
1413+useHeadTests =
1414+ [ assertWarningCount "UseHead: xs !! 0" [useHeadRule]
1415+ (withPrelude "x = xs !! 0") 1
1416+ , assertRuleId "UseHead: correct rule id" [useHeadRule]
1417+ (withPrelude "x = xs !! 0") "UseHead"
1418+ , assertSuggestion "UseHead: suggests head" [useHeadRule]
1419+ (withPrelude "x = xs !! 0") "head"
1420+ , assertWarningCount "UseHead: no fire on xs !! 1" [useHeadRule]
1421+ (withPrelude "x = xs !! 1") 0
1422+ , assertWarningCount "UseHead: no fire without import" [useHeadRule]
1423+ (withoutImports "x = xs !! 0") 0
1424+ ]
1425+
1426+-- ============================================================================
1427+-- UseElemIndex Tests
1428+-- ============================================================================
1429+
1430+useElemIndexTests :: Array TestResult
1431+useElemIndexTests =
1432+ [ assertWarningCount "UseElemIndex: findIndex (\\x -> x == a) xs" [useElemIndexRule]
1433+ (withPrelude "x = findIndex (\\y -> y == a) xs") 1
1434+ , assertRuleId "UseElemIndex: correct rule id" [useElemIndexRule]
1435+ (withPrelude "x = findIndex (\\y -> y == a) xs") "UseElemIndex"
1436+ , assertSuggestion "UseElemIndex: suggests elemIndex" [useElemIndexRule]
1437+ (withPrelude "x = findIndex (\\y -> y == a) xs") "elemIndex a xs"
1438+ , assertWarningCount "UseElemIndex: no fire on other predicate" [useElemIndexRule]
1439+ (withPrelude "x = findIndex (\\y -> y > a) xs") 0
1440+ , assertWarningCount "UseElemIndex: no fire without import" [useElemIndexRule]
1441+ (withoutImports "x = findIndex (\\y -> y == a) xs") 0
1442+ ]
1443+
1444+-- ============================================================================
1445+-- UseBreak Tests
1446+-- ============================================================================
1447+
1448+useBreakTests :: Array TestResult
1449+useBreakTests =
1450+ [ assertWarningCount "UseBreak: span (not p) xs" [useBreakRule]
1451+ (withPrelude "x = span (not p) xs") 1
1452+ , assertRuleId "UseBreak: correct rule id" [useBreakRule]
1453+ (withPrelude "x = span (not p) xs") "UseBreak"
1454+ , assertSuggestion "UseBreak: suggests break" [useBreakRule]
1455+ (withPrelude "x = span (not p) xs") "break p xs"
1456+ , assertWarningCount "UseBreak: no fire without import" [useBreakRule]
1457+ (withoutImports "x = span (not p) xs") 0
1458+ ]
1459+
1460+-- ============================================================================
1461+-- UseSpan Tests
1462+-- ============================================================================
1463+
1464+useSpanTests :: Array TestResult
1465+useSpanTests =
1466+ [ assertWarningCount "UseSpan: break (not p) xs" [useSpanRule]
1467+ (withPrelude "x = break (not p) xs") 1
1468+ , assertRuleId "UseSpan: correct rule id" [useSpanRule]
1469+ (withPrelude "x = break (not p) xs") "UseSpan"
1470+ , assertSuggestion "UseSpan: suggests span" [useSpanRule]
1471+ (withPrelude "x = break (not p) xs") "span p xs"
1472+ , assertWarningCount "UseSpan: no fire without import" [useSpanRule]
1473+ (withoutImports "x = break (not p) xs") 0
1474+ ]
1475+
1476+-- ============================================================================
1477+-- UseDollar Tests
1478+-- ============================================================================
1479+
1480+useDollarTests :: Array TestResult
1481+useDollarTests =
1482+ [ assertWarningCount "UseDollar: map f (filter g xs)" [useDollarRule]
1483+ (withPrelude "x = map f (filter g xs)") 1
1484+ , assertRuleId "UseDollar: correct rule id" [useDollarRule]
1485+ (withPrelude "x = map f (filter g xs)") "UseDollar"
1486+ , assertSuggestion "UseDollar: suggests $" [useDollarRule]
1487+ (withPrelude "x = map f (filter g xs)") "map f $ filter g xs"
1488+ , assertWarningCount "UseDollar: no fire on atomic arg" [useDollarRule]
1489+ (withPrelude "x = f (1)") 0
1490+ ]
1491+
1492+-- ============================================================================
1493+-- UseUnwrap Tests
1494+-- ============================================================================
1495+
1496+useUnwrapTests :: Array TestResult
1497+useUnwrapTests =
1498+ [ assertRuleId "UseUnwrap: correct rule id" [useUnwrapRule]
1499+ (withPrelude "x = unwrap foo") "UseUnwrap"
1500+ , assertSuggestion "UseUnwrap: suggests un ?Constructor" [useUnwrapRule]
1501+ (withPrelude "x = unwrap foo") "un ?Constructor foo"
1502+ , assertWarningCount "UseUnwrap: unwrap partial" [useUnwrapRule]
1503+ (withPrelude "x = unwrap") 1
1504+ , assertSuggestion "UseUnwrap: unwrap partial suggestion" [useUnwrapRule]
1505+ (withPrelude "x = unwrap") "un ?Constructor"
1506+ ]
1507+
13411508-- ============================================================================
13421509-- RedundantNegate Tests
13431510-- ============================================================================
zed-extension/extension.wasm

Binary file not shown.