mirror of
https://github.com/rustwasm/wasm-bindgen.git
synced 2024-11-24 14:42:35 +03:00
48a823c685
When adding support for mutable slices I was under the impression that if the wasm memory was reallocated while we were using it then we'd have to commit the changes from the original buffer back to the new buffer. What I didn't know, however, is that once the wasm memory is reallocated then all views into it are supposed to be defunkt. It looks like node 9 didn't have this implementation quite right and it appears fixed in node 10, causing the deleted test here to fail. While this commit does raise the question of whether this is the right approach to interact with slices in JS I think the answer is still "yes". The user can always initiate the copy if need be and that seems strictly better than copying 100% of the time. |
||
---|---|---|
.. | ||
all |