Commit Graph

53 Commits

Author SHA1 Message Date
martoon
e6ceeb9284
Add issue templates
Problem: by default, when creating an issue, user has to fill everything
from scratch and this is not good.

Solution: add issue templates for `task` and `bug`, refer people to
page for openning new issue in `CONTRIBUTING.md`.
2019-12-06 18:38:12 +03:00
Ivan Gromakovskii
f97ded8356
Merge pull request #5 from serokell/balsoft/build-binary
Build binary by default
2019-12-05 20:03:23 +03:00
Alexander Bantyev
5fb8841df8
Also build tests 2019-12-05 19:01:57 +03:00
Alexander Bantyev
bd99e5d7de
Build binary instead of a library 2019-12-05 18:10:04 +03:00
Ivan Gromakovskii
3d7921da5c
Merge pull request #4 from serokell/balsoft/fix-ci
Fix CI to fail when haddock fails
2019-12-05 18:04:25 +03:00
Alexander Bantyev
469e7b8e3b
Fail if haddock is not generated 2019-12-05 18:03:30 +03:00
martoon
49444bc3a4
Improve work with config UX
Problem: after recent fix the user has to specify configuration file
even if it is present in the working directory of crossref-verify run.
That's not convenient.

Solutiion: if custom config path is not specified, first try to find
it under common filenames. When configuration file is not found anyway
we now print a warning before falling back to default config.
2019-12-05 14:15:20 +03:00
Ivan Gromakovskii
0958b30309
Merge pull request #2 from serokell/gromak/bump-resolver
[INT-130] Use newer resolver
2019-12-05 00:28:08 +03:00
Ivan Gromakovskii
482e9b2684
Write some notes about CI in README
Problem: CI uses some temporary workarounds, one may wonder whether
they are necessary and not get an answer.

Solution: write about it in README.
2019-12-05 00:00:41 +03:00
Alexander Bantyev
3fc12f1b8c
Add result* pattern to gitignore 2019-12-05 00:00:40 +03:00
Alexander Bantyev
87f66c44d4
Use niv for cache 2019-12-05 00:00:39 +03:00
Alexander Bantyev
a4356aaf26
Update haskell.nix cache 2019-12-05 00:00:38 +03:00
Alexander Bantyev
64c2b08d8f
Switch to haskell.nix
Co-Authored-By: Yorick van Pelt <yorick@yorickvanpelt.nl>
2019-12-05 00:00:37 +03:00
Alexander Bantyev
198725b792
Add hspec-discover to build-tools of test 2019-12-05 00:00:36 +03:00
Ivan Gromakovskii
2ebbbc1d63
Use newer resolver
Problem: latest available LTS resolver is 14.16 and `crossref-verifier`
doesn't compile with it.

Solution: update resolver to 14.16. Newer versions of some packages
are used from now on. I assume that it shouldn't break anything as
long as tests pass.
`req` stopped using `Default` class, that's the only change in the code
I had to make.
2019-12-05 00:00:34 +03:00
Konstantin Ivanov
6e95538211
Merge pull request #3 from serokell/martoon/int128-prettify
[INT-128] Improve work with config
2019-12-03 23:27:44 +03:00
martoon
44f6008228
Use full scan by default
Initially the primary use case for this tool in my point of view was
repeated runs for a repository until documentation is valid, thus I've
set checking only local refs as default behaviour (checking external
refs takes way longer).
Another motivation was that I expected CI to have one mandatory job for
local scan and one optional for remote refs scan.

Now I think that there are more reasons to perform full scan by default.
* It occured that in CI we usually want to have all checks optional, so
  that someone could temporarily break links on purpose (e.g. in case
  of mutually-dependent pull requests).
* First impression is important, and we want to demostrate all the
  features of the tool in default run.
* If use case mentioned in the very top actually takes place, one can
  add the necessary option, that's fine.
2019-12-03 23:24:57 +03:00
martoon
7cc2c723fb
Add CLI option for dumping config
Problem: we have moved config to `src-files`, now user needs a way to
get config.

Solution: add a CLI option.
2019-12-03 23:19:39 +03:00
martoon
0671986bcb
Make providing config optional
Problem: currently `crossref-verify` executable does not work without
configuration, and user was supposed to use one from the repository if
he does not have its own. This is very inconvenient.

Solution: make executable remember some config and use it by default.
2019-12-03 23:19:37 +03:00
martoon
9625495c61
Fix configuration file
It has been broken in `1c4a0246` commit.
2019-12-03 23:17:18 +03:00
Ivan Gromakovskii
d3f1b3adb5
Merge pull request #1 from serokell/gromak/unlicense-config
Unlicense default config
2019-09-30 14:17:18 +03:00
Ivan Gromakovskii
f185587b49
Remove meta-comments from PR template
Problem: some comments in PR template only matter when this template
is added to the repo, after that they are useless.

Solution: remove those comments.
2019-09-26 22:17:23 +03:00
Ivan Gromakovskii
1c4a0246bc
Unlicense default config
Problem: default config is not really smart and seems easier to just
unlicense it, i. e. let everyone do whatever they want with it.
Also it does not have SPDX header (like any other file in this repo,
but that's another story).

Solution: add SPDX header stating that the Unlicense applies.
Make Serokell copyright holder of it, AFAIK @martoon is fine with
that (and I am not sure whether copyright holder matters for
unlicensed files at all).
2019-09-26 22:12:41 +03:00
Yorick van Pelt
47dac39907
bump lts to 13.19 2019-08-27 13:51:21 +02:00
Yorick van Pelt
bb55942d48
update nixpkgs to 19.03 2019-08-27 13:23:14 +02:00
Yorick van Pelt
d7e9a36d5e
default.nix: use stackToNix from serokell-closure 2019-08-16 15:13:18 +02:00
Yorick van Pelt
a29b1190d7
add default.nix 2019-08-16 15:01:17 +02:00
martoon
feb9a9393f
Fix typos 2019-08-15 13:41:01 +03:00
martoon
0bfb25e792
Some UX improvements 2019-07-29 14:27:55 +03:00
martoon
b3615befce
Satisfy morley's hlint 2019-05-13 20:40:47 +03:00
martoon
82629a4dd3
Apply hlint 2019-05-13 20:00:25 +03:00
martoon
77cba6ccf2
Fix ./ local refs
Problem: for reference starting from `./` anchors are not checked.

Solution: lookup for such references in gathered repo info failed,
stripping `./` resolves the issue.
2019-05-08 02:12:44 +03:00
martoon
b6c7cd6aea
Bump to lts-13.3 2019-04-13 20:05:34 +03:00
martoon
c3cef06761 Add git files to ignored 2019-04-09 03:12:13 +03:00
martoon
f229ca6e6d Fix 'headerToAnchor'
Consider some unusual cases like emoji or punctuation appearance.
2019-04-09 03:12:13 +03:00
martoon
f7bfb636c2 Split ignored and notScaned
Problem: there are files which we want to ignore completely,
while others can be references but refs in it we do not want
to check.

Solution: have two different fields in config correspondingly.
2019-04-09 03:12:13 +03:00
martoon
5e31bec984
Allow disabling progress bar
In CI one most often does not want to see it because it usually
does not interpret caret return as expected.
2019-04-06 22:01:15 +03:00
martoon
ad1ccccad7
Add README and other required meta files 2019-03-14 20:29:36 +03:00
martoon
7cc59ea80a Add position coordinates in source to anchors and references 2019-03-14 18:25:19 +03:00
martoon
a1ef695598 Notify about ambiguous anchor references
When one has several anchors with the same name, github disambiguates them automatically,
but referencesto such anchors stay fragile.

Now when such anchors are referenced then an verification error is dropped.

Also, no more wrong "anchor does not exist" error when a github-dedupicated anchor is
referenced (the link was valid, but since in our vision anchors couldn't be renamed
automatically, we treated those link as invalid).
2019-03-14 18:25:19 +03:00
martoon
90e160e7d2
Allow to specify virtual files
For instance, reference to `issues` github page is a valid one despite there is no such
file physically in the repository.

Now user can specify list of "existing" virtual files in config.
2019-03-13 15:29:33 +03:00
martoon
3ecaf245f5
Make verbosity a CLI parameter, not config one 2019-03-13 13:30:39 +03:00
martoon
c869971f69
Make parts of verification optional
Now one can disable external refs or repo-local refs verification in CLI params.
2019-03-12 17:26:27 +03:00
martoon
444fa7349f
Add verification progress bar 2019-03-12 16:40:10 +03:00
martoon
7b3f3b1bdd
Improve logic 2019-03-11 20:04:21 +03:00
martoon
c59523ea61
Prettify output 2019-03-11 17:16:25 +03:00
martoon
2f4101c361
Add tests on header to anchor conversion 2019-03-11 17:16:06 +03:00
martoon
dc14c19e45
[INT-31] Enable external references checker 2018-10-16 14:58:53 +03:00
martoon
56b4e38308
[INT-31] Add config and CLI options 2018-10-11 17:27:59 +03:00
martoon
d1ee907cfb
[INT-31] Prettify output 2018-10-11 15:40:39 +03:00