serokell/xrefcheck
1
1
Fork 0
mirror of https://github.com/serokell/xrefcheck.git synced 2024-09-11 13:37:36 +03:00
Code Issues Projects Releases Wiki Activity
b9e7ffb99d
xrefcheck/.github/pull_request_template.md
Constantine Ter-Matevosian b9e7ffb99d
[#75] Fix the root with an appended slash support 
Problem: The results of the repository analysis will always contain
invalid references if the root contains a trailing forward slash.

Solution: Strip the root's trailing slash (if present) when having it be
given as an argument of the System.FilePath.Posix.takeDirectory
function.
2021-10-26 15:16:47 +03:00

1.7 KiB
Raw Blame History

Description

Related issue(s)

✅ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.

  • Documentation

    • I checked whether I should update the docs and did so if necessary:

  • Public contracts

    • Any modifications of public contracts comply with the Evolution of Public Contracts policy.
    • I added an entry to the changelog if my changes are visible to the users and
    • provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)