git.iko.soy/streamly
on master help sign in
Add todo comments about unicode ops
commit9e57f5f16b4143e0c688539f86316a53ec62e796 authorHarendra Kumar <harendra@composewell.com> dateTue 25 Oct 2022, 05:21 (4 years ago) parent9b788e0
5 files changed+19−4
compare with master
unifiedsplit
core/src/Streamly/Internal/Unicode/Array/Char.hs+5 core/streamly-core.cabal+1−1 src/Streamly/Internal/Unicode/Char.hs+6−1 src/Streamly/Internal/Unicode/Utf8.hs+6−1 streamly.cabal+1−1
core/src/Streamly/Internal/Unicode/Array/Char.hs+5
@@ -6,6 +6,11 @@
66-- Maintainer : streamly@composewell.com
77-- Stability : experimental
88-- Portability : GHC
9+
10+-- XXX Remove this or move this to Unicode.Utf32 making "Array Char" as a
11+-- newtype wrapper for Utf32. Is this any better than the [Char] (String) type?
12+-- This provides random access and the length of the string in O(1). Also,
13+-- better append performance.
914--
1015module Streamly.Internal.Unicode.Array.Char
1116 (
core/streamly-core.cabal+1−1
@@ -327,7 +327,7 @@ library
327327 -- streamly-serde
328328 , Streamly.Internal.Data.Binary.Decode
329329
330− -- streamly-unicode
330+ -- streamly-unicode-core
331331 , Streamly.Internal.Unicode.Stream
332332 , Streamly.Internal.Unicode.String
333333 , Streamly.Internal.Unicode.Char.Parser
src/Streamly/Internal/Unicode/Char.hs+6−1
@@ -6,12 +6,16 @@
66-- Maintainer : streamly@composewell.com
77-- Stability : experimental
88-- Portability : GHC
9+
10+-- XXX This module should have the reader/writer unfold/refold and read/write
11+-- stream/fold routines to convert a char to/from stream.
912--
1013module Streamly.Internal.Unicode.Char
1114 (
1215 -- * Predicates
13− isAsciiAlpha
16+ isAsciiAlpha -- XXX Remove or move to unicode-data
1417
18+ -- XXX move to Unicode.Char.Case?
1519 -- * Unicode aware operations
1620 {-
1721 toCaseFold
@@ -20,6 +24,7 @@ module Streamly.Internal.Unicode.Char
2024 , toTitle
2125 -}
2226
27+ -- XXX Move to Unicode.Stream.Normalize or Unicode.Normalize?
2328 -- * Unicode normalization
2429 , NormalizationMode(..)
2530 , normalize
src/Streamly/Internal/Unicode/Utf8.hs+6−1
@@ -5,7 +5,12 @@
55-- Maintainer : streamly@composewell.com
66-- Stability : experimental
77-- Portability : GHC
8−--
8+
9+-- XXX We can move this to stream-core/streamly-unicode-core, and provide an
10+-- additional module in streamly-unicode for case conversions (because it
11+-- depends on unicode-data). Or just keep all of it in streamly-unicode
12+-- which will have a dependency on unicode-data.
13+
914module Streamly.Internal.Unicode.Utf8
1015 (
1116 -- * Type
streamly.cabal+1−1
@@ -365,7 +365,7 @@ library
365365 , Streamly.Internal.Data.Stream.Time
366366 , Streamly.Internal.Data.Stream.Exception.Lifted
367367
368− -- streamly-unicode
368+ -- streamly-unicode (depends on unicode-data)
369369 , Streamly.Internal.Unicode.Utf8
370370 , Streamly.Internal.Unicode.Char
371371