on master help sign in
Add todo comments about unicode ops
9e57f5fHarendra Kumar
core/src/Streamly/Internal/Unicode/Array/Char.hs+5
@@ -6,6 +6,11 @@
6-- Maintainer : streamly@composewell.com
6-- Maintainer : streamly@composewell.com
7-- Stability : experimental
7-- Stability : experimental
8-- Portability : GHC
8-- Portability : GHC
9+
10+-- XXX Remove this or move this to Unicode.Utf32 making "Array Char" as a
11+-- newtype wrapper for Utf32. Is this any better than the [Char] (String) type?
12+-- This provides random access and the length of the string in O(1). Also,
13+-- better append performance.
9--
14--
10module Streamly.Internal.Unicode.Array.Char
15module Streamly.Internal.Unicode.Array.Char
11 (
16 (
core/streamly-core.cabal+1−1
@@ -327,7 +327,7 @@ library
327 -- streamly-serde
327 -- streamly-serde
328 , Streamly.Internal.Data.Binary.Decode
328 , Streamly.Internal.Data.Binary.Decode
329
329
330− -- streamly-unicode
330+ -- streamly-unicode-core
331 , Streamly.Internal.Unicode.Stream
331 , Streamly.Internal.Unicode.Stream
332 , Streamly.Internal.Unicode.String
332 , Streamly.Internal.Unicode.String
333 , Streamly.Internal.Unicode.Char.Parser
333 , Streamly.Internal.Unicode.Char.Parser
src/Streamly/Internal/Unicode/Char.hs+6−1
@@ -6,12 +6,16 @@
6-- Maintainer : streamly@composewell.com
6-- Maintainer : streamly@composewell.com
7-- Stability : experimental
7-- Stability : experimental
8-- Portability : GHC
8-- Portability : GHC
9+
10+-- XXX This module should have the reader/writer unfold/refold and read/write
11+-- stream/fold routines to convert a char to/from stream.
9--
12--
10module Streamly.Internal.Unicode.Char
13module Streamly.Internal.Unicode.Char
11 (
14 (
12 -- * Predicates
15 -- * Predicates
13− isAsciiAlpha
16+ isAsciiAlpha -- XXX Remove or move to unicode-data
14
17
18+ -- XXX move to Unicode.Char.Case?
15 -- * Unicode aware operations
19 -- * Unicode aware operations
16 {-
20 {-
17 toCaseFold
21 toCaseFold
@@ -20,6 +24,7 @@ module Streamly.Internal.Unicode.Char
20 , toTitle
24 , toTitle
21 -}
25 -}
22
26
27+ -- XXX Move to Unicode.Stream.Normalize or Unicode.Normalize?
23 -- * Unicode normalization
28 -- * Unicode normalization
24 , NormalizationMode(..)
29 , NormalizationMode(..)
25 , normalize
30 , normalize
src/Streamly/Internal/Unicode/Utf8.hs+6−1
@@ -5,7 +5,12 @@
5-- Maintainer : streamly@composewell.com
5-- Maintainer : streamly@composewell.com
6-- Stability : experimental
6-- Stability : experimental
7-- Portability : GHC
7-- Portability : GHC
8−--
8+
9+-- XXX We can move this to stream-core/streamly-unicode-core, and provide an
10+-- additional module in streamly-unicode for case conversions (because it
11+-- depends on unicode-data). Or just keep all of it in streamly-unicode
12+-- which will have a dependency on unicode-data.
13+
9module Streamly.Internal.Unicode.Utf8
14module Streamly.Internal.Unicode.Utf8
10 (
15 (
11 -- * Type
16 -- * Type
streamly.cabal+1−1
@@ -365,7 +365,7 @@ library
365 , Streamly.Internal.Data.Stream.Time
365 , Streamly.Internal.Data.Stream.Time
366 , Streamly.Internal.Data.Stream.Exception.Lifted
366 , Streamly.Internal.Data.Stream.Exception.Lifted
367
367
368− -- streamly-unicode
368+ -- streamly-unicode (depends on unicode-data)
369 , Streamly.Internal.Unicode.Utf8
369 , Streamly.Internal.Unicode.Utf8
370 , Streamly.Internal.Unicode.Char
370 , Streamly.Internal.Unicode.Char
371
371