mirror of
https://github.com/tonsky/FiraCode.git
synced 2024-08-17 17:00:42 +03:00
2.5 KiB
2.5 KiB
QA Notes – checking & polishing Fira Code for Google Fonts
- autohint static TTFs
Checks to resolve
🔥 FAIL: Variable font weight coordinates must be multiples of 100.
- com.google.fonts/check/varfont_weight_instances
- 🔥 FAIL Found an variable font instance with 'wght'=450.0. This should instead be a multiple of 100.
-
(fontmake also started to fail, as "Retina" instance was given a custom param of
weightClass: 900
) -
uncheck "Retina" instance as
is active
instance -
file issue with FontBakery to ask Dave/Marc about this
450
weight "Retina" instance
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent.
- com.google.fonts/check/family/win_ascent_and_descent
- 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1050, but got 935 instead [code: ascent]
- 🔥 FAIL OS/2.usWinDescent value should be equal or greater than 500, but got 265 instead [code: descent]
- run script to correct vertical metrics, recheck
🔥 FAIL: Are there non-ASCII characters in ASCII-only NAME table entries?
- com.google.fonts/check/name/ascii_only_entries
- 🔥 FAIL There are 1 strings containing non-ASCII characters in the ASCII-only NAME table entries.
- ℹ INFO Bad string at [nameID 0, 'utf_16_be']: 'b'Copyright © 2015 by Nikita Prokopov''
- remove © symbol
======================================================================================
Edits and corrected FontBakery checks
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
- com.google.fonts/check/unitsperem_strict
- ⚠ WARN Even though unitsPerEm (1000) in this font is reasonable. It is strongly advised to consider changing it to 2000, since it will likely improve the quality of Variable Fonts by avoiding excessive rounding of coordinates on interpolations.
- scale UPM to 2000