git.iko.soy/typeable/servant
on master help sign in
Review fixes and note about CI.
commit832f1b985ffa9278e1d7b1fad8f7cdc743058469 authorJulian K. Arni <jkarni@gmail.com> dateThu 7 Jan 2016, 13:05 (11 years ago) parentf66981f
1 file changed+7−3
CONTRIBUTING.md+7−3
CONTRIBUTING.md+7−3
@@ -28,7 +28,7 @@ Some things we like:
2828- Explicit imports
2929- Upper and lower bounds for packages
3030- Few dependencies
31−- -Werror-compatible
31+- -Werror-compatible (for both 7.8 and 7.10)
3232
3333Though we aren't sticklers for style, the `.stylish-haskell.yaml` and `HLint.hs`
3434files in the repository provide a good baseline for consistency.
@@ -38,6 +38,10 @@ the packages you've changed. And of course, write tests!
3838
3939## PR process
4040
41+We try to give timely reviews to PRs that pass CI. If CI for your PR fails, we
42+may close the PR if it has been open for too long (though you should feel free
43+to reopen when the issues have been fixed).
44+
4145We require two +1 from the maintainers of the repo. If you feel like there has
4246not been a timely response to a PR, you can ping the Maintainers group (with
4347`@Maintainers`).
@@ -53,7 +57,7 @@ issue with the `news` tag (which we will close when we read it).
5357As for adding them to the main repo: maintaining combinators can be expensive,
5458since official combinators must have instances for all classes (and new classes
5559come along fairly frequently). We therefore have to be quite selective about
56−those that we accept. If you're considering writing a new combinator, open an
60+those that we accept. If your considering writing a new combinator, open an
5761issue to discuss it first!
5862
5963
@@ -72,5 +76,5 @@ the `news` label if you make a new package so we can know about it!
7276We are currently moving to a more aggresive release policy, so that you can get
7377what you contribute from Hackage fairly soon. However, note that prior to major
7478releases it may take some time in between releases. If you think you're change
75−is small enough that you should be backported to released major versions, say
79+is small enough that it should be backported to released major versions, say
7680so in the issue or PR.