@@ -28,7 +28,7 @@ Some things we like:
28- Explicit imports
28- Explicit imports
29- Upper and lower bounds for packages
29- Upper and lower bounds for packages
30- Few dependencies
30- Few dependencies
31−- -Werror-compatible
31+- -Werror-compatible (for both 7.8 and 7.10)
33Though we aren't sticklers for style, the `.stylish-haskell.yaml` and `HLint.hs`
33Though we aren't sticklers for style, the `.stylish-haskell.yaml` and `HLint.hs`
34files in the repository provide a good baseline for consistency.
34files in the repository provide a good baseline for consistency.
@@ -38,6 +38,10 @@ the packages you've changed. And of course, write tests!
39## PR process
39## PR process
41+We try to give timely reviews to PRs that pass CI. If CI for your PR fails, we
42+may close the PR if it has been open for too long (though you should feel free
43+to reopen when the issues have been fixed).
41We require two +1 from the maintainers of the repo. If you feel like there has
45We require two +1 from the maintainers of the repo. If you feel like there has
42not been a timely response to a PR, you can ping the Maintainers group (with
46not been a timely response to a PR, you can ping the Maintainers group (with
43`@Maintainers`).
47`@Maintainers`).
@@ -53,7 +57,7 @@ issue with the `news` tag (which we will close when we read it).
53As for adding them to the main repo: maintaining combinators can be expensive,
57As for adding them to the main repo: maintaining combinators can be expensive,
54since official combinators must have instances for all classes (and new classes
58since official combinators must have instances for all classes (and new classes
55come along fairly frequently). We therefore have to be quite selective about
59come along fairly frequently). We therefore have to be quite selective about
56−those that we accept. If you're considering writing a new combinator, open an
60+those that we accept. If your considering writing a new combinator, open an
57issue to discuss it first!
61issue to discuss it first!
@@ -72,5 +76,5 @@ the `news` label if you make a new package so we can know about it!
72We are currently moving to a more aggresive release policy, so that you can get
76We are currently moving to a more aggresive release policy, so that you can get
73what you contribute from Hackage fairly soon. However, note that prior to major
77what you contribute from Hackage fairly soon. However, note that prior to major
74releases it may take some time in between releases. If you think you're change
78releases it may take some time in between releases. If you think you're change
75−is small enough that you should be backported to released major versions, say
79+is small enough that it should be backported to released major versions, say
76so in the issue or PR.
80so in the issue or PR.