git.iko.soy/unity8
on xenial help sign in
Make EdgeDemoOverlay test more reliable by testing for what we really care about, not an indirect indicator of it. Fixes: https://bugs.launchpad.net/bugs/1248232.

Approved by PS Jenkins bot, Albert Astals Cid.

commit03ec1297cb832cd7966b079e0472057bac059b1f authorMichael Terry <michael.terry@canonical.com> dateFri 8 Nov 2013, 09:47 (13 years ago) parenta6883d552b4b93
2 files changed+4−2
compare with xenial
unifiedsplit
Components/EdgeDemoOverlay.qml+2 tests/qmltests/Components/tst_EdgeDemoOverlay.qml+2−2
Components/EdgeDemoOverlay.qml+2
@@ -105,6 +105,8 @@ Showable {
105105 visible: overlay.active
106106
107107 MouseArea {
108+ objectName: "backgroundShadeMouseArea"
109+
108110 anchors.fill: parent
109111 enabled: overlay.edge == "none" && overlay.opacity == 1.0
110112 onClicked: overlay.doSkip()
tests/qmltests/Components/tst_EdgeDemoOverlay.qml+2−2
@@ -112,8 +112,8 @@ Item {
112112 // Test that the 'none' edge skips anywhere
113113 signalSpy.target = none
114114 signalSpy.clear()
115− var backgroundShade = findChild(none, "backgroundShade")
116− tryCompare(none, "opacity", 1)
115+ var backgroundShade = findChild(none, "backgroundShadeMouseArea")
116+ tryCompare(backgroundShade, "enabled", true)
117117 mousePress(backgroundShade, 1, 1)
118118 mouseRelease(backgroundShade, 1, 1)
119119 signalSpy.wait()