on xenial help sign in
Display real name of current user in greeter
commit1648356ac408f6a1515b216fea13dceadf073497 authorMichael Terry <michael.terry@canonical.com> dateMon 1 Feb 2016, 10:15 (11 years ago) parentfc98c69
10 files changed+39−24
CMakeLists.txt+3 plugins/IntegratedLightDM/liblightdm/CMakeLists.txt+3 plugins/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp+33−7 plugins/Powerd/CMakeLists.txt−2 plugins/Unity/Indicators/CMakeLists.txt−4 plugins/Unity/Session/CMakeLists.txt−2 plugins/Utils/CMakeLists.txt−2 tests/mocks/Utils/CMakeLists.txt−2 tests/mocks/indicator-service/CMakeLists.txt−1 tests/plugins/Unity/Indicators/CMakeLists.txt−4
CMakeLists.txt+3
@@ -58,6 +58,9 @@ find_package(Qt5Concurrent 5.4 REQUIRED)
5858find_package(Qt5Sql 5.4 REQUIRED)
5959
6060pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=12)
61+pkg_check_modules(GIO REQUIRED gio-2.0>=2.32)
62+pkg_check_modules(GLIB REQUIRED glib-2.0>=2.32)
63+pkg_check_modules(QMENUMODEL REQUIRED qmenumodel)
6164
6265# Standard install paths
6366include(GNUInstallDirs)
plugins/IntegratedLightDM/liblightdm/CMakeLists.txt+3
@@ -13,14 +13,17 @@ add_library(MockLightDM-demo-shared SHARED ${LibLightDM_SOURCES})
1313
1414include_directories(
1515 ${CMAKE_CURRENT_BINARY_DIR}
16+ ${GLIB_INCLUDE_DIRS}
1617 ${LIBUSERMETRICSOUTPUT_INCLUDE_DIRS}
1718)
1819
1920target_link_libraries(integratedLightDM
21+ ${GLIB_LIBRARIES}
2022 ${LIBUSERMETRICSOUTPUT_LDFLAGS}
2123 -lpam
2224)
2325target_link_libraries(MockLightDM-demo-shared
26+ ${GLIB_LIBRARIES}
2427 ${LIBUSERMETRICSOUTPUT_LDFLAGS}
2528 -lpam
2629)
plugins/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp+33−7
@@ -18,9 +18,11 @@
1818
1919#include "UsersModelPrivate.h"
2020
21+#include <glib.h>
2122#include <QDir>
2223#include <QSettings>
2324#include <QStringList>
25+#include <unistd.h>
2426
2527namespace QLightDM
2628{
@@ -28,14 +30,38 @@ namespace QLightDM
2830UsersModelPrivate::UsersModelPrivate(UsersModel* parent)
2931 : q_ptr(parent)
3032{
31− QSettings settings(QDir::homePath() + "/.unity8-greeter-demo", QSettings::NativeFormat);
32− QStringList users = settings.value(QStringLiteral("users"), QStringList() << qgetenv("USER")).toStringList();
33+ QFileInfo demoFile(QDir::homePath() + "/.unity8-greeter-demo");
34+ QString currentUser = g_get_user_name();
3335
34− entries.reserve(users.count());
35− Q_FOREACH(const QString &user, users)
36− {
37− QString name = settings.value(user + "/name", user).toString();
38− entries.append({user, name, 0, 0, false, false, 0, 0});
36+ if (demoFile.exists()) {
37+ QSettings settings(demoFile.filePath(), QSettings::NativeFormat);
38+ QStringList users = settings.value(QStringLiteral("users"), QStringList() << currentUser).toStringList();
39+
40+ entries.reserve(users.count());
41+ Q_FOREACH(const QString &user, users)
42+ {
43+ QString name = settings.value(user + "/name", user).toString();
44+ entries.append({user, name, 0, 0, false, false, 0, 0});
45+ }
46+ } else {
47+ // If we were using the actual liblightdm, we could just ask it
48+ // for the user's real name. But we aren't. We *should* ask
49+ // AccountsService for the real name, like liblightdm does internally,
50+ // but this is close enough since AS and passwd are always in sync.
51+ QString realName = g_get_real_name(); // gets name from passwd entry
52+ if (realName == QStringLiteral("Unknown")) { // glib doesn't translate this string
53+ realName = QStringLiteral("");
54+ }
55+ if (realName == QStringLiteral("phablet")
56+ && currentUser == QStringLiteral("phablet")
57+ && getuid() == 32011
58+ && getgid() == 32011) {
59+ // This *should* be set at image-creation time, but it hasn't
60+ // always been, so we have to do it here for at least the upgrade
61+ // case. And until it is fixed at image-creation.
62+ realName = QStringLiteral("Ubuntu"); // is brand name, so not translated
63+ }
64+ entries.append({currentUser, realName, 0, 0, false, false, 0, 0});
3965 }
4066}
4167
plugins/Powerd/CMakeLists.txt−2
@@ -1,5 +1,3 @@
1−pkg_search_module(GIO REQUIRED gio-2.0)
2−
31include_directories(
42 ${GIO_INCLUDE_DIRS}
53)
plugins/Unity/Indicators/CMakeLists.txt−4
@@ -1,9 +1,5 @@
11project(IndicatorsQml)
22
3−pkg_check_modules(GLIB REQUIRED glib-2.0>=2.32)
4−pkg_check_modules(GIO REQUIRED gio-2.0>=2.32)
5−pkg_check_modules(QMENUMODEL REQUIRED qmenumodel)
6−
73find_package(Qt5Core REQUIRED)
84find_package(Qt5Quick REQUIRED)
95
plugins/Unity/Session/CMakeLists.txt−2
@@ -1,5 +1,3 @@
1−pkg_search_module(GIO REQUIRED gio-2.0)
2−
31include_directories(
42 ${CMAKE_CURRENT_SOURCE_DIR}
53 ${CMAKE_CURRENT_BINARY_DIR}
plugins/Utils/CMakeLists.txt−2
@@ -1,5 +1,3 @@
1−pkg_search_module(GIO REQUIRED gio-2.0)
2−
31include_directories(
42 ${CMAKE_CURRENT_SOURCE_DIR}
53 ${CMAKE_CURRENT_BINARY_DIR}
tests/mocks/Utils/CMakeLists.txt−2
@@ -1,5 +1,3 @@
1−pkg_search_module(GIO REQUIRED gio-2.0)
2−
31include_directories(
42 ${CMAKE_CURRENT_SOURCE_DIR}
53 ${CMAKE_CURRENT_BINARY_DIR}
tests/mocks/indicator-service/CMakeLists.txt−1
@@ -1,5 +1,4 @@
11project(mock-indicator-service)
2−pkg_search_module(GIO REQUIRED gio-2.0)
32
43set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=c99")
54
tests/plugins/Unity/Indicators/CMakeLists.txt−4
@@ -1,7 +1,3 @@
1−pkg_check_modules(GLIB REQUIRED glib-2.0>=2.32)
2−pkg_check_modules(GIO REQUIRED gio-2.0>=2.32)
3−pkg_check_modules(QMENUMODEL REQUIRED qmenumodel)
4−
51set(INDICATORS_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../../../plugins/Unity/Indicators)
62set(TEST_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../../..)
73