git.iko.soy/unity8
on xenial help sign in
fixed test
commit311734863e0cb67f8b3af937f628812ef1514a88 authorAndrea Cimitan <andrea.cimitan@gmail.com> dateThu 5 May 2016, 11:00 (10 years ago) parentb63a48d
2 files changed+7−1
compare with xenial
unifiedsplit
qml/Dash/Previews/PreviewRatingInput.qml+2 tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+5−1
qml/Dash/Previews/PreviewRatingInput.qml+2
@@ -100,6 +100,7 @@ PreviewWidget {
100100
101101 Item {
102102 id: reviewContainer
103+ objectName: "reviewContainer"
103104 implicitHeight: visible ? reviewSubmitContainer.implicitHeight + anchors.topMargin : 0
104105
105106 readonly property real innerMargin: units.gu(1)
@@ -132,6 +133,7 @@ PreviewWidget {
132133
133134 Item {
134135 id: reviewSubmitContainer
136+ objectName: "reviewSubmitContainer"
135137 anchors.fill: parent
136138 implicitHeight: reviewTextArea.implicitHeight + anchors.topMargin
137139
tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+5−1
@@ -50,7 +50,8 @@ Rectangle {
5050
5151 var authorLabel = findChild(previewRatingEdit, "authorLabel");
5252 var reviewTextArea = findChild(previewRatingEdit, "reviewTextArea");
53− var inputRating = findChild(findChild(previewRatingEdit, "input"), "rating");
53+ var ratingInput = findChild(previewRatingEdit, "input");
54+ var inputRating = findChild(ratingInput, "rating");
5455 verify(authorLabel.visible)
5556 verify(!reviewTextArea.visible)
5657
@@ -65,6 +66,9 @@ Rectangle {
6566 reviewTextArea.text = "Ho Ho";
6667 inputRating.value = 3;
6768
69+ var reviewContainer = findChild(ratingInput, "reviewContainer");
70+ var reviewSubmitContainer = findChild(ratingInput, "reviewSubmitContainer");
71+ tryCompare(reviewContainer, "implicitHeight", reviewSubmitContainer.implicitHeight + reviewContainer.anchors.topMargin);
6872 var submitButton = findChild(previewRatingEdit, "submitButton")
6973 mouseClick(submitButton);
7074