git.iko.soy/unity8
on xenial help sign in
fixed test
3117348Andrea Cimitan
qml/Dash/Previews/PreviewRatingInput.qml+2
compare with xenial
unifiedsplit
@@ -100,6 +100,7 @@ PreviewWidget {
100
100
101 Item {
101 Item {
102 id: reviewContainer
102 id: reviewContainer
103+ objectName: "reviewContainer"
103 implicitHeight: visible ? reviewSubmitContainer.implicitHeight + anchors.topMargin : 0
104 implicitHeight: visible ? reviewSubmitContainer.implicitHeight + anchors.topMargin : 0
104
105
105 readonly property real innerMargin: units.gu(1)
106 readonly property real innerMargin: units.gu(1)
@@ -132,6 +133,7 @@ PreviewWidget {
132
133
133 Item {
134 Item {
134 id: reviewSubmitContainer
135 id: reviewSubmitContainer
136+ objectName: "reviewSubmitContainer"
135 anchors.fill: parent
137 anchors.fill: parent
136 implicitHeight: reviewTextArea.implicitHeight + anchors.topMargin
138 implicitHeight: reviewTextArea.implicitHeight + anchors.topMargin
137
139
tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+5−1
@@ -50,7 +50,8 @@ Rectangle {
50
50
51 var authorLabel = findChild(previewRatingEdit, "authorLabel");
51 var authorLabel = findChild(previewRatingEdit, "authorLabel");
52 var reviewTextArea = findChild(previewRatingEdit, "reviewTextArea");
52 var reviewTextArea = findChild(previewRatingEdit, "reviewTextArea");
53− var inputRating = findChild(findChild(previewRatingEdit, "input"), "rating");
53+ var ratingInput = findChild(previewRatingEdit, "input");
54+ var inputRating = findChild(ratingInput, "rating");
54 verify(authorLabel.visible)
55 verify(authorLabel.visible)
55 verify(!reviewTextArea.visible)
56 verify(!reviewTextArea.visible)
56
57
@@ -65,6 +66,9 @@ Rectangle {
65 reviewTextArea.text = "Ho Ho";
66 reviewTextArea.text = "Ho Ho";
66 inputRating.value = 3;
67 inputRating.value = 3;
67
68
69+ var reviewContainer = findChild(ratingInput, "reviewContainer");
70+ var reviewSubmitContainer = findChild(ratingInput, "reviewSubmitContainer");
71+ tryCompare(reviewContainer, "implicitHeight", reviewSubmitContainer.implicitHeight + reviewContainer.anchors.topMargin);
68 var submitButton = findChild(previewRatingEdit, "submitButton")
72 var submitButton = findChild(previewRatingEdit, "submitButton")
69 mouseClick(submitButton);
73 mouseClick(submitButton);
70
74