git.iko.soy/unity8
on xenial help sign in
Review fixes
commit3ef9c7e9347735813219e7f859d0e02e5d940284 authorNick Dedekind <nicholas.dedekind@gmail.com> dateTue 13 Aug 2013, 11:05 (13 years ago) parentca7aa6d
2 files changed+6−2
compare with xenial
unifiedsplit
Panel/Indicators/NetworkIndicatorPage.qml+1 Panel/MenuContent.qml+5−2
Panel/Indicators/NetworkIndicatorPage.qml+1
@@ -27,6 +27,7 @@ PageStack {
2727 // Stops the search for a parent tree node.
2828 // We don't want it going up to the indicator tabs.
2929 // FIXME: need a better way of doing this.
30+ // https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1211704
3031 __propagated: null
3132
3233 property alias title: _mainPage.title
Panel/MenuContent.qml+5−2
@@ -19,6 +19,9 @@ import Ubuntu.Components 0.1
1919import Unity.Indicators 0.1 as Indicators
2020import "../Components"
2121
22+// FIXME : We dont want to use MainView.
23+// Need a regular Item which can have tabs with local header.
24+// https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1211704
2225MainView {
2326 id: content
2427
@@ -78,8 +81,8 @@ MainView {
7881
7982 Tab {
8083 id: tab
81− objectName: indicatorsModel.data(index, Indicators.IndicatorsModelRole.Identifier)
82− title: indicatorsModel.data(index, Indicators.IndicatorsModelRole.Title)
84+ objectName: model.identifier
85+ title: model.title
8386
8487 page: Page {
8588 Loader {