git.iko.soy/unity8
on xenial help sign in
Review fixes
3ef9c7eNick Dedekind
Panel/Indicators/NetworkIndicatorPage.qml+1
compare with xenial
unifiedsplit
@@ -27,6 +27,7 @@ PageStack {
27 // Stops the search for a parent tree node.
27 // Stops the search for a parent tree node.
28 // We don't want it going up to the indicator tabs.
28 // We don't want it going up to the indicator tabs.
29 // FIXME: need a better way of doing this.
29 // FIXME: need a better way of doing this.
30+ // https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1211704
30 __propagated: null
31 __propagated: null
31
32
32 property alias title: _mainPage.title
33 property alias title: _mainPage.title
Panel/MenuContent.qml+5−2
@@ -19,6 +19,9 @@ import Ubuntu.Components 0.1
19import Unity.Indicators 0.1 as Indicators
19import Unity.Indicators 0.1 as Indicators
20import "../Components"
20import "../Components"
21
21
22+// FIXME : We dont want to use MainView.
23+// Need a regular Item which can have tabs with local header.
24+// https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1211704
22MainView {
25MainView {
23 id: content
26 id: content
24
27
@@ -78,8 +81,8 @@ MainView {
78
81
79 Tab {
82 Tab {
80 id: tab
83 id: tab
81− objectName: indicatorsModel.data(index, Indicators.IndicatorsModelRole.Identifier)
84+ objectName: model.identifier
82− title: indicatorsModel.data(index, Indicators.IndicatorsModelRole.Title)
85+ title: model.title
83
86
84 page: Page {
87 page: Page {
85 Loader {
88 Loader {