on xenial help sign in
Act on review comments.
commit4cbc62dbec28fc1e809309dbd43dfeecad88237f authorPawel Stolowski <pawel.stolowski@canonical.com> dateWed 9 Oct 2013, 09:58 (13 years ago) parentbd63077
1 file changed+4−3
plugins/Utils/albumartprovider.cpp+4−3
plugins/Utils/albumartprovider.cpp+4−3
@@ -160,7 +160,7 @@ std::string AlbumArtProvider::get_image(const std::string &artist, const std::st
160160 }
161161 char tmpname[] = "/tmp/path/to/some/file/somewhere/maybe.jpg";
162162 tmpnam(tmpname);
163− //std::unique_ptr<char, int(*)(const char*)> deleter(tmpname, unlink);
163+ std::unique_ptr<char, int(*)(const char*)> deleter(tmpname, unlink);
164164 if(!download_and_store(image_url, tmpname)) {
165165 return DEFAULT_ALBUM_ART;
166166 }
@@ -207,6 +207,7 @@ QImage AlbumArtProvider::requestImage(const QString &id, QSize *realSize, const
207207 qDebug() << "Unknown error when generating image.";
208208 }
209209
210− *realSize = QSize(0, 0);
211− return QImage(QString::fromStdString(DEFAULT_ALBUM_ART));
210+ QImage fallback(QString::fromStdString(DEFAULT_ALBUM_ART));
211+ *realSize = fallback.size();
212+ return fallback;
212213}