4cbc62d · unity8 · git.iko.soy

on xenial help sign in

Act on review comments.

4cbc62dPawel Stolowski13 years ago

plugins/Utils/albumartprovider.cpp+4−3

@@ -160,7 +160,7 @@ std::string AlbumArtProvider::get_image(const std::string &artist, const std::st

160 }

161 char tmpname[] = "/tmp/path/to/some/file/somewhere/maybe.jpg";

162 tmpnam(tmpname);

163− //std::unique_ptr<char, int(*)(const char*)> deleter(tmpname, unlink);

163+ std::unique_ptr<char, int(*)(const char*)> deleter(tmpname, unlink);

164 if(!download_and_store(image_url, tmpname)) {

165 return DEFAULT_ALBUM_ART;

166 }

@@ -207,6 +207,7 @@ QImage AlbumArtProvider::requestImage(const QString &id, QSize *realSize, const

207 qDebug() << "Unknown error when generating image.";

208 }

209

210− *realSize = QSize(0, 0);

211− return QImage(QString::fromStdString(DEFAULT_ALBUM_ART));

210+ QImage fallback(QString::fromStdString(DEFAULT_ALBUM_ART));

211+ *realSize = fallback.size();

212+ return fallback;

212}

213}