Stop watching the old header item height once it's not our header anymore
It doesn't really matter since in ListViewWithPageHeader::itemImplicitHeightChanged we compare with m_headerItem again so it won't break anything but better be watching only the things we really care about
commit69519ed9ce99ff47a01a751da284e0d00127c7f9
authorAlbert Astals Cid <albert.astals@canonical.com>
dateMon 27 Jun 2016, 18:41 (10 years ago)
parent9a8c14482069b6
plugins/Dash/listviewwithpageheader.cpp+1
@@ -256,6 +256,7 @@ void ListViewWithPageHeader::setHeader(QQuickItem *headerItem)
256256 oldHeaderHeight = m_headerItem->height();
257257 oldHeaderY = m_headerItem->y();
258258 m_headerItem->setParentItem(nullptr);
259+ QQuickItemPrivate::get(m_headerItem)->removeItemChangeListener(this, QQuickItemPrivate::ImplicitHeight);
259260 }
260261 m_headerItem = headerItem;
261262 if (m_headerItem) {