on xenial help sign in
More review changes (mostly to types)
commit6d409ebbdd944a5bbb2cbbf053ef186ff6781ff0 authorJosh Arenson <joshua.arenson@canonical.com> dateFri 4 Sep 2015, 09:07 (11 years ago) parent744e334
2 files changed+5−5
plugins/LightDM/IntegratedLightDM/liblightdm/GreeterPrivate.cpp+4−4 plugins/LightDM/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp+1−1
plugins/LightDM/IntegratedLightDM/liblightdm/GreeterPrivate.cpp+4−4
@@ -65,7 +65,7 @@ public:
6565 cancelPam();
6666 }
6767
68− void start(QString &username)
68+ void start(const QString &username)
6969 {
7070 // Clear out any existing PAM interactions first
7171 cancelPam();
@@ -197,7 +197,7 @@ public:
197197 }
198198
199199public Q_SLOTS:
200− bool respond(QString response)
200+ bool respond(const QString &response)
201201 {
202202 if (!futures.isEmpty()) {
203203 futures.dequeue().reportFinished(&response);
@@ -227,7 +227,7 @@ private Q_SLOTS:
227227 Q_EMIT greeter->authenticationComplete();
228228 }
229229
230− void handleMessage(pam_handle *handle, QString text, QLightDM::Greeter::MessageType type)
230+ void handleMessage(pam_handle *handle, const QString &text, QLightDM::Greeter::MessageType type)
231231 {
232232 if (handle != pamHandle)
233233 return;
@@ -235,7 +235,7 @@ private Q_SLOTS:
235235 Q_EMIT greeter->showMessage(text, type);
236236 }
237237
238− void handlePrompt(pam_handle *handle, QString text, QLightDM::Greeter::PromptType type, QLightDM::GreeterImpl::ResponseFuture future)
238+ void handlePrompt(pam_handle *handle, const QString &text, QLightDM::Greeter::PromptType type, QLightDM::GreeterImpl::ResponseFuture future)
239239 {
240240 if (handle != pamHandle) {
241241 future.reportResult(QString());
plugins/LightDM/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp+1−1
@@ -29,7 +29,7 @@ UsersModelPrivate::UsersModelPrivate(UsersModel* parent)
2929 : q_ptr(parent)
3030{
3131 QSettings settings(QDir::homePath() + "/.unity8-greeter-demo", QSettings::NativeFormat);
32− QStringList users = settings.value("users", QStringList() << qgetenv("USER")).toStringList();
32+ const QStringList users = settings.value("users", QStringList() << qgetenv("USER")).toStringList();
3333
3434 Q_FOREACH(const QString &user, users)
3535 {