git.iko.soy/unity8
on xenial help sign in
More review changes (mostly to types)
6d409ebJosh Arenson
plugins/LightDM/IntegratedLightDM/liblightdm/GreeterPrivate.cpp+4−4
compare with xenial
unifiedsplit
@@ -65,7 +65,7 @@ public:
65 cancelPam();
65 cancelPam();
66 }
66 }
67
67
68− void start(QString &username)
68+ void start(const QString &username)
69 {
69 {
70 // Clear out any existing PAM interactions first
70 // Clear out any existing PAM interactions first
71 cancelPam();
71 cancelPam();
@@ -197,7 +197,7 @@ public:
197 }
197 }
198
198
199public Q_SLOTS:
199public Q_SLOTS:
200− bool respond(QString response)
200+ bool respond(const QString &response)
201 {
201 {
202 if (!futures.isEmpty()) {
202 if (!futures.isEmpty()) {
203 futures.dequeue().reportFinished(&response);
203 futures.dequeue().reportFinished(&response);
@@ -227,7 +227,7 @@ private Q_SLOTS:
227 Q_EMIT greeter->authenticationComplete();
227 Q_EMIT greeter->authenticationComplete();
228 }
228 }
229
229
230− void handleMessage(pam_handle *handle, QString text, QLightDM::Greeter::MessageType type)
230+ void handleMessage(pam_handle *handle, const QString &text, QLightDM::Greeter::MessageType type)
231 {
231 {
232 if (handle != pamHandle)
232 if (handle != pamHandle)
233 return;
233 return;
@@ -235,7 +235,7 @@ private Q_SLOTS:
235 Q_EMIT greeter->showMessage(text, type);
235 Q_EMIT greeter->showMessage(text, type);
236 }
236 }
237
237
238− void handlePrompt(pam_handle *handle, QString text, QLightDM::Greeter::PromptType type, QLightDM::GreeterImpl::ResponseFuture future)
238+ void handlePrompt(pam_handle *handle, const QString &text, QLightDM::Greeter::PromptType type, QLightDM::GreeterImpl::ResponseFuture future)
239 {
239 {
240 if (handle != pamHandle) {
240 if (handle != pamHandle) {
241 future.reportResult(QString());
241 future.reportResult(QString());
plugins/LightDM/IntegratedLightDM/liblightdm/UsersModelPrivate.cpp+1−1
@@ -29,7 +29,7 @@ UsersModelPrivate::UsersModelPrivate(UsersModel* parent)
29 : q_ptr(parent)
29 : q_ptr(parent)
30{
30{
31 QSettings settings(QDir::homePath() + "/.unity8-greeter-demo", QSettings::NativeFormat);
31 QSettings settings(QDir::homePath() + "/.unity8-greeter-demo", QSettings::NativeFormat);
32− QStringList users = settings.value("users", QStringList() << qgetenv("USER")).toStringList();
32+ const QStringList users = settings.value("users", QStringList() << qgetenv("USER")).toStringList();
33
33
34 Q_FOREACH(const QString &user, users)
34 Q_FOREACH(const QString &user, users)
35 {
35 {