git.iko.soy/unity8
on xenial help sign in
Fix rating input action to always be "rated", not dynamic.
commit94fab89be99aa16dcf339c6ac2a418e6cb458952 authorMichał Sawicz <michal.sawicz@canonical.com> dateTue 18 Mar 2014, 09:50 (13 years ago) parentdf0623c
2 files changed+2−2
compare with xenial
unifiedsplit
qml/Dash/Previews/PreviewRatingInput.qml+1−1 tests/qmltests/Dash/Previews/tst_PreviewRatingInput.qml+1−1
qml/Dash/Previews/PreviewRatingInput.qml+1−1
@@ -58,7 +58,7 @@ PreviewWidget {
5858 reviewTextArea.text === "")) return;
5959
6060 var data = {"rating": rating.value, "review": reviewTextArea.text, "author": null};
61− triggered(root.widgetId, widgetData["required"], data);
61+ triggered(root.widgetId, "rated", data);
6262 }
6363
6464 Item {
tests/qmltests/Dash/Previews/tst_PreviewRatingInput.qml+1−1
@@ -174,7 +174,7 @@ Rectangle {
174174 compare(spy.count, 1);
175175 var args = spy.signalArguments[0];
176176 compare(args[0], previewRatingInput.widgetId);
177− compare(args[1], data.widgetData["required"]);
177+ compare(args[1], "rated");
178178 compare(args[2]["rating"], data.triggeredData["rating"]);
179179 compare(args[2]["review"], data.triggeredData["review"]);
180180 verify(args[2]["author"]); // Just verifying it exists now