git.iko.soy/unity8
on xenial help sign in
Fix rating input action to always be "rated", not dynamic.
94fab89Michał Sawicz
qml/Dash/Previews/PreviewRatingInput.qml+1−1
compare with xenial
unifiedsplit
@@ -58,7 +58,7 @@ PreviewWidget {
58 reviewTextArea.text === "")) return;
58 reviewTextArea.text === "")) return;
59
59
60 var data = {"rating": rating.value, "review": reviewTextArea.text, "author": null};
60 var data = {"rating": rating.value, "review": reviewTextArea.text, "author": null};
61− triggered(root.widgetId, widgetData["required"], data);
61+ triggered(root.widgetId, "rated", data);
62 }
62 }
63
63
64 Item {
64 Item {
tests/qmltests/Dash/Previews/tst_PreviewRatingInput.qml+1−1
@@ -174,7 +174,7 @@ Rectangle {
174 compare(spy.count, 1);
174 compare(spy.count, 1);
175 var args = spy.signalArguments[0];
175 var args = spy.signalArguments[0];
176 compare(args[0], previewRatingInput.widgetId);
176 compare(args[0], previewRatingInput.widgetId);
177− compare(args[1], data.widgetData["required"]);
177+ compare(args[1], "rated");
178 compare(args[2]["rating"], data.triggeredData["rating"]);
178 compare(args[2]["rating"], data.triggeredData["rating"]);
179 compare(args[2]["review"], data.triggeredData["review"]);
179 compare(args[2]["review"], data.triggeredData["review"]);
180 verify(args[2]["author"]); // Just verifying it exists now
180 verify(args[2]["author"]); // Just verifying it exists now