git.iko.soy/unity8
on xenial help sign in
Make PreviewRatingSingleDisplay visible again after editing a review. (LP: #1587097)
commitae5c8ef410eb6bef532610a2a5c81f4df125c58b authorJosh Arenson <joshua.arenson@canonical.com> dateMon 27 Jun 2016, 18:42 (10 years ago) parent49867a5225f0d2
2 files changed+7−1
compare with xenial
unifiedsplit
qml/Dash/Previews/PreviewRatingEdit.qml+4−1 tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+3
qml/Dash/Previews/PreviewRatingEdit.qml+4−1
@@ -73,7 +73,10 @@ PreviewWidget {
7373 ratingValue: widgetData["rating"]
7474 reviewText: widgetData["review"]
7575
76− onTriggered: root.triggered(widgetId, actionId, data);
76+ onTriggered: {
77+ root.triggered(widgetId, actionId, data);
78+ display.visible = true;
79+ }
7780 onMakeSureVisible: root.makeSureVisible(item);
7881 }
7982
tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+3
@@ -56,7 +56,9 @@ Rectangle {
5656 verify(!reviewTextArea.visible)
5757
5858 var editButton = findChild(previewRatingEdit, "editButton");
59+ var display = findChild(previewRatingEdit, "display");
5960 mouseClick(editButton);
61+ tryCompare(display, "visible", false);
6062 verify(!authorLabel.visible)
6163 verify(reviewTextArea.visible)
6264
@@ -72,6 +74,7 @@ Rectangle {
7274 var submitButton = findChild(previewRatingEdit, "submitButton")
7375 mouseClick(submitButton);
7476
77+ tryCompare(display, "visible", true);
7578 compare(spy.count, 1);
7679 var args = spy.signalArguments[0];
7780 compare(args[0], previewRatingEdit.widgetId);