git.iko.soy/unity8
on xenial help sign in
Make PreviewRatingSingleDisplay visible again after editing a review. (LP: #1587097)
ae5c8efJosh Arenson
qml/Dash/Previews/PreviewRatingEdit.qml+4−1
compare with xenial
unifiedsplit
@@ -73,7 +73,10 @@ PreviewWidget {
73 ratingValue: widgetData["rating"]
73 ratingValue: widgetData["rating"]
74 reviewText: widgetData["review"]
74 reviewText: widgetData["review"]
75
75
76+ onTriggered: {
76− onTriggered: root.triggered(widgetId, actionId, data);
77+ root.triggered(widgetId, actionId, data);
78+ display.visible = true;
79+ }
77 onMakeSureVisible: root.makeSureVisible(item);
80 onMakeSureVisible: root.makeSureVisible(item);
78 }
81 }
79
82
tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml+3
@@ -56,7 +56,9 @@ Rectangle {
56 verify(!reviewTextArea.visible)
56 verify(!reviewTextArea.visible)
57
57
58 var editButton = findChild(previewRatingEdit, "editButton");
58 var editButton = findChild(previewRatingEdit, "editButton");
59+ var display = findChild(previewRatingEdit, "display");
59 mouseClick(editButton);
60 mouseClick(editButton);
61+ tryCompare(display, "visible", false);
60 verify(!authorLabel.visible)
62 verify(!authorLabel.visible)
61 verify(reviewTextArea.visible)
63 verify(reviewTextArea.visible)
62
64
@@ -72,6 +74,7 @@ Rectangle {
72 var submitButton = findChild(previewRatingEdit, "submitButton")
74 var submitButton = findChild(previewRatingEdit, "submitButton")
73 mouseClick(submitButton);
75 mouseClick(submitButton);
74
76
77+ tryCompare(display, "visible", true);
75 compare(spy.count, 1);
78 compare(spy.count, 1);
76 var args = spy.signalArguments[0];
79 var args = spy.signalArguments[0];
77 compare(args[0], previewRatingEdit.widgetId);
80 compare(args[0], previewRatingEdit.widgetId);