on xenial help sign in
Fix review comments.
commitd8e5a7f2c2078e05f3419b03228054fc8b9c1174 authorMichał Sawicz <michal.sawicz@canonical.com> dateFri 15 Aug 2014, 01:04 (12 years ago) parent449a51b
1 file changed+1−5
plugins/Dash/CardCreator.js+1−5
plugins/Dash/CardCreator.js+1−5
@@ -640,9 +640,7 @@ function cardString(template, components) {
640640 } else if (hasArt) {
641641 implicitHeight += 'artShapeHolder.height;\n';
642642 } else {
643− // No implicit height, close
644− code += '}\n';
645− return code
643+ implicitHeight = '';
646644 }
647645
648646 // Close the AbstractButton
@@ -658,11 +656,9 @@ function createCardComponent(parent, template, components) {
658656 var card = cardString(template, components);
659657 var code = imports + 'Component {\n' + card + '}\n';
660658
661− var o = null;
662659 try {
663660 return Qt.createQmlObject(code, parent, "createCardComponent");
664661 } catch (e) {
665− var k;
666662 console.error("ERROR: Invalid component created.");
667663 console.error("Template:");
668664 console.error(JSON.stringify(template));