d8e5a7f · unity8 · git.iko.soy

on xenial help sign in

Fix review comments.

d8e5a7fMichał Sawicz12 years ago

plugins/Dash/CardCreator.js+1−5

@@ -640,9 +640,7 @@ function cardString(template, components) {

640 } else if (hasArt) {

641 implicitHeight += 'artShapeHolder.height;\n';

642 } else {

643− // No implicit height, close

643+ implicitHeight = '';

644− code += '}\n';

645− return code

646 }

644 }

647

645

648 // Close the AbstractButton

646 // Close the AbstractButton

@@ -658,11 +656,9 @@ function createCardComponent(parent, template, components) {

658 var card = cardString(template, components);

656 var card = cardString(template, components);

659 var code = imports + 'Component {\n' + card + '}\n';

657 var code = imports + 'Component {\n' + card + '}\n';

660

658

661− var o = null;

662 try {

659 try {

663 return Qt.createQmlObject(code, parent, "createCardComponent");

660 return Qt.createQmlObject(code, parent, "createCardComponent");

664 } catch (e) {

661 } catch (e) {

665− var k;

666 console.error("ERROR: Invalid component created.");

662 console.error("ERROR: Invalid component created.");

667 console.error("Template:");

663 console.error("Template:");

668 console.error(JSON.stringify(template));

664 console.error(JSON.stringify(template));