e7bb4ce · unity8 · git.iko.soy

git.iko.soy/unity8

WindowInputMonitor - also map Qt::Key_HomePage to our home key

commite7bb4ce5712aab0f36de6fa52ca6fb9a10018d07 authorDaniel d'Andrada <daniel.dandrada@canonical.com> dateMon 21 Mar 2016, 15:47 (11 years ago) parente71b851

3 files changed+66−21

compare with xenial

unifiedsplit

plugins/Utils/WindowInputMonitor.cpp+8−8 plugins/Utils/WindowInputMonitor.h+8−2 tests/plugins/Utils/WindowInputMonitorTest.cpp+50−11

plugins/Utils/WindowInputMonitor.cpp+8−8

@@ -1,5 +1,5 @@

11/*

33 *

44 * This program is free software; you can redistribute it and/or modify

55 * it under the terms of the GNU General Public License as published by

@@ -30,7 +30,6 @@ WindowInputMonitor::WindowInputMonitor(UnityUtil::AbstractTimer *timer,

3030 QQuickItem *parent)

3131 : QQuickItem(parent)

3232 , m_windowBeingTouched(false)

33− , m_homeKeyPressed(false)

3433 , m_windowLastTouchedTimer(elapsedTimer)

3534 , m_activationTimer(timer)

3635{

@@ -42,6 +41,7 @@ WindowInputMonitor::WindowInputMonitor(UnityUtil::AbstractTimer *timer,

4241 connect(m_activationTimer, &UnityUtil::AbstractTimer::timeout,

4342 this, &WindowInputMonitor::emitActivatedIfNoTouchesAround);

4443 m_activationTimer->setInterval(msecsWithoutTouches);

44+ m_activationTimer->setSingleShot(true);

4545}

4646

4747WindowInputMonitor::~WindowInputMonitor()

@@ -67,19 +67,19 @@ void WindowInputMonitor::update(QEvent *event)

6767 if (event->type() == QEvent::KeyPress) {

6868 QKeyEvent *keyEvent = static_cast<QKeyEvent*>(event);

6969

70− m_homeKeyPressed = true;

71−

72− if (keyEvent->key() == Qt::Key_Super_L && !keyEvent->isAutoRepeat()

70+ if (m_pressedHomeKey == 0 && m_homeKeys.contains(keyEvent->key()) && !keyEvent->isAutoRepeat()

71+ && !m_activationTimer->isRunning()

7372 && !m_windowBeingTouched

7473 && m_windowLastTouchedTimer->elapsed() >= msecsWithoutTouches) {

74+ m_pressedHomeKey = keyEvent->key();

7575 m_activationTimer->start();

7676 }

7777

7878 } else if (event->type() == QEvent::KeyRelease) {

7979 QKeyEvent *keyEvent = static_cast<QKeyEvent*>(event);

8080

81− if (keyEvent->key() == Qt::Key_Super_L) {

82− m_homeKeyPressed = false;

81+ if (keyEvent->key() == m_pressedHomeKey) {

82+ m_pressedHomeKey = 0;

8383 }

8484

8585 } else if (event->type() == QEvent::TouchBegin) {

@@ -116,7 +116,7 @@ void WindowInputMonitor::setupFilterOnWindow(QQuickWindow *window)

116116

117117void WindowInputMonitor::emitActivatedIfNoTouchesAround()

118118{

119− if (!m_homeKeyPressed && !m_windowBeingTouched &&

119+ if (m_pressedHomeKey == 0 && !m_windowBeingTouched &&

120120 (m_windowLastTouchedTimer->elapsed() > msecsWithoutTouches)) {

121121 Q_EMIT homeKeyActivated();

122122 }

plugins/Utils/WindowInputMonitor.h+8−2

@@ -1,5 +1,5 @@

11/*

33 *

44 * This program is free software; you can redistribute it and/or modify

55 * it under the terms of the GNU General Public License as published by

@@ -18,6 +18,7 @@

1818#define UNITY_WINDOWINPUTMONITOR_H

1919

2020#include <QQuickItem>

21+#include <QList>

2122#include <QPointer>

2223

2324#include "Timer.h"

@@ -83,9 +84,14 @@ private Q_SLOTS:

8384private:

8485 QPointer<QQuickWindow> m_filteredWindow;

8586 bool m_windowBeingTouched;

86− bool m_homeKeyPressed;

8787 UnityUtil::AbstractElapsedTimer *m_windowLastTouchedTimer;

8888 UnityUtil::AbstractTimer *m_activationTimer;

89+

90+ // Qt::Keys that are mapped to our "home" key.

91+ QList<int> m_homeKeys{Qt::Key_Super_L, Qt::Key_HomePage};

92+ // Which Qt::Key from m_homeKeys is currently pressed.

93+ // 0 if none

94+ int m_pressedHomeKey{0};

8995};

9096

9197#endif // UNITY_WINDOWINPUTMONITOR_H

tests/plugins/Utils/WindowInputMonitorTest.cpp+50−11

@@ -1,5 +1,5 @@

11/*

33 *

44 * This program is free software; you can redistribute it and/or modify

55 * it under the terms of the GNU General Public License as published by

@@ -81,6 +81,7 @@ private Q_SLOTS:

8181 void touchTapTouch();

8282

8383 void tapWhileTouching();

84+ void multipleHomeKeys();

8485

8586private:

8687 void passTime(qint64 timeSpanMs);

@@ -112,13 +113,15 @@ void WindowInputMonitorTest::touchTapTouch_data()

112113 QTest::addColumn<int>("tapDuration");

113114 QTest::addColumn<int>("silenceAfterTap");

114115 QTest::addColumn<int>("expectedActivatedCount");

115−

116− QTest::newRow("tap followed by touch") << 2000 << 50 << 10 << 0;

117− QTest::newRow("touch, tap and touch") << 10 << 50 << 10 << 0;

118− QTest::newRow("touch followed by tap") << 10 << 50 << 2000 << 0;

119− QTest::newRow("touch followed by long tap") << 10 << 500 << 2000 << 0;

120− QTest::newRow("isolated tap") << 1000 << 50 << 1000 << 1;

121− QTest::newRow("isolated long press") << 1000 << 200 << 1000 << 0;

116+ QTest::addColumn<Qt::Key>("key");

117+

118+ QTest::newRow("tap followed by touch") << 2000 << 50 << 10 << 0 << Qt::Key_Super_L;

119+ QTest::newRow("touch, tap and touch") << 10 << 50 << 10 << 0 << Qt::Key_Super_L;

120+ QTest::newRow("touch followed by tap") << 10 << 50 << 2000 << 0 << Qt::Key_Super_L;

121+ QTest::newRow("touch followed by long tap") << 10 << 500 << 2000 << 0 << Qt::Key_Super_L;

122+ QTest::newRow("isolated tap, Super_L") << 1000 << 50 << 1000 << 1 << Qt::Key_Super_L;

123+ QTest::newRow("isolated tap, HomePage") << 1000 << 50 << 1000 << 1 << Qt::Key_HomePage;

124+ QTest::newRow("isolated long press") << 1000 << 200 << 1000 << 0 << Qt::Key_Super_L;

122125}

123126

124127void WindowInputMonitorTest::touchTapTouch()

@@ -127,6 +130,7 @@ void WindowInputMonitorTest::touchTapTouch()

127130 QFETCH(int, tapDuration);

128131 QFETCH(int, silenceAfterTap);

129132 QFETCH(int, expectedActivatedCount);

133+ QFETCH(Qt::Key, key);

130134 WindowInputMonitor homeKeyWatcher(m_fakeTimerFactory->create(), new FakeElapsedTimer);

131135 QSignalSpy activatedSpy(&homeKeyWatcher, &WindowInputMonitor::homeKeyActivated);

132136 QVERIFY(activatedSpy.isValid());

@@ -149,7 +153,7 @@ void WindowInputMonitorTest::touchTapTouch()

149153 passTime(silenceBeforeTap);

150154

151155 {

152− QKeyEvent keyEvent(QEvent::KeyPress, Qt::Key_Super_L, Qt::NoModifier);

156+ QKeyEvent keyEvent(QEvent::KeyPress, key, Qt::NoModifier);

153157 homeKeyWatcher.update(&keyEvent);

154158 }

155159 int tapTime = 0;

@@ -157,10 +161,10 @@ void WindowInputMonitorTest::touchTapTouch()

157161 passTime(10);

158162 tapTime += 10;

159163 if (tapTime + 10 >= tapDuration) {

160− QKeyEvent keyEvent(QEvent::KeyRelease, Qt::Key_Super_L, Qt::NoModifier);

164+ QKeyEvent keyEvent(QEvent::KeyRelease, key, Qt::NoModifier);

161165 homeKeyWatcher.update(&keyEvent);

162166 } else {

163− QKeyEvent keyEvent(QEvent::KeyPress, Qt::Key_Super_L, Qt::NoModifier, QString(), true /*autorepeat*/);

167+ QKeyEvent keyEvent(QEvent::KeyPress, key, Qt::NoModifier, QString(), true /*autorepeat*/);

164168 homeKeyWatcher.update(&keyEvent);

165169 }

166170 }

@@ -217,6 +221,41 @@ void WindowInputMonitorTest::tapWhileTouching()

217221 QCOMPARE(activatedSpy.count(), 0);

218222}

219223

224+/*

225+ Press multiple of the mapped home keys roughly at the same time.

226+ The first pressed will be recognized and the other ignored

227+ */

228+void WindowInputMonitorTest::multipleHomeKeys()

229+{

230+ WindowInputMonitor homeKeyWatcher(m_fakeTimerFactory->create(), new FakeElapsedTimer);

231+ QSignalSpy activatedSpy(&homeKeyWatcher, &WindowInputMonitor::homeKeyActivated);

232+ QVERIFY(activatedSpy.isValid());

233+

234+ passTime(1000);

235+ {

236+ QKeyEvent keyEvent(QEvent::KeyPress, Qt::Key_HomePage, Qt::NoModifier);

237+ homeKeyWatcher.update(&keyEvent);

238+ }

239+ passTime(50);

240+ {

241+ QKeyEvent keyEvent(QEvent::KeyPress, Qt::Key_Super_L, Qt::NoModifier);

242+ homeKeyWatcher.update(&keyEvent);

243+ }

244+ passTime(50);

245+ {

246+ QKeyEvent keyEvent(QEvent::KeyRelease, Qt::Key_HomePage, Qt::NoModifier);

247+ homeKeyWatcher.update(&keyEvent);

248+ }

249+ passTime(10);

250+ {

251+ QKeyEvent keyEvent(QEvent::KeyRelease, Qt::Key_Super_L, Qt::NoModifier);

252+ homeKeyWatcher.update(&keyEvent);

253+ }

254+ passTime(1000);

255+

256+ QCOMPARE(activatedSpy.count(), 1);

257+}

258+

220259/////////////////////////////////// FakeTimer //////////////////////////////////

221260

222261FakeTimer::FakeTimer(QObject *parent)