git.iko.soy/unity8
on xenial help sign in
Add a FIXME about reordering scopes.
eba0e33Michał Sawicz
plugins/Unity/scopes.cpp+1−1
compare with xenial
unifiedsplit
@@ -128,7 +128,7 @@ void Scopes::onScopeRemoved(const unity::dash::Scope::Ptr& scope)
128
128
129void Scopes::onScopesReordered(const unity::dash::Scopes::ScopeList& scopes)
129void Scopes::onScopesReordered(const unity::dash::Scopes::ScopeList& scopes)
130{
130{
131− // is this QML-friendly? Shall it be more robust (beginMoveRows)?
131+ // FIXME Should use beginMoveRows()/endMoveRows() to not recreate the UI for every scope.
132 beginResetModel();
132 beginResetModel();
133
133
134 // remove existing scopes
134 // remove existing scopes