urbit/shrub
1
1
Fork 0
mirror of https://github.com/urbit/shrub.git synced 2024-12-24 20:47:27 +03:00
Code Issues Packages Projects Releases Wiki Activity

push-hook: noop on unversioned, unsupported watches

Browse Source 
Mainnet is currently experiencing undue load due to a watch-kick loop.
If the watch is unsupported, it will be kicked due to a mark mismatch,
which will be interpreted by the unversioned hooks as a network pressure
kick, prompting a resub and continuing the loop. Instead, we now no-op
on unversioned, unsupported watches, waiting for the subscriber to
rewatch after it processes the versioning OTA. This will silently break
groups for the subscriber until the reach the latest OTA, but is
preferable to nacking, and kicking them permanently
This commit is contained in:
Liam Fitzgerald 2021-04-02 19:56:07 +10:00
parent f322360dca
commit 479fbfd798
No known key found for this signature in database
GPG Key ID: D390E12C61D1CFFB
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/arvo/lib/push-hook.hoon
View File

@ -277,6 +277,9 @@
:: ::
++ unversioned ++ unversioned
?> ?=([%ship @ @ *] t.path) ?> ?=([%ship @ @ *] t.path)
?. =(min-version.config 0)
~& >>> "unversioned req from: {<src.bowl>}, nooping"
`this
=/ =resource =/ =resource
(de-path:resource t.path) (de-path:resource t.path)
=/ =vase =/ =vase

1
pkg/arvo/mar/metadata/update-1.hoon
View File

@ -4,7 +4,6 @@
++ grow ++ grow
|% |%
++ noun update ++ noun update
++ metadata-update update
++ json (update:enjs:store update) ++ json (update:enjs:store update)
-- --
:: ::