Commit Graph

32324 Commits

Author SHA1 Message Date
fang
08ad367cd8
eyre: when a %request causes a crud, serve 500
Previously, if an incoming request caused a crash, we would just drop it
on the floor. We should at least have the decency to serve the client a
quick 500 and let them get on with their day.

We make sure not to touch state here. The connection is guaranteed-fresh
because of the task's semantics, and we're handling it in-line in one go.

Notably we only give a simple "crud!" for the body, instead of the full
error trace. We don't know whether the request is authenticated or not
(and who knows if checking was the cause of the crash!), and the crud
might leak sensitive details about the ship it occurred on. For the
owner, the trace still gets printed into the terminal.
2023-05-04 17:42:36 +02:00
Ted Blackman
100333cd5a
Merge pull request #6549 from urbit/jb/eyre-safe
eyre: handle agent errors safely
2023-05-03 19:16:10 -04:00
Joe Bryan
c42f1d2663 eyre: corrects connection lifecycle comment 2023-05-03 18:40:22 -04:00
Joe Bryan
c349d154b6 eyre: optimizes responses, removes redundant connection state updates 2023-05-03 18:39:19 -04:00
Joe Bryan
007a32c47a eyre: remove redundant connection retrieval 2023-05-03 18:25:48 -04:00
Joe Bryan
7fb2f613d4 eyre: no-op on agent-error when missing connection state 2023-05-03 18:25:10 -04:00
Ted Blackman
4d3af06300
Merge pull request #6545 from urbit/jb/road-pile
clay: virtualize parsing to workaround runaway memoization
2023-05-02 17:37:27 -04:00
Joe Bryan
7f2257e581 clay: virtualize parsing to workaround runaway memoization 2023-05-02 17:16:22 -04:00
Ted Blackman
51e85291c1
Merge pull request #6542 from urbit/wicrum/wan-mop
lull,ames: use `mop` instead of `pha` in `.wan.keens`
2023-05-02 11:55:38 -04:00
~wicrum-wicrun
451a84d467 jael: fake ships always have rift=0 2023-05-02 17:36:22 +02:00
Ted Blackman
09fb89bd5b
Merge pull request #6509 from urbit/jon/doccords-lustar-tistar
turn off doccord parsing for +*, =*
2023-05-02 11:23:15 -04:00
~wicrum-wicrun
c1e14bdbf5 ames: use +pry:mop and +del:mop instead of virtualizing 2023-05-02 17:07:14 +02:00
~wicrum-wicrun
99ca67db7f tests: remove defunct deq test 2023-05-02 17:02:58 +02:00
~wicrum-wicrun
c03c3dc13b ames: migration uses +tap:deq instead of +dip-left:deq 2023-05-02 17:01:53 +02:00
Ted Blackman
1c69528565
Merge pull request #6538 from bacwyls/bwyl/read-s-subs-413-patch
clay: fix read-s subs for 413
2023-05-02 10:42:29 -04:00
Ted Blackman
e4b4f25d52
Merge pull request #6543 from urbit/jb/vang-compat
hoon: support configurable doccords parsing
2023-05-02 10:41:07 -04:00
Joe Bryan
1c26d431f5 hoon: threads doccords flags through +vang, compatibly 2023-05-02 10:34:33 -04:00
Joe Bryan
4a92c7d7d4 Revert "hoon: add doc parsing flag to +vang"
This reverts commit 94ba944188.
2023-05-02 10:31:42 -04:00
~wicrum-wicrun
ecaf70bc00 ames,lull,zuse: move +pha and +deq into ames to not pollute kelvin code 2023-05-02 16:26:59 +02:00
~wicrum-wicrun
ded0b75914 ames,lull: .wan.keen uses fragment as mop key 2023-05-02 16:25:51 +02:00
~wicrum-wicrun
d7a2c53df8 lull,ames: use mop instead of pha in .wan.keens 2023-05-02 15:17:25 +02:00
bacwyls
4a1aae5c48 clay: fix read-s subs for 413
=case was added as an argument to read-s to support %cs subs
it was accidentally removed as an argument during a merge,
breaking %cs subs by causing it to always crash in a
comparison between case and [%da now], because case resolved
to the mold rather than a value. this commit restores
intended functionality.
2023-05-01 18:32:49 -05:00
Joe Bryan
6c0e53e9da
Merge pull request #6535 from urbit/jb/fix-vat
vats: fixes +vat
2023-05-01 16:35:22 -04:00
Joe Bryan
9c59c970e3 vats: fixes +vat 2023-05-01 16:30:21 -04:00
Hunter Miller
10ea5dd55b
Merge pull request #6534 from urbit/hm/landscape-413-pt2
landscape: actual 413 compat
2023-05-01 14:58:35 -05:00
Hunter Miller
5f67d79411 landscape: use correct args and syntax 2023-05-01 14:26:38 -05:00
Ted Blackman
70bef7aee3
Merge pull request #6533 from urbit/hm/landscape-413
landscape: compat w/ 413
2023-05-01 15:08:19 -04:00
Ted Blackman
b632316fba
Merge pull request #6532 from urbit/jb/vats-perf
vats: force multiline rendering, improve performance
2023-05-01 11:38:30 -04:00
Jonathan Paprocki
e718423135 hoon: remove swap +vang for (doc |) in +loll 2023-05-01 11:37:27 -04:00
Ted Blackman
c3d461d6de
Merge pull request #6515 from urbit/i/6504/fine-next-steps
fine: next steps
2023-05-01 11:32:52 -04:00
Josh Lehman
ad51758e2c
Merge pull request #6531 from jfranklin9000/maintainers
meta: don't codeblock table in MAINTAINERS.md
2023-05-01 10:11:19 -05:00
Hunter Miller
565869f86d landscape: compat w/ 413 2023-05-01 09:59:19 -05:00
Joe Bryan
48abe3a8ef
Merge pull request #6528 from jfranklin9000/contributing
meta: command corrections in CONTRIBUTING.md
2023-04-29 22:36:29 -04:00
Joe Bryan
444242b5fc vats: sort force on/off lists 2023-04-29 10:33:54 -04:00
Joe Bryan
b7bf1e68ca vats: sort alphabetically within constraints (%base first, %kids last) 2023-04-29 10:13:50 -04:00
Joe Bryan
92a1f50a49 vats: refactor generator 2023-04-29 10:05:56 -04:00
Joe Bryan
d732e5a91a vats: hack to always render multi-line tanks 2023-04-29 10:03:15 -04:00
Joe Bryan
05a7c755c6 base: pin the %kelvin mark in sur/hood for +vats 2023-04-29 10:01:06 -04:00
Joe Bryan
0de26c2000
Merge pull request #6529 from jfranklin9000/vats-base-kids
+vats: sort %base and %kids (sometimes)
2023-04-29 09:59:11 -04:00
John Franklin
d51c8bf50d meta: don't codeblock table in MAINTAINERS.md 2023-04-29 07:36:28 -05:00
John Franklin
dd02444876 +vats: sort %base and %kids (sometimes) 2023-04-29 04:04:30 -05:00
John Franklin
3fc62792e3 meta: command corrections in CONTRIBUTING.md 2023-04-29 02:20:14 -05:00
~wicrum-wicrun
b804ab3a23 gall: hold on to .ken.yoke through uninstalls 2023-04-28 19:19:42 +02:00
Ted Blackman
fa14915993
Merge pull request #6506 from jfranklin9000/develop
lib/server: de-indent ++ico-response
2023-04-28 11:52:20 -04:00
Joe Bryan
555a2d51ee
Merge pull request #6522 from jfranklin9000/report-vat
hood: +report-vat: handle desks with multiple base hashes (=verb |)
2023-04-28 11:25:54 -04:00
Ted Blackman
1119257fb3
Merge branch 'develop' into report-vat 2023-04-28 11:16:07 -04:00
Ted Blackman
8208280084
Merge pull request #6524 from urbit/philip/clay-cache
clay: Make commits fast again
2023-04-28 10:51:05 -04:00
John Franklin
249eb50d42 hood: +report-vat: handle desks with null base hash (=verb |) 2023-04-27 20:10:53 -05:00
Philip Monk
013f294cde clay: correctly save cache after goad
The refactor from aeon to tako is from May 2022, but unmerged until
March 2023.  In the meantime, I added another usage of aeon-flow in July
2022, which was converted to aeon-flow in March 2023, but the argument
itself was unchanged.  This meant we didn't save the cache after +goad.
2023-04-27 17:09:33 -07:00
John Franklin
a017c02c4f hood: +report-vat: handle desks with multiple base hashes (=verb |) 2023-04-27 18:23:34 -05:00