Mikayla Maki
35a9b90528
Fix bugs in git implementation ( #2495 )
...
fixes
https://linear.app/zed-industries/issue/Z-1593/clean-up-git-integration
- Fixes calculation of git offsets in the scrollbar:
fixes
https://linear.app/zed-industries/issue/Z-1608/fix-scrollbar-diffs-sliding-out-of-sync-with-gutter-diffs-in
fixes
https://linear.app/zed-industries/issue/Z-1629/project-search-panel-has-git-marks-on-the-scrollbar-misaligned
fixes
https://linear.app/zed-industries/issue/Z-1625/soft-wrap-affects-diff-locations-in-scrollbar
- Improves the performance of scrollbar hunks:
fixes
https://linear.app/zed-industries/issue/Z-1640/double-check-performance-of-scrollbar-hunks
- Fixes a long standing bug with how git gutters interact with soft
wraps:
fixes
https://linear.app/zed-industries/issue/Z-1442/make-hunks-grow-to-the-end-of-softwraps-when-ending-on-a-softwrapped
- Allows work directories to be renamed
fixes
https://linear.app/zed-industries/issue/Z-1577/fix-stale-git-repositories-when-directory-is-renamed
Release Notes:
* Fix the offsets of the git diffs in the scrollbar when there are
folds, wraps, or excerpts (preview only)
* Allow the work directory of a repository to be renamed (preview only)
* Extend git gutter to cover the entirety of a wrapped line
(https://github.com/zed-industries/community/issues/937 )
2023-05-19 18:15:11 -07:00
Mikayla Maki
bbb68c523c
Refactored apart the forward and the backwards iterator for diff hunks
2023-05-19 18:09:47 -07:00
Mikayla Maki
43e301eeef
refine batched anchor conversions
...
co-authored-by: max <max@zed.dev>
2023-05-19 16:52:57 -07:00
Mikayla Maki
1474429271
fmt
2023-05-19 16:32:07 -07:00
Mikayla Maki
c795c9b844
Rearrange git tests in worktree
...
Add support for renaming work directories
2023-05-19 16:30:00 -07:00
Mikayla Maki
623a177fe6
Fix bug where git diff hunks would not extend through a soft wrap
2023-05-19 16:23:45 -07:00
Mikayla Maki
560160b100
Batch anchor conversions in git hunk iterator
2023-05-19 16:23:45 -07:00
Mikayla Maki
2a41a32aac
Calculate y offsets correctly
2023-05-19 16:23:45 -07:00
Max Brunsfeld
d7d29472c2
Remove expensive-to-clone fields from worktree's LocalSnapshot ( #2497 )
...
This fixes performance problems that @nathansobo and I have seen in some
cases, when a large number of files changed on disk. A lot of time was
being spent in `worktree::LocalSnapshot::clone`. I think this may have
been because of needing to clone the `removed_entry_ids` map. This
structure is only really used when *mutating* the `LocalSnapshot` in the
background scanner, so I moved it off of the snapshots.
2023-05-19 16:20:19 -07:00
Mikayla Maki
06a89d9104
Add guards to other pane index removals ( #2496 )
...
These should be impossible for users to reach, but why leave it to
chance?
Release Notes:
* N/A
2023-05-19 15:21:00 -07:00
Max Brunsfeld
7ae642b9b8
Avoid storing removed_entry_ids on the LocalSnapshot
2023-05-19 15:16:04 -07:00
Mikayla Maki
c193b0b8fc
Add guards to other pane index removals
2023-05-19 15:10:44 -07:00
Max Brunsfeld
32c7157906
🎨 Make worktree repositories more consistent
2023-05-19 15:04:37 -07:00
Max Brunsfeld
6359333749
Don't store next_entry_id on worktree's local snapshot
2023-05-19 13:49:24 -07:00
Kirill Bulatov
7d1833b759
When the file is deleted via project panel, close it in editors ( #2490 )
...
Deals with https://github.com/zed-industries/community/issues/179 by
sending a message about it, to asynchronously apply on all workspaces.
Release Notes:
* Fixes a bug when files, deleted in the project panel were left open in
the editor
2023-05-19 21:51:37 +03:00
Max Brunsfeld
844b8d9e1e
Remove unnescessary double lookup in repo for ( #2492 )
...
Release Notes:
* Optimize repository queries (preview only)
2023-05-19 11:47:05 -07:00
Kirill Bulatov
2c8fffc4f8
Use better name for the method that closes deleted buffers
...
co-authored-by: Max <max@zed.dev>
2023-05-19 21:47:00 +03:00
Max Brunsfeld
01a3e49946
Optimize retrieving repos for entries when rendering the project panel ( #2493 )
...
This fixes slowness in rendering the project panel due to retrieving the
repository for a given entry.
Release Notes:
* Fixed a lag that would occur when lots of files changed on disk while
the project panel was open (preview only).
2023-05-19 11:46:32 -07:00
Mikayla Maki
9f157bdb67
Remove unescessary methods
2023-05-19 11:30:10 -07:00
Max Brunsfeld
729a93db6b
Optimize retrieving repos for entries when rendering the project panel
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2023-05-19 11:29:02 -07:00
Mikayla Maki
6792788216
Remove unnescessary double lookup
2023-05-19 11:08:58 -07:00
Max Brunsfeld
d480555ec9
Fix performance problems in reporting changed FS paths to language servers ( #2491 )
...
Fixes
https://linear.app/zed-industries/issue/Z-1611/main-thread-hangs-while-sending-filesystem-change-events-to-lsp
Release Notes:
* Fixed a lag that would sometime occur when large numbers of files
changed on disk, due to reporting the changed files to language servers.
2023-05-19 09:42:55 -07:00
Max Brunsfeld
847d1e73a3
Replace remaining usages of glob crate with globset
2023-05-19 09:36:46 -07:00
Max Brunsfeld
459cc9c959
Optimize matching of multiple file-watch globs using the globset crate
2023-05-19 09:13:34 -07:00
Kirill Bulatov
583b15badc
When the file is deleted via project panel, close it in editors
2023-05-19 18:52:30 +03:00
Kirill Bulatov
3984cc6d39
Properly handle WorktreeId
2023-05-19 12:37:36 +03:00
Max Brunsfeld
4bda5c4d69
Optimize LSP watched file reporting in 2 simple ways
...
* Convert globs to relative paths in advance. This avoids needing to convert
every changed path to an absolute path before performing glob matching.
* Avoid duplicate reporting for language servers with multiple worktrees.
2023-05-18 17:08:51 -07:00
Max Brunsfeld
34b0d6200f
collab 0.12.4
2023-05-18 14:58:57 -07:00
Max Brunsfeld
ffe35d171c
Avoid unnecessary code action requests when applying leader updates t… ( #2489 )
...
We noticed a huge amount of code actions requests being issued by
followers when applying leader updates. It was caused by a call to
`MultiBuffer::remove_excerpts` with an empty list of excerpts to remove.
This PR fixes that by avoiding emitting spurious events when multibuffer
excerpt manipulation methods are called with empty lists.
2023-05-18 14:52:21 -07:00
Max Brunsfeld
58f704abcb
Avoid unnecessary code action requests when applying leader updates to an editor
2023-05-18 14:46:23 -07:00
Mikayla Maki
87e206c451
Fixed an imprecise join in rejoin room ( #2488 )
...
This fixed a pre-existing bug in rejoin room that got expanded to
stalling collab with the new git status feature.
Release Notes:
* N/A
2023-05-18 14:42:59 -07:00
Mikayla Maki
99fcf23798
fmt
2023-05-18 14:31:08 -07:00
Mikayla Maki
95a7d69bce
Fixed an imprecise join in rejoin room
2023-05-18 14:29:18 -07:00
Max Brunsfeld
2883d6f1ef
Improve collab logging ( #2487 )
...
This adds some logging to the collab server, to help us identify the
source of the collaboration latency we're seeing in the 0.87 preview
version of zed.
2023-05-18 14:17:17 -07:00
Max Brunsfeld
2a11a89827
collab 0.12.3
2023-05-18 12:27:08 -07:00
Joseph Lyons
55b241a4f6
collab 0.12.2
2023-05-18 12:27:01 -07:00
Max Brunsfeld
c71b59b248
Log how long it takes to handle each RPC message
2023-05-18 12:24:07 -07:00
Kirill Bulatov
923be1892d
Maintain recently opened files history ( #2467 )
...
Part of https://github.com/zed-industries/community/issues/351 and
https://github.com/zed-industries/community/issues/1125
Adds navigation history to the search file dialogue:
The history is only shown on empty query and gets replaced by the query
results after an input.
Currently, history gets lost between the project restarts.
Release Notes:
* Added a recently opened file list to search file dialogue
2023-05-18 22:06:25 +03:00
Kirill Bulatov
2ec994dfcd
Add a unit test
2023-05-18 21:53:42 +03:00
Kirill Bulatov
201d513c50
Show navigation history in the file finder modal
...
co-authored-by: Max <max@zed.dev>
2023-05-18 21:50:38 +03:00
Kirill Bulatov
711d2c6fe7
Maintain recently opened files history
2023-05-18 21:50:38 +03:00
Julia
bd29812391
Avoid panic in get_injections ( #2486 )
2023-05-18 13:35:10 -04:00
Julia
5ab1ae1521
Avoid panic in get_injections
2023-05-18 12:23:49 -04:00
Max Brunsfeld
83f8981308
Define empty theme for tests regardless of cargo features ( #2485 )
...
This fixes some errors that were happening when running a single crate's
tests, if the test did not enable the `test-support` feature in the
`theme` crate.
2023-05-18 09:14:46 -07:00
Max Brunsfeld
71ad7e7612
Define empty theme for tests regardless of cargo features
...
Co-authored-by: Kirill <kirill@zed.dev>
2023-05-18 09:01:38 -07:00
Kirill Bulatov
263afc75a8
Merge pull request #2484 from zed-industries/kb/unite-dmg-build
...
Unite dmg build jobs
Follow-up of https://github.com/zed-industries/zed/pull/2472 actually doing the proper thing: allow running dmg builds on PRs if `run-build-dmg` label is attached.
2023-05-18 14:39:41 +03:00
Kirill Bulatov
5ab4eab369
Unite dmg build jobs
2023-05-18 13:49:55 +03:00
Max Brunsfeld
5c437e2098
Fix crashes when running zed bundled
2023-05-17 16:53:48 -07:00
Max Brunsfeld
a9b107f155
Fix release-mode stub for watch_themes
2023-05-17 16:36:06 -07:00
Max Brunsfeld
d23fc6f135
Merge pull request #2448 from zed-industries/setting-store
...
Separate the settings struct into a set of dynamically-registered setting types
2023-05-17 16:19:09 -07:00
