zed/crates/gpui/src
Marshall Bowers 1cc7f66f86
Fix documentation labels obscuring other content in completion menu (#4167)
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.

#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87">

#### After

<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235">

Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:

<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a">

I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:

<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6">

Release Notes:

- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419](https://github.com/zed-industries/community/issues/2419)).
2024-01-19 14:01:09 -05:00
..
app Update tenses of doc comment summary lines (#4161) 2024-01-19 11:18:50 -05:00
elements Fix right click handler for tabs 2024-01-18 12:10:38 -07:00
keymap Merge branch 'main' into fix-typos 2024-01-17 14:36:03 -08:00
platform Fix a double borrow error in window.open 2024-01-18 20:55:50 -07:00
text_system Update method name and partially document platform crate 2024-01-17 14:07:57 -08:00
action.rs Add remaining tests 2024-01-10 19:39:43 -08:00
app.rs Update tenses of doc comment summary lines (#4161) 2024-01-19 11:18:50 -05:00
arena.rs Ensure ArenaRef pointers are aligned to their contained type 2024-01-10 10:36:08 -08:00
assets.rs Remove 2 suffix from gpui 2024-01-03 12:59:39 -08:00
color.rs Remove some comments 2024-01-12 20:10:40 -08:00
element.rs Pull out fluent builder helpers into re-usable trait 2024-01-18 15:31:31 -08:00
executor.rs Update tenses of doc comment summary lines (#4161) 2024-01-19 11:18:50 -05:00
geometry.rs Start on caching views 2024-01-08 19:07:20 +01:00
gpui.rs Fix canary 2024-01-17 17:03:17 -08:00
image_cache.rs gpui: Add SharedUrl type (#3975) 2024-01-09 10:55:49 -05:00
input.rs Clean up references in doc comments (#3983) 2024-01-09 14:48:48 -05:00
interactive.rs Fix draw helper, add helper traits for selecting groupings of input events 2024-01-16 22:19:55 -08:00
key_dispatch.rs Preserve tooltips requested by cached views 2024-01-15 19:19:27 +01:00
platform.rs gpui: Bring back family and style names in font name suggestions 2024-01-18 12:10:17 +01:00
prelude.rs Pull out fluent builder helpers into re-usable trait 2024-01-18 15:31:31 -08:00
scene.rs Update method name and partially document platform crate 2024-01-17 14:07:57 -08:00
shared_string.rs Remove 2 suffix from gpui 2024-01-03 12:59:39 -08:00
shared_url.rs gpui: Add SharedUrl type (#3975) 2024-01-09 10:55:49 -05:00
style.rs Revert "Store a z-index id per-layer (#4128)" 2024-01-18 13:28:23 -07:00
styled.rs Fix documentation labels obscuring other content in completion menu (#4167) 2024-01-19 14:01:09 -05:00
subscription.rs Clean up references in doc comments (#3983) 2024-01-09 14:48:48 -05:00
svg_renderer.rs Remove 2 suffix from gpui 2024-01-03 12:59:39 -08:00
taffy.rs Revert "Use taffy to retrieve the parent for a given layout node" 2024-01-16 10:44:24 -05:00
test.rs Resolve more todos 2024-01-09 15:08:05 -08:00
text_system.rs gpui: Bring back family and style names in font name suggestions 2024-01-18 12:10:17 +01:00
util.rs Pull out fluent builder helpers into re-usable trait 2024-01-18 15:31:31 -08:00
view.rs Update tenses of doc comment summary lines (#4161) 2024-01-19 11:18:50 -05:00
window.rs Update tenses of doc comment summary lines (#4161) 2024-01-19 11:18:50 -05:00