Brian Hicks
544eca1f84
bump to 24.8.1
2023-09-07 10:04:15 -05:00
Brian Hicks
d1809ecd60
Merge pull request #1507 from NoRedInk/fix-character-headshot-zoom-in-safari
...
fix character headshot zoom in safari
2023-09-07 10:03:16 -05:00
Arthur Bernardi Jordão
fa1a88c520
Merge pull request #1506 from NoRedInk/bump-24.8.0
...
🏷️ Bump for version `24.8.0` Improve Message example, Implement new carousel types
2023-09-06 19:19:15 -03:00
Brian Hicks
febe1a78b3
🎨
2023-09-06 17:02:33 -05:00
Brian Hicks
51450bf9b9
add entry in changelog
2023-09-06 17:01:08 -05:00
Brian Hicks
c70c540350
fix scaling on Sal's facing-right headshot
2023-09-06 16:56:16 -05:00
Brian Hicks
01954f0fe2
fix scaling on Red's facing-right headshot
2023-09-06 16:55:49 -05:00
Brian Hicks
56cbb12192
fix scaling on Lindy's facing-right headshot
2023-09-06 16:55:41 -05:00
Arthur Bernardi Jordão
6921c7a840
Bump to 24.8.0
2023-09-06 17:57:46 -03:00
Arthur Bernardi Jordão
aacbe93dc8
Merge pull request #1488 from NoRedInk/wr-244-add-new-nriuicarousel-components
...
Implement new carousel types
2023-09-06 17:43:31 -03:00
Tessa
1724e1b3cd
Merge pull request #1505 from NoRedInk/bat/improve-message-example
...
Improve Message example
2023-09-06 13:47:12 -06:00
Tessa Kelly
8768978c6b
Ensure that the Role is configurable
2023-09-06 13:42:36 -06:00
Tessa Kelly
68e77f47b7
Use landmark region helper
2023-09-06 13:31:47 -06:00
Juan Edi
23a256c94f
properly set up focus rings in examples
2023-09-06 15:54:14 -03:00
Juan Edi
1adf7a0774
add support for custom tab attributes
...
we anticipate this being needed to properly configure focus rings with
rounded dots
2023-09-06 15:50:28 -03:00
Juan Edi
ce39fdd949
more renames for consistency
2023-09-06 15:45:46 -03:00
Juan Edi
f70f11ea88
keep config field names consistent with TabsInternal
2023-09-06 15:42:45 -03:00
Juan Edi
ba45b75803
more consistent names for returned components
2023-09-06 15:41:41 -03:00
Juan Edi
75acf138c5
merge announceAndSelect + focusAndSelect into a single message handler
2023-09-06 15:00:06 -03:00
Juan Edi
03832d7ec7
🎨 avoid singleton pipeline
2023-09-06 14:42:59 -03:00
Juan Edi
35729abf3a
rename roleToString -> roleAttribute
2023-09-06 14:42:45 -03:00
Arthur Bernardi Jordão
1dad122bfe
Add containerAttributes to docs where it's missing
2023-09-06 10:52:03 -03:00
Arthur Bernardi Jordão
6028730ff7
Make roleToString return an attribute instead of a string
2023-09-06 10:44:20 -03:00
Arthur Bernardi Jordão
716d02b424
Remove unneeded attributes from slide
2023-09-06 10:33:17 -03:00
Arthur Bernardi Jordão
e95c10d3e2
Improve docs in Role
2023-09-06 10:17:45 -03:00
Arthur Bernardi Jordão
5c26535f0f
Update src/Nri/Ui/Carousel/V2.elm
...
Co-authored-by: Tessa <tesk9@users.noreply.github.com>
2023-09-06 10:08:56 -03:00
Arthur Bernardi Jordão
43a7d4be26
Fix test when slides list is empty
2023-09-06 10:04:29 -03:00
Tessa Kelly
7e8547b468
Fix missing announcements
2023-09-05 17:43:08 -06:00
Tessa Kelly
a423ac7028
Add package example
2023-09-05 17:16:41 -06:00
Tessa Kelly
348f79538e
Adds viewWithTabControls example
2023-09-05 16:58:46 -06:00
Tessa Kelly
fe99782f4c
Adds persistent example showing the viewWithPreviousAndNextControls carousel
2023-09-05 16:43:29 -06:00
Tessa Kelly
ce917b8908
Adds failing tests -- currently passing no slides leads to a divide by zero error
2023-09-05 16:22:36 -06:00
Tessa Kelly
9eda9536f5
Use Aria helpers for tests
2023-09-05 15:56:53 -06:00
Tessa Kelly
6f708449ec
Adds examples for large and banner too
2023-09-05 14:08:34 -06:00
Tessa Kelly
b5adcee375
Adds tiny examples
2023-09-05 14:02:16 -06:00
Arthur Bernardi Jordão
7bef7dde8c
Remove unneeded imports
2023-09-05 16:59:44 -03:00
Arthur Bernardi Jordão
c002f87518
Fix code example
2023-09-05 16:58:33 -03:00
Juan Edi
78cfa998de
remove style customizations from settings
...
they were not working, the code snippet was not valid code and we didn't
even care about including those as settings in the Tabs demo so I
figured we are not losing much by removing them.
2023-09-05 15:59:44 -03:00
Juan Edi
6acff90c01
fix code examples (wip)
2023-09-05 15:47:12 -03:00
Juan Edi
5664300d2d
make icons in code snippets match the ones in real demo
2023-09-05 15:33:24 -03:00
Juan Edi
2591b0a84b
slightly more realistic preview
2023-09-05 15:23:58 -03:00
Juan Edi
b338efc378
elm-format
2023-09-05 15:09:47 -03:00
Juan Edi
86a82e3e26
make viewWithPreviousAndNextControls the default in the demo
2023-09-05 15:09:28 -03:00
Juan Edi
d039512615
🎨 don't use extensible record for viewWithTabControls
...
mostly for consistency with the other use cases. changing it helped me
realize we were passing an extra attribute in a test so that's a good
sign I guess!
2023-09-05 15:09:28 -03:00
Juan Edi
76edaed8b8
🎨 move helpers down
2023-09-05 15:09:28 -03:00
Juan Edi
94b9e0604c
remove unnecesary aria-atomic attribute
...
not needed now that we are not announcing content changes by means of aria-live
2023-09-05 15:09:28 -03:00
Juan Edi
79fced51d0
🎨 tidy up a bit
...
- hoping to make things more readable by replacing a bunch of booleans with a bunch of custom values.
- rely on built in attribute rather than custom id to identify the root of the carousel
2023-09-05 15:09:28 -03:00
Juan Edi
2f2c527e86
more consistent carousel names in tests
2023-09-05 15:09:28 -03:00
Juan Edi
6366b1e8b8
fix ensureSlideIsVisible selectors
...
handing the list of selectors to ensureViewHas directly performs
multiple checks, rather than checking that there is a single element
satisfying all conditions.
2023-09-05 15:09:28 -03:00
Arthur Bernardi Jordão
2b263e7897
Add missing property on docs
2023-09-05 14:33:57 -03:00
