Commit Graph

3036 Commits

Author SHA1 Message Date
Brian Hicks
605bc17601 don't shrink icons in messages in narrow parents 2020-09-10 08:30:27 -05:00
Tessa
bf89674dea
Merge pull request #596 from NoRedInk/raven/new-modal-version
Bump for focus trap and modal
2020-09-09 14:12:09 -07:00
Tessa Kelly
6ee8333d4b Bump 2020-09-09 14:07:34 -07:00
Tessa
1e484236a7
Merge pull request #597 from NoRedInk/raven/focus-trap-proof-of-concept
Changes to FocusTrap API
2020-09-08 16:36:38 -07:00
Tessa Kelly
960ebf0b32 Adds missing type annotations: 2020-09-08 16:24:09 -07:00
Tessa Kelly
182129ffac 💀 remove resolved comment 2020-09-08 16:20:47 -07:00
Tessa Kelly
82e4c6e63b Fix tests 2020-09-08 16:13:30 -07:00
Tessa Kelly
686fcf0846 Merge remote-tracking branch 'origin/master' into raven/focus-trap-proof-of-concept 2020-09-08 15:41:38 -07:00
Tessa Kelly
a2cc2b7ba3 Fix typo 2020-09-08 15:41:23 -07:00
Juan Edi
a73de4be5f The modal requires a focus trap now 2020-09-08 15:36:13 -03:00
Juan Edi
6370b83d99 Use a type alias instead of a custom type for FocusTrap
I don't think we are getting any value out of the custom type since we have a
single case and are exposing the constructor anway.
2020-09-08 15:29:21 -03:00
Juan Edi
365d625cca don't case now that we use a single constructor 2020-09-08 15:26:06 -03:00
Juan Edi
d4625ae274 Add some docs to the FocusTrap module 2020-09-08 15:23:50 -03:00
Juan Edi
41ea557191 Simplify example
Now that the single/multi-focusable element cases were consolidates it seems
less necessary to show two types of modals.
2020-09-08 15:17:43 -03:00
Juan Edi
a81fb3617a Update docs to use the new API in the example 2020-09-08 15:06:13 -03:00
Juan Edi
ad1bfb6672 Remove old FocusTrap helpers 2020-09-08 14:49:51 -03:00
Juan Edi
0854f2bc60
Merge pull request #595 from NoRedInk/tessa/fix-checkbox-background
Tessa/fix checkbox background
2020-09-08 14:32:07 -03:00
Tessa Kelly
53f5d77ee2 Remove the cases 2020-09-04 17:23:41 -07:00
Tessa Kelly
ce5201e900 fix 🐛s caused by duplicative id 2020-09-04 17:15:54 -07:00
Tessa Kelly
1fb208396a Pull the 9 check higher 2020-09-04 17:04:57 -07:00
Tessa Kelly
4db7df2a48 Implement one element focus trap 2020-09-04 17:01:49 -07:00
Tessa Kelly
6ddc4499fa Make the closeButton an attribute 2020-09-04 16:59:02 -07:00
Tessa Kelly
44eee7f15a Remove closeModal attribute hole 2020-09-04 16:49:59 -07:00
Tessa Kelly
a193082fa9 🎨 remove unnecessary argument hole 2020-09-04 16:49:07 -07:00
Tessa Kelly
12a804adb3 Audit current behavior 2020-09-04 16:47:31 -07:00
Tessa Kelly
fb9810354a Fix bad string value 2020-09-04 16:30:15 -07:00
Tessa Kelly
8729d8bb4f Change the racheting accessibility tooling to expect null violations 2020-09-04 16:27:56 -07:00
Tessa Kelly
000c97b92d Make the radio button filter ids unique 2020-09-04 16:27:56 -07:00
Tessa Kelly
70c221714a Fix premium checkboxes (identifiers with special chars break the filter reference) 2020-09-04 16:27:56 -07:00
Tessa Kelly
18bc07aaea Make the filter ids unique 2020-09-04 16:27:56 -07:00
Juan Edi
ba9929ac3a WIIIIIIIPP implement one of the use cases to use new FocusTrap API 2020-09-04 19:36:22 -03:00
Tessa
a3d2ab6e4b
Merge pull request #593 from NoRedInk/raven/modal-improvements
Raven/modal improvements
2020-09-04 14:29:33 -07:00
Tessa Kelly
44975187d6 Apparently nesting Control records causes deque to fail. de-nest 2020-09-04 08:52:47 -07:00
Tessa Kelly
7bb32b0787 Fix mistake in the focus handling 2020-09-02 16:57:32 -07:00
Tessa Kelly
fd69c6c8a9 Pull out focus trap helper 2020-09-02 16:56:10 -07:00
Tessa Kelly
9802c33d8f 💀 remove dead code 2020-09-02 16:42:22 -07:00
Tessa Kelly
7aa2d65e96 Change closeButton to accept any msg type 2020-09-02 16:37:00 -07:00
Tessa Kelly
708f291081 The most major of API changes:
allows the user to set the id of their focusable element, and prevents autofocusing from overrding the other element id options and vice versa
2020-09-02 16:32:17 -07:00
Tessa Kelly
72e60d9367 Fix missing attributes in example code 2020-09-02 14:46:12 -07:00
Tessa Kelly
c09053b69c Add a helper for the continue button 2020-09-02 14:35:35 -07:00
Tessa Kelly
1eda22c565 Add a helper for the close button 2020-09-02 14:32:57 -07:00
Tessa Kelly
1c184d8179 add more changes to docs 2020-09-02 14:30:52 -07:00
Tessa Kelly
94f841c5f8 Adds keyboard support notes 2020-09-02 14:19:41 -07:00
Tessa Kelly
cb2b548064 Put all the attributes in a list in the controls 2020-09-02 14:15:42 -07:00
Tessa Kelly
9972b9a46b ALlow a little more customization inthe css 2020-09-02 14:09:52 -07:00
Tessa Kelly
e249033658 Adds showTitle helper 2020-09-02 14:04:06 -07:00
Tessa Kelly
87f2064938 Make the content customizable 2020-09-02 13:59:02 -07:00
Tessa Kelly
9ad216b994 Move the theme into the settings 2020-09-02 13:53:40 -07:00
Tessa Kelly
9743a69d32 Use Debug.Control 2020-09-02 13:44:39 -07:00
Tessa Kelly
7141bc1526 Add custom attribute to modal example 2020-09-02 13:37:57 -07:00