TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-22 10:21:36 +03:00
Code Issues Projects Releases Wiki Activity
14,199 Commits 250 Branches 1,686 Tags 392 MiB
715da3e01f
Commit Graph

14199 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Naz
715da3e01f Added JSDocs to bootstrap's init method 
refs https://linear.app/tryghost/issue/CORE-103/decouple-internal-frontend-code-from-url-module

- Little type check and docs never hurt nobody
 2021-10-14 05:55:49 +13:00
Naz
fead0e3dcf Decoupled frontend rss service from the url service 
refs https://linear.app/tryghost/issue/CORE-103/decouple-internal-frontend-code-from-url-module

- We need to decouple all frontend services from URL service as much as possible. "bootstrap" module is now a central point to substitute (proxy really) function previously done by the URL service and this move changes direct usage of URL service to "bootstraps" internal proxy function
 2021-10-14 05:55:49 +13:00
Naz
add30f3d5b Decoupled frontend routing from url service 
refs https://linear.app/tryghost/issue/CORE-103/decouple-internal-frontend-code-from-url-module

- By becoming a parameter in the routing bootstrap process URL is Service no longer a "require" inside the frontend controllers but rather becomes a part of the "internal API" of the bootstrapper. This is not the end form of it, rather a step closer to decouplint routing from the URL serivce.
- The bootstrap module needs a facelift to have cleaner distinction between init/start methods. This is left for another time
 2021-10-14 05:55:49 +13:00
Naz
0a9837ebcf Made bootstrap module's API slightly more readable 
refs https://linear.app/tryghost/issue/CORE-103/decouple-internal-frontend-code-from-url-module

- It was hard to see straight away what methods the module exposes
 2021-10-14 05:55:49 +13:00
Thibaut Patel
dc4694d8d3 ✨ Added a gscan check to prevent the declaration of unused custom theme setting 
ref 136e02adfd
ref https://github.com/TryGhost/Team/issues/1105

- Custom theme settings are defined in package.json, this rule triggers an error if a defined rule doesn't appear in any handlebars templates.
 2021-10-13 18:30:58 +02:00
Kevin Ansfield
7cb93be60b Added boolean as allowed custom theme setting type 
refs https://github.com/TryGhost/Team/issues/1106

- updated schema validation to add `'boolean'` as an allowed `type` value
- added `format()` and `parse()` methods to `CustomThemeSetting` model to match `Settings` model behaviour for boolean-type settings
 2021-10-13 17:25:32 +01:00
Fabien O'Carroll
f3dcf578a9 Prefixed migration with 01 
refs https://github.com/TryGhost/Ghost/commit/b48c16c1

This was missed in the initial commit. We require numbers so that we can
easily see the order in which migrations will run.
 2021-10-13 17:37:39 +02:00
Fabien O'Carroll
b93e7d7f7c Added offer_redemptions table to database 
refs https://github.com/TryGhost/Team/issues/1132

This will be used to store Offer Redemptions, which will be used to list
the Offers which a Member has redeemed, as well as the number of times
an Offer has been redeemed.
 2021-10-13 17:37:39 +02:00
Daniel Lockyer
64f2aa2af5
Updated @tryghost/metrics dependency 
no issue

- this adds in some missing dependencies of `@tryghost/metrics`
 2021-10-13 14:48:05 +02:00
Sam Lord
4d043ba3e1 Added ghost-version to metrics 
no issue
One of the most important parts of tracking metrics is determining how they are changed by our code changes, so including the current Ghost Version in metrics which we ship is a great way to track improvements
 2021-10-13 11:29:14 +01:00
Fabien O'Carroll
7722780539 Restricted archived Offers from being used for Checkout 
refs https://github.com/TryGhost/Team/issues/1133

This updates the MembersAPI Checkout Session handling to 403 if an
attempt is made to create a Checkout Session using an archived Offer.
 2021-10-13 11:23:05 +02:00
Fabien O'Carroll
a441825c3f Passed MembersAPI the OffersAPI over OfferRepository 
no-issue

The MembersAPI using the OfferRepository coupled it to the internals of
the Offers Module - instead we pass the "external" API - so that we can
change the internals, and not have to update the MembersAPI's usage.
 2021-10-13 11:17:32 +02:00
Hannah Wolfe
00bcaeeb8c
Fixed duplicate message due to bad merge 
- sadly git is not always detecting conflicts properly
 2021-10-13 09:17:01 +01:00
PJ
4943c97ecb
Replace i18n with tpl in api/v2/utils/validators/input/users.js (#13589) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:08:57 +01:00
PJ
d362d8c8bd
Replace i18n with tpl in core/server/api/v3/invites.js (#13587) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:07:57 +01:00
PJ
09a9a9844f
Replace i18n with tpl in api/v3/pages-public.js (#13586) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:07:42 +01:00
PJ
f8033596c0
Replace i18n with tpl in api/v3/pages.js (#13585) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:06:53 +01:00
PJ
6e14047a2a
Replace i18n with tpl in core/server/api/v3/memberSigninUrls.js (#13584) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:05:38 +01:00
Naz
dbdf7160bf Simplified DynamicRedirectManager's constructor 
refs https://linear.app/tryghost/issue/CORE-84/have-a-look-at-the-eggs-redirects-refactor-branch

- This simplification allows to make the test for dependent services a lot more readable without a need to stub urlUtils
 2021-10-13 10:04:55 +02:00
PJ
57ce743d98
Replace i18n with tpl in output/authentication.js (#13581) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 09:00:19 +01:00
Tomás Castillo
2c659ea447
Replaced i18n.t w/ tpl helper in v3/posts.js file (#13580) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:58:34 +01:00
IncredibleZuess
dd5a96d37c
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/setup.js (#13579) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:54:22 +01:00
IncredibleZuess
b2e4145bd9
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/settings.js (#13578) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:53:57 +01:00
IncredibleZuess
0cbc813f28
Replaced i18n.t w/ tpl in core/server/api/v2/utils/validators/input/passwordreset.js (#13577) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package
 2021-10-13 08:52:39 +01:00
IncredibleZuess
e0c0022cb7
Replaced i18n.t w/ tpl in core/server/api/v2/utils/validators/input/invites.js (#13576) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:52:19 +01:00
IncredibleZuess
6d4b682b95
Replaced i18n.t w/ tpl in api/v2/utils/validators/input/images.js (#13575) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-13 08:50:15 +01:00
Levi Richardson
6421f60852
Switch i18n.t to tpl in users.js (#13574) 
refs: #13380

- i18n is deprecated and is being replaced with tpl
 2021-10-13 08:44:04 +01:00
Fabien O'Carroll
b1914758b8 Added support for filter Offers by status 
refs https://github.com/TryGhost/Team/issues/1131

This will allow Ghost Admin to display separate lists of active and
archived Offers! We must pass the options through so that the
OffersService is able to handle the filter passed in the request.
 2021-10-12 18:39:25 +02:00
Thibaut Patel
836b5b4a0e ✨ Added a gscan check to make sure the match helper on custom settings of type select is used against specified options 
refs 056928f7b9
refs https://github.com/TryGhost/Team/issues/1105
 2021-10-12 18:35:02 +02:00
Fabien O'Carroll
dc3dad4524 Added initial support for Offer status 
refs https://github.com/TryGhost/Team/issues/1131

This updates the Offers Service to include the `status` of an Offer,
which will be either 'active' or 'archived'. It also allows setting the
`status` of an Offer to one of these two values when adding & editing
Offers.
 2021-10-12 17:15:26 +02:00
Sam Lord
a535cfdf16 Added metric-shipping to monitor boot-time 
no issue
Boot-time metrics are really valuable for understanding how releases affect the performance of Ghost. The new @tryghost/metrics package lets us ship these metrics to different sources using the same configuration framework as @tryghost/logging introduced.
 2021-10-12 15:01:50 +01:00
ItsMeSatan
af7fe99127
Replaced i18n.t with tpl in memberSigninUrls.js and oembed.js (#13564) 
refs: #13380

- i18n is deprecated and is being replaced with tpl
 2021-10-12 14:47:53 +01:00
PakkuDon
0fe62e3aee
Replaced i18n.t with tpl in core/server/services/bulk-email and core/server/services/permissions (#13562) 
refs: #13380

- i18n is deprecated and is being replaced with tpl
 2021-10-12 14:46:35 +01:00
Fabien 'egg' O'Carroll
b48c16c118
Added active column to offers table (#13592) 
refs https://github.com/TryGhost/Team/issues/1131

This will be used as a flag to determine whether or not an Offer is
archived or active.
 2021-10-12 15:20:45 +02:00
Fabien O'Carroll
1bb9c3a9ac Invalidated site cache when adding & editing Offers 
no-issue

Because adding and editing Offers can update the redirects for Ghost, we
should ensure that any site cache is cleared so as to not conflict with
Offer redirects.
 2021-10-12 15:20:31 +02:00
Fabien O'Carroll
37deda3587 Fixed handling of labs flag for Offers 
no-issue

Because we only called `init` if the labs flag is enabled, when starting
up a site without the flag enabled - the listener for adding redirects
wasn't active. So new Offers would not have their redirects setup.
 2021-10-12 15:20:31 +02:00
Thibaut Patel
f8b19f286a ✨ Added gscan checks for custom themes settings 
refs https://github.com/TryGhost/Team/issues/1105

- checks package.json for the config.custom object shape
- checks for unknown custom theme settings
 2021-10-12 14:52:50 +02:00
Marco F
ed6045d82c
Replaced i18n.t() with tpl() in v2/utils/validators/input/invitations.js (#13560) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 09:12:04 +01:00
PJ
9ccf590ddc
Replaced i18n with tpl in GhostMailer.js (#13555) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 09:10:50 +01:00
Indrakant Dana
e2aeca56e9
Replaced i18n.t w/ tpl in v3/utils/serializers (#13552) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 08:39:15 +01:00
Indrakant Dana
8029d1ce6a
Replaced i18n.t w/ tpl in v3/settings.js (#13551) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-12 08:36:11 +01:00
Shadman Ahmed Khan
c1789a3a03
Replaced i18n with tpl in core/server/api/v3 (#13548) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.

Co-authored-by: Shadman Khan <shadmankhan@ShadmanMac.local>
 2021-10-12 08:33:33 +01:00
Jack Wu
65d5b8d671
replaced i18n with tpl in mega of core services (#13546) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.

Co-authored-by: jack.wu <jack.wu@wemoscooter.com>
 2021-10-12 08:29:34 +01:00
Renovate Bot
c5459db52e
Update dependency keypair to v1.0.4 2021-10-11 21:11:01 +00:00
Indrakant Dana
4f0999b6db
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/setup.js (#13534) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 21:28:01 +01:00
Indrakant Dana
91dd9eae4e
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/webhooks.js (#13536) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 20:54:06 +01:00
Indrakant Dana
1f2ce40fed
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/users.js (#13535) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 20:28:22 +01:00
Indrakant Dana
7c14ff903b
Replaced i18n.t w/ tpl in api/v3/utils/validators/input/settings.js (#13533) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:57:40 +01:00
Indrakant Dana
cef32dd1fe
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/passwordreset.js (#13532) 
refs: TryGhost#13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:56:23 +01:00
Indrakant Dana
a73459d904
Replaced i18n.t w/ tpl in core/server/api/v3/utils/validators/input/invitations.js (#13531) 
refs: #13380

- The i18n package is deprecated. It is being replaced with the tpl package.
 2021-10-11 19:45:29 +01:00