Simon Backx
450e01d1c0
Added placeholder basic subscription details to email template
...
refs https://github.com/TryGhost/Team/issues/2736
The renewal date is still missing, and style and desin is only a placeholder.
2023-03-15 17:12:56 +01:00
Rishabh Garg
d98ffcff28
Updated last mentions report timestamp to use number
...
Co-authored-by: Simon Backx <simon@ghost.org>
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
266c70a8fd
Added mentions-email-report service
...
This wires up the @tryghost/mentions-email-report service
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
7300130986
Added templates for mention report email
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
3cf3f633aa
Refactored staff-service
...
This moves the shared data between all templates into a method so that
it's calculated in a single place, as well as exposing separate render
methods for HTML and Text. We've also added some new custom helpers
for use in the handlebars templates
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
04efb6c177
Exposed MentionsAPI from mentions service
...
This is necessary so that we can use it as the IMentionReportGenerator
dependency for the mentions-email-report packages
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
018e2654c5
Added getAll method to BookshelfMentionRepository
...
This is necessary to support the getMentionReport method in MentionsAPI
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
0262083bb0
Added getMentionReport method to MentionsAPI
...
This will be used by the mentions-report-email package to generate the
data used for the report emails
2023-03-15 21:22:13 +05:30
Fabien "egg" O'Carroll
c56b819748
Added @tryghost/mentions-email-report package
...
This package contains the business logic for the sending of mention
report emails, it could eventually be included in the webmentions
package I think, but has been kept separate for now in favour of
smaller packages.
2023-03-15 21:22:13 +05:30
Simon Backx
b8b0d1538e
Added very basic subscription details in preview labs
...
refs https://github.com/TryGhost/Team/issues/2738
2023-03-15 15:07:26 +01:00
Kevin Ansfield
e2eba623dc
Added complex object URL transform support for lexical card datasets
...
refs https://github.com/TryGhost/Team/issues/2722
- bumped `@tryghost/url-utils` with additional lexical card dataset support
- see 2154b26dd2
2023-03-15 14:00:23 +00:00
Daniel Lockyer
7409f9524a
Added link to GitHub commit if prerelease version
...
refs https://ghost.slack.com/archives/C025584CA/p1678886661494989?thread_ts=1678886465.260379&cid=C025584CA
- if we're running a prerelease, our usual format is `<major>.<minor>.<patch>-pre.<commit hash>.<build>`
- if you wanna see what commit it was built on, you have to copy and
paste the hash into a GitHub URL
- this provides an easier route to the commit by detecting if the
version is our special format and links direct to GitHub if so
2023-03-15 14:47:45 +01:00
Simon Backx
a5ac2bd470
Added showSubscriptionDetails toggle in admin
...
refs https://github.com/TryGhost/Team/issues/2737
2023-03-15 14:44:37 +01:00
Simon Backx
80043f2699
Fixed snapshot tests in batch sending
2023-03-15 14:11:05 +01:00
Simon Backx
6e5ddc6a9a
Fixed email preview snapshots
2023-03-15 14:03:24 +01:00
Sanne de Vries
c4bbaf7c7b
Updated spacing in emails without post title
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 13:33:10 +01:00
Sanne de Vries
e0c3573079
Updated email template snapshot resulting in test failure
...
No ref
2023-03-15 12:45:54 +01:00
Sanne de Vries
4284292736
Updated email spacing for when post title is hidden
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 12:27:03 +01:00
Sanne de Vries
f9cb4bcaaf
Updated comments link UI in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-15 12:10:10 +01:00
Simon Backx
da2e56916e
Added show_subscription_details column to newsletter table ( #16403 )
...
fixes https://github.com/TryGhost/Team/issues/2708
Adds `show_subscription_details` column to newsletter table. Disabled by
default.
2023-03-15 11:53:45 +01:00
Fabien 'egg' O'Carroll
bdaddd1a64
Added setting to store last mention report email date ( #16399 )
...
Because there is no guarantee about a daily job running exactly once a
day, we need to store the last time that the email was sent, so that we
can refrain from sending one if it's been less than a day since the
last.
A setting has been used for this as we don't currently have a pattern
for it, we might want to consider moving this to some kind of cache
based solution in future. This has been added as a core setting so that
we don't expose it via the API.
The setting is stored as a number to allow us to store value as unix timestamp.
---------
Co-authored-by: Rishabh <zrishabhgarg@gmail.com>
2023-03-15 15:34:41 +05:30
Sodbileg Gansukh
64e5fbe5b7
Adjusted Portal popup width for better readibility
...
refs https://github.com/TryGhost/Team/issues/2621
2023-03-15 17:45:01 +08:00
Sanne de Vries
9667ec2eea
Updated spacing between header and feature image in email preview
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-15 10:34:51 +01:00
Simon Backx
4cc7d7d6d1
Added show/hide comment CTA to preview labs view
...
refs https://github.com/TryGhost/Team/issues/2714
Uses the comments settings and the showCommentCta setting from the newsletter.
2023-03-15 10:16:57 +01:00
Daniel Lockyer
42d9c3ea4d
Reorganised React imports
...
- we use ES6 `import` for all other imports so this standardizes the
React package to also use import vs require
- merged with other imports from the react package if present
2023-03-15 10:15:04 +01:00
Sanne de Vries
03b8715276
Added support for center-aligning comments link in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
- When center-aligning the post title, the meta data and comments link are also centered
2023-03-15 10:12:20 +01:00
Sanne de Vries
c538e39d33
Updated comments link UI in email preview
...
Refs https://github.com/TryGhost/Team/issues/2714
2023-03-15 10:02:43 +01:00
Simon Backx
b27c7bc707
Fixed batch sending snapshots dates
...
no issue
The snapshots contained the current date, so they broke every day. This commit fixes the issue by setting a fixed date.
2023-03-15 09:45:36 +01:00
Sodbileg Gansukh
7c9e77bc81
Updated recent posts links to analytics
...
Refs https://github.com/TryGhost/Team/issues/2612
- the recent posts were used to link to the editor, now they're linked to their analytics page
- now that we have an analytics screen for each post it makes sense to link to that screen where possible
2023-03-15 15:21:26 +08:00
Kevin Ansfield
6a3a4632ad
Updated post links in member event feeds to point to post analytics screen ( #16384 )
...
refs https://github.com/TryGhost/Team/issues/2612
- member event feeds previously had links to posts that opened the
front-end post URL in a new tab
- now that we have an analytics screen for each post it makes sense to
link to that screen where possible because it allows drill-down into
site performance
2023-03-15 15:12:16 +08:00
renovate[bot]
a7207eb0dd
Update dependency sqlite3 to v5.1.6
2023-03-15 07:51:08 +01:00
Naz
b627516088
Removed mediaInliner labs flag
...
refs https://github.com/TryGhost/Toolbox/issues/524
- The 'mediaInliner' beta flag is not used for anything anymore, so there's no need to keep it around. The only surface of the feature is the `POST /db/media/inline` endpoint that will be used through internal tooling mostly and won't be accessible through the Admin UI.
2023-03-14 22:13:04 +01:00
Naz
f442398239
Reverted media inlining button in settings>labs
...
refs https://github.com/TryGhost/Toolbox/issues/524
- We no longer need the UI of any kind for the media inliner feature as
the inliner endpoint will be used mostly for internal purposes through
automated tooling
- This reverts commit 901485c47b
2023-03-14 21:57:35 +01:00
Naz
8025663616
Moved POST /db/media/inline endpoint outside labs
...
refs https://github.com/TryGhost/Toolbox/issues/524
- The endpoints is for internal (non-documented) usage at the moment and is fine without the labs flag.
- This should allows us to test the inlining on production sites sooner
2023-03-14 18:32:52 +01:00
Simon Backx
66c20710ba
Added placeholder comment CTA button to emails
...
fixes https://github.com/TryGhost/Team/issues/2725
- Added to emails if labs flag enabled, comments enabled and comment CTA button enabled
- Links to comment section
- Design and styling not added yet
2023-03-14 17:11:24 +01:00
Simon Backx
56cbb15e37
Wired up showCommentCTA in admin
...
fixes https://github.com/TryGhost/Team/issues/2726
This makes sure the toggle actually saves to the database, and that the toggle is only shown when comments is enabled.
2023-03-14 16:35:23 +01:00
Simon Backx
bb019a0ab5
Added E2E test for sending email without post title
...
fixes https://github.com/TryGhost/Team/issues/2724
This change also includes new snapshots for email sending (similar for email previews, but this time for the real emails to make sure we catch changes).
2023-03-14 16:05:18 +01:00
Sanne de Vries
3cdd13ba3a
Updated spacing of email newsletter modal sidebar
...
Refs https://github.com/TryGhost/Team/issues/2699
2023-03-14 15:37:22 +01:00
Simon Backx
350b291c34
Added show_comment_cta column to newsletter table ( #16401 )
...
fixes https://github.com/TryGhost/Team/issues/2707
Adds the new column for storing whether we need to show a comment CTA in
emails. Enabled by default.
2023-03-14 15:03:02 +01:00
Sanne de Vries
3a95b558e0
Fixed post title not being hidden in email preview
...
Refs https://github.com/TryGhost/Team/issues/2705
2023-03-14 13:37:52 +01:00
Sam Lord
72ba6ec4af
Added member feedback to data generator
...
refs: https://github.com/TryGhost/Toolbox/issues/454
2023-03-14 10:32:34 +00:00
Simon Backx
1e435fb328
Implemented showPostTitleSection ( #16404 )
...
fixes https://github.com/TryGhost/Team/issues/2705
- Added showPostTitleSection to newsletter model in admin
- Wired up UI to admin model so it saves to the database
- Implemented showPostTitleSection in newsletter preview and added some
minor temporary css styling
- Implemented showPostTitleSection in newsletter template in backend,
and added some extra CSS styling to fix spacing
2023-03-14 11:29:43 +01:00
Aileen Nowak
475d8f9dd6
Fixed not providing a boolean value or slack-notifications service
...
no issue
The logic was incorrect and provided a URL instead of the expected `boolean` value for `isEnabled`
2023-03-14 12:00:20 +02:00
Simon Backx
69d07c892c
Fixed getLazyRelation returning new model for optional relations ( #16411 )
...
no issue
When using `getLazyRelation` on an optional relation that is not set, it
will return a newly created model instead of a model from the database.
- Adds a new require option to `getLazyRelation`, that throws an error
if the relation is not set (off by default to match existing use cases)
- This caused a bug (not visible because we always pass a newsletter id)
in email previews, where when the newsletter id was not explicitly set,
it would use `newsletter = (await post.getLazyRelation('newsletter')) ??
(await this.models.Newsletter.getDefaultNewsletter());`, which always
returned the first one, and could return a newly initiated newsletter
with all properties set to undefined.
- Some page snapshots are altered by this, because the usage of
`getLazyRelation` on a post no longer sets the email relation to some
new model.
2023-03-14 10:58:58 +01:00
Sagar Gupta
1fd20151bd
🐛 Fixed upper price limit in Membership Tiers
...
closes https://github.com/TryGhost/Team/issues/2287
- Stripe allows a max. amount of 999,999.99, cf. Stripe docs https://stripe.com/docs/api/payment_intents/object#payment_intent_object-amount
- The publisher now sees an error if they choose a price that is higher than the upper limit
2023-03-14 10:52:17 +01:00
Simon Backx
ff5e7202c6
Added show_post_title_section column to newsletters table ( #16397 )
...
fixes https://github.com/TryGhost/Team/issues/2706
Only includes the migration. The setting is not used at the moment, but
will be enabled by default.
2023-03-14 09:48:13 +01:00
renovate[bot]
3c22203c71
Update @tryghost ( #16406 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@tryghost/html-to-mobiledoc](https://togithub.com/TryGhost/SDK/tree/master#readme )
([source](https://togithub.com/TryGhost/SDK )) | [`2.0.6` ->
`2.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fhtml-to-mobiledoc/2.0.6/2.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-card-factory](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`4.0.4` ->
`4.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-card-factory/4.0.4/4.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-clean-basic-html](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`3.0.6` ->
`3.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-clean-basic-html/3.0.6/3.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-default-cards](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`6.0.4` ->
`6.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-default-cards/6.0.4/6.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-default-nodes](https://togithub.com/TryGhost/Koenig/tree/main#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`0.0.15` ->
`0.0.16`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-default-nodes/0.0.15/0.0.16 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-lexical-html-renderer](https://togithub.com/TryGhost/Koenig/tree/main#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`0.1.11` ->
`0.1.12`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-lexical-html-renderer/0.1.11/0.1.12 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-mobiledoc-html-renderer](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`6.0.4` ->
`6.0.5`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-mobiledoc-html-renderer/6.0.4/6.0.5 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@tryghost/kg-parser-plugins](https://togithub.com/TryGhost/Koenig/tree/master#readme )
([source](https://togithub.com/TryGhost/Koenig )) | [`3.0.6` ->
`3.0.7`](https://renovatebot.com/diffs/npm/@tryghost%2fkg-parser-plugins/3.0.6/3.0.7 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>TryGhost/SDK</summary>
###
[`v2.0.7`](ca389b95dd...924c77a60eca389b95dd...924c77a60ehttps://togithub.com/TryGhost/Koenig/compare/@tryghost/kg-card-factory@4.0.4...@tryghost/kg-card-factory@4.0.5 )
[Compare
Source](https://togithub.com/TryGhost/Koenig/compare/@tryghost/kg-card-factory@4.0.4...@tryghost/kg-card-factory@4.0.5 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At
any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/TryGhost/Ghost ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-14 06:47:38 +00:00
renovate[bot]
221d1e616c
Update dependency sqlite3 to v5.1.5 [SECURITY]
2023-03-14 07:09:09 +01:00
renovate[bot]
0780cc2dd1
Update dependency metascraper to v5.34.0
2023-03-13 21:36:01 +00:00
Daniel Lockyer
f06ee87787
Removed myself as a CODEOWNER for migrations
...
refs https://ghost.slack.com/archives/C02G9E68C/p1678726901892459
- following a procedure update, I am no longer required to review
migrations so I can remove myself as a CODEOWNER for those paths
2023-03-13 18:06:35 +01:00
