Commit Graph

18151 Commits

Author SHA1 Message Date
Simon Backx
9774dc7a51 Released @tryghost/signup-form v0.1.2 2023-06-16 16:01:09 +02:00
Simon Backx
f13c8c4af2 🐛 Fixed signup form text wrapping after submitting
no issue
2023-06-16 15:57:51 +02:00
Peter Zimon
78aa31973c Updated installed theme list
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-16 15:44:02 +02:00
Sag
dfd69f9cf7 Bumped Lexical dependencies
no issue
2023-06-16 15:23:20 +02:00
Fabien 'egg' O'Carroll
a1dae99245
Enabled errors for our error rules in eslint (#17041)
Yo dawg, I heard you like errors?

This fixes the last issues we had with incorrect error usage and updates
eslint to longer allow them through!
2023-06-16 14:50:06 +02:00
Michael Barrett
721d7202a0
Added truncation to custom theme setting description (#17044)
no issue

Added truncation to custom theme setting description to prevent overly
long custom setting descriptions from diminishing the settings UX
2023-06-16 13:14:43 +01:00
Daniel Lockyer
f3894d5898 Moved Portal to apps/
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
2023-06-16 13:37:58 +02:00
Rishabh
eeabce2473 Fixed official theme image assets not loading in adminX
refs https://github.com/TryGhost/Team/issues/3432

The admin assets url are modified by ember build process by adding cache busting, so the original urls can't be used directly in adminX. This change passes the image assets from ember admin, causing the right image urls to be passed to adminX and for loading images.
2023-06-16 17:06:22 +05:30
Ronald Langeveld
77e3b3e947
🐛 Fixed page revision returning empty array on update and restore (#17042)
closes https://github.com/TryGhost/Team/issues/3491

- the `PostRevisionModel` had a `belongsTo` relation to Post which resulted in the Page model returning an empty array in the `post_revisions` property.
- Simply removing it fixed it. refs https://ghost.slack.com/archives/C02G9E68C/p1686912389383579?thread_ts=1686909240.034419&cid=C02G9E68C
2023-06-16 13:24:02 +02:00
Daniel Lockyer
99aeb73ecc Optimized DB reset during tests
refs https://github.com/TryGhost/Toolbox/issues/592

- it turns out that `TRUNCATE` in CI takes ~300ms for all tables, but
  `DELETE FROM` takes ~30ms
- whilst truncating is generally known to be faster, I believe it's only
  faster on large tables
- this saves 90% of the time it takes to reset the DB in MySQL
2023-06-16 13:15:17 +02:00
Peter Zimon
0f9417456a Added optional confirmation for modals in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-16 12:35:27 +02:00
Peter Zimon
f4e015d2c5 Added back button to theme preview in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-16 12:35:27 +02:00
Naz
09264261b7 Added ability to fetch posts by collection
closes https://github.com/TryGhost/Team/issues/3423

- For convenience we need a way to fetch posts that belong to a certain collection. This change adds support for `collection` query parameter: `/?collection=` which can be either an id or slug of the collections we are trying to fetch.
- When posts are fetched by collection we ignore any filters passed along in query parameters as collection is a "filter" by it's very nature.
2023-06-16 17:28:12 +07:00
Daniel Lockyer
b5d3066116
Removed eslint-plugin-react dependency from signup-form
refs 997cd3687e

- the `eslint-config-react-app` dependency already covers all necessary rules from `eslint-plugin-react`
  and using it separately causes conflicts across projects in eslint config
- thanks for the commit message @rishabhgrg :)
2023-06-16 11:53:40 +02:00
Rishabh
997cd3687e Removed eslint-plugin-react from AdminX
The `eslint-config-react-app` already covers all necessary rules from `eslint-plugin-react` and using it separately causes conflicts across projects in eslint config
2023-06-16 15:21:19 +05:30
Naz
25e0cb12c0
Added "getBySlug" method to Collections Service
refs https://github.com/TryGhost/Team/issues/3423

- This is a convenience method that should allow fetching collections by their slug. It is a great developer experience for in case when fetching built-in collections like "featured" and "index", so can avoid an extra call to find the collection and it's ide one wants to use.
2023-06-16 16:31:50 +07:00
renovate[bot]
e9595d9a4b Update dependency ember-cli-dependency-checker to v3.3.2 2023-06-16 10:15:56 +02:00
renovate[bot]
3aa0c7018d Update dependency i18next to v23 2023-06-16 10:15:18 +02:00
renovate[bot]
6ad1e5be68 Update dependency @ember/test-helpers to v2.9.4 2023-06-16 10:03:40 +02:00
renovate[bot]
c1d90df181 Update dependency @playwright/test to v1.35.1 2023-06-16 10:03:32 +02:00
renovate[bot]
d6664b70fd Update dependency semver to v7.5.2 2023-06-16 09:56:57 +02:00
Naz
1d214361ad
Refactored posts browsing to posts service
refs https://github.com/TryGhost/Team/issues/3423

- This refactor allow for smaller and cleaner change that's coming up when dealing with `?collection=` query parameter
2023-06-16 14:52:55 +07:00
Ronald Langeveld
cfbc97b033
🐛 Fixed revisions relation not linked to Posts api (#17037)
no issue

This was a bit of an oversight from our feature built at the retreat. We
didn't take revisions into account for pages at all, but luckily it made
revisions without issues regardless.
It just wasn't accessible and users weren't able to restore via ADMIN
because the API didn't serve them at all.

This wires up the revisions relation to be served by the API so we can
retrieve it in Admin.
2023-06-16 09:49:12 +02:00
Daniel Lockyer
02eadc32d3
Switched to only enabling retries in CI
refs https://ghost.slack.com/archives/C02G9E68C/p1686841987067309?thread_ts=1686761234.035659&cid=C02G9E68C

- enabling retries has helped reduce the number of flaky tests we see,
  but it means it's causing issues with local development and snapshots
- this moves the retry config to the CI specific commands so we don't
  have retries enabled locally
- also deduped test:base and test:single
2023-06-16 09:47:03 +02:00
Fabien "egg" O'Carroll
0d7f98f4d1 Supported adding/removing post to collection via Posts API
We've got some fairly simple diffing logic here to update the collections which
a post is in, the bulk of the changes here are to support the return of a DTO
rather than Bookshelf Model. This also helps improve the architecture because
we are step closer to removing infrastructure concerns (HTTP Response Headers)
from the business logic layer.

For now there is a crappy EventString which can be passed back to the
controller which can then handle any HTTP related concerns, although long term
these should be actual events like PostPublished or PostUpdated.
2023-06-16 09:28:19 +02:00
Fabien "egg" O'Carroll
f3f9e5a2f3 Moved serialisation of formats into the serialiser-layer
This prepares us to return a DTO rather than BookshelfModel to the serialiser
layer. When passing a BookshelfModel, the serialisation layer uses the model to
read from when building computed properties. By stripping values out in the
toJSON method it means that the DTO will be missing them and the computed
properties won't be able to be calculated. Instead we return ALL values to the
serialisation layer, and then strip out the ones that weren't requested in the
"clean" step.

This also inadvertently fixes the issue with `reading_time` requiring the
`html` field to be requested, we can now request just `reading_time`, as well
as have it included by default.
2023-06-16 09:17:47 +02:00
Fabien "egg" O'Carroll
41716a06ae Fixed mutation of shared state for matcher
This can cause bugs due to the matcher constraints changing in each test
2023-06-16 09:17:47 +02:00
Fabien "egg" O'Carroll
53eea00d21 Fixed check for god_mode param
Rather than require the string 'true', we allow any value to be passed, this
works with any parsing of params into booleans.
2023-06-16 09:17:47 +02:00
Fabien "egg" O'Carroll
229875d67d Bumbed @tryghost/admin-api-schema to latest version
This includes the changes necessary to allow the `collection` property to be
passed on posts
2023-06-16 09:17:47 +02:00
Jono Mingard
c71d245b1d Show descriptions from theme settings if set
refs https://github.com/TryGhost/Team/issues/3354
2023-06-16 15:43:48 +12:00
Peter Zimon
005a488eed Changed button color in nav settings in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-15 20:46:51 +02:00
Peter Zimon
5bfbd5a7a0 Refined navigation design in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-15 20:42:33 +02:00
Rishabh
5559b2234e Released Admin-x-settings v0.0.7 2023-06-15 23:09:19 +05:30
Rishabh
e19c1e905d Removed theme images from adminX
refs https://github.com/TryGhost/Team/issues/3432

The theme images are used directly from admin assets using the admin assets url in AdminX, so these are redundant and not used.
2023-06-15 22:55:27 +05:30
Rishabh
7400937f52 Added delete and upload confirmation for themes in adminX
refs https://github.com/TryGhost/Team/issues/3432

- shows user confirmation popup on deleting a theme
- shows user confirmation popup to activate an uploaded theme
- shows user confirmation popup to overwrite an existing theme
2023-06-15 21:00:51 +05:30
Rishabh
44a07e04e2 Fixed file upload not triggering for same file selection
refs https://github.com/TryGhost/Team/issues/3432

File upload component was not firing `onChange` when user attempts to upload the same again, which is a side-effect of `input` field behavior. This change resets the file input on every upload with a new key so that the upload always fires
2023-06-15 21:00:51 +05:30
Michael Barrett
9ce4c85905
Added custom theme setting descriptions (#17024)
refs https://github.com/TryGhost/Team/issues/3448

Added the ability to specify a description for a custom theme setting

---------

Co-authored-by: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
2023-06-15 15:10:56 +01:00
Daniel Lockyer
4b6cfa8f28
Added yarn archive to produce a build tarball
fixes https://github.com/TryGhost/Ghost/issues/16835

- this reimplements a command to product a tarball with Ghost after we
  took over `yarn build` for package-specific build steps
2023-06-15 15:42:39 +02:00
Simon Backx
885e5b7b9c 🐛 Fixed visible scrollbars in signup form preview
fixes https://github.com/TryGhost/Team/issues/3485
2023-06-15 15:04:09 +02:00
Naz
6335033466
Added full post data when returning collection's posts
refs https://github.com/TryGhost/Team/issues/3423

- When querying for posts that belong to a collection we should be returning full post information just like we do for Posts API.
2023-06-15 18:35:58 +07:00
renovate[bot]
8ccb0f37ad Update storybook monorepo to v7.0.21 2023-06-15 13:04:31 +02:00
Elena Baidakova
26abeb0ad2 Hide announcement bar script if visibility wasn't chosen
no issue
2023-06-15 15:03:04 +04:00
Ghost CI
a22317305e Merged v5.51.2 into main 2023-06-15 08:11:45 +00:00
Ghost CI
ab119ec96e v5.51.2 2023-06-15 08:11:43 +00:00
ErminMerdanovic
7cbff19995
Updated German translations (#17027)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-15 09:22:49 +02:00
Leonardo Ferreira
b28b18c05a
Updated Brazilian Portuguese translations (#17010)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-15 09:15:41 +02:00
Kevin Ansfield
3ee857a0de
🎨 Added word count to beta editor
closes https://github.com/TryGhost/Team/issues/3242

- the beta editor now provides `<WordCountPlugin>` for tracking word count so we can add the UI for it back
2023-06-15 09:04:13 +02:00
Ronald Langeveld
49f936b098
🐛 Fixed empty icon crashing signup embed preview (#17022)
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
2023-06-15 09:03:14 +02:00
Fabien 'egg' O'Carroll
8cb8b84786
🐛 Fixed Post History for posts sent as an email (#16999)
refs https://github.com/TryGhost/Team/issues/3458

From the discussion in slack, for all published/sent posts:
  Published only --> view history & restore
  Published & sent --> view history & restore
  Email only --> history hidden

And for all unpublished/unsent posts:
  All states --> view history & restore.
2023-06-15 09:03:01 +02:00
Jono Mingard
63a6b20b18 Added navigation settings logic to AdminX
refs https://github.com/TryGhost/Team/issues/3433
2023-06-15 15:39:11 +12:00
Kevin Ansfield
3e8a0c5028
🎨 Added word count to beta editor
closes https://github.com/TryGhost/Team/issues/3242

- the beta editor now provides `<WordCountPlugin>` for tracking word count so we can add the UI for it back
2023-06-14 17:56:03 +01:00
Rogerio
09cbfae5c5
Updated Brazilian Portuguese translations (#16968)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-14 17:47:35 +02:00
Simon Backx
82a511e2df Released Signup Form v0.1.1 2023-06-14 17:45:33 +02:00
Ronald Langeveld
004f5ff9bf Added empty line at end of file to i18n.d.ts
no issue

- added missing empty line
2023-06-14 16:59:28 +02:00
Ronald Langeveld
b8935a918e
Removed typescript declaration build step for i18n (#17023)
ref https://ghost.slack.com/archives/C02G9E68C/p1686735066587639

### <samp>🤖 Generated by Copilot at f9ec3e9</samp>

This pull request removes redundant build scripts from the `ghost/i18n`
and `ghost/signup-form` packages. This simplifies the build process and
avoids unnecessary TypeScript compilation.
2023-06-14 16:51:14 +02:00
Simon Backx
5bb4a94444 Added signup form attribution tests
no issue

Added some tests for the signup form attribution when on an external site or on the Ghost site.
2023-06-14 15:50:04 +02:00
Simon Backx
4da658e72a 🎨 Reused attribution for embeddable signup forms on own site
fixes https://github.com/TryGhost/Team/issues/3473

When a signup happens via the embeddable signup form on your own site, we'll use the default
attribution, so it indistinguishable from a signup via Portal.
2023-06-14 15:26:40 +02:00
Ronald Langeveld
998708c81a
🐛 Fixed empty icon crashing signup embed preview (#17022)
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
2023-06-14 15:13:49 +02:00
Simon Backx
14e05a6f0f 🐛 Disabled signup form embed menu when members are disabled
fixes https://github.com/TryGhost/Team/issues/3470

- When members are disabled or invite only, the signup form embed should be disabled
- The comments access setting is now also disabled if members are disabled
- The tiers menus are now also disabled if members are disabled
2023-06-14 14:57:08 +02:00
Daniel Lockyer
ecc28c5acd
Revert "Update dependency expect to v29.5.0"
This reverts commit 155c08bc61.
2023-06-14 14:56:03 +02:00
renovate[bot]
155c08bc61 Update dependency expect to v29.5.0 2023-06-14 14:43:08 +02:00
Aileen Booker
00131de0b6 Simplify logic when to call stripeService.connect() 2023-06-14 08:18:19 -04:00
Aileen Booker
10859b9b01 Fixed e2e tests 2023-06-14 08:18:19 -04:00
Aileen Booker
d27bb8f075 Added new Stripe events to DomainEventsAnalytics
no issue

- We need to send information about Stripe being enabled or disabled in live mode to analytics
- This hooks up the Domain events listeners in the analytics service and processes this information accordingly
2023-06-14 08:18:19 -04:00
Aileen Booker
48f9e85e09 Expose Stripe events in package 2023-06-14 08:18:19 -04:00
Aileen Booker
98fd6a7dbf Hooked up Stripe service connect method on Stripe public key update
no issue

- Withing the `SettingsBREADService` we want to call the `connect` method of the Stripe Service, which then dispatches the `DomainEvent`
- In order to ensure that the Stripe service is connected in 'live' mode, we compare the public key and make sure no live key was set before so to avoid multiple triggers of this call.
2023-06-14 08:18:19 -04:00
Aileen Booker
f3e0cec0d2 Added StripeLiveEnabledEvent and StripeLiveDisabledEvent to Stripe service
no issue

- This is preparation work to be able to listen to events whenever Stripe gets enabled in live mode or disabled again.
- This creates two new event types, which are being dispatched with `DomainEvents` from the Stripe service on the `connect()` and - vice versa - the `disconnect()` methods.
2023-06-14 08:18:19 -04:00
Daniel Lockyer
974ce0b25b
Updated i18n support locales
refs https://github.com/TryGhost/Team/issues/2795

- added Croatian and Malay, and added the changes they've had since
  merging
2023-06-14 12:29:01 +02:00
Daniel Lockyer
7a124a6901 Moved announcement-bar to apps/
refs https://github.com/TryGhost/Toolbox/issues/594

- we're moving all the standalone apps to a separate folder to keep them
  out of the core code and easier to find
2023-06-14 12:28:55 +02:00
Nik Syarul Zaffi
ed20ff4a06
Added Malay locale (#16952)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-14 12:23:45 +02:00
Daniel Lockyer
fa43a0236b Moved Sodo-Search into apps/
refs https://github.com/TryGhost/Toolbox/issues/594

- this is the first of a set of commits to move our "apps" into the
  `apps/` folder, so we don't mix Ghost core and standalone apps
2023-06-14 12:10:57 +02:00
renovate[bot]
da0b2373a0 Update babel monorepo to v7.22.5 2023-06-14 12:08:12 +02:00
Simon Backx
04d04e1864
Revert "Fixed post editor items getting cut off on iOS" (#17017)
Reverts TryGhost/Ghost#16765

This commit broke the browser tests because the save button is hidden
underneath the settings menu:


![image](https://github.com/TryGhost/Ghost/assets/5277847/ec384fbb-6a39-4799-965d-768f66df3ad5)
2023-06-14 11:31:58 +02:00
Ronald Langeveld
327daa5dde
🐛 Fixed horizontal scrolling on signup form input field. (#17002)
closes https://github.com/TryGhost/Team/issues/3429

Resolved the issue where the input field in the signup form was not scrolling horizontally when a long text was entered. Updated the form container to properly contain the input field and prevent it from extending behind the button. The input field now blends into the form box and enables horizontal scrolling when necessary.
---------

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
2023-06-14 11:15:48 +02:00
Peter Zimon
010be7fd3d Updated theme preview in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-14 10:57:22 +02:00
Simon Backx
e680ddf14a Fixed retrying failed email without error message
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686730494254149?thread_ts=1686593227.689069&cid=CTH5NDJMS
2023-06-14 10:18:50 +02:00
Simon Backx
dbf6ccf29e Added missing cover style for signup card in frontend 2023-06-14 10:18:32 +02:00
Thomas Lamant
4e082a33cc
Updated Danish translations (#16967)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-14 09:46:20 +02:00
Jonathan Browne
d34b9b021a
Fixed post editor items getting cut off on iOS (#16765) 2023-06-14 09:45:17 +02:00
Thomas Lamant
5bfbaec262
Updated French translations (#16942)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-14 09:41:22 +02:00
Peter Zimon
5c229ce543 Added Breadcrumbs component to AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-14 09:40:27 +02:00
Naz
34f7b77190
Fixed collections snapshot
no issue

- The snapshot has save a wrong amount of "pages" for collections and was falsely passing after a retry. The correct amount should be 6.
2023-06-14 14:17:23 +07:00
Peter Zimon
15ec9f0d14 Added page header component in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-14 09:13:00 +02:00
renovate[bot]
52af10fef5 Update dependency lib0 to v0.2.78 2023-06-14 08:55:45 +02:00
renovate[bot]
77cc3aa2c0 Update dependency @storybook/addon-styling to v1.3.0 2023-06-14 08:55:26 +02:00
Peter Zimon
8820efa80b AdminX Design System component structure cleanup
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-14 08:35:51 +02:00
renovate[bot]
24ea03b3fe Update dependency @babel/plugin-proposal-decorators to v7.22.0 2023-06-14 08:24:59 +02:00
renovate[bot]
e7289e755a Update storybook monorepo to v7.0.20 2023-06-14 08:24:23 +02:00
renovate[bot]
10d60d7fe1 Update dependency ember-auto-import to v2.6.3 2023-06-14 08:12:55 +02:00
Peter Zimon
d2c78b0129 Refined official theme list in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-14 08:04:57 +02:00
Gary Lai
a74b60a025
Updated traditional Chinese translations (#17011)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-14 07:54:44 +02:00
renovate[bot]
a086f1f680 Update dependency @embroider/macros to v1.11.1 2023-06-14 07:52:01 +02:00
Jono Mingard
899fd4d29c Updated official themes to show installed/activated in AdminX
refs https://github.com/TryGhost/Team/issues/3432
2023-06-14 15:59:42 +12:00
Jono Mingard
ae0989ebea Added a basic theme install API call in AdminX settings
refs https://github.com/TryGhost/Team/issues/3432
2023-06-14 15:52:41 +12:00
Jono Mingard
7832f5c685 Added tier selection for default post access in AdminX
refs https://github.com/TryGhost/Team/issues/3151
2023-06-14 12:29:11 +12:00
Rishabh
902fb999a2 Updated official themes view in adminX
refs https://github.com/TryGhost/Team/issues/3432

- updated theme preview urls to use admin assets
- updated theme selection preview to include full theme info
2023-06-13 22:36:54 +05:30
Rishabh
36ced958f8 Wired theme change UI in adminX
refs https://github.com/TryGhost/Team/issues/3432

- wires list of installed themes
- allows actions on themes like upload, activate, delete and download
- cleans up theme modal content and toolbar into granular components
2023-06-13 22:00:49 +05:30
Rishabh
3dbc2ee507 Added theme management hooks in adminX
refs https://github.com/TryGhost/Team/issues/3432

- adds new `useRequest` hook to manage API requests
- adds new `useThemes` hook that allows fetching and updating themes
- adds models pattern to store specific type and helper info for themes
2023-06-13 22:00:49 +05:30
Daniel Lockyer
01e90dfb65 Extracted regression tests to a separate workflow
refs https://github.com/TryGhost/Toolbox/issues/592

- this commit extracts the regression tests into a separate workflow
- this means they run in parallel and reduce the time we have to wait
  for DB tests in general
- also fixes a test that was reliant on being run after the E2E
  tests (!)
2023-06-13 16:47:19 +02:00
Daniel Lockyer
082ab6dc3e Refactored truncateAll util to async-await
refs https://github.com/TryGhost/Toolbox/issues/592

- async-await makes the code easier to read
- also performs a small optimization to only load the foreign_keys
  pragma once for SQLite
2023-06-13 14:46:57 +02:00
Elena Baidakova
9f1279b58e
🐛 Fixed snippet insertion in the new editor (#17003)
refs TryGhost/Team#3445
- The snippet model always expects an object as it gets serialized when
saving - if we give it a string, it gets doubly serialized. It breaks
snippet replacement and insertion in the new editor.
2023-06-13 15:51:23 +04:00
Daniel Lockyer
6a9d01c6ad
Removed superfluous GHA workflow
- this was left here when we moved Sodo-Search into the monorepo but
  isn't needed now
2023-06-13 13:44:49 +02:00
Peter Zimon
6023bddafc Replaced tab component in themes (AdminX)
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:11:44 +02:00
Peter Zimon
1071d4437c Updated 'upload theme' component in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:11:44 +02:00
Daniel Lockyer
264773ccd1 Reset URL service between test boots
refs https://github.com/TryGhost/Toolbox/issues/592

- we should reset the URL service to avoid event listeners piling up and
  slowing down CI due to the number of events it has to process
2023-06-13 12:52:03 +02:00
Daniel Lockyer
cedfb14924 Fixed random timeouts with mysql2 library during tests
refs https://github.com/TryGhost/Toolbox/issues/592

- heads up, I'm not really sure about this fix
- when we're wrapping `setTimeout`, time stops and mysql2 starts doing
  weird things because we then shift time and it hits timeouts
- apparently `shouldAdvanceTime` should fix this by automatically
  incrementing time along with the system clock
- given the problem is quite difficult to hit, I could just be seeing a
  lack of this due to some other factor
- also removed unnecessary sinon sandbox creation as this is superfluous
2023-06-13 12:52:03 +02:00
Fabien 'egg' O'Carroll
7e1efd97e8
🐛 Fixed Post History for posts sent as an email (#16999)
refs https://github.com/TryGhost/Team/issues/3458

From the discussion in slack, for all published/sent posts:
  Published only --> view history & restore
  Published & sent --> view history & restore
  Email only --> history hidden

And for all unpublished/unsent posts:
  All states --> view history & restore.
2023-06-13 12:38:39 +02:00
Naz
7717021331 Added GET /collections/:id/posts endpoint
refs https://github.com/TryGhost/Team/issues/3423

- The Admin API endpoint allows to browse collection posts and paginate over them
2023-06-13 17:23:09 +07:00
Naz
ddc23b3467 Added collection's posts fetching to collections lib
refs https://github.com/TryGhost/Team/issues/3423

- This is a building block to allow paging, querying etc. of the posts belonging to a collection
2023-06-13 17:23:09 +07:00
Peter Zimon
db1c4e6381 Restructured components for theme mngmt in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:20:29 +02:00
Peter Zimon
09b404acd2 Fixed modal footer bug in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:16:19 +02:00
Peter Zimon
58f51a1838 Updated theme setting copy in AdminX
refs. https://github.com/TryGhost/Team/issues/3432
2023-06-13 12:05:52 +02:00
Hannah Wolfe
b80b90229f Added consistent linting pattern to all packages
refs: https://github.com/TryGhost/Toolbox/issues/188

- some of our older packages used a pattern for linting which missed using test config for linting tests
- we need this to be consistent so that we can add more eslint rules for testing
- two packages also didn't use the lib pattern, which made the lint pattern error - so this was fixed as well
2023-06-13 10:43:29 +01:00
Rishabh Garg
b697ca2768
Added basic theme settings design in AdminX (#17000)
refs https://github.com/TryGhost/Team/issues/3432

- adds basic design structure for theme settings/management in adminX

---------

Co-authored-by: Peter Zimon <peter.zimon@gmail.com>
2023-06-13 14:27:29 +05:30
Rishabh
5cc1c43257 Added theme management apis in adminX
refs https://github.com/TryGhost/Team/issues/3432
2023-06-13 13:24:47 +05:30
Jono Mingard
778e9a5f96 Added offers support in default recipients 2023-06-13 18:48:45 +12:00
Jono Mingard
731858e9e0 Added tier and label selection in default recipients
refs https://github.com/TryGhost/Team/issues/3151
2023-06-13 18:48:45 +12:00
Ronald Langeveld
c0e638fecd Added membersEnabled config to lexical editor
refs https://github.com/TryGhost/Team/issues/3456

- adds a boolean config whether members signup is enabled so that we can
  hide the signup card option from the editor if it's not enabled.
2023-06-13 08:47:16 +02:00
Jesús
a98f25b37a
Updated Catalan translations (#16992)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-13 08:33:15 +02:00
Yin Guobing
8bc04e9e6e
Updated Chinese translations (#16995)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-13 08:31:23 +02:00
Ghost CI
6c25f4cb08 Merged v5.51.1 into main 2023-06-13 05:52:58 +00:00
Ghost CI
e990bf5a94 v5.51.1 2023-06-13 05:52:56 +00:00
Steve Larson
d857e0ef15 Upgraded koenig lexical dependencies
no refs
2023-06-12 16:49:21 -05:00
Steve Larson
e742283ec8 Bumped koenig lexical dependencies
no refs
-added a couple more fixes: callout card rendering, code editor wrapping
2023-06-12 16:48:18 -05:00
Steve Larson
fd7b30fac0 Updated koenig lexical dependencies
no refs
-various fixes, including renderer for embed cards
2023-06-12 12:17:46 -05:00
Steve Larson
1345afdd71 Updated koenig lexical dependencies
no refs
-updated to fix embed card rendering
2023-06-12 12:08:19 -05:00
Daniel Lockyer
af8c0dc7a5 Prevented registering multiple Slack event listeners
refs https://github.com/TryGhost/Toolbox/issues/592

- in tests, we boot Ghost over and over
- this inits all the services each time
- it turns out that the Slack event listener is registered 80+ times
- to prevent this, we can check if it has already been registered, like
  we do with webhooks: 4639396c3a/ghost/core/core/server/services/webhooks/listen.js (L67-L69)
- not sure about this pattern in general, but it's something we can
  review in coming weeks
2023-06-12 15:04:11 +02:00
Daniel Lockyer
4639396c3a
Collected Ghost boot timing in test framework
refs https://github.com/TryGhost/Toolbox/issues/592

- this should help us track and calculate how much time is being spent
  in the boot/DB reset process during tests
2023-06-12 12:07:04 +02:00
Daniel Lockyer
3ac28c7a95
Fixed snapshot for settings
- this deviated somewhere, which I am investigating
2023-06-12 10:04:50 +02:00
Raka Afp
078aa72a2d
Updated Bahasa Indonesia translations (#16981)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:47:07 +02:00
EchoBilisim
eca84d61c4
Updated Turkish translation (#16979)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:45:13 +02:00
EchoBilisim
9d8c9cda09
Updated Turkish translation (#16982)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-12 09:44:18 +02:00
Naz
bb4e2fcadb
Added "index" built in collection
closes https://github.com/TryGhost/Team/issues/3425

- Index collection is needed to support one of the usecases we have in the near future where we'd hold all posts that would be displayed on the "index" page.
2023-06-12 12:57:52 +07:00
Naz
6421e202e5
Removed API endpoints adding posts to collections
closes https://github.com/TryGhost/Team/issues/3431

- We don't currently have a clear usecase to use the new pattern of updating posts as nested resource (of a collection). To simplify the API we are sticking with the approach of controlling where the post belongs to only through the Posts Admin API.
2023-06-12 12:08:37 +07:00
Jono Mingard
345d90bbba Added homepage/post URL selection in AdminX design settings
refs https://github.com/TryGhost/Team/issues/3354
2023-06-12 13:46:14 +12:00
Jono Mingard
ba2436e834 Fixed type errors in storybook 2023-06-12 11:10:53 +12:00
Jono Mingard
c3f6d77fd9 Added simple tests for design modal
refs https://github.com/TryGhost/Team/issues/3354
2023-06-12 11:04:19 +12:00
Jono Mingard
90c269275e Factored out useForm from useSettingGroup to be useful in more places
refs https://github.com/TryGhost/Team/issues/3151
2023-06-12 10:01:13 +12:00
Steve Larson
d1b5bf0a80 Updated koenig lexical dependencies
no refs
2023-06-09 12:22:01 -05:00
Steve Larson
88c3412cd4 Updated koenig lexical dependencies
no refs
2023-06-09 12:11:37 -05:00
renovate[bot]
ae3e38a14d Update dependency concurrently to v8.2.0 2023-06-09 17:39:51 +02:00
Ghost CI
2744d9a58b v5.51.0 2023-06-09 15:03:06 +00:00
Rishabh
eaf5aaade2 Updated site preview to handle theme settings
refs https://github.com/TryGhost/Team/issues/3354

- wires theme settings to site preview frame, dynamically updating the preview when theme settings change
2023-06-09 20:06:06 +05:30
Naz
f7e2f82089 Enabled collections permissions in controller
refs https://github.com/TryGhost/Team/issues/3220

- With permissions in place in the database, they can be enabled on controller level.
2023-06-09 21:13:06 +07:00
Naz
05bb82cf1a Added collections CRUD permissions
refs https://github.com/TryGhost/Team/issues/3220

- Added permissions for collection resources
2023-06-09 21:13:06 +07:00
Simon Backx
2a263c1024 Updated Signup Form to v0.1
no issue
2023-06-09 14:32:17 +02:00
Simon Backx
c3abd3a021 Released Signup Form v0.1.0 2023-06-09 14:31:32 +02:00
Peter Zimon
2d3ab08724 Experimenting with sticky footers in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:29:39 +02:00
Peter Zimon
4e5523674c Updated twitter and FB settings tests in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:16:56 +02:00
Peter Zimon
33ea5486df Updated user detail modal buttons in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 14:16:56 +02:00
Simon Backx
6d6da2492c Fixed showing errors when non 2XX response in signup form
no issue
2023-06-09 14:12:09 +02:00
Rishabh
c26f77586a Added dynamic site preview iframe
refs https://github.com/TryGhost/Team/issues/3354

- adds dynamically loading iframe with site preview based on preview data in Admin
2023-06-09 17:39:53 +05:30
Simon Backx
a4b24b1c7a Filled in signup form translation contexts 2023-06-09 13:54:23 +02:00
Simon Backx
08b37395cf Added translated placeholder in signup form embed
no issue
2023-06-09 13:48:43 +02:00
Simon Backx
381149e45b Added signup form button animation (minimal)
no issue
2023-06-09 12:07:57 +02:00
Sanne de Vries
afe18d54de Added email icon to signup form success page
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#de29f9cc1a364a12a4a0eeebef68f3a4
2023-06-09 11:35:36 +02:00
Simon Backx
5e7edb9da5 Added embeddable signup form
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
2023-06-09 11:30:03 +02:00
Peter Zimon
90b9959afc Set up showing images in brand settings (AdminX)
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-09 11:26:56 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
2023-06-09 11:08:14 +02:00
Simon Backx
66840cda0a Fixed minimal form padding
no issue

Previous change made the viewport always maximum 440px, so it always triggered the `sm` breakpoint
2023-06-09 11:06:50 +02:00
Sanne de Vries
6cdaf04fcd Updated NL translations for Portal and Signup Form
No ref
2023-06-09 10:53:22 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default
no issue

Added `margin: 0 auto;` css by default.
2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
2023-06-09 10:42:24 +02:00
Simon Backx
f4a822e7e0 Removed success page for minimal signup form
no issue

Shows the success state in the button now.
2023-06-09 10:26:05 +02:00
Naz
c507ea9600 Improved oversized batch correction logic
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- After analyzing data dumps, the data revealed that we have extra data from a stray batch. The filtering logic manually filters out the data to the recipients that belong to a "current batch".
- Hunting down the root cause of the data mixup proved to be too expensive of an investigation, so this is a "good enough patch" to deal with the problem.
- Most likely cause is the concurrent batch sending, but reducing the concurrency would be too expensive of a performance price to pay instead of filtering the data rarely.
2023-06-09 14:40:12 +07:00
Fabien "egg" O'Carroll
643fbbbb1f Removed collections from stable list in Admin API
We had to add these so that they could be played with programatically
but now we have a god_mode flag, we can remove them.
2023-06-09 09:31:44 +02:00
Fabien "egg" O'Carroll
29a403cc68 Supported a god_mode param in the Admin API
This currently skips the not-implemented middleware and can be used to
access experimental endpoints whilst in development.
2023-06-09 09:31:44 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971)
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy
No ref
2023-06-09 08:26:21 +02:00
renovate[bot]
58f48d2e0a Update dependency @playwright/test to v1.35.0 2023-06-09 08:25:51 +02:00
Naz
efac36c36c
Removed data dump during email batching
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- Having a data dumped in production was a one-off trick to allow us debug the error. Now that we have data it's no longer needed.
2023-06-09 10:44:13 +07:00
Simon Backx
7e47bff92f Released Signup Form v0.0.3 2023-06-08 16:35:54 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code
fixes https://github.com/TryGhost/Team/issues/3389
2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
2023-06-08 13:38:13 +02:00
Zabriskije
f3b60e6c6f
Updated Italian translations (#16966)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-08 13:33:18 +02:00
Markus Härnvi
bd679e0a81
Updated Swedish translations (#16964)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-08 13:32:11 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes
fixes https://github.com/TryGhost/Team/issues/3401
2023-06-08 13:23:38 +02:00
Simon Backx
a1e632abe0 Removed page color in signup form Storybook preview component
no issue

The Storybook did set the color, but that shouldn't be set because normally the components are always rendered in an iframe, with a default black, unchangeable color.
2023-06-08 13:17:54 +02:00
Simon Backx
887f7385e1 Fixed label picker overflow hidde in modal in signup form modal
no issue
2023-06-08 13:17:54 +02:00
Sanne de Vries
a8b9be38f8 Added max width to success message in signup form
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#419cf40167784a5c85bd38ea3a2006ed
2023-06-08 13:13:32 +02:00
Sanne de Vries
5346fb430c Updated loading state for embeddable signup form
Closes https://github.com/TryGhost/Team/issues/3390
2023-06-08 12:28:45 +02:00
Simon Backx
0b6cae09e9 Fixed Storybook missing context
no issue

Storybook didn't have access to the `t` method needed for translations. This change adds a Storybook decorator to all stories.
2023-06-08 11:20:16 +02:00
Elena Baidakova
4f1a92fb17
Fixed the ability to return to the main post page after scheduling a post in lexical (#16970)
refs TryGhost/Team#3405
- BackgroundSave option sets post status as Draft. Don't need such
behaviour as a post already can have a different status when a user
leaves the page.
2023-06-08 12:20:07 +04:00
Peter Zimon
cacd54b8c6 Remove traffic lights when in mobile view (AdminX)
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:33:01 +02:00
Peter Zimon
207651e2b0 Rename design modal cancel button in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:27:37 +02:00
Peter Zimon
949df42000 Added temporary preview content
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:14:12 +02:00
Peter Zimon
0d1d4dc365 Removed custom view switch functions
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 08:03:53 +02:00
Peter Zimon
2eda7c3287 Added mobile view to preview modal in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:59:32 +02:00
Peter Zimon
d87994d210 Renamed chrome header component in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:28:16 +02:00
Peter Zimon
011db27650 Moved preview toolbar to global preview component
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 07:11:12 +02:00
Peter Zimon
859e052810 Updated unstyled option to select input in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
f28829b24e Updated multiselect styles in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
d1c32e47bb Updated default input field styles in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Peter Zimon
c67d6fd11b Added dynamic heading color to inputs in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-08 06:32:03 +02:00
Jono Mingard
c1628f46e0 Updated api services to be memoized in case of re-renders
no issue
2023-06-08 11:08:00 +12:00
Jono Mingard
446841ce9c Updated design settings to be editable and show theme settings
refs https://github.com/TryGhost/Team/issues/3354
2023-06-08 10:30:25 +12:00
Peter Zimon
567422174d Fixed select input size bug in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:58:47 +02:00
Peter Zimon
1cd341d9e6 Fixed type error
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:53:42 +02:00
Peter Zimon
812b83a66e Fixed type error
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:50:56 +02:00
Peter Zimon
1bfade4891 Added preview selection toolbar in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 22:48:58 +02:00
Ghost CI
a173a31736 Merged v5.50.4 into main 2023-06-07 18:43:27 +00:00
Ghost CI
e7eba9f4d7 v5.50.4 2023-06-07 18:43:25 +00:00
Kevin Ansfield
2a32187ad4
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta
no issue

- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
2023-06-07 18:51:02 +01:00
Steve Larson
f6457569c6
Added koenig lexical package version to sentry report
closes TryGhost/Team#3381
2023-06-07 18:50:58 +01:00
Kevin Ansfield
0c24c009d2
🐛 Fixed converter bug that stopped some snippets being migrated for the editor beta
no issue

- if the converted mobiledoc started with a card and contained any text content we would hit a "can not read .length of undefined" error which could prevent snippets from being migrated when opening the beta editor and result in copy/paste from old editor to new not working
- bumped `@tryghost/kg-converters` to a fixed version
2023-06-07 18:48:19 +01:00
Steve Larson
85896287e3 Added koenig lexical package version to sentry report
closes TryGhost/Team#3381
2023-06-07 11:05:35 -05:00
Ghost CI
e1b1af38e9 Merged v5.50.3 into main 2023-06-07 16:01:00 +00:00
Ghost CI
887155938a v5.50.3 2023-06-07 16:00:59 +00:00
Peter Zimon
ed43ebaee6
Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:52:55 +02:00
Peter Zimon
5960fdeb53 Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:30:07 +02:00
Peter Zimon
f48dc5a847 Added inner scrolling for Design sidebar in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor (#16959) 2023-06-07 16:05:38 +01:00
Michael Barrett
9da246ac84
Enforce explicit cacheInvalidate header (#16826)
refs https://github.com/TryGhost/Team/issues/3005
2023-06-07 15:13:45 +01:00
Fabien "egg" O'Carroll
e0da095c76 Allowed integrations to use Collections API 2023-06-07 15:40:24 +02:00
Fabien 'egg' O'Carroll
92172aca8e
Wired up collections to posts endpoint (#16945)
- Added support for `include=collections` to the Posts Admin API behind a flag
- Refactored some of the collections work to support it
2023-06-07 15:06:15 +02:00
Daniel Lockyer
d127b975af
Disabled autoRefresh when inserting fixtures
refs https://github.com/TryGhost/Toolbox/issues/592

- we don't need to receive the refreshed model back afterwards so we can
  save an SQL select per insert by disabling auto-refresh
- this saves about 18000 DB queries for the MySQL tests, which should
  help reduce test time due to the overhead
2023-06-07 15:03:12 +02:00
Aileen Booker
9372124d61 Decouple sentry from analytics events handlers by expecting general exception handler
no issue

- The class should not rely on being passed a specific dependency, but rather needs to communicate with types what structure and method it needs to function correctly.
- Replaced the specific dependency to `sentry` with a generic definition of what is expected.
2023-06-07 09:00:49 -04:00
Aileen Booker
5db1950090 Added tests ModelEventsAnalytics
no issue

- Added full unit tests for `ModelEventsAnalytics` class
2023-06-07 09:00:49 -04:00
Aileen Booker
6efc1cce82 Added JSDoc types and inject more deps for DomainEventsAnalytics
no issue
2023-06-07 09:00:49 -04:00
Aileen Booker
591ca2c9bf Added first test structure for ModelEventsAnalytics
no issue

- The added `ModelEventsAnalytics` class didn't have tests before the refactor. Added unit tests to verify functionality.
2023-06-07 09:00:49 -04:00
Aileen Booker
9b27804276 Added tests for DomainEventsAnalytics
no issue

- Added unit tests for newly added `DomainEventsAnalytics` class to verify intended functionality
2023-06-07 09:00:49 -04:00
Aileen Booker
2c4d9e2776 First pass on adding domainevents to segment service
no issue

- In order to listen to `DomainEvents` for `MilestoneCreatedEvents` we need to add a `DomainEvents` listener and handler to the Segment analytics service.
- For better readability and to be more consistent with how code is currently written in Ghost, I refactored the service index file and split the two types of event listener into separate classes which is much cleaner and easier to test.
2023-06-07 09:00:49 -04:00
Peter Zimon
20eaff9e5c Updated sticky footer component in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 13:06:26 +02:00
Sanne de Vries
6b444dabdc Added max width to signup card form in split layout
Refs https://www.notion.so/ghost/Sign-up-card-feedback-doc-6b9aa746ed654a1a87b759dc5f5bb031?pvs=4#693bad1f085a430aa6da2a9659ac3f27
2023-06-07 13:00:18 +02:00
Fabien "egg" O'Carroll
7667d6d589 Removed coverage checks from regression tests
Regression tests are not written to ensure coverage of code, in fact they are
barely written at all anymore, instead we write unit and e2e tests. Because of
this the coverage is constantly dropping as the codebase grows. This causes
significant pain and suffering for developers and slows down development.
2023-06-07 12:46:39 +02:00
Peter Zimon
76704d05c6 Added global sticky footer component in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 11:53:51 +02:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch
no issue

- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
2023-06-07 09:56:18 +01:00
Peter Zimon
ef096d9c87 Cleaned up classname properties in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 10:48:33 +02:00
Peter Zimon
f05b6a6037 Added unstyled property to image uploads AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 10:29:03 +02:00
Peter Zimon
9faf2cafbe Got rid of modal folders in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:53:20 +02:00
Peter Zimon
a3cba13381 Broke down design settings in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:40:56 +02:00
Peter Zimon
d7e5661a35 Fixed preview modal size bug in AdminX
refs. https://github.com/TryGhost/Team/issues/3354
2023-06-07 09:10:16 +02:00
Sodbileg Gansukh
dfd4ab0f0f
Fixed search input focus on iOS (#16950)
closes https://github.com/TryGhost/Ghost/issues/16825

- iOS is very restrictive on input focus which doesn't allow without any
user interaction
- The only workaround was creating a temporary input, focus it, and
remove it after moving the focus to the actual searfch input
- It also moves the inputRef to the parent component, so that it can be
used in the click event handler, because the focus event only works when
it's inside a function that's triggered after user interaction
2023-06-07 15:01:28 +08:00
Duberly, Guarnizo Fuentes Rivera
28bef37d02
Updated Spanish translations (#16940)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-07 08:57:30 +02:00
EchoBilisim
095a262b14
Updated Turkish translations (#16937)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-07 08:52:20 +02:00
Daniel Lockyer
5d7d56198c
Released Portal v2.33.1 2023-06-07 08:38:25 +02:00
Daniel Lockyer
5f860c6e31
Fixed encoded characters appearing for Offers in Portal
fixes https://github.com/TryGhost/Team/issues/3392

- the "price" here can contain a slash, which is encoded/escaped by default by
  i18next
- this disables the escaping to fix the text that is shown to the user
2023-06-07 08:35:40 +02:00
Rishabh
71e5d708d4 Reverted "Disabled image editor setting check"
This reverts commit 9d9e296148.

This commit was a temporary fix to load the image editor if the setting was disabled.
2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9 Merged v5.50.2 into main 2023-06-06 19:05:20 +00:00
Ghost CI
924d73e02e v5.50.2 2023-06-06 19:05:19 +00:00
Rishabh
9d9e296148 Disabled image editor setting check
refs https://github.com/TryGhost/Team/issues/3034

Temporarily disables image editor setting check to allow it load by default
2023-06-06 23:59:43 +05:30
Rishabh
6806b88139 Fixed pintura link in image editor integration
refs https://github.com/TryGhost/Team/issues/3034
2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be Added koenig lexical version to feedback submission
refs TryGhost/Team#3381
2023-06-06 12:55:51 -05:00
Naz
fab5b1845c
Made builtin collections un-deletable
closes https://github.com/TryGhost/Team/issues/3376

- It should not be possible to delete a built-in collection.
2023-06-06 22:04:16 +07:00
Ghost CI
c8b713a679 Merged v5.50.1 into main 2023-06-06 14:40:58 +00:00
Ghost CI
6a07d63f38 v5.50.1 2023-06-06 14:40:57 +00:00
Kevin Ansfield
076c2be9aa
🐛 Fixed copy/paste of HR cards between editor and beta editor
no issue

- bumped `@tryghost/kg-converters` which contains a fix for an incorrect card name map in the lexical/mobiledoc converter methods
2023-06-06 15:20:35 +01:00