Timothy Clem
4f3e5fa069
Produce error nodes if productions don't match expected shape
2016-10-31 13:29:58 -07:00
Josh Vera
9d00d63e15
Merge pull request #894 from github/move-javascript-repo
...
Update javascript repo location
2016-10-21 11:34:17 -04:00
Rick Winfrey
416a69e823
Point javascript repo to new location
2016-10-21 10:19:24 -05:00
Josh Vera
457e18e420
Merge pull request #893 from github/improve-imports2
...
Fix root cause of Import diff summary issues
2016-10-20 18:42:04 -04:00
Rick Winfrey
5be0a11707
Update Import tests
2016-10-20 17:27:30 -05:00
Rick Winfrey
bd9fb81037
Consolidate back to single functions, passing in a function to extract the correct Annotation
2016-10-20 17:19:42 -05:00
Rick Winfrey
85a3864a96
Remove unused function
2016-10-20 16:34:54 -05:00
Rick Winfrey
c91fd3270d
Use new afterTerm behavior for all semantic-diff
2016-10-20 16:33:47 -05:00
Rick Winfrey
2f0d04ef0f
Use afterTerm'
2016-10-20 16:22:56 -05:00
Rick Winfrey
e68be8e3b8
Take the after annotation when we take the afterTerm
2016-10-20 16:22:45 -05:00
Rick Winfrey
8d7a74c2b2
Remove behavior stripping Indexed nodes
2016-10-20 16:22:29 -05:00
Josh Vera
15e5f8d611
Merge pull request #886 from github/improve-imports
...
Improve import diff summary statements
2016-10-20 11:57:55 -04:00
Rick Winfrey
78f778c82b
Remove unnecessary import
2016-10-19 18:12:00 -05:00
Rick Winfrey
1a787335b8
Update tests
2016-10-19 18:10:28 -05:00
Rick Winfrey
fe803e94ba
Only remove indexed nodes for import statements when the indexed node contains a child indexed node and so on.
...
This is to make sure for these cases, when we have an indexed node
containing a single indexed node and so on, that we’re capturing the
range of children Leaf or other Syntax other than Indexed nodes. This
is because of an issue that occurs when we construct SyntaxDiff for
import syntaxes specifically for nested indexed statements.
2016-10-19 18:08:16 -05:00
Rick Winfrey
84d2f7ae36
Remove comments
2016-10-19 18:06:34 -05:00
Rick Winfrey
c64056894d
Clean up warnings
2016-10-18 16:57:29 -05:00
Rick Winfrey
1f5c73143d
++import.json tests
2016-10-18 16:54:15 -05:00
Rick Winfrey
7ae5ad32f3
Use termNameFromChildren and revmoeIndexedNode helper function for Import SyntaxDiff terms
2016-10-18 16:51:08 -05:00
Rick Winfrey
956fd5ba25
Add removeIndexedNode helper function
2016-10-18 16:50:43 -05:00
Rick Winfrey
e423dfdc2b
Add Data.List (concatMap)
2016-10-18 16:50:22 -05:00
Rick Winfrey
5de66456f9
Merge branch 'master' into improve-imports
2016-10-18 11:06:36 -05:00
Rick Winfrey
541edccd26
Merge pull request #885 from github/constraint-alias
...
Introduce DefaultFields Constraint alias
2016-10-18 10:56:41 -05:00
Rick Winfrey
469b76d82b
Remove redundant imports
2016-10-18 10:44:36 -05:00
Rick Winfrey
5149ff100f
Update Summary.hs to use DefaultFields
2016-10-18 10:43:05 -05:00
Rick Winfrey
9b9569b8a5
Update Diffing.hs to use DefaultFields
2016-10-18 10:41:58 -05:00
Rick Winfrey
87d3111bcc
Merge branch 'master' into constraint-alias
2016-10-18 10:37:31 -05:00
Rick Winfrey
2df9e9ad39
Merge branch 'improve-imports' of github.com:github/semantic-diff into improve-imports
2016-10-18 10:35:48 -05:00
Rick Winfrey
3b984eb470
++javascript
2016-10-18 10:34:49 -05:00
Rick Winfrey
90f1cc2fb4
Remove unnecessary brackets
2016-10-18 10:34:36 -05:00
Rick Winfrey
a8dee06d07
Merge branch 'master' into improve-imports
2016-10-17 19:17:12 -05:00
Rick Winfrey
99e070e107
Remove if-else generated file
2016-10-17 18:51:23 -05:00
Rick Winfrey
43e082c85f
Remove import generated file
2016-10-17 18:50:47 -05:00
Rick Winfrey
bad1ae2d78
Remove warnings
2016-10-17 18:47:49 -05:00
Rick Winfrey
c05a3a961e
For Import Syntax nodes containing an Indexed Syntax node with only one element, we need to take the source span of the child.
...
- If we don’t, this can lead to us taking more of the source than is
desired. This relates to unnamed nodes in TreeSitter. The trouble is we
don’t have the ability to determine if an unnamed node is what we want.
2016-10-17 18:44:15 -05:00
Rick Winfrey
e831229779
Don't single quote around an import statement
2016-10-17 18:42:24 -05:00
Rick Winfrey
242654b05f
Update tests
2016-10-17 18:41:03 -05:00
Rick Winfrey
69492f39e4
Maintain space for "from" when term node is not an Indexed node
2016-10-17 11:29:49 -05:00
Rick Winfrey
36eb60d05d
Conditionally match against Indexed nodes when applying toTermName for Import Syntax
2016-10-17 11:01:45 -05:00
Rick Winfrey
2893e373f1
Merge pull request #887 from github/weekly
...
Add weekly notes
2016-10-14 18:19:17 -05:00
joshvera
d83efce2e0
add weekly
2016-10-14 17:46:41 -04:00
Rick Winfrey
dfc11385d8
++tests
2016-10-14 13:40:07 -05:00
Rick Winfrey
a4dfe48ff4
Output an import statement's expressions
2016-10-14 13:39:57 -05:00
Rick Winfrey
6aa62cc8f9
Merge branch 'master' into constraint-alias
2016-10-14 12:01:31 -05:00
Rick Winfrey
56dfa479e8
Revert moves
2016-10-14 12:00:28 -05:00
Rick Winfrey
75a254175c
Use DefaultFields constraint alias
2016-10-14 11:53:47 -05:00
Rick Winfrey
014a6a21d7
Update comment, extract appendParentContexts function
2016-10-14 11:53:34 -05:00
Rick Winfrey
8960836bcb
Change order of functions, use DefaultFields constraint alias
2016-10-14 11:53:08 -05:00
Rick Winfrey
053393fdca
Move data declarations to top
2016-10-14 11:52:36 -05:00
Rick Winfrey
c1f6be7b7f
Add DefaultFields constraint alias
2016-10-14 11:51:17 -05:00