Commit Graph

6564 Commits

Author SHA1 Message Date
Antoine Leblanc
d7309b811e Partial cleanup of Hasura/App, refactor of GlobalCtx
### Description

As part of another project (the continuation of #8421), i have started a cleanup of `Hasura.App`, focusing on deleting old code and grouping together things that belong together. This quickly grew into a refactor of `GlobalCtx`, now renamed into `BasicConnectionInfo`. This small refactor adds comments, and aims at making clear what the purpose of those types and functions is.

Furthermore, it also changes the way the default postgres connection info is created, by making that part of the process of creating the `BasicConnectionInfo`, to deduplicate similar effort across different files.

This is expected to be a no-op.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8440
GitOrigin-RevId: 412c5b1905f629beb9c6cd262b9798cb31c93bdb
2023-03-22 21:41:53 +00:00
Nicolas Beaussart
d861a2a3c8 frontend: setup buid validator executor
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8446
GitOrigin-RevId: b63613585a880c1812a7012640937cf0e98253be
2023-03-22 20:53:53 +00:00
Daniel Harvey
ebb571ef39 feature(server): metadata for SQLServer logical model
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8444
GitOrigin-RevId: 86cfd7adbf326560a0ec72034de3dcd9dcb5124c
2023-03-22 17:11:19 +00:00
Daniel Harvey
7e437fc32b feature(server): ordered columns in Logical Model return type
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8434
Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com>
GitOrigin-RevId: 4ebd569bef868e01b15583e4af90d583d6713da7
2023-03-22 16:35:56 +00:00
Daniele Cammareri
14f6ccbe78 console: change dynamic db label
Quick PR for just updating the label of a tab and fix doc links

<img width="412" alt="image" src="https://user-images.githubusercontent.com/5709409/226867834-c85eb8da-2e84-4cc6-a8de-4446b87b1dd6.png">

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8431
GitOrigin-RevId: c449be121eef1d8e28fc2179c2910e729ee8aabe
2023-03-22 11:24:29 +00:00
Philip Lykke Carlsen
34e40e6caf refactor: newtype alias for action checking feature flags
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8429
GitOrigin-RevId: e543b608a91e0c39c39f06b772a7d43f360d5dc3
2023-03-22 10:48:22 +00:00
Philip Lykke Carlsen
a763eeeeb2 refactor: Componentizing Fixture
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8428
GitOrigin-RevId: 8295a85b4a42dc3821d100371de1f350ed97cda3
2023-03-22 09:55:48 +00:00
pranshi06
f194c47156 server: fix value of created_at for postgres event triggers
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8287
Co-authored-by: Karthikeyan Chinnakonda <15602904+codingkarthik@users.noreply.github.com>
GitOrigin-RevId: d4ae6a517da63f2f43567dc16fda135b3cd1d7e6
2023-03-22 07:32:42 +00:00
Daniel Chambers
08f05d45cf Include SQLite agent in Remote Joins HSpec API tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8382
GitOrigin-RevId: 6e264b4b3e49c1072b042b69ee256817a105c470
2023-03-22 03:30:02 +00:00
Solomon
cca1a92399 Simplify Transformable Requests Module
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8400
GitOrigin-RevId: 10728012c3d74e178c34b926e13d3627d514ce17
2023-03-22 00:01:07 +00:00
Tom Harding
e3d76a8fe5 Implement logical models metadata commands for BigQuery
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8415
GitOrigin-RevId: d972abb9a0763f036c8b1d58feca34967abfac5f
2023-03-21 18:47:49 +00:00
Nicolas Inchauspe
b72849e06e console: bootstrap leaking styles mitigation - step 1
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8265
GitOrigin-RevId: f35a250f77dae0f6652b03d390fa04623e3e8e81
2023-03-21 18:11:47 +00:00
Tom Harding
dba32d91c2 Generalise logical model test return types across backends
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8411
GitOrigin-RevId: b2c2c761415ed5e6fae172d1ccdc72afb0d01574
2023-03-21 17:41:53 +00:00
Nicolas Beaussart
83bd95f332 frontend: fixup process env values
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8412
GitOrigin-RevId: 7e14fd7b926db0d944a915aa8b376ac2e5c5efce
2023-03-21 17:04:12 +00:00
Tom Harding
6651e9b60d Use DerivingStrategies in BigQuery.Types
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8405
GitOrigin-RevId: ef3cd6cba009cb18e9441aabef146b060963dc65
2023-03-21 16:27:57 +00:00
Antoine Leblanc
e6b8b16478 Further remove explicit AppEnv threading in favour of askAppEnv
### Description

This PR continues some of the work done in #8392, and makes use of `HasAppEnv` to reduce the amount of explicit env passing in init functions, including removing it from the setup hook.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8408
GitOrigin-RevId: 4d6c906f78fbcc303571f9aac16d163d68b77e41
2023-03-21 15:51:30 +00:00
Rob Dominguez
f5c25b2dcc docs: add ref to discord for feedback component
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8368
GitOrigin-RevId: 1c166d6dcd41d7bdd1e304e3ef7aab72077758d4
2023-03-21 12:55:28 +00:00
Rob Dominguez
f3d0829197 docs: update replace_metadata snippet
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8406
GitOrigin-RevId: a69bf5a510862d9c28d426f37eff5c81c3f367cd
2023-03-21 12:41:01 +00:00
Antoine Leblanc
1d76015629 delete ExecutionCtx in favour of explicit argument passing
### Description

This small PR removes `ExecutionCtx`: it was only used as a `Reader` argument for `runGQ`, and two of its wrappers. Explicit argument passing removes one additional small record, and one more `runReaderT`.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8397
GitOrigin-RevId: cdf65f643283be37d493d483d46a586f0f9ef885
2023-03-21 12:37:21 +00:00
pranshi06
ea691b3c06 server: improve logging around 'Internal Exception' errors
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8369
GitOrigin-RevId: 22160a2c8a17d571ceeda0bf3e9b672bea31b8f9
2023-03-21 12:00:00 +00:00
Luca Restagno
21f9918677 console: add support for specific data types (datetime / time) for gdc
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8393
GitOrigin-RevId: c1eeb1fb6a5cb825853ec29d7ec1f8b0b702ad07
2023-03-21 11:18:36 +00:00
Antoine Leblanc
0a1628c0cc Clean AppEnv and AppContext passing, remove RunT, reduce ServerConfigCtx uses
## Description

This PR does several different things that happen to overlap; the most important being:
- it removes `RunT`: it was redundant in places where we already had `Handler`, and only used in one other place, `SchemaUpdate`, for which a local `SchemaUpdateT` is more than enough;
- it reduces the number of places where we create a `ServerConfigCtx`, since now `HasServerConfigCtx` can be implemented directly by `SchemaUpdateT` and `Handler` based on the full `AppContext`;
- it drastically reduces the number of arguments we pass around in the app init code, by introducing `HasAppEnv`;
- it simplifies `HandlerCtx` to reduce duplication

In doing so, this changes paves the way towards removing `ServerConfigCtx`, since there are only very few places where we construct it: we can now introduce smaller classes than `HasServerConfigCtx`, that expose only a relevant subset of fields, and implement them where we now implement `HasServerConfigCtx`.

This PR is loosely based on ideas in #8337, that are no longer applicable due to the changes introduced in #8159. A challenge of this PR was the postgres tests, which were running in `PGMetadataStorageAppT CacheBuild` 🙀

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8392
GitOrigin-RevId: b90c1359066d20dbea329c87762ccdd1217b4d69
2023-03-21 10:45:56 +00:00
Daniel Harvey
eba0a3fb33 chore(tooling): Make command to run SQLServer repl
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8404
GitOrigin-RevId: 163ee869d436b29f3563a7ec3294f0786b32f19c
2023-03-21 09:47:13 +00:00
Krushan Bauva
6e6aa54d84 docs: add missing comma in get_scheduled_events API example
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8402
GitOrigin-RevId: 31b1cf90562cb2b504790f72832bbefbf09d2630
2023-03-21 09:16:11 +00:00
Nicolas Beaussart
5cd32ffd2a frontend: house keeping
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8395
GitOrigin-RevId: e577c320e96227fe0c8c3dc85fc3170b12080c45
2023-03-21 08:52:51 +00:00
Matthew Goodwin
a9ab4bc418 Initial PR for work on frontend docker compose [DSF-193]
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8313
GitOrigin-RevId: 34fc399b46ed09c2e4f6288811870ec00ad05753
2023-03-21 01:24:33 +00:00
awjchen
4f6240fb04 server: refactor ConnectionTemplateResolver
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8381
GitOrigin-RevId: 5286c384bb8c739170c90960a9b4a324a629c43b
2023-03-20 21:56:20 +00:00
Julian@Hasura
e501b60a82 console: Only use json string editor for jsonb columns DSF-211
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8396
Co-authored-by: Julian <843342+okjulian@users.noreply.github.com>
GitOrigin-RevId: bce8e6483bf163aecfdc54dfe23c91439dafaf59
2023-03-20 19:07:14 +00:00
Aaysha
bf5f5a0e30 frontend :Removing Heroku Banner from Connect database page
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8389
GitOrigin-RevId: dfd709ef2dbb0f12f41f114022ed76b382fa7963
2023-03-20 16:55:59 +00:00
Puru Gupta
5ec4d6e91b server: always add query type in http-log logs (whenever available)
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8353
GitOrigin-RevId: f7a2f8ab033043ed331c15b861218547de6f2744
2023-03-20 16:14:25 +00:00
Sean Park-Ross
c8f4ea27fc Docs: Update pg_create_remote_relationship Metadata API Reference
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4745
GitOrigin-RevId: c7f4d9919c356a12bc5d5f5eae8023e5f14790ae
2023-03-20 12:48:18 +00:00
Julian@Hasura
d89c3f6698 Permissions: Support jsonb columns DSF-157
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8363
Co-authored-by: Julian <843342+okjulian@users.noreply.github.com>
Co-authored-by: Luca Restagno <59067245+lucarestagno@users.noreply.github.com>
GitOrigin-RevId: a7726c2b32e9faeb5ff6a6d6ea3b6fec24cf4667
2023-03-20 12:16:23 +00:00
paritosh-08
d5fcb4118f docs: add auth-hook cache card in EE overview
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8387
GitOrigin-RevId: 694003c9bc3504665b36db46d638af0ecc7394d1
2023-03-20 11:40:07 +00:00
Sean Park-Ross
d0ccddf75c Docs: Remove duplicated permissions example page in auth section
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8385
GitOrigin-RevId: 6b528e928afae4bc1880162f1caf06905b225eca
2023-03-20 11:20:46 +00:00
Krushan Bauva
de0d4a3d3b docs: update version API reference docs to include server_type info
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8346
GitOrigin-RevId: a63dd3992f83c2942adc74d8ecb114f323f05e75
2023-03-20 10:03:55 +00:00
Daniel Harvey
fb562883f0 chore(ci): use ScalarType in LogicalModels tests
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8378
GitOrigin-RevId: afd4ac325dde8459ecd1ef8eb0bed855354327c2
2023-03-20 09:55:15 +00:00
Antoine Leblanc
6118b440b4 chore(server): revamp hlint config and add new undefined rule
### Description

This PR adds a new rule to our hlint config, that flags all uses of `undefined`. Any use of `undefined` will therefore be flagged in future PRs. Additionally, this PR cleans up our hlint config, including fixing the `ignore: { group: _ }` block: `group` isn't a valid key for `ignore`, and therefore that `ignore` block was _suppressing all hints_ in the matching files.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8311
GitOrigin-RevId: 51b702cfd056588a8dae9db4c9e4471ea039210e
2023-03-20 08:41:59 +00:00
Rikin Kachhia
0a1656b0b8 docs: fix nitpicks in mysql and oracle docs
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8367
Co-authored-by: Sean Park-Ross <94021366+seanparkross@users.noreply.github.com>
GitOrigin-RevId: 319af3d3a621a6d49720f2cbb1fe38074b7646b6
2023-03-20 07:14:51 +00:00
Daniel Chambers
e9c697aaa9 Fix "limit" from permissions being incorrectly applied to aggregates in Data Connectors
[GDC-1064]: https://hasurahq.atlassian.net/browse/GDC-1064?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8345
GitOrigin-RevId: 9ef91944ba6408e1030a47de58f3271145433ee2
2023-03-20 04:02:23 +00:00
Stef Moreno
6e1ebd6a4b Update wiki Contributor guide
## Description
Updating wiki contributor guide in response to Jira [this ticket](https://www.google.com/url?q=https://hasurahq.atlassian.net/jira/software/projects/DOCS/boards/19?selectedIssue%3DDOCS-275&sa=D&source=calendar&ust=1679491564232347&usg=AOvVaw3LLVDh1KVpy5dnW5ZVUwpW).

## Preview
[Link](https://pr-8376---docusaurus-5kcgrtdh3a-wl.a.run.app/docs/wiki/contributions/#step-8-compare-and-pull-request)

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8376
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
GitOrigin-RevId: dc6c71aa91ec1a90892e8929875086adf6ad134c
2023-03-17 19:26:31 +00:00
Philip Lykke Carlsen
3b9b389c99 docs: Clarify the permissions necessary for update_by_pk
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8375
GitOrigin-RevId: 8f17f50b2f30c469c68e1059b922359eb6622552
2023-03-17 17:54:17 +00:00
Jesse Hallett
1ad37eff31 server: codecs for network config, graphql introspection
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8132
GitOrigin-RevId: 6b800f35a76b6d38817862a4678644b8bf230a95
2023-03-17 17:46:16 +00:00
Philip Lykke Carlsen
e86a09bd93 docs: Wide numeric types
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8360
Co-authored-by: Rob Dominguez <24390149+robertjdominguez@users.noreply.github.com>
GitOrigin-RevId: 5790f7fef9219a8d6ec296c7ca037e85ec79fd59
2023-03-17 17:07:19 +00:00
Nicolas Inchauspe
260c3ddcb4 console: add autocomplete ability to input field
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8372
GitOrigin-RevId: dcbd61b9308aaff13e8937738a9b62fc08ec7508
2023-03-17 16:25:35 +00:00
Auke Booij
29f0660dee chore(server): remove some unused function arguments
These didn't trigger GHC warnings because their name starts with an underscore.

PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7954
GitOrigin-RevId: 6898b165f073e70aad06e1a2aa5f703ac385f9ed
2023-03-17 15:51:33 +00:00
Daniel Harvey
8d92c48c3c chore(server): logical models in Citus
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8356
GitOrigin-RevId: 98cb2dcaebe45b98d506279bc7a363b8d2696cd8
2023-03-17 11:28:31 +00:00
Puru Gupta
c437a42f6d server: rename SchemaCacheRef to AppStateRef and add AppContext to it
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8159
Co-authored-by: Naveen Naidu <30195193+Naveenaidu@users.noreply.github.com>
Co-authored-by: Anon Ray <616387+ecthiender@users.noreply.github.com>
GitOrigin-RevId: a57f6dc8b3e992d86490e5c51508827f00151dfe
2023-03-17 10:30:38 +00:00
Erik Magnusson
662754ef9e Fix cloneable permissions between query types
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8284
GitOrigin-RevId: 17c0590bcfa032d9a396851dfc0c97b2ee94feb1
2023-03-17 08:44:54 +00:00
Sean Park-Ross
18368d6c6d Docs: Oracle
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/7961
Co-authored-by: Brandon Martin <40686+codedmart@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GitOrigin-RevId: e6a585c45c795cafca1ad0d9db4da606687eec81
2023-03-17 07:03:58 +00:00
Daniel Chambers
c1ea1ea5e6 Fix SQLite agent hard crashing if db file does not exist
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/8364
GitOrigin-RevId: db56baaa11d79f5324bcdb39e7975920daeb7d62
2023-03-17 07:00:18 +00:00