Commit Graph

385 Commits

Author SHA1 Message Date
Jeroen Engels
3d2b7234f9 Fix test 2021-03-10 17:02:21 +01:00
Jeroen Engels
22f68ab542 Add Review.Test.expectGlobalErrors function 2021-03-10 17:02:21 +01:00
Jeroen Engels
6345bc8a90 Add annotations 2021-03-10 17:02:21 +01:00
Jeroen Engels
0d7eb30f4e Remove code related to getting the elm.json key 2021-03-10 17:02:21 +01:00
Jeroen Engels
362a192665 Print target function name 2021-03-10 17:02:21 +01:00
Jeroen Engels
2da8367965 NoUnsafeRegexFromLiteral: Report as global error 2021-03-10 17:02:21 +01:00
Jeroen Engels
6bf6d41c55 Backport NoUnsafeRegexFromLiteral rule 2021-02-28 18:51:45 +01:00
Jeroen Engels
a4bb1719b5 Backport rules from elm-review-code-style 2021-02-10 17:15:09 +01:00
Jeroen Engels
584f0bef8a Adapt tests to elm-syntax fix 2021-02-02 16:03:05 +01:00
Jeroen Engels
4669fe3960 Backport elm-review-unused 2021-01-24 16:46:42 +01:00
Jeroen Engels
63819d3fb7 Backport elm-review-debug 2021-01-24 16:43:58 +01:00
Jeroen Engels
fa8bc02068 Backport rules from elm-review-common 2021-01-19 21:45:35 +01:00
Jeroen Engels
cb604c782f Backport unused and test-values 2020-12-23 19:12:04 +01:00
Jeroen Engels
2a4c93a0b4 Remove unused imports 2020-12-21 21:45:55 +01:00
Jeroen Engels
f044f9cd1d ModuleNameLookupTable: Add test to make sure that aliasing in patterns works 2020-12-06 14:30:39 +01:00
Jeroen Engels
c6ca7ec9fe Backport elm-review-unused 2020-12-05 12:40:40 +01:00
Jeroen Engels
13371a1af9 Backport rules from elm-review-noop 2020-11-18 10:16:23 +01:00
Jeroen Engels
ed1f40bbc3 Fix ModuleNameLookupTable not registering aliases from the prelude 2020-11-18 10:07:16 +01:00
Jeroen Engels
66f5375eaa ModuleNameLookupTableTest: Add tests for function declarations handling 2020-09-23 10:38:39 +02:00
Jeroen Engels
82037d4e5b ModuleNameLookupTableTest: Add signature texts 2020-09-23 10:30:47 +02:00
Jeroen Engels
efebce84d1 ModuleNameLookupTableTest: Refactor declaration visitor 2020-09-23 10:27:39 +02:00
Jeroen Engels
ccfcc99468 ModuleNameLookupTableTest: Add declaration visitor 2020-09-23 10:25:40 +02:00
Jeroen Engels
97c0e4abe9 Add test for handling pattern aliases 2020-09-23 10:21:35 +02:00
Jeroen Engels
c2488a06b0 Add failing test case for ModuleNameLookupTableTest 2020-09-23 10:12:19 +02:00
Jeroen Engels
b1b96c6dcf Backport rules from other projects 2020-09-23 08:11:51 +02:00
Jeroen Engels
80e4d87436 Use helper in declaration visitor 2020-09-22 19:08:17 +02:00
Jeroen Engels
75e535ce2a Use helper in expression visitor 2020-09-22 19:06:45 +02:00
Jeroen Engels
4ad35edde3 Add helper for showing the real name 2020-09-22 19:03:43 +02:00
Jeroen Engels
01e2f66fc7 Rename test module 2020-09-22 19:01:02 +02:00
Jeroen Engels
2208b410a0 Change test suite title 2020-09-22 19:00:15 +02:00
Jeroen Engels
e4acd4de29 Move code from ModuleNameForValueTest into ModuleNameForTypeTest 2020-09-22 18:59:34 +02:00
Jeroen Engels
bb0955c07b ModuleNameType: Creator rule dynamicaly 2020-09-22 18:56:30 +02:00
Jeroen Engels
e925d0a25a Fix files not being evaluated when they're ignored in project rules without a folder 2020-09-09 18:50:42 +02:00
Jeroen Engels
3087e757a8 Fix module name lookup table not knowing about patterns inside let functions destructuring 2020-09-08 10:06:28 +02:00
Jeroen Engels
0ff71b2c84 Remove unused code 2020-08-26 19:01:47 +02:00
Jeroen Engels
7c0d7e6fad Support record update functions for module name lookup table 2020-08-25 15:28:56 +02:00
Jeroen Engels
7455bca8a8 Use lookup table in ScopeExample 2020-08-22 10:23:25 +02:00
Jeroen Engels
9c40b95394 Add ScopeExample 2020-08-22 10:21:53 +02:00
Jeroen Engels
219bb11ff6 Use lookup table in ModuleNameForValueTest 2020-08-22 10:02:31 +02:00
Jeroen Engels
e550dce72d Use lookup table in ModuleNameForTypeTest 2020-08-22 09:54:20 +02:00
Jeroen Engels
31eef5486b Use lookup table in NoUnused.CustomTypeConstructors 2020-08-22 09:43:30 +02:00
Jeroen Engels
808baa1a22 Use lookup table in NoUnused.Exports 2020-08-22 08:50:39 +02:00
Jeroen Engels
7064268dc0 Use lookup table in NoUMissingSubscriptionsCall 2020-08-21 23:29:54 +02:00
Jeroen Engels
3e85e3709a Add elements in the lookup table 2020-08-21 20:53:33 +02:00
Jeroen Engels
08a3cbf7a7 Pass in module name lookup table to rules 2020-08-21 18:53:22 +02:00
Jeroen Engels
95b4e12b76 Use the lookup tables collected during the pre-run 2020-08-21 09:27:01 +02:00
Jeroen Engels
c4f1a268d6 TMP Only run a single test 2020-08-20 23:00:21 +02:00
Jeroen Engels
2b12cebd9c Use lookup table 2020-08-19 23:43:02 +02:00
Jeroen Engels
556a4b24bc Move again 2020-08-19 23:26:48 +02:00
Jeroen Engels
494d376ba6 Add ModuleNameLookupTable 2020-08-19 23:16:20 +02:00
Jeroen Engels
f32dc336af Add new Scope type 2020-08-19 23:01:43 +02:00
Jeroen Engels
df8fef43e9 Remove unused variable in NoUnapprovedLicense 2020-08-11 17:20:52 +02:00
Jeroen Engels
449b21addd Backport rules from other packages 2020-08-09 18:56:12 +02:00
Jeroen Engels
747dfabb3f Rename and document new functions 2020-07-02 07:41:19 +02:00
Jeroen Engels
aa72525032 Remove unused function 2020-06-28 13:44:52 +02:00
Jeroen Engels
260f34d743 Add a new function to initialize a module rule's context using a context creator + isInSourceDirectories metadata 2020-06-28 12:21:13 +02:00
Jeroen Engels
619850016a Add a way to get the module context using a module context creator 2020-06-28 10:00:43 +02:00
Jeroen Engels
4c43013fb8 Remove Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
d2220e652b Use Rule instead of Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
0688386fb8 Remove unused code 2020-06-26 19:39:07 +02:00
Jeroen Engels
7bd35b1941 Add project visitors to module visitors 2020-06-26 00:08:31 +02:00
Jeroen Engels
1d5ca98a61 Make visitor order test more robust 2020-06-25 23:09:09 +02:00
Jeroen Engels
c8445f7bf6 Rename all _New functions 2020-06-25 22:57:31 +02:00
Jeroen Engels
8216097025 Rename ModuleVisitor into ModuleRuleSchema, until the next breaking change 2020-06-25 22:52:11 +02:00
Jeroen Engels
94b0ab6a79 Turn module visitors into project rules 2020-06-25 22:49:44 +02:00
Jeroen Engels
b66816b589 Add module visitors to project rules 2020-06-25 19:23:09 +02:00
Jeroen Engels
dc131e8265 Use new module rules in tests 2020-06-25 19:23:09 +02:00
Jeroen Engels
5a2e85ecbf Create working project rule without module visitors 2020-06-25 19:23:09 +02:00
Jeroen Engels
c9e8f9680d Backport changes from review dependencies 2020-06-20 20:09:03 +02:00
Jeroen Engels
97179db534 Remove unused variables in NoLeftPizza 2020-06-20 18:21:58 +02:00
Jeroen Engels
b98f83d5f9 Backport changes from elm-review-noleftpizza 2020-06-19 18:44:03 +02:00
Jeroen Engels
2082f1fd34 Use withExpressionEnterVisitor in tests and examples 2020-06-19 17:57:27 +02:00
Jeroen Engels
748583e778 Deprecate Direction 2020-06-19 15:35:11 +02:00
Jeroen Engels
5e2b633c54 Fix inversion of result and expected fixed source code in whitespace failure message 2020-06-19 12:36:12 +02:00
Jeroen Engels
cfd7a9157e Rename enter and exit visitors 2020-06-16 22:03:18 +02:00
Jeroen Engels
767a7ba321 Use onEnter variants on test rules 2020-06-16 00:00:41 +02:00
Jeroen Engels
210dbea5e1 Enable NoUnused.Parameters 2020-06-14 16:44:44 +02:00
Jeroen Engels
acc00dfc3f Backport changes from review-unused and elm-review-scope 2020-06-14 16:44:44 +02:00
Jeroen Engels
be43b18a2f Make every test failure title red and bold 2020-06-03 19:16:42 +02:00
Jeroen Engels
932c788b9f Backport work from review packages 2020-06-03 18:23:19 +02:00
Jeroen Engels
46f94c220d Fix tests: fixed code with only two lines was incorrectly extracted 2020-06-02 18:04:08 +02:00
Jeroen Engels
70bfc6f0bd Rename NoInvalidLicense to NoUnapprovedLicense 2020-06-01 09:02:33 +02:00
Jeroen Engels
ca98c71e43 Make "Rule reported less errors than expected" error more informative 2020-05-19 19:41:11 +02:00
Jeroen Engels
c76d4d972f Make expected errors order-agnostic
Fixes #12
2020-05-17 17:08:27 +02:00
Jeroen Engels
ee8f294c18 Backport scope v0.2.0 2020-05-16 22:44:11 +02:00
Jeroen Engels
f1e3e725a8 Backport work from review-unused 2020-05-14 21:24:29 +02:00
Jeroen Engels
7d2a08d335 Backport Scope 2020-05-14 21:24:29 +02:00
Jeroen Engels
d0bd0579f3 Fix Review.Test not working correctly with multilines 2020-05-14 21:24:29 +02:00
Jeroen Engels
d2c37dd489 Fix typo in test failure messages 2020-05-14 20:45:16 +02:00
Jeroen Engels
06564b9cc1 Rename ErrorMessage to FailureMessage 2020-05-14 20:45:16 +02:00
Jeroen Engels
bd4377f106 Fix files not being ignored correctly in Windows 2020-04-29 19:32:06 +02:00
Jeroen Engels
d0b9cb16f7 Remove Review.Scope 2020-04-21 23:02:26 +02:00
Jeroen Engels
33c85462ed Backport work from review packages and elm-review-scope 2020-04-21 23:01:47 +02:00
Jeroen Engels
418a50e183 Backport work from review packages 2020-04-20 23:11:53 +02:00
Jeroen Engels
2d42e89092 Backport work from review packages 2020-04-08 18:36:56 +02:00
Jeroen Engels
1fbf67bddb Backport work from review-common 2020-04-08 00:19:25 +02:00
Jeroen Engels
ddf76dcba9 Backport work from review packages 2020-04-07 23:25:35 +02:00
Jeroen Engels
1d91332a68 Remove duplicate information in NoInvalidLicense 2020-04-06 19:13:13 +02:00
Jeroen Engels
2070a15ada Backport work from review-simplification 2020-04-06 17:18:56 +02:00
Jeroen Engels
4f2500c9c8 Backport work from review-simplification 2020-04-05 09:57:34 +02:00