Elizabeth Mitchell
3151fd8d90
fix(textfield): error styles not removing when an unrelated control is invalid
...
The bug: given a form with two required text fields,
1. Try to submit the form, both fields show error.
2. Add a value to the first field.
3. Try to submit the form, the first field does not remove its error.
This is fixed by listening to form submits and clearing the error state if the control is valid.
I refactored `injectFormReportValidityHooks()` into `addFormReportValidListener()` to keep the `OnReportValidity` class cleaner and better identify the problem we're trying to solve.
PiperOrigin-RevId: 597664564
2024-01-11 15:06:22 -08:00
Elizabeth Mitchell
f2ebcdac79
chore(labs): fix onReportValidity called twice with form.reportValidity
...
PiperOrigin-RevId: 597661314
2024-01-11 14:53:43 -08:00
Elizabeth Mitchell
5c22b2baea
test(labs): add more report validity tests
...
PiperOrigin-RevId: 597598077
2024-01-11 10:47:52 -08:00
Elizabeth Mitchell
e44f6a5a7f
test(labs): re-organize report validity tests for unhandled use cases
...
PiperOrigin-RevId: 597596342
2024-01-11 10:42:11 -08:00
Material Web Team
73725be670
fix(select): allow aria-expanded to be set to false
...
fixes #5360
PiperOrigin-RevId: 597381616
2024-01-10 16:09:04 -08:00
Elizabeth Mitchell
6efc90403b
fix(textfield): focus style lost after reportValidity()
during change
...
PiperOrigin-RevId: 597047043
2024-01-09 14:34:16 -08:00
Elizabeth Mitchell
cef1b740ee
fix(ripple): multiple touches causing ripples to start from center
...
Fix is pretty simple, we weren't clearing out the first pointerdown event, and subsequent ones were ignored since the `pointerId` changes with each touch.
Fixes #5349
PiperOrigin-RevId: 596668539
2024-01-08 12:17:43 -08:00
Copybara-Service
ad52075135
Merge pull request #5363 from jason2506:fix-button-sass-imports
...
PiperOrigin-RevId: 595816152
2024-01-04 15:19:28 -08:00
Elizabeth Mitchell
3c6e55006b
feat(textfield): add no-spinner
to remove number spin buttons
...
PiperOrigin-RevId: 595788647
2024-01-04 13:28:18 -08:00
Elizabeth Mitchell
553aaa6695
docs: todo cleanup
...
PiperOrigin-RevId: 595708369
2024-01-04 08:10:56 -08:00
Elliott Marquez
043bbad6f3
fix(select): clicking select toggles the menu rather than just open
...
PiperOrigin-RevId: 595540752
2024-01-03 17:07:06 -08:00
Material Web Team
89427158b7
fix(select): ensure md-select selection logic uses fresh DOM references
...
Previously selectItem would work with cached references to select-option elements which could become stale causing the deactivation logic to fail. This cl just ensures that selectItem always re-fetches the nodes to avoid the issue.
PiperOrigin-RevId: 595524158
2024-01-03 15:50:56 -08:00
Elizabeth Mitchell
68b078b4e1
fix(slider): move ripple and focus ring beneath handle
...
PiperOrigin-RevId: 595437166
2024-01-03 10:20:54 -08:00
Chi-En Wu
37fad0660d
fix(button): add missing sass imports
2024-01-03 20:08:12 +08:00
Elizabeth Mitchell
5dc870bfe1
fix(chips): filter's click.preventDefault()
not working when also updating selected
...
Fixes #5199
This bug appeared when calling prevent default as well as changing the state of the chip in the same listener. Now calling preventDefault will always revert to the previous value.
PiperOrigin-RevId: 595199149
2024-01-02 13:41:33 -08:00
Elizabeth Mitchell
035d155366
chore: remove todos for un-actionable spacing tokens bug
...
PiperOrigin-RevId: 594158700
2023-12-27 21:13:43 -08:00
Elizabeth Mitchell
363fc054d3
chore: remove un-actionable todos from labs
...
PiperOrigin-RevId: 594112463
2023-12-27 15:49:30 -08:00
Elizabeth Mitchell
9973b90981
fix(textfield): counter showing when max length is 0 or removed
...
Fixes #4998
This also fixes an error being thrown in text field's validator when minlength/maxlength change to out of bounds if they're not set in the correct order.
PiperOrigin-RevId: 594013553
2023-12-27 08:13:58 -08:00
Elizabeth Mitchell
4ae9db6c67
fix(dialog): text is now selectable
...
Fixes #5145
Added some notes on Material dialog focusing. Normally the dialog should *not* be focused, so you may wonder why we care about delegating focus at all. It's because:
1. We don't have focus trapping yet
2. We need to handle what happens when there isn't a focusable child in the dialog, even though that's against spec.
PiperOrigin-RevId: 594013328
2023-12-27 08:12:29 -08:00
Copybara-Service
689f9459c2
Merge pull request #5311 from christophe-g:cg-remove-unecessary-progress-animation
...
PiperOrigin-RevId: 594013260
2023-12-27 08:11:01 -08:00
Elizabeth Mitchell
c9360e2310
chore: remove commitlint.config.js from build files
...
PiperOrigin-RevId: 592670865
2023-12-20 15:20:00 -08:00
Elizabeth Mitchell
3dcfe65620
chore: don't add reviewers to size update PR and try new branch
...
PiperOrigin-RevId: 592656210
2023-12-20 14:18:29 -08:00
Elizabeth Mitchell
be3dc6f677
fix(dialog): immediate escape key not firing cancel event in Chrome 120
...
Fixes #5313
PiperOrigin-RevId: 592651305
2023-12-20 13:59:06 -08:00
Elliott Marquez
8912019b90
feat(select): add keyboard support for arrow end and home
...
PiperOrigin-RevId: 592643729
2023-12-20 13:29:14 -08:00
Elizabeth Mitchell
9c5cff8f90
fix(labs): card content not clickable with outline fix
...
Fixes #5312
PiperOrigin-RevId: 592594621
2023-12-20 10:20:39 -08:00
Elliott Marquez
50a9ffae46
feat(select): add menuAlign to allow end-aligning the select menu
...
PiperOrigin-RevId: 592384480
2023-12-19 17:10:25 -08:00
Elliott Marquez
4bb9418a52
feat(select): support width fit-content
...
width: fit-content will resize the select to be the width of its text content + icons. We need to add a wrapper to the menu that is width: 0px so that the width of the menu does not affect the size of the host.
PiperOrigin-RevId: 592382035
2023-12-19 16:59:37 -08:00
Elizabeth Mitchell
d06a3e781e
chore: add event hooks for default prevention behavior
...
PiperOrigin-RevId: 592375327
2023-12-19 16:29:52 -08:00
Elizabeth Mitchell
eca1357f1a
fix: rename and move internal/controller/events
...
Split `internal/controller/events` into `internal/events/redispatch-event` and `internal/events/form-label-activation`
PiperOrigin-RevId: 592350371
2023-12-19 14:49:35 -08:00
Elliott Marquez
57168f6a95
fix(slider): nested dir attributes do not break on chrome 120+
...
fixes the case where there is a `dir=rtl` grandparent and a `dir=ltr` parent to slider.
PiperOrigin-RevId: 592086653
2023-12-18 20:18:58 -08:00
Elliott Marquez
422f1050ff
docs(textfield): add jsdoc several properties
...
Added jsdoc to properties on textfield itself. I don't think we can count the bug closed until the api docs bot is fixed so that we can see what is exposed or not via the new mixins.
PiperOrigin-RevId: 592071151
2023-12-18 18:52:49 -08:00
Material Web Team
edb3559a1c
fix(select): expose SelectOption interface
...
PiperOrigin-RevId: 592022961
2023-12-18 15:14:41 -08:00
Elizabeth Mitchell
18bdabedd2
docs: fix broken progress indicator token links
...
PiperOrigin-RevId: 592021202
2023-12-18 15:09:16 -08:00
Elizabeth Mitchell
2bb480fb82
chore: move events out of controller folder
...
PiperOrigin-RevId: 592021123
2023-12-18 15:07:51 -08:00
christophe-g
f0dab482fd
chore(progress): use ternary operator + nothing instead of when
2023-12-18 21:26:00 +01:00
Elizabeth Mitchell
3f46ab6c14
docs: add contributing guide
...
Fixes #246
PiperOrigin-RevId: 591967524
2023-12-18 11:52:14 -08:00
christophe-g
4de5e74b5c
fix(progress): prevent unnecessary animation to run when not visible
...
Progress has an infinite animation on `<div class="dots">`. `.dots` is
only visible when `value` < `max` or `buffer` < `max`. But the animation
runs in any case.
2023-12-18 11:53:52 +01:00
Elizabeth Mitchell
839667dcf6
perf(ripple): don't process events in high contrast mode
...
PiperOrigin-RevId: 591368699
2023-12-15 15:01:49 -08:00
Elliott Marquez
cc8d02c847
docs: expose component size page and make bold look not fuzzy
...
PiperOrigin-RevId: 591365088
2023-12-15 14:48:19 -08:00
Elizabeth Mitchell
ddf1fb0c61
fix(tabs): --md-elevation-level
no longer leaks into tabs
...
Fixes #5137
PiperOrigin-RevId: 591357826
2023-12-15 14:19:15 -08:00
Copybara-Service
80edf15920
Merge pull request #5229 from aarondrabeck:md-menu-color-fix
...
PiperOrigin-RevId: 591297433
2023-12-15 10:37:44 -08:00
Elizabeth Mitchell
926edfb367
fix(textfield): remove Firefox high contrast mode background on linux
...
PiperOrigin-RevId: 591065806
2023-12-14 15:16:41 -08:00
Elizabeth Mitchell
b0eea7f59d
chore: add commitlint config for scopes
...
PiperOrigin-RevId: 591061701
2023-12-14 15:02:12 -08:00
Copybara-Service
4095c06e5a
Merge pull request #5294 from material-components:auto-update-size
...
PiperOrigin-RevId: 591043696
2023-12-14 13:57:53 -08:00
lit-robot
de692ecad5
chore: update sizes
2023-12-14 21:40:19 +00:00
Elizabeth Mitchell
53ec44b4b8
fix(labs): add card support for high contrast mode
...
PiperOrigin-RevId: 591038474
2023-12-14 13:38:48 -08:00
Copybara-Service
6eb9fe670f
Merge pull request #5285 from material-components:size
...
PiperOrigin-RevId: 591037361
2023-12-14 13:34:17 -08:00
Liz Mitchell
3638187e5f
chore: add leading and trailing table pipes
2023-12-13 20:22:56 -08:00
Elliott Marquez
bad478dd91
docs(menu): fix the popover demo and warning blockquote
...
PiperOrigin-RevId: 590796459
2023-12-13 20:19:58 -08:00
Elizabeth Mitchell
f92eb0efe0
chore: add feature request template
...
PiperOrigin-RevId: 590796188
2023-12-13 20:18:26 -08:00