microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-04 06:03:10 +03:00
Code Issues Projects Releases Wiki Activity
12,861 Commits 34 Branches 138 Tags 211 MiB
b269ceb773
Commit Graph

4477 Commits

Author SHA1 Message Date
Olaf Alders
5b00ce1594
docs: fix typo in ConsoleMessage class (#30857) 2024-05-22 13:31:14 +02:00
Pavel Feldman
e7a11c0ca2
fix: propagate close reason to api context (#30945) 2024-05-21 18:05:58 -07:00
Pavel Feldman
7b27fc3916
chore: pass outputDir to uimode (#30941) 
Fixes https://github.com/microsoft/playwright/issues/30886
 2024-05-21 14:36:31 -07:00
Yury Semikhatsky
148d759a4c
fix(chromium): do not fetch intercepted request body from network (#30938) 
Fixes https://github.com/microsoft/playwright/issues/30760
 2024-05-21 12:49:47 -07:00
오소현
165ecac5df
feat(test): add URL field to annotations for hyperlink display (#30665) 2024-05-21 12:46:38 -07:00
Joel Einbinder
d0644f5444
fix(electron): flaky startup if stderr comes in too fast (#30855) 
Chromium's `DevTools listening on` message sometimes arrives before
Playwright is finished connecting to Node. Without this patch, it would
miss the message and fail to connect.
 2024-05-21 12:15:05 -07:00
Dmitry Gozman
6290af3a08
feat(reporters): align and document environment variables (#30912) 
- Documents `PLAYWRIGHT_FORCE_TTY` and `FORCE_COLOR` across terminal
reporters.
- New `PLAYWRIGHT_LIST_PRINT_STEPS`. Removes undocumented test-only
`PW_TEST_DEBUG_REPORTERS_PRINT_STEPS`.
- Replaces `PLAYWRIGHT_HTML_REPORT` with `PLAYWRIGHT_HTML_OUTPUT_DIR`
and `PW_TEST_HTML_REPORT_OPEN` with `PLAYWRIGHT_HTML_OPEN` for
consistency, supports older versions for backwards compatibility.
- New `PLAYWRIGHT_HTML_HOST`, `PLAYWRIGHT_HTML_PORT` and
`PLAYWRIGHT_HTML_ATTACHMENTS_BASE_URL`.
- New `PLAYWRIGHT_JUNIT_STRIP_ANSI` and
`PLAYWRIGHT_JUNIT_INCLUDE_PROJECT_IN_TEST_NAME`.
- Removes `PW_HTML_REPORT` that was set for unknown reason.
 2024-05-21 10:46:52 -07:00
Max Schmitt
a93ad3dade
fix(fetch): allow UTF-8 in Location header (#30904) 2024-05-21 09:15:33 +02:00
Yury Semikhatsky
042896472b
fix: route.continue should not change multipart form data body (#30863) 
The bug was fixed in https://github.com/microsoft/playwright/pull/30734.
This PR adds a test and updates interception logic to not send post data
when it is not modified.

Fixes https://github.com/microsoft/playwright/issues/30788
 2024-05-20 16:36:57 -07:00
Lukas Bockstaller
437b14a903
fix: relative url path for ui mode (#29924) 
This is a follow up #29564 

I did a deep dive on a redirect issue I observed in my infrastructure
and originally attributed to some configuration mistakes on my part.
I have code hosted on `example.com/code` and use subdomain proxying.
This leads to the uimode being exposed on
`example.com/code/proxy/{{port}}`.

Clicking on the open uimode link shown by vscode redirected with a 302
to `example.com/proxy/{{port}}`

The absolute redirect url overruled the relative path handling reverse
proxies rely on.

This PR turns the absolute into a relative url to avoid this issue.
 2024-05-20 10:18:08 -07:00
Max Schmitt
162c18f586
feat(roll): roll Firefox to r1450 (#30865) 
Fixes
https://github.com/microsoft/playwright/actions/runs/9120975643/job/25079367394
 2024-05-19 16:28:32 +02:00
Playwright Service
b6a7d0a17e
feat(chromium): roll to r1119 (#30879) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-17 19:06:11 +02:00
Yury Semikhatsky
dcaded5255
chore(trace-viewer): format negative duration as - (#30840) 2024-05-17 09:32:57 -07:00
Yury Semikhatsky
b375f10778
fix: fulfill with unassigned status codes (#30856) 
Fixes https://github.com/microsoft/playwright/issues/30773
 2024-05-17 09:32:40 -07:00
Dmitry Gozman
4ad94c1a8c
chore: print friendly localhost address from http server (#30853) 2024-05-17 08:55:12 -07:00
Playwright Service
c9df73bc59
feat(webkit): roll to r2010 (#30861) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-17 09:45:16 +02:00
Playwright Service
4efb788f99
feat(chromium-tip-of-tree): roll to r1222 (#30859) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-16 23:23:47 +02:00
Max Schmitt
1526f1b522
chore: freeze webkit on macOS-12 (#30854) 2024-05-16 20:10:27 +02:00
Yury Semikhatsky
2734a05342
feat(trace-viewer): show nework request source id (#30810) 
<img width="1392" alt="image"
src="https://github.com/microsoft/playwright/assets/9798949/dcfd4d71-4a41-48ac-9f24-2996200f966a">

Fixes https://github.com/microsoft/playwright/issues/28903
 2024-05-15 16:29:26 -07:00
Dmitry Gozman
89cdf3d56e
feat: env.PLAYWRIGHT_FORCE_TTY to control reporters' tty (#30834) 
Previously, terminal reporters consulted `process.stdout.isTTY`. Now it
is possible to control the tty behavior:
- `PLAYWRIGHT_FORCE_TTY=0` or `PLAYWRIGHT_FORCE_TTY=false` to disable
TTY;
- `PLAYWRIGHT_FORCE_TTY=1` or `PLAYWRIGHT_FORCE_TTY=true` to enable TTY,
defaults to 100 columns when real columns are unavailable;
- `PLAYWRIGHT_FORCE_TTY=<number>` to force enable TTY and set the
columns.

Fixes #29422.
 2024-05-15 15:01:52 -07:00
Playwright Service
3370f37e7b
feat(webkit): roll to r2009 (#30833) 2024-05-15 23:24:42 +02:00
Pavel Feldman
8dec672121
chore(testServer): accept video parameter when running tests (#30832) 2024-05-15 12:45:57 -07:00
Dmitry Gozman
5fa0583dcb
fix(test runner): regular worker termination finishes long fixtures (#30769) 
Previously, terminating worker always had a 30 seconds force exit.

Now, regular worker termination assumes that process will eventually
finish tearing down all the fixtures and exits. However, the
self-destruction routine keeps the 30 seconds timeout to avoid zombies.

Fixes #30504.
 2024-05-15 10:37:36 -07:00
Max Schmitt
90765a226f
fix(electron): allow launching with spaces in path (#30820) 
Fixes https://github.com/microsoft/playwright/issues/30755
 2024-05-15 18:20:00 +02:00
Joe-Hendley
6ae5cd3824
feat: implement flag to fail flaky tests (#30618) 
Implements feature requested in
https://github.com/microsoft/playwright/issues/30457

The test runner treats flaky tests as failures when the flag is enabled,
but still reports flaky tests as flaky in the reporting interface. It
feels like something worth discussing as this behaviour makes sense to
me, but looked a bit odd to @BJSS-russell-pollock when I ran this past
him.

Closes #30457.
 2024-05-15 09:10:10 -07:00
Pavel Feldman
7a588e6c72
chore: do not close the reused context when video is on (#30807) 
Fixes https://github.com/microsoft/playwright/issues/30779
 2024-05-15 09:05:06 -07:00
Playwright Service
fda9051c75
feat(webkit): roll to r2008 (#30818) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2024-05-15 11:34:39 +02:00
Yury Semikhatsky
fb319e6d3d
fix: match client step and server action by explicit stepId (#30641) 
Matching bu `apiName@wallTime` fails when two actions start at the same
time, e.g. two parallel api requests. Moreover, it results in trace
actions that have parent set to themselves, which in turn causes
infinite loop in the trace viewer. To avoid this problems we write
stepId explicitly to the library trace and use those step ids to find
corresponding test runner steps.

The stepId is passed via zone in case of expect, because the protocol
step is quite deep in the call chain after or explicitly in case of API
call steps created by the test runner instrumentation.
 2024-05-14 12:10:46 -07:00
Sander
9ce41fa1b0
fix(ct): mount then unmount then mount (#30657) 
closes https://github.com/microsoft/playwright/issues/30628
 2024-05-14 11:03:46 -07:00
Max Schmitt
b06c1dfff1
Revert "fix(highlight): highlight Top Layer elements (#30001)" (#30800) 
This reverts commit a932222662.

Closes https://github.com/microsoft/playwright/pull/30797 - maybe there
is a better way to get the page height?
`document.documentElement.scrollHeight` seems to not work on Firefox.
Relates https://github.com/microsoft/playwright/issues/30770
 2024-05-14 17:23:52 +01:00
Yury Semikhatsky
873f3a03ac
chore(trace): add context create event for test runner (#30697) 
Adding metadata event to the test.trace to simplify time computation
logic.
 2024-05-14 09:00:33 -07:00
Playwright Service
f56f965461
feat(chromium-tip-of-tree): roll to r1221 (#30786) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-14 13:44:29 +01:00
Playwright Service
07ccd5ed7f
feat(webkit): roll to r2007 (#30776) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2024-05-14 10:33:00 +01:00
Dmitry Gozman
776b04e5ea
feat: APIRequestContext dispose reason (#30765) 
Similarly to page.close, we pass test-runner specific reason to
facilitate better error messages.

```
  1) a.test.ts:10:11 › test

    Error: apiRequestContext.fetch: Fixture { request } from beforeAll cannot be reused in a test.
      - Recommended fix: use a separate { request } in the test.
      - Alternatively, manually create APIRequestContext in beforeAll and dispose it in afterAll.
    See https://playwright.dev/docs/api-testing#sending-api-requests-from-ui-tests for more details.

       9 |
      10 |       test('test', async () => {
    > 11 |         await context.fetch('http://example.com');
         |                       ^
      12 |       });
      13 |
```

Closes #29260.
 2024-05-13 18:51:30 -07:00
Dmitry Gozman
8334191b94
fix(selector generator): properly escape re used in has-text (#30767) 
Fixes #30499.
 2024-05-13 12:40:46 -07:00
Yury Semikhatsky
64b4ac1732
fix(electron): record har file (#30748) 
Fixes https://github.com/microsoft/playwright/issues/30747
 2024-05-10 15:32:01 -07:00
Yury Semikhatsky
e728e90944
docs: waitForResponse method predicate example (#30739) 
Fixes https://github.com/microsoft/playwright/issues/30731
 2024-05-10 09:22:59 -07:00
Yury Semikhatsky
00bf7ea815
chore(trace-viewer): more clear classification of trace contexts (#30737) 2024-05-09 17:28:39 -07:00
Yury Semikhatsky
a50cd30519
chore: use monotonic time for sorting (#30735) 
* Use only monotonicTime for sorting, do not use wallTime for that
* Since test runner and the library can be running on different
machines, those machines may have clocks which are not synchronized. To
avoid problems in such cases we compute delta between test runner and
and library contexts based on a start time of action that exists in both
contexts.
 2024-05-09 15:31:23 -07:00
Dmitry Gozman
0d004c9f3c
fix(chromium): concat all post data entries for request.postData() (#30734) 
This already works in Firefox, but does not work in WebKit.
 2024-05-09 14:08:38 -07:00
Yury Semikhatsky
1a22e06062
chore: only patch callIds when there are multiple trace files (#30721) 2024-05-09 09:33:16 -07:00
Playwright Service
cfde97b0a0
feat(chromium): roll to r1118 (#30728) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-09 17:06:43 +01:00
Playwright Service
8d588477a0
feat(chromium-tip-of-tree): roll to r1220 (#30725) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-09 17:06:31 +01:00
Dmitry Gozman
a5d384c1f6
docs: add section explaining scrolling (#30719) 
Fixes #30643.
 2024-05-08 21:04:05 -07:00
Yury Semikhatsky
7a0c7730e7
fix(trace-viewer): make call ids unique across trace files (#30720) 2024-05-08 17:33:31 -07:00
Playwright Service
4a1a63189f
feat(chromium-tip-of-tree): roll to r1219 (#30712) 2024-05-08 22:30:54 +01:00
Viktor Szépe
150cbcbdf3
chore: fix typos (#30645) 2024-05-08 19:40:03 +01:00
Rui Figueira
cf3ff6531a
chore: make NodeSnapshot type recursive and more (#30619) 
Also, deviceDescriptors are now imported with ESM import instead of require()
 2024-05-08 11:08:40 -07:00
Saswat Das
7c826719ec
chore: remove redundant parameters from isElementStyleVisibilityVisible (#30637) 2024-05-08 17:45:53 +01:00
Max Schmitt
a0938fc7a4
chore: set minimum Node.js requirement to 18 (#30684) 2024-05-08 17:41:27 +01:00
Yury Semikhatsky
0164dca302
chore: extract trace modernizer into its own class (#30696) 2024-05-07 11:42:28 -07:00
ggorlen
2d7b1480b2
docs(reporters): wrap reporter in array, fixing typo in docs (#30686) 2024-05-07 11:16:21 +00:00
Pavel Feldman
979233e483
chore: print resolved host in the http server terminal (#30677) 2024-05-06 11:01:36 -07:00
Max Schmitt
aa0020878a
fix(chromium): allow pasting in DevTools without self-xss warning (#30653) 
Fixes https://github.com/microsoft/playwright/issues/30425
 2024-05-03 18:22:43 +00:00
Playwright Service
ce69236510
feat(chromium): roll to r1117 (#30646) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-03 15:29:02 +00:00
Yury Semikhatsky
d5b387159a
feat(fetch): sendImmediately (#30627) 
Fixes https://github.com/microsoft/playwright/issues/30534
 2024-05-02 16:30:12 -07:00
Playwright Service
5639cab4a4
feat(webkit): roll to r2005 (#30638) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-02 18:13:21 +00:00
jonghoonpark
a6488c4a28
fix(html-reporter): add filter for anonymous describe (#30621) 
related issue: https://github.com/microsoft/playwright/issues/30475

## Motivation:
On https://github.com/microsoft/playwright/issues/30475, we found that
anonymous describe is rendered in html report

## Modification:
Make filter for anonymous describe

## Result:
anonymous describe will be filtered out.
Not render empty describe
Close https://github.com/microsoft/playwright/issues/30475 issue
 2024-05-02 09:54:44 -07:00
Dmitry Gozman
fd92509dda
fix(role): extract tagName safely (#30636) 
Fixes #30616.
 2024-05-02 09:42:19 -07:00
georg.dev
8173cdc485
fix(reporters): improve detection of output folder clashes (#30607) 
When comparing `outputDir` and html-reporter `outputFolder`, we now make
sure that both paths end with a forward-slash.

Fixes #28677

---------

Co-authored-by: Georg Unterholzner <georg.unterholzner@dynatrace.com>
 2024-05-02 08:32:57 -07:00
Playwright Service
c1fbc753a7
feat(webkit): roll to r2004 (#30633) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-02 12:44:19 +00:00
Max Schmitt
980f9c6ad4
chore: drop firefox-asan (#30626) 2024-05-01 22:13:00 +00:00
Yury Semikhatsky
ff35f651e6
chore: delete expired location handler from client map (#30574) 2024-05-01 13:04:21 -07:00
Yury Semikhatsky
3b7c4fac22
chore: add common env vars for junit and json reporters (#30611) 2024-05-01 10:16:49 -07:00
Yury Semikhatsky
ad0938c659
chore: mark 1.45.0-next (#30598) 2024-04-29 17:19:05 -07:00
Pavel Feldman
fb90797d73
fix(last-run): remove globalOutputDir (#30571) 2024-04-29 09:02:54 -07:00
Pavel Feldman
96f3d19819
feat(ctrl_or_meta): add a universal ctrl-meta modifier (#30572) 
Fixes https://github.com/microsoft/playwright/issues/12168
 2024-04-29 08:15:12 -07:00
Pavel Feldman
b5dee9ecb7
feat(html): allow ctrl+clicking status (#30556) 2024-04-26 10:50:20 -07:00
Dmitry Gozman
ab3df111c9
chore: remove TeleTestCase._resultsMap (#30567) 2024-04-26 10:11:01 -07:00
Tan Li Hau
194479d90e
fix: pass key attribute from jsx to component test (#30426) 
When using the `key` attribute in jsx inside the test modules, it is not
serialised and passed to the browser in component test
 2024-04-26 09:49:44 -07:00
Yury Semikhatsky
3643fd456b
feat: outputFile option and PLAYWRIGHT_BLOB_OUTPUT_FILE env for blob (#30559) 
Reference https://github.com/microsoft/playwright/issues/30091
 2024-04-26 09:33:53 -07:00
Yury Semikhatsky
ae9345d0bd
docs: add FormData to the examples (#30557) 2024-04-25 16:31:27 -07:00
Dmitry Gozman
6d20da568e
feat: expect(locator).toHaveRole(role) (#30555) 
References #13517. Fixes #18332.
 2024-04-25 15:26:10 -07:00
Yury Semikhatsky
9a1b34a4b0
Revert "fix: shut down workers before reporter.onEnd (#30329)" (#30551) 
This reverts commit 3cea17abb6.

Reference https://github.com/microsoft/playwright/issues/30550

The test is preserved but marked as fixme.
 2024-04-25 14:21:54 -07:00
Dmitry Gozman
086ea79c25
chore: remove checkCoverage script (#30552) 
We do not benefit from it for many years already.
 2024-04-25 14:00:14 -07:00
Dmitry Gozman
9bd2aea130
feat(locator handler): address api review feedback (#30554) 
- Remove `handler` argument from `removeLocatorHandler`.
- Rename `allowStayingVisible` into `noWaitAfter`.
- Improve logging related to locator handler.
- Remove experimental badges.
 2024-04-25 14:00:02 -07:00
Dmitry Gozman
dc0665210f
fix(reporters): properly determine flaky status for serial mode (#30529) 
There are plenty of edge cases in this area:
- interrupted test run;
- did not run because of serial mode failure;
- failed before `test.skip()` call (e.g. in `beforeEach`) in one of the
retries;
- and more...

Related issues: #28322, #28321, #27455, #17652.
Prior changes: #27762, #26385, #28360, probably more.

There is still some duplication between `outcome()` and similar logic in
`base.ts`, which might be deduped in a follow-up.

Fixes #28322.
 2024-04-25 13:39:14 -07:00
Yury Semikhatsky
5502a16e1d
fix(junit): merged report should preserve total duration (#30525) 
Fixes https://github.com/microsoft/playwright/issues/30518
 2024-04-25 13:34:17 -07:00
Yury Semikhatsky
714235d6c8
fix(merge): include command hash into the report name (#30528) 
Reference https://github.com/microsoft/playwright/issues/30091
 2024-04-25 13:34:00 -07:00
Pavel Feldman
4fa1030af6
chore: hide skipped tests by default (#30546) 
Fixes https://github.com/microsoft/playwright/issues/30540
 2024-04-25 12:48:41 -07:00
Pavel Feldman
14413148f4
chore: document --last-failed (#30544) 
drive-by: undocument --browser
 2024-04-25 12:29:51 -07:00
Playwright Service
dfda3003a1
feat(webkit): roll to r2003 (#30543) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-25 19:38:21 +02:00
Yury Semikhatsky
b074932a44
feat(blob): PLAYWRIGHT_BLOB_FILE_NAME env variable (#30530) 
Reference https://github.com/microsoft/playwright/issues/30091
 2024-04-25 09:45:38 -07:00
Pavel Feldman
a2eb43b335
feat(runner): allow running last failed tests (#30533) 
Fixes: https://github.com/microsoft/playwright/issues/30506
 2024-04-25 08:15:27 -07:00
Playwright Service
8e6272b1e3
feat(chromium): roll to r1116 (#30542) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-25 16:08:13 +02:00
Playwright Service
0f28063538
feat(chromium-tip-of-tree): roll to r1215 (#30541) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-25 15:26:03 +02:00
Pavel Feldman
ff3d3ae8f2
fix(ui): print config and global setup errors (#30531) 
Fixes: https://github.com/microsoft/playwright/issues/30513
 2024-04-24 18:54:48 -07:00
Dmitry Gozman
59689c9c97
feat(addLocatorHandler): various improvements (#30494) 
- Automatically waiting for the overlay locator to be hidden, with
`allowStayingVisible` opt-out.
- `times: 1` option.
- `removeLocatorHandler(locator, handler)` method.
- Passing `locator` as first argument to `handler`.

Fixes #30471. Fixes #30424. Fixes #29779.
 2024-04-24 15:19:12 -07:00
Yury Semikhatsky
e2f7acea1e
docs: fix capitalization and alphabetic order in TestConfig (#30523) 2024-04-24 15:18:43 -07:00
Yury Semikhatsky
f1f3929a67
chore: get rid of ConfigInWorker, use FullConfig instead (#30517) 
Addressing API review feedback.
 2024-04-24 14:14:05 -07:00
Yury Semikhatsky
4e086e6df8
docs: update type property description (#30516) 2024-04-24 13:10:17 -07:00
Playwright Service
9914b35c96
feat(firefox-beta): roll to r1449 (#30510) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-24 12:43:26 -07:00
Pavel Feldman
e91d372544
fix(ct): allow importing components from node_modules (#30493) 
Fixes https://github.com/microsoft/playwright/issues/29854
 2024-04-24 12:32:28 -07:00
Pavel Feldman
7a9fd27146
chore: never watch node_modules (#30514) 2024-04-24 12:27:47 -07:00
Dmitry Gozman
8fc7723f22
fix(types): allow any return type from event handlers (#30492) 
Closes #29353.
 2024-04-24 09:25:43 -07:00
Playwright Service
b1d963c24c
feat(webkit): roll to r2002 (#30505) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-24 17:06:52 +02:00
Yury Semikhatsky
230a8437d3
feat(fetch): support FormData as multipart parameter (#30489) 
Reference https://github.com/microsoft/playwright/issues/28070
 2024-04-23 17:05:27 -07:00
Dmitry Gozman
25b881cd10
fix(firefox): "warn" console messages should be "warning" (#30490) 
Fixes #30136.
 2024-04-23 15:07:29 -07:00
Pavel Feldman
4514b7e3ed
chore: use original test ids in html report (#30486) 
Fixes https://github.com/microsoft/playwright/issues/30430
 2024-04-23 14:28:27 -07:00
Yury Semikhatsky
67c430435a
docs: more accurate test id description (#30487) 
Reference https://github.com/microsoft/playwright/issues/30430
 2024-04-23 14:07:37 -07:00
Pavel Feldman
f5ca5241f3
feat(esm): support import attributes (#30482) 
Fixes https://github.com/microsoft/playwright/issues/30473
 2024-04-23 10:13:01 -07:00
Dmitry Gozman
02c0706896
docs: do not recommend waitForLoadState (#30483) 
Instead, just perform an action and auto-waiting will handle it.

Closes #30236.
 2024-04-23 09:22:58 -07:00
Rui Figueira
c80b851422
fix(codegen): prevent csp directive violations (#30366) 2024-04-23 07:33:12 -07:00
Max Schmitt
d7169973ae
chore(roll): roll chromium-tip-of-tree to r1214 (#30481) 2024-04-23 15:59:48 +02:00
Dmitry Gozman
b0fbe058ae
feat: TestProject.ignoreSnapshots (#30466) 2024-04-22 16:16:38 -07:00
Yury Semikhatsky
1d786c804d
chore: generate globalTimeout and maxFailures errors in runner (#30467) 
Generate 'global timeout' and 'max failures' errors in the runner. Avoid
reading `config.globalTimeout` and `config.maxFailures` in the base
reporters.

Reference https://github.com/microsoft/playwright/issues/29768
 2024-04-22 14:00:16 -07:00
Yury Semikhatsky
1e52c37b25
chore: remove unused field (#30465) 2024-04-22 13:31:17 -07:00
Dmitry Gozman
4a275b8eca
feat: expect(locator).toHaveAccessibleDescription (#30463) 
References #18332.
 2024-04-22 12:33:30 -07:00
Yury Semikhatsky
42f91e30d1
chore: remove link to deleted troubleshooting guide (#30462) 
Fixes https://github.com/microsoft/playwright/issues/30446
 2024-04-22 10:58:48 -07:00
Playwright Service
35a6d91ada
feat(firefox): roll to r1449 (#30432) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-22 09:29:34 -07:00
Playwright Service
dd1a9f5e96
feat(chromium): roll to r1115 (#30449) 2024-04-20 18:42:22 +02:00
Max Schmitt
a932222662
fix(highlight): highlight Top Layer elements (#30001) 2024-04-20 08:51:16 +02:00
Playwright Service
d332541df7
feat(webkit): roll to r2001 (#30435) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-20 00:39:01 +02:00
Dmitry Gozman
9b6627a063
feat(role): roll and pass WPT accname tests, calculate description (#30434) 
There are new "non-manual" WPT accname tests that we now mostly pass,
which required a few tweeks in calculating role and name.

Also implemented accessible description computation, which is just a
small addition on top of accessible name, and passed respective wpt
tests.

References #18332.
 2024-04-19 12:49:49 -07:00
Yury Semikhatsky
8c181f7e2b
fix: rebuild project tree from scratch when listing tests (#30407) 
Instead of filtering tests assuming there are no two projects with same
name we always rebuild test tree from scratch and restore previos test
results in the list mode.

Fixes https://github.com/microsoft/playwright/issues/30396
 2024-04-18 16:49:07 -07:00
Max Schmitt
a1b3332e54
chore: follow-up on Electron launch (#30423) 
Follow-up to https://github.com/microsoft/playwright/pull/30382.
 2024-04-19 00:34:07 +02:00
Dmitry Gozman
eea1f9984f
feat: expect(locator).toHaveAccessibleName (#30420) 
References #18332.
 2024-04-18 12:28:55 -07:00
Dmitry Gozman
103ec90751
fix(role): align presentation role conflict resolution with the spec (#30408) 
See
https://www.w3.org/TR/wai-aria-1.2/#conflict_resolution_presentation_none

Fixes #26809.
 2024-04-18 08:53:31 -07:00
Playwright Service
a98abbdda9
feat(chromium-tip-of-tree): roll to r1213 (#30415) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-18 15:29:11 +02:00
Playwright Service
a41122daa2
feat(firefox): roll to r1448 (#30411) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-18 11:16:28 +02:00
Dmitry Gozman
984182bd53
fix(role): embedded control inside the target element (#30403) 
According to the spec, such controls should use the native value as long
as they have "aria-label". The relevant spec section is 2D.

However, there is an open issue that claims this should always apply,
and all browsers and wpt test actually do that:
https://github.com/w3c/accname/issues/64.

Fixes #28848.
 2024-04-17 12:25:08 -07:00
Dmitry Gozman
b72e3a3eba
fix(role): explicitly hidden aria-labelledby should be recursively traversed (#30402) 
The accessible name computation spec has changed to explicitly mention
this case:

Step 2A. Hidden Not Referenced. If the current node is hidden and is:
- Not part of an aria-labelledby or aria-describedby traversal, where
the node directly referenced by that relation was hidden.
- Nor part of a native host language text alternative element (e.g.
label in HTML) or attribute traversal, where the root of that traversal
was hidden.

See https://w3c.github.io/accname/#computation-steps. Chromium, Firefox
and Safari all agree with the spec.

Fixes #29796.
 2024-04-17 11:22:09 -07:00
Mateusz Burzyński
82aefd24db
types: allow readonly tuples to be used as ReporterDescription (#30387) 
This makes it easier to create helper functions like:
```ts
function createReporter(options: MyOptions) {
  return ['my-reporter', options] as const
}
```

At the moment, such functions can't be passed to `reporters` because a
readonly array is not assignable to the expected mutable array.
Playwirght certainly doesn't require those arrays to be mutable so it
would make sense to relax this.
 2024-04-16 17:39:11 -07:00
Yury Semikhatsky
3bdbe4284e
fix(steps): make expect.toPass and expect.poll step containers (#30389) 
Fixes https://github.com/microsoft/playwright/issues/30322
 2024-04-16 16:18:37 -07:00
Yury Semikhatsky
73fce8fb98
chore: replace Zones with AsyncLocalStorage (#30381) 
Reference https://github.com/microsoft/playwright/issues/30322
 2024-04-16 12:51:20 -07:00
Yury Semikhatsky
3cea17abb6
fix: shut down workers before reporter.onEnd (#30329) 2024-04-16 09:49:11 -07:00
Peng Xiao
58187075c8
fix: running electron tests on windows for node 20.12.2 (#30382) 2024-04-16 17:41:19 +02:00
Playwright Service
78793e05ff
feat(chromium): roll to r1114 (#30385) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-16 13:55:36 +02:00
Playwright Service
e2c1efad9e
feat(chromium-tip-of-tree): roll to r1212 (#30380) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-16 07:33:17 +02:00
Dmitry Gozman
a6a44a07a7
chore: align crServiceWorker with crPage (#30367) 
Simplify network-related methods because crNetworkManager already
handles initial/non-initial calls.
 2024-04-15 11:09:38 -07:00
Playwright Service
950e2af44c
feat(webkit): roll to r2000 (#30374) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-15 18:47:31 +02:00
Playwright Service
80e725b5a3
feat(chromium): roll to r1113 (#30364) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-13 14:04:30 +02:00
Max Schmitt
a467312731
fix(snapshotter): remove noscript when javaScriptEnabled is undefined (#30355) 2024-04-12 20:26:52 +02:00
Max Schmitt
56a7adeb8a
test: unflake 'should not include trace resources from the previous chunks' test (#30257) 2024-04-12 19:48:53 +02:00
Yury Semikhatsky
1ef85015f3
fix(merge): preserve static annotations on the tests that did not run (#30348) 
Fixes https://github.com/microsoft/playwright/issues/30260
 2024-04-11 16:17:57 -07:00
Playwright Service
1ab40d8860
feat(webkit): roll to r1999 (#30343) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-11 19:09:46 +02:00
Max Schmitt
96053ed0b5
Revert "fix(reuse): reset Origin Private File System API (#29921)" (#30342) 
This reverts commit 048d6669fd.

This change caused the crash for
https://github.com/microsoft/playwright/issues/30339#issuecomment-2049870789.
If we don't execute this code, it does not crash.

Reverting it for now until the Chromium fix lands in Beta/Stable.
 2024-04-11 19:07:15 +02:00
Max Schmitt
15b423106f
fix(ui-mode): do not loose run information after writing into testDir (#30312) 
Partially reverts https://github.com/microsoft/playwright/pull/30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.

https://github.com/microsoft/playwright/issues/30300.
 2024-04-10 19:01:51 +02:00
Max Schmitt
b2ded9fed1
fix(expect): throw better received error when no element was found (#29890) 
Fixes https://github.com/microsoft/playwright/issues/29873
 2024-04-10 10:01:19 +02:00
Playwright Service
b5e36583f6
feat(webkit): roll to r1998 (#30310) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-09 16:19:58 +02:00
Playwright Service
f9b97fa125
feat(chromium-tip-of-tree): roll to r1210 (#30308) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-09 15:10:26 +02:00
Playwright Service
62ae71f96a
feat(webkit): roll to r1997 (#30295) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-08 19:01:49 +02:00
Playwright Service
8deb44cd37
feat(webkit): roll to r1996 (#30291) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-08 14:16:01 +02:00
Sander
1a34c85886
chore(ct): bump vite to v5.2.8 (#30264) 2024-04-08 09:48:05 +02:00
Dmitry Gozman
a6827772a5
fix(esmLoader): unref MessagePort in the main thread (#30271) 
This prevents the process from not exiting forever due to an open port.
 2024-04-06 14:25:57 -07:00
Yury Semikhatsky
3e03c800df
chore: resolve config location earlier (#30275) 
Reference https://github.com/microsoft/playwright/issues/29768
 2024-04-05 19:32:56 -07:00
Yury Semikhatsky
9e89f292bf
chore: remove usage of configFile from junit reporter (#30273) 
Reference https://github.com/microsoft/playwright/issues/29768
 2024-04-05 15:44:00 -07:00
Pavel Feldman
3cea258a9c
chore: expose clear cache to test server (#30268) 2024-04-05 09:31:34 -07:00
Pavel Feldman
5043bd55dc
chore: move dev server to config-based framework extensibility (#30234) 2024-04-05 08:39:51 -07:00
Dmitry Gozman
d5907f4b13
feat(junit): includeProjectInTestName option (#30233) 
Fixes #30246.
 2024-04-04 11:04:51 -07:00
Dmitry Gozman
88f2717e87
docs: hint that popup main request is accessible through BrowserContext (#30249) 
Fixes #30229.
 2024-04-04 09:23:21 -07:00
Playwright Service
345240b9df
feat(chromium-tip-of-tree): roll to r1209 (#30242) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-04 14:12:57 +02:00
Playwright Service
4d4308e7b3
feat(chromium): roll to r1112 (#30235) 2024-04-04 09:25:57 +02:00
dependabot[bot]
0d5964d3f9
chore(deps): bump vite from 5.0.12 to 5.0.13 (#30227) 2024-04-04 09:25:46 +02:00
Pavel Feldman
8ee286b366
chore: migrate to the testserver.initialize (#30226) 2024-04-03 12:50:56 -07:00
Yury Semikhatsky
5c5f0d77e4
chore: move implementation of Config and Project to TestConfig and TestProject (#30212) 
Reference https://github.com/microsoft/playwright/issues/29768
 2024-04-03 10:47:32 -07:00
Max Schmitt
43745210a5
fix(trace-viewer): exit if given trace.zip does not exist (#30222) 2024-04-03 18:47:03 +02:00
Max Schmitt
010bc29a3c
chore: harden markdown link validation (#30221) 2024-04-03 17:51:32 +02:00
Playwright Service
0734d1e733
feat(webkit): roll to r1995 (#30218) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-03 14:17:06 +02:00
Yury Semikhatsky
63f876a335
chore: remove overrides for type and status (#30211) 
Reference https://github.com/microsoft/playwright/issues/29768
 2024-04-02 17:42:13 -07:00
Козынченко Вячеслав
e58a33a0ae
feat(expect) - add ignoreCase option for toHaveURL (#30192) 
feat(expect): add ignoreCase option for toHaveURL

Fixes #30057
 2024-04-02 16:20:46 -07:00
Yury Semikhatsky
81bcf2a53b
docs: document FullReporter API (#30186) 
* FullConfig split into FullConfig and ConfigInWorker
* FullProject split into FullProject and ProjectInWorker
* Tests can only access {Config, Project}InWorker, while reporters can
only access Full{Config,Project}. This will allow in the future to
change the reporter API independently from the tests.
* Added documentation for the 4 classes.
 2024-04-02 16:15:02 -07:00
Yury Semikhatsky
39b3c93b85
docs: note about sharded projects in the merged config (#30184) 
Fixes https://github.com/microsoft/playwright/issues/29841
 2024-04-02 14:41:23 -07:00
Playwright Service
4baacba4f9
feat(chromium-tip-of-tree): roll to r1208 (#30207) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-04-02 16:29:09 +02:00
Dmitry Gozman
6d56b453ff
fix(connect): include websocket close reason in the error message (#30203) 
When websocket disconnects during `browserType.connect()` call, the
error looks like this now:

```
browserType.connect: Custom error message received over WebSocket
```

Previously, it was a generic error:
```
browserType.connect: Target page, context or browser has been closed
```
 2024-04-01 21:05:33 -07:00
Pavel Feldman
6e799fdfa8
chore: do not run setup tasks on test run via server (#30202) 2024-04-01 15:31:09 -07:00
Peng Xiao
cc881fdb1f
fix: content editable retarget (#29792) 
If `contenteditable` is wrapped into a button or `[role=button]`,
`element.fill` will incorrectly retarget the closest button element.

fix https://github.com/microsoft/playwright/issues/29813
 2024-04-01 13:03:09 -07:00
Playwright Service
7f88c4f482
feat(chromium-tip-of-tree): roll to r1207 (#30190) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-31 22:26:52 +02:00
Pavel Feldman
7afd4170ea
chore: opt into stdio forwarding (#30185) 2024-03-30 18:45:10 -07:00
Hansanto
a950a7b86b
feat: Support intervals arg for toPass (#30037) 
Fixes #30040

# Context

In the `playwright.config` file, we can custom the default `timeout`
property for `expect.toPass` by the property:

```ts title='playwright.config.ts'
export default defineConfig({
  // ...
  expect: {
    toPass: {
      timeout: 60_000,
    },
  },
});
```

However, we can't customize the `intervals` option. So the default value
is always `[100, 250, 500, 1000]`.

# Goal

Add the possibility to customize the intervals option from the
`playwright.config` file.

```ts title='playwright.config.ts'
export default defineConfig({
  // ...
  expect: {
    toPass: {
      timeout: 60_000,
      intervals: [1000, 2000, 3000]
    },
  },
});
```
 2024-03-29 10:17:29 -07:00
Yury Semikhatsky
3001c9ac73
fix: preserve test declaration order in html and merged report (#30159) 
* Add `Suite.entries` that returns tests and suites in their declaration
order
* Exposed `Suite.type` and `TestCase.type` for discriminating between
different entry types.
* Blob report format is updated to store entries instead of separate
lists for suites and tests.
* Bumped blob format version to 2, added modernizer.

Fixes https://github.com/microsoft/playwright/issues/29984
 2024-03-29 10:12:33 -07:00
Yury Semikhatsky
16318ea715
chore: remove unused botName from types (#30172) 2024-03-28 16:16:15 -07:00
Playwright Service
4d8babb27c
feat(webkit): roll to r1994 (#30171) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-28 21:44:19 +01:00
Pavel Feldman
baaf8c8093
chore: hide internal commands (#30170) 2024-03-28 12:19:03 -07:00
Andrey Lushnikov
4781b3c3a8
fix(firefox): disable cache when request interception is enabled (#30113) 
Fixes #30000
 2024-03-28 10:25:37 -07:00
Playwright Service
a440800403
feat(chromium-tip-of-tree): roll to r1206 (#30165) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-28 15:53:12 +01:00
Playwright Service
ff6bb7546f
feat(chromium): roll to r1111 (#30164) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-28 15:20:52 +01:00
Max Schmitt
ffffb81c3b
fix: UI Mode tags without theme applied (#30138) 
Trace Viewer theming is override based. By default you should have
something applied - an optional `dark-mode` class might be there too.
 2024-03-27 16:46:26 +01:00
Pavel Feldman
5912362089
chore: export MatcherReturnType type (#30139) 
Fixes https://github.com/microsoft/playwright/issues/30131
 2024-03-27 08:33:00 -07:00
Playwright Service
352609c44f
feat(webkit): roll to r1993 (#30137) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-27 01:49:24 +01:00
Pavel Feldman
d7710f0c3e
chore: do not exit UI mode upon page reload (#30135) 2024-03-26 15:49:44 -07:00
Max Schmitt
aeb403f851
feat(webkit): dedicated macOS-14 build (#30079) 
Fixes https://github.com/microsoft/playwright/issues/30070
 2024-03-26 23:05:14 +01:00
Dmitry Gozman
b9b06cb010
chore: mark version 1.44.0-next (#30129) 2024-03-26 13:44:10 -07:00
Yury Semikhatsky
021c5c108c
chore: revert support of duplicate form data fields in multipart post data (#30127) 
We want to adopt FormData API for the requests.

This is a revert of 4b3c596874 and
a849ea9741

Reference https://github.com/microsoft/playwright/issues/28070
 2024-03-26 12:36:35 -07:00
Dmitry Gozman
e4403dd6c8
fix(chromium): race between requestPaused and requestWillBeSent in workers (#30125) 
Workers use page's session for `Fetch` domain and worker's session for
`Network` domain. Therefore, `CRNetworkManager` should keep track of the
right session for each domain separately.

This is covered by currently flaky tests:
- `should report and intercept network from nested worker`,
- `should intercept network activity from worker`,
- `should intercept network activity from worker 2`.
 2024-03-26 11:11:09 -07:00
Dmitry Gozman
dd1eca2a9d
fix(trace viewer): show correct number of pages without screencast (#30124) 
Exposed by the flaky "should open two trace files" test.
 2024-03-26 10:25:12 -07:00
Pavel Feldman
0bf635ecce
chore: ensure max failures exit yields erroneous status code (#30120) 
Fixes https://github.com/microsoft/playwright/issues/30118
 2024-03-26 09:20:13 -07:00
Pavel Feldman
2de8a6b002
chore: move filter params into the clearCookies (#30111) 2024-03-26 08:12:26 -07:00
Playwright Service
1824ba118e
feat(chromium-tip-of-tree): roll to r1205 (#30119) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-26 15:19:59 +01:00
Max Schmitt
599185dd07
feat(ui-mode): show native tags in test tree (#30092) 
This brings up the question that we would show the tag name twice if its
a tag in a title. This would be aligned to how HTML report is doing it.

Fixes https://github.com/microsoft/playwright/issues/29927

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2024-03-26 01:06:22 +01:00
Dmitry Gozman
051afb9ce0
fix(test runner): update fixture teardown error message (#30109) 
With the recent change that gave after hooks a separate timeout, fixture
teardown does not imply that "test finished successfully, but fixture
teardown was slow".
 2024-03-25 17:04:03 -07:00
Playwright Service
8e27d67ecd
feat(webkit): roll to r1992 (#30110) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-26 00:06:46 +01:00
Max Schmitt
65d82797f1
fix(ct): ct ID clash on similar imports (#30108) 
This restores the [best
effort](https://github.com/microsoft/playwright/pull/29407/files#diff-8dd3534dc5013c3779edeaded71324b0dd1c1807668f3c6d9e9a1aab1c20ae91L152)
logic if its a relativ path.

Fixes https://github.com/microsoft/playwright/issues/30085

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
 2024-03-25 23:50:45 +01:00
Pavel Feldman
7039ad0d11
chore: follow up to the api review for test server (#30097) 2024-03-25 15:42:58 -07:00
Yury Semikhatsky
a849ea9741
feat(fetch): multiple fields with the same name in post data (#30104) 
Rerefence https://github.com/microsoft/playwright/issues/28070
 2024-03-25 15:39:45 -07:00
Dmitry Gozman
911d8effb9
feat(test runner): do not mock tty in the worker process (#30107) 
This was historically done to make `console.log()` have colors. However,
this makes any other code that checks `process.stdout.isTTY` incorrectly
assume real TTY support.

Node18 and Node20 now respect `FORCE_COLOR=1` in console, so our default
behavior of forcing colors in the worker process just works out of the
box. See https://github.com/nodejs/node/pull/48034.
 2024-03-25 15:31:58 -07:00
Playwright Service
05cbb14d28
feat(firefox): roll to r1447 (#30080) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-25 19:48:38 +01:00
Max Schmitt
253a2f9a9c
chore: address UI Mode keyboard shortcut feedback (#30088) 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2024-03-25 19:48:20 +01:00
Playwright Service
2e8db67f07
feat(firefox-beta): roll to r1447 (#30100) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-25 19:22:59 +01:00
Max Schmitt
f5823786fd
docs: migrate to newer :::warning syntax (#30089) 
- Migrate from `:::warning` to `:::danger[Warning]`.
- Migrate from `:::caution` to `:::warning`.
- `:::warning` and `:::caution` were the color same before.
- `:::caution` is deprecated and gets removed in v4 of Docusaurus
- Also migrate to the [newer title
syntax](3877c1254f/packages/docusaurus-utils/src/markdownUtils.ts (L86-L91))

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
 2024-03-25 19:22:15 +01:00
Shriphad Rao
82804cce64
fix: time in ms for skip test (#30078) 
Fixes https://github.com/microsoft/playwright/issues/29861
 2024-03-25 08:51:09 -07:00
Dmitry Gozman
95d649b406
feat: address api review feedback for 1.43 (#30066) 
- Update docs for `trace: retain-on-first-failure`.
- Update docs for `devtools` option.
- Rename `Locator.enterFrame()` to `Locator.contentFrame()`.
- Rename `FrameLocator.exitFrame()` to `FrameLocator.owner()`.
 2024-03-25 07:42:13 -07:00
Dmitry Gozman
7a3c002944
fix(ct): allow importing json files (#30067) 
While we are not fully resolving imports during compilation, do not
treat `json` as a non-importable asset.

Fixes #29926.
 2024-03-25 07:41:54 -07:00
Pavel Feldman
1539cde034
chore: allow passing path to config to the test server (#30068) 2024-03-22 16:04:59 -07:00
Pavel Feldman
ee9432b9da
chore: send test params over the wire in ui mode (#30046) 2024-03-22 13:49:28 -07:00
Playwright Service
2443d6560f
feat(firefox-beta): roll to r1446 (#30062) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 21:27:33 +01:00
Dmitry Gozman
c1400a3db5
Revert "feat(codegen): add button to generate toHaveScreenshot statement (#29996)" (#30064) 
This reverts commit 1bb463163b. Decided to
wait for a better VRT story.

References #29250.
 2024-03-22 13:26:22 -07:00
Yury Semikhatsky
a511731f55
fix(html): keep projects from different bots separate (#30051) 2024-03-22 10:02:00 -07:00
Playwright Service
9ce83e10f4
feat(firefox): roll to r1446 (#30053) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 13:00:38 +01:00
Playwright Service
b834c0b9ed
feat(webkit): roll to r1991 (#30049) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 13:00:15 +01:00
Playwright Service
63cc132daa
feat(firefox-beta): roll to r1445 (#30028) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 12:59:21 +01:00
Pavel Feldman
a9fc4de37e
chore: queue run and list commands from ui (#30033) 2024-03-21 14:28:07 -07:00
Dmitry Gozman
e0588446c0
feat(firefox): roll to 1445 (#30043) 2024-03-21 13:26:02 -07:00
Max Schmitt
352cb7fa08
feat(browser): roll Chromium to 1110 (#30039) 
Browser roll bot was broken, got fixed by
3d4e0061bc.
 2024-03-21 14:26:42 +01:00
Playwright Service
86d43131e9
feat(chromium-tip-of-tree): roll to r1204 (#30038) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-21 14:23:38 +01:00
Pavel Feldman
7ad0a12c23
chore: remove ui mode update globals (#30031) 2024-03-20 21:09:49 -07:00
Dmitry Gozman
3e73a6ce69
feat(test runner): show multiple errors, at most one per stage (#30024) 
Previously, there was at most one "hard error", as opposite to multiple
"soft errors". This was done to preserve the historic behavior at the
time of introducing multiple `TestInfo.errors`.

With this change, every user callback that is executed `withRunnable()`
can throw an error and/or timeout, and both of these will end up in
`TestInfo.errors`.

Additionally, there is at most one "unhandled exception" error, to avoid
flooding the report with mass failures.

Drive-by: remove boolean arguments from `_failWithError()`.

Fixes #29876.
 2024-03-20 21:01:30 -07:00
Dmitry Gozman
6f360f7207
feat(trace): do not record events that are not used in the viewer (#30030) 
This is especially useful for network events that are already in the
har, but also get into the trace.
 2024-03-20 21:01:17 -07:00
Dmitry Gozman
9d40f619c4
feat: deprecate "devtools" launch option (#30025) 
References #29899.
 2024-03-20 16:48:00 -07:00
Yury Semikhatsky
69e90f38c7
fix(codegen): import re in python (#30026) 
Fixes https://github.com/microsoft/playwright/issues/30019
 2024-03-20 16:38:28 -07:00
Pavel Feldman
8a1ff34578
chore: split ui mode view into files (#30029) 2024-03-20 16:00:35 -07:00
Pavel Feldman
48ccc9cbcd
chore: prepare to reuse test server from ui mode (6) (#30008) 2024-03-20 13:43:26 -07:00
Playwright Service
c712b365ad
feat(chromium-tip-of-tree): roll to r1203 (#30017) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-20 13:31:12 +01:00
Yury Semikhatsky
da2b099b5c
docs: note on locator handler trigger (#30004) 
Fixes https://github.com/microsoft/playwright/issues/30003
 2024-03-19 16:54:49 -07:00
Pavel Feldman
0a22a86e2e
chore: prepare to reuse test server from ui mode (5) (#30005) 2024-03-19 14:08:21 -07:00
Dmitry Gozman
1bb463163b
feat(codegen): add button to generate toHaveScreenshot statement (#29996) 
Fixes #29250.
 2024-03-19 14:01:04 -07:00
Pavel Feldman
54aca430b0
chore: prepare to reuse test server from ui mode (4) (#29995) 2024-03-19 13:00:49 -07:00
Playwright Service
3ee13cbf2b
feat(webkit): roll to r1990 (#29999) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 14:31:38 +01:00
jonghoonpark
b929c0d8f7
feat(ui-mode): add key shortcuts for playwright uI test runner (#29868) 2024-03-19 12:36:42 +01:00
Playwright Service
db7d40e4f2
feat(firefox-beta): roll to r1444 (#29851) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 11:50:19 +01:00
Playwright Service
3c993fbbda
feat(firefox): roll to r1444 (#29853) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 11:50:12 +01:00
Dmitry Gozman
be1af15d57
feat: always enable ESM loader with the new API (#29991) 
It does not require a process restart anymore, so safe to enable.

Fixes #29747.
 2024-03-18 21:54:25 -07:00
Dmitry Gozman
b41b802662
fix(test runner): avoid dependency tracking colliding between esm and cjs (#29994) 
When collecting dependencies both from CJS loader and from ESM loader,
the latter would overwrite the dependencies set instead of appending.

Also make sure cts/cjs/mts/mjs are all supported equally.

References #29747.
 2024-03-18 17:17:58 -07:00
Pavel Feldman
c7b074d39e
chore: prepare to reuse test server from ui mode (3) (#29989) 2024-03-18 17:14:21 -07:00
Dmitry Gozman
70e6cdac57
feat: enterFrame/exitFrame (#29992) 
This introduces `Locator.enterFrame()` and `FrameLocator.exitFrame()` to
convert between locator and frame locator.

Fixes #29336.
 2024-03-18 13:42:08 -07:00
Max Schmitt
a6d1fb93de
fix(trace-viewer): encode attachment filenames as UTF-8 (#29993) 
Fixes https://github.com/microsoft/playwright/issues/29967

Tested in Firefox, Chromium, and Safari. This now leads to "good
attachment names" in Chromium and Safari, for Firefox, it won't produce
attachments, it will open them inline, but this is not a regression, was
before like that already.

See here for the spec:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#filename_2

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
 2024-03-18 21:26:45 +01:00
Yury Semikhatsky
35db70ea1d
chore: trim file names longer than 60 chars (was 100) (#29725) 
Test-specific output dir and snapshot names are trimmed to 60 chars
instead of just 100. The snapshot names are still trimmed at 100 chars
for backwards compatibility.


Reference https://github.com/microsoft/playwright/issues/29719
 2024-03-18 12:53:15 -07:00
Pavel Feldman
ef4438ee99
chore: prepare to reuse test server from ui mode (2) (#29966) 2024-03-18 09:59:02 -07:00
Pavel Feldman
6faadf5160
chore: prepare to reuse test server from ui mode (#29965) 2024-03-18 09:50:11 -07:00
Max Schmitt
0db1d40abc
fix(types): evaluate should not unpack return unions (#29971) 2024-03-18 16:42:33 +01:00
Playwright Service
306db80d03
feat(chromium-tip-of-tree): roll to r1202 (#29963) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-15 20:04:22 +01:00
Max Schmitt
5d0c61fa0c
docs: fix logger API usage (#29961) 2024-03-15 19:04:14 +01:00
Max Schmitt
048d6669fd
fix(reuse): reset Origin Private File System API (#29921) 
Fixes https://github.com/microsoft/playwright/issues/29901

This clears the Origin Private File System API when using VSCode
extension.
 2024-03-15 17:40:46 +01:00
Max Schmitt
be465c6a1c
fix(trace-viewer): allow Chrome extension fallback in SW (#29954) 
https://github.com/microsoft/playwright/issues/29144
 2024-03-15 16:27:07 +01:00
Max Schmitt
5bc6ca6345
fix: allow disposing ElementHandles multiple times (#29953) 
Fixes https://github.com/microsoft/playwright/issues/29945
 2024-03-15 16:26:56 +01:00
Max Schmitt
3e78426acc
fix(trace-viewer): report upload error as aria-role=alert (#29956) 
Turns out NVDA and Narrator work differently. This is a follow-up to
https://github.com/microsoft/playwright/pull/29838 which was not working
in NVDA before - looks like a NVDA bug. Using alert instead.

Relates
https://github.com/microsoft/playwright/issues/29095#issuecomment-1999332067
 2024-03-15 16:25:36 +01:00
Pavel Feldman
94348bb3c5
chore: align test tree with vscode (#29864) 2024-03-14 15:44:35 -07:00
Playwright Service
23bfeec5c7
feat(webkit): roll to r1989 (#29942) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-14 21:15:08 +01:00
Max Schmitt
7cbef691ae
fix: throw error if setInputFile does not exist (#29944) 
Fixes https://github.com/microsoft/playwright/issues/29941
 2024-03-14 20:27:33 +01:00
Max Schmitt
b158e4ef96
fix: postDataJSON without Content-Type header (#29918) 
Regressed after
38fc74db7c.

Test coverage: Some tests were failing on the flakiness dashboard
 2024-03-14 16:48:34 +01:00