* Fix lint issues: Replace golint with revive
golint is deprecated and recommended to be replaced with revive
* Updating comments to be more accurate
* Updating comments again
Co-authored-by: Azeem Shaikh <azeemshaikh38@gmail.com>
* Fix lint issues: whitespace linter
* Fix lint issues: wrapcheck linter
* Fix lint issues: errcheck linter
* Fix lint issues: paralleltest linter
* Fix lint issues: gocritic linter
Most changes from this commit are from passing checker.CheckResult by reference and not by value. gocritic identified that as a huge parameter.
gocritic also prefers regexp.MustCompile over Compile when the pattern is a const
Use the release TagName instead of Name when reporting found releases.
An example of the problem using Name:
$ go run . --repo=github.com/magefile/mage --show-details --checks=Signed-Releases
Starting [Signed-Releases]
Finished [Signed-Releases]
RESULTS
-------
Signed-Releases: Fail 10
release found: Colors, working directory, some better errors
!! release Colors, working directory, some better errors has no signed artifacts
release found: Modules and go1.13 Fixes
!! release Modules and go1.13 Fixes has no signed artifacts
release found: v1.8.0 - Papercuts and Bug Fixes
!! release v1.8.0 - Papercuts and Bug Fixes has no signed artifacts
release found: v1.7.1
!! release v1.7.1 has no signed artifacts
release found: v1.7.0 Mage Imports
!! release v1.7.0 Mage Imports has no signed artifacts
release found: v1.6.2 Bug Fixes
!! release v1.6.2 Bug Fixes has no signed artifacts
found signed artifacts for 0 out of 6 releases
With this commit:
Signed-Releases: Fail 10
release found: v1.10.0
!! release v1.10.0 has no signed artifacts
release found: v1.9.0
!! release v1.9.0 has no signed artifacts
release found: v1.8.0
!! release v1.8.0 has no signed artifacts
release found: v1.7.1
!! release v1.7.1 has no signed artifacts
release found: v1.7.0
!! release v1.7.0 has no signed artifacts
release found: v1.6.2
!! release v1.6.2 has no signed artifacts
found signed artifacts for 0 out of 6 releases
Negative results logged with a "!!" prefix.
Updates #95
$ go run . --repo=github.com/gohugoio/hugo --show-details --checks=Signed-Releases
Starting [Signed-Releases]
Finished [Signed-Releases]
RESULTS
-------
Signed-Releases: Fail 10
release found: v0.79.1
!! release v0.79.1 has no signed artifacts
release found: v0.79.0
!! release v0.79.0 has no signed artifacts
release found: v0.78.2
!! release v0.78.2 has no signed artifacts
release found: v0.78.1
!! release v0.78.1 has no signed artifacts
release found: v0.78.0
!! release v0.78.0 has no signed artifacts
release found: v0.77.0
!! release v0.77.0 has no signed artifacts
found signed artifacts for 0 of 6 releases
